Home

Remove the linker_private and linker_private_weak linkages.

Press ? to show keyboard shortcuts.
Auditors
Bigcheese
H1 Object File Stuff Triggered Audit
Committed
rafaelMar 13 2014, 4:18 PM
Parents
rL203865: Phase 2 of the great MachineRegisterInfo cleanup. This time, we're changing
Branches
Unknown
Tags
Unknown
Subscribers
None
Projects
None
Description

Remove the linker_private and linker_private_weak linkages.

These linkages were introduced some time ago, but it was never very
clear what exactly their semantics were or what they should be used
for. Some investigation found these uses:

  • utf-16 strings in clang.
  • non-unnamed_addr strings produced by the sanitizers.

It turns out they were just working around a more fundamental problem.
For some sections a MachO linker needs a symbol in order to split the
section into atoms, and llvm had no idea that was the case. I fixed
that in r201700 and it is now safe to use the private linkage. When
the object ends up in a section that requires symbols, llvm will use a
'l' prefix instead of a 'L' prefix and things just work.

With that, these linkages were already dead, but there was a potential
future user in the objc metadata information. I am still looking at
CGObjcMac.cpp, but at this point I am convinced that linker_private
and linker_private_weak are not what they need.

The objc uses are currently split in

  • Regular symbols (no '\01' prefix). LLVM already directly provides

whatever semantics they need.

  • Uses of a private name (start with "\01L" or "\01l") and private

linkage. We can drop the "\01L" and "\01l" prefixes as soon as llvm
agrees with clang on L being ok or not for a given section. I have two
patches in code review for this.

  • Uses of private name and weak linkage.

The last case is the one that one could think would fit one of these
linkages. That is not the case. The semantics are

  • the linker will merge these symbol by *name*.
  • the linker will hide them in the final DSO.

Given that the merging is done by name, any of the private (or
internal) linkages would be a bad match. They allow llvm to rename the
symbols, and that is really not what we want. From the llvm point of
view, these objects should really be (linkonce|weak)(_odr)?.

For now, just keeping the "\01l" prefix is probably the best for these
symbols. If we one day want to have a more direct support in llvm,
IMHO what we should add is not a linkage, it is just a hidden_symbol
attribute. It would be applicable to multiple linkages. For example,
on weak it would produce the current behavior we have for objc
metadata. On internal, it would be equivalent to private (and we
should then remove private).

Changes (31)

HistoryBrowseChangePath
HistoryBrowseModifiedllvm/trunk/docs/BitCodeFormat.rst
HistoryBrowseModifiedllvm/trunk/docs/LangRef.rst
HistoryBrowseModifiedllvm/trunk/include/llvm/IR/GlobalValue.h
HistoryBrowseModifiedllvm/trunk/lib/AsmParser/LLLexer.cpp
HistoryBrowseModifiedllvm/trunk/lib/AsmParser/LLParser.cpp
HistoryBrowseModifiedllvm/trunk/lib/AsmParser/LLToken.h
HistoryBrowseModifiedllvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
HistoryBrowseModifiedllvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp
HistoryBrowseModifiedllvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
HistoryBrowseModifiedllvm/trunk/lib/IR/AsmWriter.cpp
HistoryBrowseModifiedllvm/trunk/lib/IR/Core.cpp
HistoryBrowseModifiedllvm/trunk/lib/IR/Mangler.cpp
HistoryBrowseModifiedllvm/trunk/lib/LTO/LTOModule.cpp
HistoryBrowseModifiedllvm/trunk/lib/Object/IRObjectFile.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/CppBackend/CPPBackend.cpp
HistoryBrowseModifiedllvm/trunk/test/Bitcode/linkage-types-3.2.ll
HistoryBrowseDeletedllvm/trunk/test/CodeGen/ARM/2009-08-23-linkerprivate.ll
HistoryBrowseModifiedllvm/trunk/test/CodeGen/ARM/2011-04-12-AlignBug.ll
HistoryBrowseModifiedllvm/trunk/test/CodeGen/NVPTX/bug17709.ll
HistoryBrowseDeletedllvm/trunk/test/CodeGen/PowerPC/2009-08-23-linkerprivate.ll
HistoryBrowseModifiedllvm/trunk/test/CodeGen/SPARC/exception.ll
HistoryBrowseModifiedllvm/trunk/test/CodeGen/SPARC/setjmp.ll
HistoryBrowseDeletedllvm/trunk/test/CodeGen/X86/2009-08-23-linkerprivate.ll
HistoryBrowseModifiedllvm/trunk/test/CodeGen/X86/cfstring.ll
HistoryBrowseDeletedllvm/trunk/test/CodeGen/X86/linker-private.ll
HistoryBrowseDeletedllvm/trunk/test/Feature/linker_private_linkages.ll
HistoryBrowseDeletedllvm/trunk/test/Transforms/ConstantMerge/linker-private.ll
HistoryBrowseModifiedllvm/trunk/test/Transforms/ObjCARC/ensure-that-exception-unwind-path-is-visited.ll
HistoryBrowseModifiedllvm/trunk/utils/kate/llvm.xml
HistoryBrowseModifiedllvm/trunk/utils/llvm.grm
HistoryBrowseModifiedllvm/trunk/utils/vim/llvm.vim

rL203866

llvm/trunk/docs/BitCodeFormat.rst

Loading...

llvm/trunk/docs/LangRef.rst

Loading...

llvm/trunk/include/llvm/IR/GlobalValue.h

Loading...

llvm/trunk/lib/AsmParser/LLLexer.cpp

Loading...

llvm/trunk/lib/AsmParser/LLParser.cpp

Loading...

llvm/trunk/lib/AsmParser/LLToken.h

Loading...

llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp

Loading...

llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp

Loading...

llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

Loading...

llvm/trunk/lib/IR/AsmWriter.cpp

Loading...

llvm/trunk/lib/IR/Core.cpp

Loading...

llvm/trunk/lib/IR/Mangler.cpp

Loading...

llvm/trunk/lib/LTO/LTOModule.cpp

Loading...

llvm/trunk/lib/Object/IRObjectFile.cpp

Loading...

llvm/trunk/lib/Target/CppBackend/CPPBackend.cpp

Loading...

llvm/trunk/test/Bitcode/linkage-types-3.2.ll

Loading...

llvm/trunk/test/CodeGen/ARM/2009-08-23-linkerprivate.ll

Loading...

llvm/trunk/test/CodeGen/ARM/2011-04-12-AlignBug.ll

Loading...

llvm/trunk/test/CodeGen/NVPTX/bug17709.ll

Loading...

llvm/trunk/test/CodeGen/PowerPC/2009-08-23-linkerprivate.ll

Loading...

llvm/trunk/test/CodeGen/SPARC/exception.ll

Loading...

llvm/trunk/test/CodeGen/SPARC/setjmp.ll

Loading...

llvm/trunk/test/CodeGen/X86/2009-08-23-linkerprivate.ll

Loading...

llvm/trunk/test/CodeGen/X86/cfstring.ll

Loading...

llvm/trunk/test/CodeGen/X86/linker-private.ll

Loading...

llvm/trunk/test/Feature/linker_private_linkages.ll

Loading...

llvm/trunk/test/Transforms/ConstantMerge/linker-private.ll

Loading...

llvm/trunk/test/Transforms/ObjCARC/ensure-that-exception-unwind-path-is-visited.ll

Loading...

llvm/trunk/utils/kate/llvm.xml

Loading...

llvm/trunk/utils/llvm.grm

Loading...

llvm/trunk/utils/vim/llvm.vim

Loading...

Add Comment