Rename FunctionProtoType accessors from 'arguments' to 'parameters'

Press ? to show keyboard shortcuts.
Committed
alpJan 20 2014, 12:26 PM
Parents
rL199685: Simplify further.
Branches
Unknown
Tags
Unknown
Description

Rename FunctionProtoType accessors from 'arguments' to 'parameters'

Fix a perennial source of confusion in the clang type system: Declarations and
function prototypes have parameters to which arguments are supplied, so calling
these 'arguments' was a stretch even in C mode, let alone C++ where default
arguments, templates and overloading make the distinction important to get
right.

Readability win across the board, especially in the casting, ADL and
overloading implementations which make a lot more sense at a glance now.

Will keep an eye on the builders and update dependent projects shortly.

No functional change.

Changes (52)

HistoryBrowseChangePath
HistoryBrowseModifiedcfe/trunk/include/clang/AST/ASTContext.h
HistoryBrowseModifiedcfe/trunk/include/clang/AST/CanonicalType.h
HistoryBrowseModifiedcfe/trunk/include/clang/AST/DataRecursiveASTVisitor.h
HistoryBrowseModifiedcfe/trunk/include/clang/AST/DeclObjC.h
HistoryBrowseModifiedcfe/trunk/include/clang/AST/RecursiveASTVisitor.h
HistoryBrowseModifiedcfe/trunk/include/clang/AST/Type.h
HistoryBrowseModifiedcfe/trunk/include/clang/AST/TypeLoc.h
HistoryBrowseModifiedcfe/trunk/include/clang/CodeGen/CGFunctionInfo.h
HistoryBrowseModifiedcfe/trunk/include/clang/Sema/Sema.h
HistoryBrowseModifiedcfe/trunk/lib/AST/ASTContext.cpp
HistoryBrowseModifiedcfe/trunk/lib/AST/ASTImporter.cpp
HistoryBrowseModifiedcfe/trunk/lib/AST/Decl.cpp
HistoryBrowseModifiedcfe/trunk/lib/AST/DeclObjC.cpp
HistoryBrowseModifiedcfe/trunk/lib/AST/ItaniumMangle.cpp
HistoryBrowseModifiedcfe/trunk/lib/AST/Mangle.cpp
HistoryBrowseModifiedcfe/trunk/lib/AST/MangleNumberingContext.cpp
HistoryBrowseModifiedcfe/trunk/lib/AST/MicrosoftMangle.cpp
HistoryBrowseModifiedcfe/trunk/lib/AST/Type.cpp
HistoryBrowseModifiedcfe/trunk/lib/AST/TypePrinter.cpp
HistoryBrowseModifiedcfe/trunk/lib/AST/VTableBuilder.cpp
HistoryBrowseModifiedcfe/trunk/lib/Analysis/BodyFarm.cpp
HistoryBrowseModifiedcfe/trunk/lib/CodeGen/CGCall.cpp
HistoryBrowseModifiedcfe/trunk/lib/CodeGen/CGClass.cpp
HistoryBrowseModifiedcfe/trunk/lib/CodeGen/CGDebugInfo.cpp
HistoryBrowseModifiedcfe/trunk/lib/CodeGen/CGExprCXX.cpp
HistoryBrowseModifiedcfe/trunk/lib/CodeGen/CodeGenFunction.h
HistoryBrowseModifiedcfe/trunk/lib/CodeGen/CodeGenTypes.cpp
HistoryBrowseModifiedcfe/trunk/lib/Index/USRGeneration.cpp
HistoryBrowseModifiedcfe/trunk/lib/Rewrite/Frontend/RewriteModernObjC.cpp
HistoryBrowseModifiedcfe/trunk/lib/Rewrite/Frontend/RewriteObjC.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/Sema.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaAccess.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaChecking.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaCodeComplete.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaDecl.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaDeclAttr.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaDeclCXX.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaExceptionSpec.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaExpr.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaExprCXX.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaLambda.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaLookup.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaOverload.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaTemplate.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaTemplateDeduction.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/SemaType.cpp
HistoryBrowseModifiedcfe/trunk/lib/Sema/TreeTransform.h
HistoryBrowseModifiedcfe/trunk/lib/Serialization/ASTWriter.cpp
HistoryBrowseModifiedcfe/trunk/lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp
HistoryBrowseModifiedcfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
HistoryBrowseModifiedcfe/trunk/tools/libclang/CXType.cpp

rL199686

cfe/trunk/include/clang/AST/ASTContext.h

Loading...

cfe/trunk/include/clang/AST/CanonicalType.h

Loading...

cfe/trunk/include/clang/AST/DataRecursiveASTVisitor.h

Loading...

cfe/trunk/include/clang/AST/DeclObjC.h

Loading...

cfe/trunk/include/clang/AST/RecursiveASTVisitor.h

Loading...

cfe/trunk/include/clang/AST/Type.h

Loading...

cfe/trunk/include/clang/AST/TypeLoc.h

Loading...

cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h

Loading...

cfe/trunk/include/clang/Sema/Sema.h

Loading...

cfe/trunk/lib/AST/ASTContext.cpp

Loading...

cfe/trunk/lib/AST/ASTImporter.cpp

Loading...

cfe/trunk/lib/AST/Decl.cpp

Loading...

cfe/trunk/lib/AST/DeclObjC.cpp

Loading...

cfe/trunk/lib/AST/ItaniumMangle.cpp

Loading...

cfe/trunk/lib/AST/Mangle.cpp

Loading...

cfe/trunk/lib/AST/MangleNumberingContext.cpp

Loading...

cfe/trunk/lib/AST/MicrosoftMangle.cpp

Loading...

cfe/trunk/lib/AST/Type.cpp

Loading...

cfe/trunk/lib/AST/TypePrinter.cpp

Loading...

cfe/trunk/lib/AST/VTableBuilder.cpp

Loading...

cfe/trunk/lib/Analysis/BodyFarm.cpp

Loading...

cfe/trunk/lib/CodeGen/CGCall.cpp

Loading...

cfe/trunk/lib/CodeGen/CGClass.cpp

Loading...

cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Loading...

cfe/trunk/lib/CodeGen/CGExprCXX.cpp

Loading...

cfe/trunk/lib/CodeGen/CodeGenFunction.h

Loading...

cfe/trunk/lib/CodeGen/CodeGenTypes.cpp

Loading...

cfe/trunk/lib/Index/USRGeneration.cpp

Loading...

cfe/trunk/lib/Rewrite/Frontend/RewriteModernObjC.cpp

Loading...

cfe/trunk/lib/Rewrite/Frontend/RewriteObjC.cpp

Loading...

cfe/trunk/lib/Sema/Sema.cpp

Loading...

cfe/trunk/lib/Sema/SemaAccess.cpp

Loading...

cfe/trunk/lib/Sema/SemaChecking.cpp

Loading...

cfe/trunk/lib/Sema/SemaCodeComplete.cpp

Loading...

cfe/trunk/lib/Sema/SemaDecl.cpp

Loading...

cfe/trunk/lib/Sema/SemaDeclAttr.cpp

Loading...

cfe/trunk/lib/Sema/SemaDeclCXX.cpp

Loading...

cfe/trunk/lib/Sema/SemaExceptionSpec.cpp

Loading...

cfe/trunk/lib/Sema/SemaExpr.cpp

Loading...

cfe/trunk/lib/Sema/SemaExprCXX.cpp

Loading...

cfe/trunk/lib/Sema/SemaLambda.cpp

Loading...

cfe/trunk/lib/Sema/SemaLookup.cpp

Loading...

cfe/trunk/lib/Sema/SemaOverload.cpp

Loading...

cfe/trunk/lib/Sema/SemaTemplate.cpp

Loading...

cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp

Loading...

cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp

Loading...

cfe/trunk/lib/Sema/SemaType.cpp

Loading...

cfe/trunk/lib/Sema/TreeTransform.h

Loading...

cfe/trunk/lib/Serialization/ASTWriter.cpp

Loading...

cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp

Loading...

cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp

Loading...

cfe/trunk/tools/libclang/CXType.cpp

Loading...

Add Comment