Home

Fix parsing of .symver directive on ARM

Press ? to show keyboard shortcuts.
Auditors
grosbach
H23 MC code reviews Triggered Audit
Committed
dpeixottJan 15 2014, 2:40 PM
Parents
rL199338: [LTO] Add a hook to map LLVM diagnostics into the clients of LTO.
Branches
Unknown
Tags
Unknown
Subscribers
None
Projects
None
Description

Fix parsing of .symver directive on ARM

ARM assembly syntax uses @ for a comment, execpt for the second
parameter of the .symver directive which requires @ as part of the
symbol name. This commit fixes the parsing of this directive by
adding a special case for ARM for this one argumnet.

To make the change we had to move the AllowAtInIdentifier variable
to the MCAsmLexer interface (from AsmLexer) and expose a setter for
the value. The ELFAsmParser then toggles this value when parsing
the second argument to the .symver directive for a target that
uses @ as a comment symbol

rL199339

llvm/trunk/include/llvm/MC/MCParser/AsmLexer.h

Loading...

llvm/trunk/include/llvm/MC/MCParser/MCAsmLexer.h

Loading...

llvm/trunk/lib/MC/MCParser/ELFAsmParser.cpp

Loading...

llvm/trunk/test/MC/ARM/arm-elf-symver.s

Loading...

llvm/trunk/test/MC/ARM/comment.s

Loading...

Add Comment