[PM] Split DominatorTree into a concrete analysis result object which

Press ? to show keyboard shortcuts.
Committed
chandlercJan 13 2014, 5:07 AM
Parents
rL199103: [PM][cleanup] Clean up comments and use modern doxygen in this file.
Branches
Unknown
Tags
Unknown
Description

[PM] Split DominatorTree into a concrete analysis result object which
can be used by both the new pass manager and the old.

This removes it from any of the virtual mess of the pass interfaces and
lets it derive cleanly from the DominatorTreeBase<> template. In turn,
tons of boilerplate interface can be nuked and it turns into a very
straightforward extension of the base DominatorTree interface.

The old analysis pass is now a simple wrapper. The names and style of
this split should match the split between CallGraph and
CallGraphWrapperPass. All of the users of DominatorTree have been
updated to match using many of the same tricks as with CallGraph. The
goal is that the common type remains the resulting DominatorTree rather
than the pass. This will make subsequent work toward the new pass
manager significantly easier.

Also in numerous places things became cleaner because I switched from
re-running the pass (!!! mid way through some other passes run!!!) to
directly recomputing the domtree.

Changes (60)

HistoryBrowseChangePath
HistoryBrowseModifiedllvm/trunk/include/llvm/Analysis/DominanceFrontier.h
HistoryBrowseModifiedllvm/trunk/include/llvm/CodeGen/StackProtector.h
HistoryBrowseModifiedllvm/trunk/include/llvm/IR/Dominators.h
HistoryBrowseModifiedllvm/trunk/include/llvm/InitializePasses.h
HistoryBrowseModifiedllvm/trunk/include/llvm/Support/GenericDomTree.h
HistoryBrowseModifiedllvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
HistoryBrowseModifiedllvm/trunk/lib/Analysis/DomPrinter.cpp
HistoryBrowseModifiedllvm/trunk/lib/Analysis/DominanceFrontier.cpp
HistoryBrowseModifiedllvm/trunk/lib/Analysis/IVUsers.cpp
HistoryBrowseModifiedllvm/trunk/lib/Analysis/Lint.cpp
HistoryBrowseModifiedllvm/trunk/lib/Analysis/LoopInfo.cpp
HistoryBrowseModifiedllvm/trunk/lib/Analysis/MemoryDependenceAnalysis.cpp
HistoryBrowseModifiedllvm/trunk/lib/Analysis/RegionInfo.cpp
HistoryBrowseModifiedllvm/trunk/lib/Analysis/ScalarEvolution.cpp
HistoryBrowseModifiedllvm/trunk/lib/CodeGen/DwarfEHPrepare.cpp
HistoryBrowseModifiedllvm/trunk/lib/CodeGen/GCStrategy.cpp
HistoryBrowseModifiedllvm/trunk/lib/CodeGen/StackProtector.cpp
HistoryBrowseModifiedllvm/trunk/lib/CodeGen/UnreachableBlockElim.cpp
HistoryBrowseModifiedllvm/trunk/lib/IR/Core.cpp
HistoryBrowseModifiedllvm/trunk/lib/IR/Dominators.cpp
HistoryBrowseModifiedllvm/trunk/lib/IR/Verifier.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/PowerPC/PPCCTRLoops.cpp
HistoryBrowseModifiedllvm/trunk/lib/Target/R600/SIAnnotateControlFlow.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/IPO/LoopExtractor.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/IPO/PartialInlining.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/ObjCARC/ObjCARCContract.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/CodeGenPrepare.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/DeadStoreElimination.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/GVN.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/LICM.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/LoopDeletion.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/LoopInstSimplify.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/LoopRerollPass.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/LoopRotation.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/SROA.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/SampleProfile.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/Sink.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Scalar/StructurizeCFG.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Utils/BasicBlockUtils.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Utils/BreakCriticalEdges.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Utils/LCSSA.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Utils/Local.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Utils/SimplifyInstructions.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Vectorize/BBVectorize.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp
HistoryBrowseModifiedllvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp
HistoryBrowseModifiedllvm/trunk/tools/opt/GraphPrinters.cpp
HistoryBrowseModifiedllvm/trunk/unittests/Analysis/CFGTest.cpp
HistoryBrowseModifiedllvm/trunk/unittests/IR/DominatorTreeTest.cpp

rL199104

llvm/trunk/include/llvm/Analysis/DominanceFrontier.h

Loading...

llvm/trunk/include/llvm/CodeGen/StackProtector.h

Loading...

llvm/trunk/include/llvm/IR/Dominators.h

Loading...

llvm/trunk/include/llvm/InitializePasses.h

Loading...

llvm/trunk/include/llvm/Support/GenericDomTree.h

Loading...

llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp

Loading...

llvm/trunk/lib/Analysis/DomPrinter.cpp

Loading...

llvm/trunk/lib/Analysis/DominanceFrontier.cpp

Loading...

llvm/trunk/lib/Analysis/IVUsers.cpp

Loading...

llvm/trunk/lib/Analysis/Lint.cpp

Loading...

llvm/trunk/lib/Analysis/LoopInfo.cpp

Loading...

llvm/trunk/lib/Analysis/MemoryDependenceAnalysis.cpp

Loading...

llvm/trunk/lib/Analysis/RegionInfo.cpp

Loading...

llvm/trunk/lib/Analysis/ScalarEvolution.cpp

Loading...

llvm/trunk/lib/CodeGen/DwarfEHPrepare.cpp

Loading...

llvm/trunk/lib/CodeGen/GCStrategy.cpp

Loading...

llvm/trunk/lib/CodeGen/StackProtector.cpp

Loading...

llvm/trunk/lib/CodeGen/UnreachableBlockElim.cpp

Loading...

llvm/trunk/lib/IR/Core.cpp

Loading...

llvm/trunk/lib/IR/Dominators.cpp

Loading...

llvm/trunk/lib/IR/Verifier.cpp

Loading...

llvm/trunk/lib/Target/PowerPC/PPCCTRLoops.cpp

Loading...

llvm/trunk/lib/Target/R600/SIAnnotateControlFlow.cpp

Loading...

llvm/trunk/lib/Transforms/IPO/LoopExtractor.cpp

Loading...

llvm/trunk/lib/Transforms/IPO/PartialInlining.cpp

Loading...

llvm/trunk/lib/Transforms/ObjCARC/ObjCARCContract.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/CodeGenPrepare.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/DeadStoreElimination.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/GVN.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/LICM.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/LoopDeletion.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/LoopInstSimplify.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/LoopRerollPass.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/LoopRotation.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/SROA.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/SampleProfile.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/Sink.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/StructurizeCFG.cpp

Loading...

llvm/trunk/lib/Transforms/Utils/BasicBlockUtils.cpp

Loading...

llvm/trunk/lib/Transforms/Utils/BreakCriticalEdges.cpp

Loading...

llvm/trunk/lib/Transforms/Utils/LCSSA.cpp

Loading...

llvm/trunk/lib/Transforms/Utils/Local.cpp

Loading...

llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp

Loading...

llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp

Loading...

llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp

Loading...

llvm/trunk/lib/Transforms/Utils/SimplifyInstructions.cpp

Loading...

llvm/trunk/lib/Transforms/Vectorize/BBVectorize.cpp

Loading...

llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp

Loading...

llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp

Loading...

llvm/trunk/tools/opt/GraphPrinters.cpp

Loading...

llvm/trunk/unittests/Analysis/CFGTest.cpp

Loading...

llvm/trunk/unittests/IR/DominatorTreeTest.cpp

Loading...

Add Comment