Home

[PM] Pull the generic graph algorithms and data structures for dominator

Press ? to show keyboard shortcuts.
Committed
chandlercJan 13 2014, 2:52 AM
Parents
rL199094: Add the check name to the clang-tidy diagnostic output.
Branches
Unknown
Tags
Unknown
Subscribers
None
Projects
None
Description

[PM] Pull the generic graph algorithms and data structures for dominator
trees into the Support library.

These are all expressed in terms of the generic GraphTraits and CFG,
with no reliance on any concrete IR types. Putting them in support
clarifies that and makes the fact that the static analyzer in Clang uses
them much more sane. When moving the Dominators.h file into the IR
library I claimed that this was the right home for it but not something
I planned to work on. Oops.

So why am I doing this? It happens to be one step toward breaking the
requirement that IR verification can only be performed from inside of
a pass context, which completely blocks the implementation of
verification for the new pass manager infrastructure. Fixing it will
also allow removing the concept of the "preverify" step (WTF???) and
allow the verifier to cleanly flag functions which fail verification in
a way that precludes even computing dominance information. Currently,
that results in a fatal error even when you ask the verifier to not
fatally error. It's awesome like that.

The yak shaving will continue...

rL199095

llvm/trunk/include/llvm/CodeGen/MachineDominators.h

Loading...

llvm/trunk/include/llvm/IR/DominatorInternals.h

Loading...

llvm/trunk/include/llvm/IR/Dominators.h

Loading...

llvm/trunk/include/llvm/IR/Verifier.h

Loading...

llvm/trunk/include/llvm/Support/GenericDomTree.h

Loading...

llvm/trunk/include/llvm/Support/GenericDomTreeConstruction.h

Loading...

llvm/trunk/lib/Analysis/PostDominators.cpp

Loading...

llvm/trunk/lib/CodeGen/GCStrategy.cpp

Loading...

llvm/trunk/lib/IR/Dominators.cpp

Loading...

llvm/trunk/lib/Target/R600/AMDILCFGStructurizer.cpp

Loading...

llvm/trunk/lib/Transforms/Scalar/CodeGenPrepare.cpp

Loading...

Add Comment