HomePhabricator

Switch the default of VerifyIntegerConstantExpression from constant

Authored by rsmith on Oct 15 2020, 4:50 PM.

Description

Switch the default of VerifyIntegerConstantExpression from constant
folding to not constant folding.

Constant folding of ICEs is done as a GCC compatibility measure, but new
code was picking it up, presumably by accident, due to the bad default.

While here, also switch the flag from a bool to an enum to make it more
obvious what it means at call sites. This highlighted a couple of places
where our behavior is different between C++11 and C++14 due to switching
from checking for an ICE to checking for a converted constant
expression (where there is no 'fold' codepath).

Details

Committed
rsmithOct 15 2020, 4:58 PM
Parents
rG2bf423b0218c: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher
Branches
Unknown
Tags
Unknown