HomePhabricator

[upstream-with-swift] Temporary workaround for LLVM r334283
ef3db22752a7Unpublished

Authored by bob.wilson on Jun 13 2018, 12:10 PM.

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

[upstream-with-swift] Temporary workaround for LLVM r334283

LLVM r334283 changed StringRef.h so that split(char) and rsplit(char) are
implemented using [r]split(StringRef), which does not have an inlinable
definition in the header file. Because the Swift runtime and other target
libraries use StringRef and other ADT headers without actually linking
libSupport, this causes link failures. Changing to build libSupport for
every target is complicated, so we may just need to tweak Swift to avoid
using these StringRef functions. This change just puts back the old inline
implementations until we can sort that out.

apple-llvm-split-commit: cfd4e41eaedd0405b191d423337542f8f3ee3c86
apple-llvm-split-dir: llvm/

Details

Committed
bob.wilsonJun 13 2018, 12:10 PM
Parents
rGb4982d6c48c9: Propagating prior merge from 'llvm.org/master'.
Branches
Unknown
Tags
Unknown