HomePhabricator

[clang-tidy] Fix RedundantStringCStrCheck with r values

Authored by njames93 on Wed, Jul 29, 7:35 AM.

Description

[clang-tidy] Fix RedundantStringCStrCheck with r values

The previous fix for this, https://reviews.llvm.org/D76761, Passed test cases but failed in the real world as std::string has a non trivial destructor so creates a CXXBindTemporaryExpr.

This handles that shortfall and updates the test case std::basic_string implementation to use a non trivial destructor to reflect real world behaviour.

Reviewed By: gribozavr2

Differential Revision: https://reviews.llvm.org/D84831

Details

Committed
njames93Wed, Jul 29, 7:35 AM
Reviewer
gribozavr2
Differential Revision
D84831: [clang-tidy] Fix RedundantStringCStrCheck with r values
Parents
rG8d27be8dbaff: [OpenCL] Add global_device and global_host address spaces
Branches
Unknown
Tags
Unknown