HomePhabricator
Diffusion LLVM Github Monorepo b8d28420885a

CGDebugInfo: Delete unneeded UnwrapTypeForDebugInfo
b8d28420885a
Actions

Authored by MaskRay on Sun, Jan 10, 10:22 PM.

Description

CGDebugInfo: Delete unneeded UnwrapTypeForDebugInfo

Tested with stage 2 -DCMAKE_BUILD_TYPE=Debug clang, byte identical.

Details

Committed
MaskRaySun, Jan 10, 10:22 PM
Parents
rG6215c1b778f6: CGDebugInfo: Delete redundant test
Branches
Unknown
Tags
Unknown

Event Timeline

MaskRay committed rGb8d28420885a: CGDebugInfo: Delete unneeded UnwrapTypeForDebugInfo (authored by MaskRay).Sun, Jan 10, 10:22 PM
dblaikie added a subscriber: dblaikie.Mon, Jan 11, 12:47 PM

Might still be a useful conversion for possible future callsites? Or are all the call sites pretty clearly not using this?

If there's some uncertainty, perhaps it'd be worth including an assertion that Ty == unwrap(Ty)?

MaskRay added a comment.Mon, Jan 11, 1:02 PM
In rGb8d28420885a42d16a57e02c28129d0eb92474a1#969496, @dblaikie wrote:

Might still be a useful conversion for possible future callsites? Or are all the call sites pretty clearly not using this?

If there's some uncertainty, perhaps it'd be worth including an assertion that Ty == unwrap(Ty)?

An assertion sound good. I'll add it...

Changes (1)

PathSize
clang/
lib/
CodeGen/

rGb8d28420885a

View Options

clang/lib/CodeGen/CGDebugInfo.cpp

Loading...