HomePhabricator

Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer…

Authored by dblaikie on Thu, Jan 7, 5:01 PM.

Description

Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis."""

This reverts commit d2ddc694ff94743d9735aaf07edcaf6db8aaca04.

This still contains a circular dependency between Analysis and CrossTU:

$ grep -r include.*Analysis clang/include/clang/CrossTU
clang/include/clang/CrossTU/CrossTranslationUnit.h:

#include "clang/Analysis/CrossTUAnalysisHelper.h"

$ grep -r include.*CrossTU clang/lib/Analysis
clang/lib/Analysis/PlistHTMLPathDiagnosticConsumer.cpp:

#include "clang/CrossTU/CrossTranslationUnit.h"

clang/lib/Analysis/PlistPathDiagnosticConsumer.cpp:

#include "clang/Analysis/CrossTUAnalysisHelper.h"