HomePhabricator

clang-format: fix spacing in `operator const char*()`
99e5b2ff9df5Unpublished

Authored by krasimir on Jan 17 2020, 4:26 AM.

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

clang-format: fix spacing in operator const char*()

Summary:
Revision a75f8d98d7ac9e557b238a229a9a2647c71feed1 fixed spacing for operators,
but caused the const and non-const versions to diverge:

// With Style.PointerAlignment = FormatStyle::PAS_Left:

struct A {
  operator char*() { return ""; }
  operator const char *() const { return ""; }
};

The code was checking if the type specifier was directly preceded by operator.
However there could be comments and const/volatile in between.

Reviewers: mprobst

Reviewed By: mprobst

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72911

(cherry picked from commit 33463cfba2be7c8d6c08e666123cc34f114a1f3e)

Details

Committed
hansMar 2 2020, 2:19 AM
Reviewer
mprobst
Differential Revision
D72911: clang-format: fix spacing in `operator const char*()`
Parents
rG6b16ce944fef: Attempt to fix ZLIB CMake logic on Windows
Branches
Unknown
Tags
Unknown