HomePhabricator

Define a `NoTerminator` traits that allows operations with a single block…

Authored by mehdi_amini on Mar 11 2021, 3:58 PM.

Description

Define a NoTerminator traits that allows operations with a single block region to not provide a terminator

In particular for Graph Regions, the terminator needs is just a
historical artifact of the generalization of MLIR from CFG region.
Operations like Module don't need a terminator, and before Module
migrated to be an operation with region there wasn't any needed.

To validate the feature, the ModuleOp is migrated to use this trait and
the ModuleTerminator operation is deleted.

This patch is likely to break clients, if you're in this case:

  • you may iterate on a ModuleOp with getBody()->without_terminator(), the solution is simple: just remove the ->without_terminator!
  • you created a builder with Builder::atBlockTerminator(module_body), just use Builder::atBlockEnd(module_body) instead.
  • you were handling ModuleTerminator: it isn't needed anymore.
  • for generic code, a Block::mayNotHaveTerminator() may be used.

Differential Revision: https://reviews.llvm.org/D98468