Diffusion LLVM Github Monorepo 8904ee8ac7eb

[JITLink] Add JITLinkDylib type, thread through JITLinkMemoryManager APIs.
8904ee8ac7eb
Actions

Authored by lhames on Dec 13 2020, 4:14 PM.

Tags

None

Subscribers

Description

[JITLink] Add JITLinkDylib type, thread through JITLinkMemoryManager APIs.

JITLinkDylib represents a target dylib for a JITLink link. By representing this
explicitly we can:

Enable JITLinkMemoryManagers to manage allocations on a per-dylib basis (e.g by maintaining a seperate allocation pool for each JITLinkDylib).
Enable new features and diagnostics that require information about the target dylib (not implemented in this patch).

Details

Committed

Dec 13 2020, 5:29 PM

Parents

rG77bb3c1ac200: [JITLink] Fix include guard end comment.

Branches

Unknown

Tags

Unknown

Reverted By

rG5b112bcc0de7: Revert "[JITLink] Add JITLinkDylib type, thread through JITLinkMemoryManager…

Event Timeline

lhames committed rG8904ee8ac7eb: [JITLink] Add JITLinkDylib type, thread through JITLinkMemoryManager APIs. (authored by lhames).Dec 13 2020, 5:29 PM

The build is broken due to the missing file.

/llvm/include/llvm/ExecutionEngine/JITLink/JITLinkMemoryManager.h
17	This file is missing and breaks the build. Could you add that missing file?

kazu added a subscriber: kazu.Dec 13 2020, 6:16 PM

kazu added inline comments.

/llvm/include/llvm/ExecutionEngine/JITLink/JITLinkMemoryManager.h
17	Is there any chance you forgot to check in JITLinkDylib.h? I'm getting a build failure.

• thakis added a reverting change: rG5b112bcc0de7: Revert "[JITLink] Add JITLinkDylib type, thread through JITLinkMemoryManager….Dec 13 2020, 6:31 PM

lhames mentioned this in rG04795ab8368a: Re-apply 8904ee8ac7e with missing header included this time..Dec 13 2020, 6:40 PM

Hi All,

Sorry -- my internet access dropped out, I only just got the emails. Thanks
for reverting Nico. This should be fixed in 04795ab8368.

Lang.

Changes (10)

Path

Size

llvm/

include/

llvm/

ExecutionEngine/

JITLink/

JITLinkMemoryManager.h

Orc/

OrcRPCTargetProcessControl.h

OrcRemoteTargetClient.h

lib/

ExecutionEngine/

JITLink/

JITLinkGeneric.cpp

JITLinkMemoryManager.cpp

Orc/

ObjectLinkingLayer.cpp

TPCIndirectionUtils.cpp

tools/

llvm-jitlink/

llvm-jitlink.cpp

rG8904ee8ac7eb

llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h

Loading...

llvm/include/llvm/ExecutionEngine/JITLink/JITLinkMemoryManager.h

Loading...

llvm/include/llvm/ExecutionEngine/Orc/Core.h

Loading...

llvm/include/llvm/ExecutionEngine/Orc/OrcRPCTargetProcessControl.h

Loading...

llvm/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetClient.h

Loading...

llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp

Loading...

llvm/lib/ExecutionEngine/JITLink/JITLinkMemoryManager.cpp

Loading...

llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp

Loading...

llvm/lib/ExecutionEngine/Orc/TPCIndirectionUtils.cpp

Loading...

llvm/tools/llvm-jitlink/llvm-jitlink.cpp

Loading...