HomePhabricator

[JITLink] Add JITLinkDylib type, thread through JITLinkMemoryManager APIs.

Authored by lhames on Dec 13 2020, 4:14 PM.

Description

[JITLink] Add JITLinkDylib type, thread through JITLinkMemoryManager APIs.

JITLinkDylib represents a target dylib for a JITLink link. By representing this
explicitly we can:

  • Enable JITLinkMemoryManagers to manage allocations on a per-dylib basis (e.g by maintaining a seperate allocation pool for each JITLinkDylib).
  • Enable new features and diagnostics that require information about the target dylib (not implemented in this patch).

Event Timeline

hliao added a subscriber: hliao.Dec 13 2020, 6:14 PM

The build is broken due to the missing file.

/llvm/include/llvm/ExecutionEngine/JITLink/JITLinkMemoryManager.h
17

This file is missing and breaks the build. Could you add that missing file?

kazu added a subscriber: kazu.Dec 13 2020, 6:16 PM
kazu added inline comments.
/llvm/include/llvm/ExecutionEngine/JITLink/JITLinkMemoryManager.h
17

Is there any chance you forgot to check in JITLinkDylib.h? I'm getting a build failure.

Hi All,

Sorry -- my internet access dropped out, I only just got the emails. Thanks
for reverting Nico. This should be fixed in 04795ab8368.

  • Lang.