HomePhabricator

[Flang][OpenMP][NFC][1/2] Reorder OmpStructureChecker and simplify it.

Authored by sameeranjoshi on Oct 28 2020, 11:13 AM.

Description

[Flang][OpenMP][NFC][1/2] Reorder OmpStructureChecker and simplify it.

OmpStructureChecker has too much boilerplate code in source file.
It was not easy to figure out the seperation of clauses inside 'OmpClause' and
the ones which had a seperate node in parse-tree.h.

This patch:

  1. Removes the boilerplate by defining a few macros.
  2. Makes seperation between constructs, directives and clauses(sub classes are seperated).
  3. Macros could have been shared between OMP and OACC, template specilizations might have been costly hence used macros.

Follows the same strategy used for AccStructureChecker.

Next patch in series to simplify OmpStructureChecker would try to simplify
boilerplates inside the functions and either create abstractions or use if
something is available inside check-directive-structure.h

Reviewed By: kiranchandramohan, clementval

Differential Revision: https://reviews.llvm.org/D90324

Details