Diffusion LLVM Github Monorepo 549e55b3d563

Temporarily Revert "[clangd] Add Random Forest runtime for code completion."
549e55b3d563
Actions

Authored by echristo on Sep 18 2020, 2:47 PM.

Tags

None

Subscribers

Description

Temporarily Revert "[clangd] Add Random Forest runtime for code completion."
as a header doesn't appear to have made it into the commit.

This reverts commit 9b6765e784b39c88cb8cdb85ab083e6c95a997ed and followup

Details

Committed

Sep 18 2020, 2:47 PM

Parents

rG1f0b43638ed7: [spirv] Move device info from resource limit into target env

Branches

Unknown

Tags

Unknown

Reverts

D83814: [clangd] Add Random Forest runtime for code completion.
rG9b6765e784b3: [clangd] Add Random Forest runtime for code completion.

Reverted By

rG985deba9319b: Revert "Temporarily Revert "[clangd] Add Random Forest runtime for code…

Event Timeline

echristo committed rG549e55b3d563: Temporarily Revert "[clangd] Add Random Forest runtime for code completion." (authored by echristo).Sep 18 2020, 2:47 PM

echristo added reverted changes: rG9b6765e784b3: [clangd] Add Random Forest runtime for code completion., D83814: [clangd] Add Random Forest runtime for code completion..Sep 18 2020, 2:50 PM

• thakis mentioned this in rG90fffdd0f705: Revert "[gn build] (manually) port 9b6765e784b3" anf follow-ups.Sep 18 2020, 6:14 PM

Which header do you think is missing? It built fine on several machines over here.

In rG549e55b3d5634870aa9d42135f51ad46a6a0e347#948006, @thakis wrote:

Which header do you think is missing? It built fine on several machines over here.

I replied back and realized I missed something. It's being generated rather than included. I have some concerns about the complexity involved in the test, but mentioned that it could be recommitted at will (or I can, but I was hoping the concerns might be allayed).

Sorry for the churn.

-eric

I agree, it does look pretty complicated :)

:)

usaxena95 added a reverting change: rG985deba9319b: Revert "Temporarily Revert "[clangd] Add Random Forest runtime for code….Sep 19 2020, 2:21 AM

Changes (15)

Path

Size

clang-tools-extra/

clangd/

CompletionModel.cmake

CompletionModelCodegen.py

unittests/

CodeCompleteTests.cpp

DecisionForestTests.cpp

decision_forest_model

CategoricalFeature.h

rG549e55b3d563

clang-tools-extra/clangd/CMakeLists.txt

Loading...

clang-tools-extra/clangd/quality

Loading...

clang-tools-extra/clangd/quality/CompletionModel.cmake

Loading...

clang-tools-extra/clangd/quality/CompletionModelCodegen.py

Loading...

clang-tools-extra/clangd/quality/README.md

Loading...

clang-tools-extra/clangd/quality/model

Loading...

clang-tools-extra/clangd/quality/model/features.json

Loading...

clang-tools-extra/clangd/quality/model/forest.json

Loading...

clang-tools-extra/clangd/unittests/CMakeLists.txt

Loading...

clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

Loading...

clang-tools-extra/clangd/unittests/DecisionForestTests.cpp

Loading...

clang-tools-extra/clangd/unittests/decision_forest_model

Loading...

clang-tools-extra/clangd/unittests/decision_forest_model/CategoricalFeature.h

Loading...

clang-tools-extra/clangd/unittests/decision_forest_model/features.json

Loading...

clang-tools-extra/clangd/unittests/decision_forest_model/forest.json

Loading...