HomePhabricator

MS ABI: Support mangling op<=> now that MSVC 2019 has a mangling

Authored by thakis on Apr 23 2019, 9:37 AM.

Description

MS ABI: Support mangling op<=> now that MSVC 2019 has a mangling

llvm-svn: 359009

Details

Committed
thakisApr 23 2019, 9:37 AM
Parents
rG7c0bd5a27c5b: [x86] fix test checks for fdiv combine; NFC
Branches
Unknown
Tags
Unknown

Event Timeline

This commit has broken in our downstream tooling, which doesn't use the Microsoft ABI nor (I believe) has modified mangling in any way.

Specifically, the second RUN line, which looks for 'define {{.*}}@"??__MA@@QEAAXH@Z"(' fails. The relevant output of clang is is the following:

define dso_local x86_thiscallcc void @"??__MA@@QAEXH@Z"(%struct.A* %this, i32) #0 align 2 {

Note the difference in qualifiers 'QEAAXH' versus 'QAEXH'. Can you confirm that this is somehow an issue on our end?