HomePhabricator

[X86][SSE] Shuffle combine blends to OR(X,Y) if the relevant elements are known…

Authored by RKSimon on Aug 3 2020, 9:53 AM.

Description

[X86][SSE] Shuffle combine blends to OR(X,Y) if the relevant elements are known zero.

This allows us to remove the (depth violating) code in getFauxShuffleMask where we were combining the OR(SHUFFLE,SHUFFLE) shuffle inputs as well, and not just the OR().

This is a minor step toward being able to shuffle combine from/to SELECT/BLENDV as a faux shuffle.

Event Timeline

hctim added a subscriber: hctim.Aug 3 2020, 1:52 PM

Hi Simon, looks like this patch breaks bots that use -Wsign-compare (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/28842/steps/ninja%20check-asan/logs/stdio).

I've reverted in 66e7dce714fabd3ddb1aed635e4b826476d4f1a2 to bring the bots back online

Hi Simon, looks like this patch breaks bots that use -Wsign-compare (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/28842/steps/ninja%20check-asan/logs/stdio).

I've reverted in 66e7dce714fabd3ddb1aed635e4b826476d4f1a2 to bring the bots back online

np, cheers - I don't appear to have received any buildbot failure emails which is a bit odd. I'll resubmit in the morning.

hctim added a comment.Aug 3 2020, 4:09 PM

Hi Simon, looks like this patch breaks bots that use -Wsign-compare (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/28842/steps/ninja%20check-asan/logs/stdio).

I've reverted in 66e7dce714fabd3ddb1aed635e4b826476d4f1a2 to bring the bots back online

np, cheers - I don't appear to have received any buildbot failure emails which is a bit odd. I'll resubmit in the morning.

No problems - I think this patch was submitted during a time that the buildbots were already red (from a different patch that's now fixed), which would explain why you didn't see anything.