HomePhabricator

[BranchAlign] Add master --x86-branches-within-32B-boundaries flag

Authored by reames on Jan 14 2020, 6:16 PM.

Description

[BranchAlign] Add master --x86-branches-within-32B-boundaries flag

This flag was originally part of D70157, but was removed as we carved away pieces of the review. Since we have the nop support checked in, and it appears mature(*), I think it's time to add the master flag. For now, it will default to nop padding, but once the prefix padding support lands, we'll update the defaults.

(*) I can now confirm that downstream testing of the changes which have landed to date - nop padding and compiler support for suppressions - is passing all of the functional testing we've thrown at it. There might still be something lurking, but we've gotten enough coverage to be confident of the basic approach.

Note that the new flag can be used either when assembling an .s file, or when using the integrated assembler directly from the compiler. The later will use all of the suppression mechanism and should always generate correct code. We don't yet have assembly syntax for the suppressions, so passing this directly to the assembler w/a raw .s file may result in broken code. Use at your own risk.

Also note that this isn't the wiring for the clang option. I think the most recent review for that is D72227, but I've lost track, so that might be off.

Differential Revision: https://reviews.llvm.org/D72738

Details

Committed
reamesJan 14 2020, 6:17 PM
Differential Revision
D72738: [BranchAlign] Add master --x86-branches-within-32B-boundaries flag
Parents
rGff1e0fce817e: [Concepts] Type Constraints
Branches
Unknown
Tags
Unknown