Page MenuHomePhabricator

debug-infoProject
ActivePublic

Recent Activity

Today

dmgreen added a comment to D82678: [CGP] Set debug locations when optimizing phi types.

Thanks for taking a look folks.

Sat, Sep 26, 10:20 AM · debug-info, Restricted Project
dmgreen updated the diff for D82678: [CGP] Set debug locations when optimizing phi types.
Sat, Sep 26, 10:20 AM · debug-info, Restricted Project

Yesterday

StephenTozer added a comment to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.

I think wait for someone with more experience in this area to give approval, but aside from the outstanding comments, LGTM.

Fri, Sep 25, 9:06 AM · debug-info, Restricted Project
cameron.mcinally added a comment to D78778: Add SupportsDebugUnwindInformation to MCAsmInfo.

Cray/HPE is motivated to see this patch land. My confidence is low in this area, but I don't see any review comments that are fatal. Any reason we can't move forward with this change?

Fri, Sep 25, 8:03 AM · debug-info, Restricted Project
djtodoro added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Fri, Sep 25, 7:56 AM · debug-info, Restricted Project
umesh.kalappa0 added a comment to D87147: PR-47391 : Two DIFile entries are describing the same file two different ways.

I think the comment in https://reviews.llvm.org/rL349065 describes it quite well:

The DIFile used by the CU is special and distinct from the main source
file. Its directory part specifies what becomes the DW_AT_comp_dir
(the compilation directory), even if the source file was specified
with an absolute path.

So while the CU links to a DIFile it's more a storage mechanism for DW_AT_comp_dir and not a "file" in the normal sense and thus should be treated special. (And we might want to just store a string instead to avoid this confusion in the future.

Fair points.

@umesh.kalappa0 is there specific observable behavior of the resulting DWARF you were trying to address (I seem to recall/think there was)? Or only the quirky/strange IR representation?

@dblaikie ,like stated in https://bugs.llvm.org/show_bug.cgi?id=47391 ,we are trying to address the specific behavior, where the debug_line referring to two different file index's (1 and 2).

Fri, Sep 25, 7:56 AM · debug-info
StephenTozer added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Fri, Sep 25, 7:36 AM · debug-info, Restricted Project
djtodoro added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Fri, Sep 25, 7:14 AM · debug-info, Restricted Project
StephenTozer added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Fri, Sep 25, 6:57 AM · debug-info, Restricted Project
djtodoro added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Fri, Sep 25, 2:57 AM · debug-info, Restricted Project
djtodoro planned changes to D87233: [POC][DebugInfo] Use entry values within IR.

@StephenTozer @dstenb Thanks for your comments! I'll try to change the approach (by putting some extra context), so we might end up changing this one (a bit).

Fri, Sep 25, 12:36 AM · Restricted Project, debug-info

Thu, Sep 24

dstenb accepted D87233: [POC][DebugInfo] Use entry values within IR.

I'm equally fine with doing the Implicit flag change here, or for someone to do it in a separate patch.

Thu, Sep 24, 3:16 PM · Restricted Project, debug-info
vsk added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Thu, Sep 24, 1:59 PM · debug-info, Restricted Project
StephenTozer accepted D87233: [POC][DebugInfo] Use entry values within IR.

LGTM. I think the Implicit flag idea might be able to be folded into this patch without much issue, but it's not urgent and can definitely be shifted to another patch (or even just left as a TODO).

Thu, Sep 24, 8:58 AM · Restricted Project, debug-info
StephenTozer requested review of D88232: [DebugInfo] Handle multiple variable location operands in IR.
Thu, Sep 24, 8:04 AM · debug-info, Restricted Project
StephenTozer requested review of D88230: [DebugInfo] Support multiple location operands via DIArgList in DbgVariableIntrinsics.
Thu, Sep 24, 7:23 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Thu, Sep 24, 1:41 AM · Restricted Project, debug-info
avl added inline comments to D74169: [WIP][LLD][ELF][DebugInfo] Remove obsolete debug info..
Thu, Sep 24, 1:26 AM · debug-info, lld, Restricted Project

Wed, Sep 23

dblaikie added a comment to D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..

hmm, possibly more words in the patch description (& IR documentation). of this and the previous patch - what is implicit_pointer V explicit_pointer? Maybe some examples in the patch description and IR documentation about how they could be used?

Wed, Sep 23, 7:41 PM · debug-info, Restricted Project
dblaikie added inline comments to D84113: [Debuginfo] (1/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.
Wed, Sep 23, 7:39 PM · Restricted Project, debug-info
ayermolo added inline comments to D74169: [WIP][LLD][ELF][DebugInfo] Remove obsolete debug info..
Wed, Sep 23, 2:58 PM · debug-info, lld, Restricted Project
StephenTozer updated the summary of D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic.
Wed, Sep 23, 11:41 AM · Restricted Project, debug-info
StephenTozer requested review of D88175: [DebugInfo] Add new metadata, DIArgList, for referencing a list of SSA values inside a debug variable intrinsic.
Wed, Sep 23, 11:40 AM · Restricted Project, debug-info
StephenTozer added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 9:50 AM · Restricted Project, debug-info
djtodoro planned changes to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 8:35 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 8:34 AM · Restricted Project, debug-info
StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Updated changes for latest master (there may be some lurking unseen errors, still trying to flush any out), addressed some review comments. Right now, I think the only thing holding this patch up is the discussion on the llvm-dev mailing list about using DBG_VALUE_LIST as the default for all debug values. If anyone on this review has any input for that, please go ahead and reply to the chain - I think that the latest proposal I put forward should satisfy everyone's requirements, but I don't want to push ahead without being sure of that.

Wed, Sep 23, 8:26 AM · Restricted Project, debug-info
StephenTozer added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 7:51 AM · Restricted Project, debug-info
cameron.mcinally accepted D76879: [AMDGPU] Begin emitting CFI for AMDGCN.

LGTM

Wed, Sep 23, 7:28 AM · debug-info, Restricted Project
dstenb added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 6:25 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 4:44 AM · Restricted Project, debug-info
Orlando added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 4:12 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 3:56 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 3:54 AM · Restricted Project, debug-info
StephenTozer added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 3:38 AM · Restricted Project, debug-info
jmorse accepted D87494: Improve LSR debug-info.

LGTM; I guess it'd be better if SCEV exposed a helper method, rather than this patch having to expose one, but that's well out of scope.

Wed, Sep 23, 3:16 AM · Restricted Project, debug-info
djtodoro updated the diff for D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
  • addressing comment
Wed, Sep 23, 3:00 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 2:56 AM · Restricted Project, debug-info
djtodoro updated the diff for D87233: [POC][DebugInfo] Use entry values within IR.
  • addressing comments
Wed, Sep 23, 2:26 AM · Restricted Project, debug-info
djtodoro added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

Sorry for a piecemeal review from my part!

No problem, the tempo works for me. :) Thanks!

Wed, Sep 23, 2:22 AM · Restricted Project, debug-info
StephenTozer added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 2:21 AM · Restricted Project, debug-info
markus added a comment to D87494: Improve LSR debug-info.

This is looking good, a few nits inline. Some slightly broader questions: do you know if there's any risk of debug-info affecting decisions made by SCEV, i.e. causing codegen to change when compiling -g? I don't have any reason to believe that could be the case, but it's a fear in the back of my mind.

Wed, Sep 23, 12:20 AM · Restricted Project, debug-info

Tue, Sep 22

markus updated the diff for D87494: Improve LSR debug-info.

Fixed most of the review remarks.

Tue, Sep 22, 11:58 PM · Restricted Project, debug-info
dstenb added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

Sorry for a piecemeal review from my part!

Tue, Sep 22, 3:07 PM · Restricted Project, debug-info
cameron.mcinally accepted D76880: [AMDGPU] Emit entry function CFI.

LGTM with moderate confidence. Does anyone see a reason that this shouldn't land?

Tue, Sep 22, 2:05 PM · debug-info, Restricted Project
cameron.mcinally accepted D76884: [AMDGPU] Implement -amdgpu-spill-cfi-saved-regs.

LGTM with moderate confidence. Does anyone see a reason that this shouldn't land?

Tue, Sep 22, 1:13 PM · debug-info, Restricted Project
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Tue, Sep 22, 10:18 AM · Restricted Project, debug-info
Orlando added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Tue, Sep 22, 9:42 AM · Restricted Project, debug-info
Orlando added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Tue, Sep 22, 9:38 AM · Restricted Project, debug-info
dblaikie added a comment to D87147: PR-47391 : Two DIFile entries are describing the same file two different ways.

I think the comment in https://reviews.llvm.org/rL349065 describes it quite well:

The DIFile used by the CU is special and distinct from the main source
file. Its directory part specifies what becomes the DW_AT_comp_dir
(the compilation directory), even if the source file was specified
with an absolute path.

So while the CU links to a DIFile it's more a storage mechanism for DW_AT_comp_dir and not a "file" in the normal sense and thus should be treated special. (And we might want to just store a string instead to avoid this confusion in the future.

Tue, Sep 22, 9:33 AM · debug-info