Today
Filter out DbgUsers that will not be sunk prior to sorting.
Yesterday
Nice find!
I think this looks mostly good, but it looks like it's missing a unittest for the DIBuilder function that you added.
Added more context to diff
This looks good to me - does this need a test case?
Mon, Jan 25
Fri, Jan 22
Wed, Jan 20
Tue, Jan 19
I know this change is old but I'd like to get it committed if possible. (Got waylaid by the pandemic) Or maybe abandon it and resubmit?
Anyway, are there any reviewers out there?
Ping - this one has had a lot of discussion, and I think all of the substantial concerns have been addressed; are there any further comments?
Ping.
Ping.
Ping - any further comments?
Thanks @rnk
Mon, Jan 18
Fixed issue in which DBG_VALUE_LIST expressions were being emitted without subregister masking.
@ntesic Do you have commit access?
Addressed comments:
- Use shouldUpdateCallSiteInfo() predicate
- Use ToErase->eraseFromParent()
- Reduce function attributes in test
some comments inline, lgtm otherwise
Sun, Jan 17
Fri, Jan 15
lgtm
How does it look now, with some renaming I did?
Rebased onto recent master (resolving clashes with the DW_OP_implicit_ptr patch); rewrote dbg-value-list-spill.mir test.
Thu, Jan 14
This fixes 32r6{,el}_defconfig and does not regress any of my other MIPS kernel builds.
LGTM
Patch fixes the reported bug; added test cases produces a crash before patch is applied. LGTM with minor nit.
Address feedback from @bjope:
+ Change comment for dbg.value+derefs in ShouldRemove lambda.
+ Update the test to check that the backward scan removes adjacent duplicate dbg.value+derefs still.
Rebase