Page MenuHomePhabricator

debug-infoProject
ActivePublic

Recent Activity

Today

StephenTozer updated the diff for D95463: Avoid redundant or out-of-order debug value sinking in InstCombine.

Filter out DbgUsers that will not be sunk prior to sorting.

Wed, Jan 27, 2:25 AM · Restricted Project, debug-info

Yesterday

rnk added a comment to D95463: Avoid redundant or out-of-order debug value sinking in InstCombine.

Nice find!

Tue, Jan 26, 7:11 PM · Restricted Project, debug-info
aprantl added a comment to D76115: Add debug support for set types.

I think this looks mostly good, but it looks like it's missing a unittest for the DIBuilder function that you added.

Tue, Jan 26, 2:23 PM · debug-info, Restricted Project
aprantl accepted D91423: [NFC][DebugInfo] Factor LowerDbgDeclare into two functions [1/3].
Tue, Jan 26, 2:18 PM · debug-info, Restricted Project
StephenTozer requested review of D95463: Avoid redundant or out-of-order debug value sinking in InstCombine.
Tue, Jan 26, 11:07 AM · Restricted Project, debug-info
StephenTozer added a comment to D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.

I would argue this is minor enough to go in without one, but I'm happy to add one if you feel strongly in favour for a test going in too.

Tue, Jan 26, 6:45 AM · debug-info
TWeaver added a comment to D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.

This looks good to me - does this need a test case?

Tue, Jan 26, 4:19 AM · debug-info
TWeaver updated the diff for D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.

Added more context to diff

Tue, Jan 26, 4:17 AM · debug-info
StephenTozer added a comment to D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.

This looks good to me - does this need a test case?

Tue, Jan 26, 3:33 AM · debug-info

Mon, Jan 25

probinson added a comment to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

W.r.t the replacement of DBG_VALUE with DBG_VALUE_LIST, the current plan is to make that all happen in a patch following this stack. The patch itself should mostly be deletion of old code and simplifying where possible, renaming DBG_VALUE_LIST to DBG_VALUE, adding an extra operand to the new DBG_VALUE to represent directness, adding several tests, and updating existing tests as appropriate.

Mon, Jan 25, 9:04 AM · Restricted Project, debug-info
condy added a member for debug-info: condy.
Mon, Jan 25, 4:40 AM

Fri, Jan 22

jmorse added a comment to D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.

Paging @vsk -- it was a while ago, but do you still have the bitcode from D7406 handy, and would you have spare cycles to test it against this (combined patch in D94631)?

Fri, Jan 22, 7:51 AM · Restricted Project, debug-info

Wed, Jan 20

TWeaver updated subscribers of D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.
Wed, Jan 20, 7:09 AM · debug-info
TWeaver requested review of D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.
Wed, Jan 20, 6:54 AM · debug-info

Tue, Jan 19

mehdi_amini changed the edit policy for debug-info.
Tue, Jan 19, 8:22 PM
demoitem added a comment to D76115: Add debug support for set types.

I know this change is old but I'd like to get it committed if possible. (Got waylaid by the pandemic) Or maybe abandon it and resubmit?
Anyway, are there any reviewers out there?

Tue, Jan 19, 7:15 PM · debug-info, Restricted Project
StephenTozer added a comment to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Ping - this one has had a lot of discussion, and I think all of the substantial concerns have been addressed; are there any further comments?

Tue, Jan 19, 8:03 AM · Restricted Project, debug-info
StephenTozer added a comment to D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.

Ping.

Tue, Jan 19, 4:10 AM · Restricted Project, debug-info
StephenTozer added a comment to D83895: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugVariables.

Ping.

Tue, Jan 19, 4:09 AM · Restricted Project, debug-info
StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Ping - any further comments?

Tue, Jan 19, 4:09 AM · debug-info, Restricted Project
Orlando added a comment to D94761: [DebugInfo][dexter] Add dexter tests for merged values.

Thanks @rnk

Tue, Jan 19, 3:31 AM · debug-info, Restricted Project
Orlando closed D94761: [DebugInfo][dexter] Add dexter tests for merged values.
Tue, Jan 19, 3:29 AM · debug-info, Restricted Project
jmorse activated debug-info.
Tue, Jan 19, 2:13 AM

Mon, Jan 18

231084fg archived debug-info.
Mon, Jan 18, 5:39 PM
StephenTozer updated the diff for D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.

Fixed issue in which DBG_VALUE_LIST expressions were being emitted without subregister masking.

Mon, Jan 18, 7:56 AM · Restricted Project, debug-info
djtodoro closed D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.
Mon, Jan 18, 6:30 AM · Restricted Project, debug-info
ntesic added a comment to D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

@ntesic Do you have commit access?

Mon, Jan 18, 3:54 AM · Restricted Project, debug-info
atanasyan added a comment to D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

@ntesic Do you have commit access?

Mon, Jan 18, 3:46 AM · Restricted Project, debug-info
djtodoro accepted D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.
Mon, Jan 18, 3:19 AM · Restricted Project, debug-info
ntesic updated the diff for D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

Addressed comments:

  • Use shouldUpdateCallSiteInfo() predicate
  • Use ToErase->eraseFromParent()
  • Reduce function attributes in test
Mon, Jan 18, 3:16 AM · Restricted Project, debug-info
StephenTozer added inline comments to D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.
Mon, Jan 18, 2:42 AM · Restricted Project, debug-info
djtodoro added a comment to D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

some comments inline, lgtm otherwise

Mon, Jan 18, 12:16 AM · Restricted Project, debug-info

Sun, Jan 17

scott.linder added inline comments to D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.
Sun, Jan 17, 12:18 PM · Restricted Project, debug-info

Fri, Jan 15

rnk accepted D94761: [DebugInfo][dexter] Add dexter tests for merged values.

lgtm

Fri, Jan 15, 4:35 PM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [AMDGPU] Add SupportsDebugUnwindInformation to MCAsmInfo.

How does it look now, with some renaming I did?

Fri, Jan 15, 10:26 AM · debug-info, Restricted Project
StephenTozer added inline comments to D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.
Fri, Jan 15, 9:30 AM · Restricted Project, debug-info
StephenTozer updated the diff for D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.

Rebased onto recent master (resolving clashes with the DW_OP_implicit_ptr patch); rewrote dbg-value-list-spill.mir test.

Fri, Jan 15, 8:28 AM · Restricted Project, debug-info
Orlando requested review of D94761: [DebugInfo][dexter] Add dexter tests for merged values.
Fri, Jan 15, 3:19 AM · debug-info, Restricted Project
alok closed D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.
Fri, Jan 15, 1:17 AM · debug-info, Restricted Project

Thu, Jan 14

nathanchance added a comment to D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

This fixes 32r6{,el}_defconfig and does not regress any of my other MIPS kernel builds.

Thu, Jan 14, 12:25 PM · Restricted Project, debug-info
atanasyan accepted D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

LGTM

Thu, Jan 14, 10:44 AM · Restricted Project, debug-info
atanasyan added a reviewer for D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller: atanasyan.
Thu, Jan 14, 10:43 AM · Restricted Project, debug-info
nickdesaulniers added a reviewer for D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller: nickdesaulniers.
Thu, Jan 14, 10:35 AM · Restricted Project, debug-info
nickdesaulniers added a comment to D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

Patch fixes the reported bug; added test cases produces a crash before patch is applied. LGTM with minor nit.

Thu, Jan 14, 10:34 AM · Restricted Project, debug-info
nickdesaulniers updated subscribers of D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.
Thu, Jan 14, 10:27 AM · Restricted Project, debug-info
ntesic added a comment to D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Thu, Jan 14, 6:31 AM · Restricted Project, Restricted Project, debug-info
ntesic requested review of D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.
Thu, Jan 14, 6:26 AM · Restricted Project, debug-info
Orlando updated subscribers of D91424: [DebugInfo] Improve debug info accuracy for locals after inlining alloca uses [2/3].

As @bjope points out on D91425, it should be mentioned that while solution will improve the debugging experience in a number of cases it isn't bulletproof. For example a pass could insert a non-debug instruction between the dbg.value+deref and the to-be-inlined call.

Thu, Jan 14, 2:58 AM · debug-info, Restricted Project
Orlando updated the diff for D91425: [DebugInfo] Skip dbg.value+derefs in RemoveRedundantDbgInstrs forward scan [3/3].

Address feedback from @bjope:
+ Change comment for dbg.value+derefs in ShouldRemove lambda.
+ Update the test to check that the backward scan removes adjacent duplicate dbg.value+derefs still.

Thu, Jan 14, 2:51 AM · debug-info, Restricted Project
Orlando updated the diff for D91425: [DebugInfo] Skip dbg.value+derefs in RemoveRedundantDbgInstrs forward scan [3/3].

Rebase

Thu, Jan 14, 2:49 AM · debug-info, Restricted Project