Fix error message formatting

Apply clang format suggestion

Update error statement, clean up getSymbolName function, add size to enum

Fix typo

Change return type of getSymbolType function from Error to Expected<StringRef>
Also remove StringRef parameter passed by reference to the function
Update error messages to be more descriptive

Return Error instead of error_code for function getSymbolName
Address other review comments

Added unit test GOFFObjectFileTest.cpp, and added GOFF case in TestFileMagic.cpp
Addressed more review comments

Remove setERSymbolType and getERSymbolType functions

Remove return after llvm_unreachable statement

Add check for ESD name length field size
Update loops to comply with LLVM coding standard:
https://llvm.org/docs/CodingStandards.html#don-t-evaluate-end-every-time-through-a-loop

Clean up some cast statements from const uint8_t * to const char *

Change errorCodeToError to createStringError in GOFFObjectFile constructor

Address formatting comments

Address some formatting comments

@jhenderson the comments you left have been addressed. Are there any other suggestions you have?

This update cleans up reinterpret_cast<> statements in GOFFObjectFile related to EsdPtrs, TextPtrs, and RldPtrs

This update cleans up GOFF.h by replacing various set/get functions with templated functions.

This updates the function createGOFFObjectFile to use Error instead of std::error_code as described in https://llvm.org/docs/ProgrammersManual.html#fallible-constructors

Update llvm/include/llvm/Object/GOFF.h to consider endianness of the host system for parsing GOFF records.

This update removes the RLDRelocationType enum from llvm/include/llvm/BinaryFormat/GOFF.h and clarifies comments regarding endianness.

This update removes variable definitions which are used only in the immediate next line and not used elsewhere.

This update fixes formatting issues, along with stubbing functions that are unnecessary
to implement for the time being from the GOFFObjectFile class

This patch has been broken down into the following 3 patches:
https://reviews.llvm.org/D89071
https://reviews.llvm.org/D89073
https://reviews.llvm.org/D89074

It looks to me like you uploaded the wrong diff. You need to upload a diff of your entire final commit that this will be committed as, when making edits to the code. If you intend to upload a series of individual commits, and want them all reviewed together, you should create separate patches for each of them and link them together using the "edit related objects" option to create a patch series.

This patch adds support for a large number of different dumping options all at once. Please break it down into separate smaller pieces. For example, your first patch could just create the GOFFDumper, and do nothing with it, the next adds section header support, the next symbol table support and so on. It is not going to be straightforward to review such a large piece of work all at once.

This update uploads the correct diff with all changes

Fix formatting issues

Overall the patch LGTM, aside from 1 change we may want to make.