Page MenuHomePhabricator

yroux (Yvan Roux)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2014, 12:27 AM (362 w, 5 h)

Recent Activity

Today

yroux abandoned D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM.

All patches are now committed.

Tue, Jan 19, 2:02 AM · Restricted Project, Restricted Project
yroux committed rG244ad228f343: [ARM][MachineOutliner] Add stack fixup feature (authored by yroux).
[ARM][MachineOutliner] Add stack fixup feature
Tue, Jan 19, 1:59 AM
yroux closed D92934: [ARM][MachineOutliner] Add stack fixup feature..
Tue, Jan 19, 1:59 AM · Restricted Project

Yesterday

yroux added a comment to D92934: [ARM][MachineOutliner] Add stack fixup feature..

Hi Sam,

Mon, Jan 18, 5:30 AM · Restricted Project

Thu, Jan 14

yroux accepted D94167: [ARM][GISel] Treat calls as variadic even if only fixed arguments provided.

LGTM

Thu, Jan 14, 11:41 PM · Restricted Project
yroux added a comment to D92934: [ARM][MachineOutliner] Add stack fixup feature..

ping

Thu, Jan 14, 1:41 AM · Restricted Project

Wed, Jan 13

yroux accepted D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner.

Approved now that I've properly tested it.

Wed, Jan 13, 6:57 AM · Restricted Project

Mon, Jan 11

yroux added a comment to D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner.

One small comment otherwise LGTM

Mon, Jan 11, 8:12 AM · Restricted Project

Wed, Jan 6

yroux committed rG0c41b1c9f93c: [Driver][MachineOutliner] Support outlining option with LTO (authored by yroux).
[Driver][MachineOutliner] Support outlining option with LTO
Wed, Jan 6, 7:04 AM
yroux closed D93385: [Driver][MachineOutliner] Support outlining option with LTO.
Wed, Jan 6, 7:04 AM · Restricted Project

Mon, Jan 4

yroux added a comment to D92934: [ARM][MachineOutliner] Add stack fixup feature..

ping

Mon, Jan 4, 11:33 PM · Restricted Project
yroux added a comment to D93385: [Driver][MachineOutliner] Support outlining option with LTO.

ping

Mon, Jan 4, 11:33 PM · Restricted Project

Dec 17 2020

yroux committed rG923ca0b411f7: [ARM][MachineOutliner] Fix costs model. (authored by yroux).
[ARM][MachineOutliner] Fix costs model.
Dec 17 2020, 7:12 AM
yroux closed D92933: [ARM][MachineOutliner] Fix costs model..
Dec 17 2020, 7:12 AM · Restricted Project
yroux added inline comments to D92933: [ARM][MachineOutliner] Fix costs model..
Dec 17 2020, 5:27 AM · Restricted Project
yroux added inline comments to D92933: [ARM][MachineOutliner] Fix costs model..
Dec 17 2020, 5:16 AM · Restricted Project
yroux added inline comments to D92933: [ARM][MachineOutliner] Fix costs model..
Dec 17 2020, 4:16 AM · Restricted Project
yroux added a comment to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Hi Andrew, the new version LGTM

Dec 17 2020, 1:03 AM · Restricted Project

Dec 16 2020

yroux requested review of D93385: [Driver][MachineOutliner] Support outlining option with LTO.
Dec 16 2020, 2:26 AM · Restricted Project

Dec 14 2020

yroux added inline comments to D92933: [ARM][MachineOutliner] Fix costs model..
Dec 14 2020, 1:08 AM · Restricted Project

Dec 10 2020

yroux retitled D92933: [ARM][MachineOutliner] Fix costs model. from [ARM][MachineOutliner] Handle stack usage. to [ARM][MachineOutliner] Fix costs model..
Dec 10 2020, 2:31 AM · Restricted Project
yroux added inline comments to D92933: [ARM][MachineOutliner] Fix costs model..
Dec 10 2020, 2:27 AM · Restricted Project

Dec 9 2020

yroux committed rG03a77d04b412: [LLD][ELF] Fix typo in relocation-model-pic.ll (authored by yroux).
[LLD][ELF] Fix typo in relocation-model-pic.ll
Dec 9 2020, 6:39 AM
yroux abandoned D90836: [ARM][MachineOutliner] Add stack fixup feature..

Hi Sam,

Dec 9 2020, 4:54 AM · Restricted Project
yroux requested review of D92934: [ARM][MachineOutliner] Add stack fixup feature..
Dec 9 2020, 4:46 AM · Restricted Project
yroux requested review of D92933: [ARM][MachineOutliner] Fix costs model..
Dec 9 2020, 4:42 AM · Restricted Project

Nov 27 2020

yroux added a comment to D90836: [ARM][MachineOutliner] Add stack fixup feature..

Ping

Nov 27 2020, 3:00 AM · Restricted Project

Nov 20 2020

yroux accepted D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

I think that the previous comments were addressed. LGTM

Nov 20 2020, 6:16 AM · Restricted Project

Nov 19 2020

yroux added inline comments to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Nov 19 2020, 2:19 AM · Restricted Project

Nov 18 2020

yroux updated the diff for D90836: [ARM][MachineOutliner] Add stack fixup feature..
Nov 18 2020, 6:11 AM · Restricted Project

Nov 13 2020

yroux committed rGdee452da7a44: [UpdateTestChecks] Fix $ in function test for ARM. (authored by yroux).
[UpdateTestChecks] Fix $ in function test for ARM.
Nov 13 2020, 3:27 AM

Nov 9 2020

yroux accepted D89483: [ARM][MachineOutliner] Emit more CFI instructions.

Just a small comment, otherwise LGTM, thanks

Nov 9 2020, 1:01 AM · Restricted Project

Nov 6 2020

yroux added a comment to D82995: [UpdateTestChecks] Allow $ in function names.

Hi David,

Nov 6 2020, 1:33 AM · Restricted Project

Nov 5 2020

yroux requested review of D90836: [ARM][MachineOutliner] Add stack fixup feature..
Nov 5 2020, 3:24 AM · Restricted Project
yroux accepted D90627: [sanitizer] Assume getrandom might not be supported by the kernel.

LGTM

Nov 5 2020, 2:51 AM · Restricted Project

Nov 4 2020

yroux accepted D90628: [lsan] Disable some LSAN tests for arm-linux-gnueabi{hf}.

LGTM, given it is needed to bring ARM bots back online

Nov 4 2020, 2:07 AM · Restricted Project
yroux added a comment to D90627: [sanitizer] Assume getrandom might not be supported by the kernel.

The change makes sense to me and will fix ARM broken bots, I'd say that it can be accepted if there is no objection within a day

Nov 4 2020, 2:06 AM · Restricted Project

Nov 3 2020

yroux accepted D89625: Add default value for MachineInstr::modifiesRegister. NFC..

LGTM

Nov 3 2020, 5:27 AM · Restricted Project

Nov 2 2020

yroux added a comment to D89625: Add default value for MachineInstr::modifiesRegister. NFC..

I'd check if there are some calls of modifiesRegister that pass nullptr, the patch LGTM otherwise

Nov 2 2020, 1:32 AM · Restricted Project
yroux accepted D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.

(Sorry for the delay, I took some vacations)

Nov 2 2020, 1:29 AM · Restricted Project

Oct 16 2020

yroux added inline comments to D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.
Oct 16 2020, 5:53 AM · Restricted Project

Oct 12 2020

yroux added a comment to D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.

Thanks for raising this issue, I've two inlined comments

Oct 12 2020, 6:05 AM · Restricted Project

Oct 1 2020

yroux updated subscribers of D68364: Implement C++20's P0784 (More constexpr containers).

Hi Louis,

Oct 1 2020, 4:38 AM · Restricted Project, Restricted Project

Sep 17 2020

yroux committed rGdeb8f8bcf315: [ARM][MachineOutliner] Add missing testcase for calls. (authored by yroux).
[ARM][MachineOutliner] Add missing testcase for calls.
Sep 17 2020, 6:21 AM

Sep 16 2020

yroux committed rG070b96962f51: [ARM][MachineOutliner] Add calls handling. (authored by yroux).
[ARM][MachineOutliner] Add calls handling.
Sep 16 2020, 1:00 AM
yroux closed D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 16 2020, 1:00 AM · Restricted Project

Sep 14 2020

yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 14 2020, 5:09 AM · Restricted Project
yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 14 2020, 4:15 AM · Restricted Project

Sep 10 2020

yroux updated the diff for D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 10 2020, 4:38 AM · Restricted Project

Sep 8 2020

yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 8 2020, 6:41 AM · Restricted Project
yroux added inline comments to D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 8 2020, 6:35 AM · Restricted Project

Sep 4 2020

yroux requested review of D87136: [ARM][MachineOutliner] Add calls default handling..
Sep 4 2020, 4:56 AM · Restricted Project

Sep 1 2020

yroux added a comment to D86869: [zorg] Add flang to clang-cmake-aarch64-full.

LGTM

Sep 1 2020, 7:15 AM
yroux abandoned D76068: [ARM][MachineOutliner] Add NoLRSave and Register modes..

Thsi was committed as D80125 and D80127

Sep 1 2020, 5:04 AM · Restricted Project
yroux abandoned D83313: [MachineOutliner] Fix liveness computing..

Issue fixed by D40061

Sep 1 2020, 5:01 AM · Restricted Project

Aug 26 2020

yroux accepted D82951: [ARM] Enable outliner at -Oz for M-class.

Hi Sam,

Aug 26 2020, 11:58 PM · Restricted Project
yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

My bad, I applied the previous version where a branch was inserted in those tests but your last version is fine.

Aug 26 2020, 6:51 AM · Restricted Project
yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

Hi Sam,

Aug 26 2020, 1:37 AM · Restricted Project

Aug 25 2020

yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

I think a few more testcases need to be updated:

Aug 25 2020, 8:34 AM · Restricted Project

Aug 20 2020

yroux committed rG0459f29e8b0f: [ARM][MachineOutliner] Add default mode. (authored by yroux).
[ARM][MachineOutliner] Add default mode.
Aug 20 2020, 12:31 AM
yroux closed D76069: [ARM][MachineOutliner] Add default mode..
Aug 20 2020, 12:31 AM · Restricted Project

Aug 19 2020

yroux added a comment to D40061: [ARM] Make MachineVerifier more strict about terminators.

I've tested the patch and it fixes the liveness issue seen with Machine Outliner enabled.

Aug 19 2020, 9:32 AM · Restricted Project

Jul 27 2020

yroux updated the diff for D76069: [ARM][MachineOutliner] Add default mode..

Removed uneeded LR addition to live-in set.

Jul 27 2020, 6:53 AM · Restricted Project

Jul 23 2020

yroux added inline comments to D76069: [ARM][MachineOutliner] Add default mode..
Jul 23 2020, 5:30 AM · Restricted Project

Jul 20 2020

yroux updated the diff for D76069: [ARM][MachineOutliner] Add default mode..

I've extracted parts which handle calls inside outlined frames (I'll submit that in the next patch) and enhanced the testcases.

Jul 20 2020, 7:42 AM · Restricted Project

Jul 9 2020

yroux added a comment to D83313: [MachineOutliner] Fix liveness computing..

I guess I just don't understand why the BX_RET wouldn't be marked with using the link register in the first place?

Jul 9 2020, 6:28 AM · Restricted Project
yroux added a comment to D83313: [MachineOutliner] Fix liveness computing..

I'm not really happy with this approach; if LiveRegUnits isn't producing correct results, we should fix it, not try to hack around it.

Maybe we should revive D40061...

Jul 9 2020, 6:14 AM · Restricted Project

Jul 7 2020

Herald added a project to D83313: [MachineOutliner] Fix liveness computing.: Restricted Project.
Jul 7 2020, 8:22 AM · Restricted Project

Jul 1 2020

yroux added a comment to D82951: [ARM] Enable outliner at -Oz for M-class.

Hi Sam,

Jul 1 2020, 7:00 AM · Restricted Project

Jun 15 2020

yroux committed rGffe8f6d33bcc: [ARM][MachineOutliner] Fix no-lr-save testcase. (authored by yroux).
[ARM][MachineOutliner] Fix no-lr-save testcase.
Jun 15 2020, 7:34 AM
yroux committed rG669066de650a: [ARM][MachineOutliner] Add LR RegSave mode. (authored by yroux).
[ARM][MachineOutliner] Add LR RegSave mode.
Jun 15 2020, 6:29 AM
yroux closed D80127: [ARM][MachineOutliner] Add LR RegSave mode..
Jun 15 2020, 6:29 AM · Restricted Project

Jun 11 2020

yroux added a comment to D80127: [ARM][MachineOutliner] Add LR RegSave mode..

No there is 3 more patches in the set, one for the default mode (save/restore of lr on the stack), one which will add the support of calls in the outlined regions and the most tricky one which will fixup the stack to handle load/store. In the end we should reach ~3% of size reduction in T32 and ~5% in ARM (this is what I observed on average for various benchs).

Jun 11 2020, 7:09 AM · Restricted Project
yroux committed rG6b8628a1f036: [ARM][MachineOutliner] Add NoLRSave mode. (authored by yroux).
[ARM][MachineOutliner] Add NoLRSave mode.
Jun 11 2020, 12:01 AM
yroux closed D80125: [ARM][MachineOutliner] Add NoLRSave mode..
Jun 11 2020, 12:01 AM · Restricted Project

Jun 9 2020

yroux updated the diff for D80125: [ARM][MachineOutliner] Add NoLRSave mode..

Updated testcase

Jun 9 2020, 2:42 AM · Restricted Project
yroux added inline comments to D80127: [ARM][MachineOutliner] Add LR RegSave mode..
Jun 9 2020, 2:42 AM · Restricted Project
yroux updated the diff for D80127: [ARM][MachineOutliner] Add LR RegSave mode..

Change register class to rGPR for both modes and updated testcase

Jun 9 2020, 2:42 AM · Restricted Project
yroux added inline comments to D80125: [ARM][MachineOutliner] Add NoLRSave mode..
Jun 9 2020, 2:42 AM · Restricted Project

Jun 4 2020

yroux committed rG6b9e10224363: [ARM][MachineOutliner] Remove unneeded dynamic allocation. (authored by yroux).
[ARM][MachineOutliner] Remove unneeded dynamic allocation.
Jun 4 2020, 4:18 AM

May 18 2020

yroux created D80127: [ARM][MachineOutliner] Add LR RegSave mode..
May 18 2020, 8:34 AM · Restricted Project
yroux added a comment to D80125: [ARM][MachineOutliner] Add NoLRSave mode..

This was splitted from D76068

May 18 2020, 8:34 AM · Restricted Project
yroux created D80125: [ARM][MachineOutliner] Add NoLRSave mode..
May 18 2020, 8:34 AM · Restricted Project

May 15 2020

yroux committed rG3648dde3ddd3: [ARM][MachineOutliner] Fix memory leak #2. (authored by yroux).
[ARM][MachineOutliner] Fix memory leak #2.
May 15 2020, 8:40 AM
yroux committed rG96c4460a0be6: [ARM][MachineOutliner] Fix memory leak. (authored by yroux).
[ARM][MachineOutliner] Fix memory leak.
May 15 2020, 7:35 AM
yroux committed rG0e4827aa4e4a: [ARM][MachineOutliner] Add Machine Outliner support for ARM. (authored by yroux).
[ARM][MachineOutliner] Add Machine Outliner support for ARM.
May 15 2020, 12:09 AM
yroux closed D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
May 15 2020, 12:08 AM · Restricted Project, Restricted Project

May 13 2020

yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

I found a last issue when doing a full bootstrap with -moutline used to build clang, there was a case of thunk outlining where the original was call a BLX LR which was broken by the outlining call BL OUTLINE_FUNCTION_X I fixed this issue by checking the use of link register before handling calls and I've added a test case.

May 13 2020, 1:36 PM · Restricted Project, Restricted Project

May 6 2020

yroux added a comment to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Ah, yes, good point. Then I have nothing else, but definitely worth waiting to see if Eli has further comments.

May 6 2020, 1:02 AM · Restricted Project, Restricted Project

May 5 2020

yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
May 5 2020, 1:30 PM · Restricted Project, Restricted Project
yroux added a comment to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Thanks for adding the MVE changes, but I also still don't see any DSP tests, i.e QADD, SADD16.

May 5 2020, 1:30 PM · Restricted Project, Restricted Project

Apr 30 2020

yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

This update avoids outlining MVE instructions.

Apr 30 2020, 8:29 AM · Restricted Project, Restricted Project
yroux accepted D79161: Update parallelization settings on Linaro builders.

LGTM

Apr 30 2020, 3:01 AM
yroux added inline comments to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
Apr 30 2020, 2:44 AM · Restricted Project, Restricted Project

Apr 29 2020

yroux added inline comments to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
Apr 29 2020, 8:33 AM · Restricted Project, Restricted Project
yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
Apr 29 2020, 8:02 AM · Restricted Project, Restricted Project
yroux updated the diff for D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Here is a new update of the patch.

Apr 29 2020, 8:00 AM · Restricted Project, Restricted Project

Apr 9 2020

yroux added inline comments to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.
Apr 9 2020, 4:50 AM · Restricted Project, Restricted Project
yroux added a comment to D77648: [ARM][MVE] Tail predicate VML[A|S]LDAV.

Ok thanks, LGTM

Apr 9 2020, 4:50 AM · Restricted Project

Apr 8 2020

yroux added a comment to D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM.

Hi Sam,

Apr 8 2020, 8:39 AM · Restricted Project, Restricted Project