Page MenuHomePhabricator

xiangzhangllvm (Xiang Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 25 2018, 11:14 PM (108 w, 2 d)

Recent Activity

Yesterday

xiangzhangllvm added inline comments to D95136: [X86] Fix tile config register spill issue..
Thu, Jan 21, 11:50 PM · Restricted Project
xiangzhangllvm added inline comments to D95136: [X86] Fix tile config register spill issue..
Thu, Jan 21, 11:08 PM · Restricted Project
xiangzhangllvm added inline comments to D95136: [X86] Fix tile config register spill issue..
Thu, Jan 21, 9:53 PM · Restricted Project

Sat, Jan 16

xiangzhangllvm added inline comments to D94155: [X86] Fix tile config register spill issue..
Sat, Jan 16, 5:44 PM · Restricted Project

Dec 21 2020

xiangzhangllvm added inline comments to D63908: hwasan: Improve precision of checks using short granule tags..
Dec 21 2020, 11:43 PM · Restricted Project, Restricted Project, Restricted Project

Dec 16 2020

xiangzhangllvm committed rG39584ae5b5cb: [Debugify] Support checking Machine IR debug info (authored by xiangzhangllvm).
[Debugify] Support checking Machine IR debug info
Dec 16 2020, 10:18 PM
xiangzhangllvm added a reverting change for rG50aaa8c27491: [Debugify] Support checking Machine IR debug info: rG1e42ad9d6291: Revert "[Debugify] Support checking Machine IR debug info".
Dec 16 2020, 8:13 PM
xiangzhangllvm committed rG1e42ad9d6291: Revert "[Debugify] Support checking Machine IR debug info" (authored by xiangzhangllvm).
Revert "[Debugify] Support checking Machine IR debug info"
Dec 16 2020, 8:13 PM
xiangzhangllvm added a reverting change for D91595: [Debugify] Support checking Machine IR debug info: rG1e42ad9d6291: Revert "[Debugify] Support checking Machine IR debug info".
Dec 16 2020, 8:13 PM · Restricted Project
xiangzhangllvm committed rG50aaa8c27491: [Debugify] Support checking Machine IR debug info (authored by xiangzhangllvm).
[Debugify] Support checking Machine IR debug info
Dec 16 2020, 6:06 PM
xiangzhangllvm closed D91595: [Debugify] Support checking Machine IR debug info.
Dec 16 2020, 6:05 PM · Restricted Project
xiangzhangllvm added a comment to D91595: [Debugify] Support checking Machine IR debug info.

As this review has last so long, (1 month), It has accepted before and I fixed all reviewers' comments except @vsk 's "merging" suggestion.
I want to let this patch in first.
About @vsk 's "merging" suggestion, I am almost sure that the code will be some ugly compared with current code,
So I'll use another special patch to handle his "merging" suggestion, let/wait @vsk to accept it or not.
tks!

Dec 16 2020, 3:50 PM · Restricted Project

Dec 15 2020

xiangzhangllvm added a comment to D91595: [Debugify] Support checking Machine IR debug info.

Imo this overstates the difficulty of code sharing in this context, and underweights the potential long-term effects of having divergent code paths that are supposed to do the same thing. I urge you to reconsider :).

Hi @vsk, I am fine to merge if you still feel the following explanation doesn't hold water:

  1. The logic here not 100% same, currently, mir-check doesn't check the phi node. (which will eliminate at back end)
  2. I still feel it is trouble to "Distinguish isa<DbgValueInst>(&I) with MI.isDebugValue() and so on"
  3. In my eyes, the small logic of ir/mir check here is just happen to be same/similar, not must (or no need) to be, make them not affect each other is better.
Dec 15 2020, 3:47 PM · Restricted Project
xiangzhangllvm added a comment to D91595: [Debugify] Support checking Machine IR debug info.

Hello @vsk ,could you help accept it ?

Dec 15 2020, 12:36 AM · Restricted Project
xiangzhangllvm updated the diff for D91595: [Debugify] Support checking Machine IR debug info.

Update affected tests: AArch64/GlobalISel/constant-mir-debugify.mir and phi-mir-debugify.mir
Because this patch add metadata "llvm.mir.debugify", it affected the index of some old test.
For e.g. change Checking "debug-location !10" to Checking "debug-location !11"

Dec 15 2020, 12:34 AM · Restricted Project
xiangzhangllvm reopened D91595: [Debugify] Support checking Machine IR debug info.
Dec 15 2020, 12:28 AM · Restricted Project
xiangzhangllvm added a comment to D91595: [Debugify] Support checking Machine IR debug info.

OK, thanks for reminding.

Dec 15 2020, 12:06 AM · Restricted Project

Dec 14 2020

xiangzhangllvm updated subscribers of D91595: [Debugify] Support checking Machine IR debug info.

Apologies, I reverted this because else reverting D78135 https://reviews.llvm.org/D78135 which breaks check-llvm) creates merge conflicts that I can't quickly figure out.

Yes, it cause fail in the tests of D78135, I'll update it. thank you.

Dec 14 2020, 7:44 PM · Restricted Project
xiangzhangllvm committed rGc4d2d4337d50: [Debugify] Support checking Machine IR debug info (authored by xiangzhangllvm).
[Debugify] Support checking Machine IR debug info
Dec 14 2020, 5:54 PM
xiangzhangllvm closed D91595: [Debugify] Support checking Machine IR debug info.
Dec 14 2020, 5:54 PM · Restricted Project
xiangzhangllvm added a reverting change for rG57a3d9ec4a8c: [Debugify] Support checking Machine IR debug info: rGfc0f4010bb4c: Revert "[Debugify] Support checking Machine IR debug info".
Dec 14 2020, 5:49 PM
xiangzhangllvm committed rGfc0f4010bb4c: Revert "[Debugify] Support checking Machine IR debug info" (authored by xiangzhangllvm).
Revert "[Debugify] Support checking Machine IR debug info"
Dec 14 2020, 5:49 PM
xiangzhangllvm committed rG57a3d9ec4a8c: [Debugify] Support checking Machine IR debug info (authored by xiangzhangllvm).
[Debugify] Support checking Machine IR debug info
Dec 14 2020, 5:38 PM

Dec 3 2020

xiangzhangllvm committed rGf2e292446334: [X86] Unbind the ebx with GOT address in regcall calling convention (authored by xiangzhangllvm).
[X86] Unbind the ebx with GOT address in regcall calling convention
Dec 3 2020, 6:02 PM
xiangzhangllvm closed D91020: [X86] Unbind the ebx with GOT address in regcall calling convention.
Dec 3 2020, 6:02 PM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Dec 3 2020, 4:45 PM · Restricted Project

Dec 2 2020

xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Dec 2 2020, 4:38 PM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Dec 2 2020, 4:29 PM · Restricted Project

Dec 1 2020

xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Dec 1 2020, 7:15 PM · Restricted Project
xiangzhangllvm updated the diff for D91595: [Debugify] Support checking Machine IR debug info.

Mark TODO for DBG_INSTR_REF and refine docs/HowToUpdateDebugInfo.rst

Dec 1 2020, 7:11 PM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Dec 1 2020, 4:42 PM · Restricted Project
xiangzhangllvm added a comment to D91020: [X86] Unbind the ebx with GOT address in regcall calling convention.

Thank you! Pls wait for 1 or 2 days to see if any other reviews have any comments.

Dec 1 2020, 3:59 PM · Restricted Project

Nov 30 2020

xiangzhangllvm added a comment to D91020: [X86] Unbind the ebx with GOT address in regcall calling convention.

ping
@LuoYuanke I see you give the most comments, could you +1 for this patch. tks

Nov 30 2020, 9:50 PM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 30 2020, 9:45 PM · Restricted Project

Nov 28 2020

xiangzhangllvm added inline comments to D91020: [X86] Unbind the ebx with GOT address in regcall calling convention.
Nov 28 2020, 11:31 PM · Restricted Project
xiangzhangllvm updated the diff for D91020: [X86] Unbind the ebx with GOT address in regcall calling convention.
Nov 28 2020, 11:18 PM · Restricted Project

Nov 26 2020

xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 26 2020, 3:58 PM · Restricted Project
xiangzhangllvm updated the diff for D91595: [Debugify] Support checking Machine IR debug info.
Nov 26 2020, 3:12 AM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 26 2020, 2:57 AM · Restricted Project

Nov 25 2020

xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 25 2020, 9:30 PM · Restricted Project

Nov 24 2020

xiangzhangllvm added a comment to D91595: [Debugify] Support checking Machine IR debug info.

Thanks very much for your reviews!!

Nov 24 2020, 4:34 PM · Restricted Project
xiangzhangllvm updated the diff for D91595: [Debugify] Support checking Machine IR debug info.
Nov 24 2020, 4:22 PM · Restricted Project

Nov 23 2020

xiangzhangllvm added a reviewer for D91020: [X86] Unbind the ebx with GOT address in regcall calling convention: andrew.w.kaylor.
Nov 23 2020, 9:13 PM · Restricted Project
xiangzhangllvm added inline comments to D91020: [X86] Unbind the ebx with GOT address in regcall calling convention.
Nov 23 2020, 8:08 PM · Restricted Project
xiangzhangllvm updated the diff for D91595: [Debugify] Support checking Machine IR debug info.
Nov 23 2020, 5:36 PM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 23 2020, 4:35 PM · Restricted Project

Nov 20 2020

xiangzhangllvm updated the diff for D91595: [Debugify] Support checking Machine IR debug info.
Nov 20 2020, 7:53 PM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 20 2020, 1:03 AM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 20 2020, 12:01 AM · Restricted Project

Nov 18 2020

xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 18 2020, 9:45 PM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 18 2020, 9:39 PM · Restricted Project
xiangzhangllvm updated the diff for D91595: [Debugify] Support checking Machine IR debug info.
Nov 18 2020, 9:29 PM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 18 2020, 6:01 PM · Restricted Project
xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 18 2020, 4:34 PM · Restricted Project

Nov 17 2020

xiangzhangllvm added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 17 2020, 5:48 PM · Restricted Project
xiangzhangllvm updated the diff for D91595: [Debugify] Support checking Machine IR debug info.
Nov 17 2020, 5:47 PM · Restricted Project
xiangzhangllvm added a comment to D91595: [Debugify] Support checking Machine IR debug info.

All done, @djtodoro thanks very much for you review !

Nov 17 2020, 5:26 PM · Restricted Project
xiangzhangllvm updated the diff for D91595: [Debugify] Support checking Machine IR debug info.
Nov 17 2020, 5:24 PM · Restricted Project
xiangzhangllvm updated the summary of D91595: [Debugify] Support checking Machine IR debug info.
Nov 17 2020, 12:59 AM · Restricted Project
xiangzhangllvm requested review of D91595: [Debugify] Support checking Machine IR debug info.
Nov 17 2020, 12:58 AM · Restricted Project

Nov 7 2020

xiangzhangllvm added inline comments to D91020: [X86] Unbind the ebx with GOT address in regcall calling convention.
Nov 7 2020, 10:55 PM · Restricted Project
xiangzhangllvm added inline comments to D91020: [X86] Unbind the ebx with GOT address in regcall calling convention.
Nov 7 2020, 6:42 PM · Restricted Project
xiangzhangllvm added reviewers for D91020: [X86] Unbind the ebx with GOT address in regcall calling convention: craig.topper, LuoYuanke, pengfei, annita.zhang, wxiao3, MaskRay, thanm.
Nov 7 2020, 5:49 PM · Restricted Project
xiangzhangllvm requested review of D91020: [X86] Unbind the ebx with GOT address in regcall calling convention.
Nov 7 2020, 5:45 PM · Restricted Project

Nov 3 2020

xiangzhangllvm committed rG7ba3293691be: [StackColoring] Conservatively merge catch point of V for catch(V) (authored by xiangzhangllvm).
[StackColoring] Conservatively merge catch point of V for catch(V)
Nov 3 2020, 6:55 PM
xiangzhangllvm closed D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Nov 3 2020, 6:55 PM · Restricted Project
xiangzhangllvm added a comment to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).

Then you can change your test case name to pr48064.mir

OK, good, I'll change it in committing.

Nov 3 2020, 4:50 PM · Restricted Project
xiangzhangllvm added a comment to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).

I created a bug ID (48064) for it https://bugs.llvm.org/show_bug.cgi?id=48064

Nov 3 2020, 4:37 PM · Restricted Project
xiangzhangllvm added a comment to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).

LGTM. Is there a bug number associated with this?

Nov 3 2020, 3:53 PM · Restricted Project

Nov 2 2020

xiangzhangllvm added a comment to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).

Thanks for your review !

Nov 2 2020, 6:42 PM · Restricted Project
xiangzhangllvm updated the diff for D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Nov 2 2020, 6:39 PM · Restricted Project
xiangzhangllvm added a comment to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).

Hello @thanm, I think you care about this patch/bug, do you have additional comments? If you feel my idea is reasonable, could you help accept this patch, thank you again!

Nov 2 2020, 12:35 AM · Restricted Project

Oct 28 2020

xiangzhangllvm added a comment to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).

First, I thanks for your careful reviewing.
The windows Exception model has work well for many years, I tend not to change it. If we carefully watch the catch values (e.g. Type * *exp.i), we will find that they usually have a very long life range guarded by lifetime.start and lifetime.end, (usually almost equal with the whole function life range).
This seems that the front/mid ends don't want to do much optimization on this special mechanism, because in their eyes, the back-end optimization should based on the lifetime.start and lifetime.end they generated.
And if we reflected it in the IR, it will bring much complexity into current clear mid end IR, because every function in try block (may contain branch) need to reflected that it may change the catch values (e.g. Type * *exp.i).
I also find that, current "-stackcoloring-lifetime-start-on-first-use" didn't handle the multi-lifetime.start/end case, catch value may has multi-first use. it is make sense to handle the corner case of catch variable in this option.
What's more, current patch is simple and clear, I think it is the most probably easiest way to fix this bug.

Oct 28 2020, 5:48 PM · Restricted Project

Oct 27 2020

xiangzhangllvm abandoned D88194: [X86] CET endbr enhance.

OK

Oct 27 2020, 8:18 PM · Restricted Project
xiangzhangllvm added a comment to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).

Unlike linux, usually by @__cxa_begin_catch ,windows Exception didn't has a suitable port to reflect how it change the catch value, it is more like a "ABI" action, where the throw impliedly write and where the catch block get it.
I think the early designer do this mainly because the catch value (e.g. type** exp.i), is only used in adjacent catch block.

Oct 27 2020, 6:41 AM · Restricted Project

Oct 26 2020

xiangzhangllvm added inline comments to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 26 2020, 11:45 PM · Restricted Project
xiangzhangllvm updated the summary of D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 26 2020, 11:27 PM · Restricted Project
xiangzhangllvm updated the summary of D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 26 2020, 11:26 PM · Restricted Project
xiangzhangllvm added inline comments to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 26 2020, 11:24 PM · Restricted Project
xiangzhangllvm updated the diff for D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 26 2020, 11:17 PM · Restricted Project
xiangzhangllvm updated the diff for D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 26 2020, 8:52 PM · Restricted Project
xiangzhangllvm added inline comments to D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 26 2020, 5:54 PM · Restricted Project

Oct 25 2020

xiangzhangllvm updated the summary of D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 25 2020, 6:59 PM · Restricted Project
xiangzhangllvm updated the diff for D86673: [StackColoring] Conservatively merge point pV = &(&Variable) in catch(Variable).
Oct 25 2020, 6:58 PM · Restricted Project

Oct 24 2020

xiangzhangllvm added a comment to D89178: [X86] Alternate implementation of D88194..

Are we ok with this implementation?

I don't have a great way to protect intrinsics not using TargetConstant properly in the future, but I think we're ok at the moment based on what I see in the isel table.

Oct 24 2020, 11:36 PM · Restricted Project

Oct 21 2020

xiangzhangllvm added a comment to D88631: [X86] Support customizing stack protector guard.

TKS all review!!

Oct 21 2020, 7:11 PM · Restricted Project, Restricted Project
xiangzhangllvm committed rG7c3fea7721e4: [X86] Support customizing stack protector guard (authored by xiangzhangllvm).
[X86] Support customizing stack protector guard
Oct 21 2020, 7:09 PM
xiangzhangllvm closed D88631: [X86] Support customizing stack protector guard.
Oct 21 2020, 7:08 PM · Restricted Project, Restricted Project

Oct 20 2020

xiangzhangllvm updated the diff for D88631: [X86] Support customizing stack protector guard.
Oct 20 2020, 6:48 PM · Restricted Project, Restricted Project

Oct 19 2020

xiangzhangllvm added inline comments to D88631: [X86] Support customizing stack protector guard.
Oct 19 2020, 5:17 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D88631: [X86] Support customizing stack protector guard.
Oct 19 2020, 1:36 AM · Restricted Project, Restricted Project

Oct 18 2020

xiangzhangllvm updated the diff for D88631: [X86] Support customizing stack protector guard.
Oct 18 2020, 7:49 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D88631: [X86] Support customizing stack protector guard.
Oct 18 2020, 7:46 PM · Restricted Project, Restricted Project

Oct 15 2020

xiangzhangllvm added a comment to D88631: [X86] Support customizing stack protector guard.

TKS for reviewing!

Oct 15 2020, 11:45 PM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D88631: [X86] Support customizing stack protector guard.
Oct 15 2020, 11:34 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D88631: [X86] Support customizing stack protector guard.

ping

Oct 15 2020, 12:12 AM · Restricted Project, Restricted Project

Oct 12 2020

xiangzhangllvm added a comment to D88194: [X86] CET endbr enhance.

Thanks for your reviews! Please let me suspend this patch first.

Oct 12 2020, 2:12 AM · Restricted Project

Oct 9 2020

xiangzhangllvm added inline comments to D89178: [X86] Alternate implementation of D88194..
Oct 9 2020, 9:59 PM · Restricted Project
xiangzhangllvm added a comment to D88194: [X86] CET endbr enhance.

Ok, I don't have any other questions/comments (other than it would still be helpful to reduce/pre-commit the tests).

Oct 9 2020, 6:42 PM · Restricted Project
xiangzhangllvm updated the diff for D88194: [X86] CET endbr enhance.
Oct 9 2020, 6:40 PM · Restricted Project