Page MenuHomePhabricator

wwei (weiwei)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 29 2018, 8:48 PM (118 w, 2 d)

Recent Activity

Nov 20 2020

wwei committed rG1cd19fc5681b: [DeadMachineInstrctionElim] Post order visit all blocks and Iteratively run… (authored by wwei).
[DeadMachineInstrctionElim] Post order visit all blocks and Iteratively run…
Nov 20 2020, 9:03 AM
wwei closed D91513: [DeadMachineInstrctionElim] Post order visit all blocks and Iteratively run DeadMachineInstructionElim pass until nothing dead.
Nov 20 2020, 9:03 AM · Restricted Project

Nov 18 2020

wwei committed rGea7ab5a42cd4: [IndVarSimplify] Notify top most loop to drop cached exit counts (authored by wwei).
[IndVarSimplify] Notify top most loop to drop cached exit counts
Nov 18 2020, 11:58 PM
wwei closed D91325: [IndVarSimplify] Notify top most loop to drop cached exit counts.
Nov 18 2020, 11:57 PM · Restricted Project
wwei added a comment to D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..

ping

Nov 18 2020, 9:04 AM · Restricted Project

Oct 8 2020

wwei added inline comments to D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..
Oct 8 2020, 7:58 AM · Restricted Project
wwei added inline comments to D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..
Oct 8 2020, 3:00 AM · Restricted Project
wwei updated the diff for D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..
Oct 8 2020, 2:57 AM · Restricted Project

Sep 23 2020

wwei committed rGc2deacd929da: [AArch64] Fix ldst optimization of non-immediate store offset (authored by wwei).
[AArch64] Fix ldst optimization of non-immediate store offset
Sep 23 2020, 8:20 AM
wwei closed D87905: [AArch64] Fix ldst optimization of non-immediate store offset.
Sep 23 2020, 8:20 AM · Restricted Project

Sep 22 2020

wwei added a comment to D87905: [AArch64] Fix ldst optimization of non-immediate store offset.

Update test case by using MIR

Sep 22 2020, 1:55 AM · Restricted Project
wwei updated the diff for D87905: [AArch64] Fix ldst optimization of non-immediate store offset.
Sep 22 2020, 1:51 AM · Restricted Project

Sep 21 2020

wwei added a comment to D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..

ping

Sep 21 2020, 4:30 AM · Restricted Project

Sep 18 2020

wwei requested review of D87905: [AArch64] Fix ldst optimization of non-immediate store offset.
Sep 18 2020, 7:24 AM · Restricted Project
wwei committed rG8f09cec8c999: [AArch64] Add tests for zext pattern match with AssertZext/AssertSext operand… (authored by wwei).
[AArch64] Add tests for zext pattern match with AssertZext/AssertSext operand…
Sep 18 2020, 12:24 AM

Sep 17 2020

wwei committed rG992698cfbc89: [AArch64] Emit zext move when the source of the zext is AssertZext or AssertSext (authored by wwei).
[AArch64] Emit zext move when the source of the zext is AssertZext or AssertSext
Sep 17 2020, 10:09 PM
wwei closed D87771: [AArch64] Emit zext move when the source of the zext is AssertZext or AssertSext.
Sep 17 2020, 10:09 PM · Restricted Project
wwei added inline comments to D87771: [AArch64] Emit zext move when the source of the zext is AssertZext or AssertSext.
Sep 17 2020, 10:10 AM · Restricted Project
wwei added inline comments to D87771: [AArch64] Emit zext move when the source of the zext is AssertZext or AssertSext.
Sep 17 2020, 9:30 AM · Restricted Project
wwei updated the diff for D87771: [AArch64] Emit zext move when the source of the zext is AssertZext or AssertSext.
Sep 17 2020, 9:27 AM · Restricted Project
wwei added a comment to D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..

update test cases mentioned in PR47462

Sep 17 2020, 9:25 AM · Restricted Project
wwei updated the diff for D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..
Sep 17 2020, 9:24 AM · Restricted Project

Sep 16 2020

wwei requested review of D87771: [AArch64] Emit zext move when the source of the zext is AssertZext or AssertSext.
Sep 16 2020, 8:51 AM · Restricted Project

Sep 9 2020

wwei added inline comments to D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..
Sep 9 2020, 6:35 AM · Restricted Project
wwei added inline comments to D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..
Sep 9 2020, 5:56 AM · Restricted Project
wwei updated the diff for D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..
Sep 9 2020, 5:46 AM · Restricted Project

Sep 8 2020

wwei requested review of D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..
Sep 8 2020, 9:52 AM · Restricted Project

Sep 7 2020

wwei committed rG78071fb52456: [LSR] Canonicalize a formula before insert it into the list (authored by wwei).
[LSR] Canonicalize a formula before insert it into the list
Sep 7 2020, 10:40 PM
wwei closed D86939: [LSR] Canonicalize a formula before insert it into the list.
Sep 7 2020, 10:39 PM · Restricted Project

Jul 19 2020

wwei added a comment to D83644: [AArch64][ELF] Support FDE references more than +/-2GB range for AArch64 large code model.

ping

Jul 19 2020, 6:15 PM · Restricted Project

Jul 13 2020

wwei added inline comments to D83644: [AArch64][ELF] Support FDE references more than +/-2GB range for AArch64 large code model.
Jul 13 2020, 9:37 AM · Restricted Project
wwei updated the diff for D83644: [AArch64][ELF] Support FDE references more than +/-2GB range for AArch64 large code model.

update test case

Jul 13 2020, 9:31 AM · Restricted Project

Jul 12 2020

Herald added a reviewer for D83644: [AArch64][ELF] Support FDE references more than +/-2GB range for AArch64 large code model: espindola.
Jul 12 2020, 9:37 AM · Restricted Project

Mar 18 2020

wwei added inline comments to D57779: [SLP] Add support for throttling..
Mar 18 2020, 11:19 PM · Restricted Project

Mar 16 2020

wwei added a comment to D57779: [SLP] Add support for throttling..

Do you have any plan to support throttling for horizontal reduction?

Mar 16 2020, 10:20 AM · Restricted Project

Feb 18 2020

wwei committed rG4ca753f4e3ed: [RISCV] Implement mayBeEmittedAsTailCall for tail call optimization (authored by wwei).
[RISCV] Implement mayBeEmittedAsTailCall for tail call optimization
Feb 18 2020, 7:59 AM
wwei closed D73699: [RISCV] Implement mayBeEmittedAsTailCall for tail call optimization.
Feb 18 2020, 7:58 AM · Restricted Project

Feb 11 2020

wwei committed rGdb875f665544: [RISCV] Optimize seteq/setne pattern expansions for better code size (authored by wwei).
[RISCV] Optimize seteq/setne pattern expansions for better code size
Feb 11 2020, 6:47 AM
wwei closed D71774: [RISCV] Optimize seteq/setne pattern expansions for better code size.
Feb 11 2020, 6:46 AM · Restricted Project

Feb 10 2020

wwei added inline comments to D73699: [RISCV] Implement mayBeEmittedAsTailCall for tail call optimization.
Feb 10 2020, 6:21 AM · Restricted Project
wwei updated the diff for D73699: [RISCV] Implement mayBeEmittedAsTailCall for tail call optimization.

update test case for this patch

Feb 10 2020, 6:21 AM · Restricted Project

Jan 30 2020

wwei added inline comments to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Jan 30 2020, 9:00 AM · Restricted Project
wwei added inline comments to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Jan 30 2020, 8:50 AM · Restricted Project
wwei added inline comments to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Jan 30 2020, 8:50 AM · Restricted Project
wwei added inline comments to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Jan 30 2020, 8:50 AM · Restricted Project
wwei updated the diff for D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Jan 30 2020, 8:50 AM · Restricted Project
wwei created D73699: [RISCV] Implement mayBeEmittedAsTailCall for tail call optimization.
Jan 30 2020, 5:45 AM · Restricted Project
wwei added a comment to D71774: [RISCV] Optimize seteq/setne pattern expansions for better code size.

This seems like a fun issue:

  • addi is compressible
  • xor is almost certainly easier to analyse (from the view of KnownBits and the like).

Have you seen any regressions in code generation from this change?

No, there's no any regressions. For the case where the register is compared with an immediate value (equal or unequal), using xori or addi with neg imm in the pattern seteq or setne is equivalent, in order to get a result equal to 0 or not equal to 0.

Jan 30 2020, 1:15 AM · Restricted Project

Jan 13 2020

wwei committed rG05366870eed1: [LegalizeTypes] Add SoftenFloatResult support for… (authored by wwei).
[LegalizeTypes] Add SoftenFloatResult support for…
Jan 13 2020, 9:10 AM
wwei closed D72277: [LegalizeTypes] Add SoftenFloatResult support for STRICT_SINT_TO_FP/STRICT_UINT_TO_FP.
Jan 13 2020, 9:10 AM · Restricted Project

Jan 6 2020

wwei created D72277: [LegalizeTypes] Add SoftenFloatResult support for STRICT_SINT_TO_FP/STRICT_UINT_TO_FP.
Jan 6 2020, 8:28 AM · Restricted Project

Dec 20 2019

wwei added a comment to D71774: [RISCV] Optimize seteq/setne pattern expansions for better code size.

The case was from dhrystone(dhry_2.c):

Boolean Func_3 (Enum_Par_Val)
/***************************/
    /* executed once        */
    /* Enum_Par_Val == Ident_3 */
Dec 20 2019, 9:19 AM · Restricted Project
wwei created D71774: [RISCV] Optimize seteq/setne pattern expansions for better code size.
Dec 20 2019, 9:10 AM · Restricted Project

Dec 18 2019

wwei added inline comments to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Dec 18 2019, 9:17 AM · Restricted Project
wwei updated the diff for D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..

Fix some typos and add a new function lowerReturnVal

Dec 18 2019, 9:07 AM · Restricted Project
wwei added inline comments to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Dec 18 2019, 9:03 AM · Restricted Project
wwei added inline comments to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Dec 18 2019, 8:44 AM · Restricted Project

Nov 4 2019

wwei created D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Nov 4 2019, 9:51 AM · Restricted Project

Jul 31 2019

wwei added a comment to D62007: [RISCV] Minimal stack realignment support.

@lenary @asb It seems that PEI::calculateFrameObjectOffsets function in PrologEpilogInserter pass has done some stack size rounding up work. Each stack object will call AdjustStackOffset to adjust the stack frame offset, and corresponding update may be made for MaxAlign.
Also, there's a TFI hook targetHandlesStackFrameRounding to decide if the target is responsible for rounding up the stack frame(default return false). For RISCV, maybe this function should return true I think, thus the stack size for StackRealignment will be calculated at RISCV's emitPrologue time.
For the implementation in this patch, the stack size for StackRealignment will be calculathed two times, one in PEI::calculateFrameObjectOffsets, another time in RISCVFrameLowering::determineFrameLayout, and the stack size may become bigger.)

Jul 31 2019, 7:51 AM · Restricted Project

Jul 29 2019

wwei abandoned D65218: [RISCV] Make input/output args analyzing functions public.
Jul 29 2019, 6:29 PM · Restricted Project
wwei added a comment to D65218: [RISCV] Make input/output args analyzing functions public.

Please can you merge this into D65219, given these changes are relevant to that patch? It's hard to know if these changes are "correct" without the context of that patch.

Jul 29 2019, 8:26 AM · Restricted Project

Jul 28 2019

wwei updated the diff for D65219: [RISCV GlobalISel] Adding initial GlobalISel infrastructure.

Some changes for this update:

  1. Rename the GPRRegBank from GPR to GPRB
  2. Add using of RISCVInstructionSelector::selectImpl in RISCVInstructionSelector.cpp.
  3. Add a seperate test case for running all globalisel passes.
Jul 28 2019, 9:20 AM · Restricted Project

Jul 24 2019

wwei created D65219: [RISCV GlobalISel] Adding initial GlobalISel infrastructure.
Jul 24 2019, 9:25 AM · Restricted Project
wwei created D65218: [RISCV] Make input/output args analyzing functions public.
Jul 24 2019, 9:20 AM · Restricted Project

Nov 29 2018

wwei created D55106: A new software pipliner pass based on non-SSA form.
Nov 29 2018, 11:45 PM