User Details
- User Since
- Feb 20 2015, 10:57 AM (308 w, 4 d)
Today
Yesterday
Fri, Jan 15
LGTM. Thanks.
Thu, Jan 14
LGTM. Thanks.
Wed, Jan 13
Address Hongtao's comment.
Address Hongtao's comment.
Address Wenlei and David's comments.
Tue, Jan 12
I guess there will be a separate patch to turn on this work, i.e, setting CtxSplitLayout?
LGTM.
LGTM.
Sorry for the delay in review. It makes a lot of sense to have a priority based inliner for CSSPGO since its profile annotation doesn't rely on replaying the inlining. But I don't understand why we rely on BFS/DFS strategy to expose the hottest callsite for priority based inliner. In my mind, CSSPGO can know the hotness of each callsite with full context information. Can we just sort all the callsites based on CSSPGO profile then try to inline the hottest callsite under a specific context first in a top down manner? We may actually need to inline some parent callsites before we can inline the hottest callsite, but it is all driven by the target to inline the hottest callsite first. If we worry some callsite is too deep and we need to inline through a deep path before we can inline the specific callsite, we may add the depth into priority computation. What do you think?
Mon, Jan 11
Sun, Jan 10
This change speeds up this by grouping all the call frame within one LBR sample into a trie and aggregating the result(sample counter) on it.
Fri, Jan 8
Sorry for the delay in review. I will try to catch up.
Thu, Jan 7
Sorry for the delay. LGTM.
Dec 17 2020
Thanks to Simon Pilgrim who helped to fix it at
https://reviews.llvm.org/rG4bb10be9a6e06a6c51cc1695ff5dc9d68c953334.
Dec 16 2020
Address Hongtao's comment.
LGTM.
Address Hongtao's comment.
Dec 15 2020
The const indices passed to writeOneSection were incorrect (from a stale patch). Upload the latest version.
Dec 14 2020
Dec 13 2020
Dec 9 2020
Please add a message for all the assertions. Other than that, LGTM.
Dec 8 2020
Sorry for the delay in review. Some general questions.
Dec 7 2020
LGTM.
Dec 4 2020
Address Hongtao's comment.
Address David and Hongtao's comments.
Dec 3 2020
Dec 2 2020
LGTM.
Dec 1 2020
Another question. Sorry for not bringing it up earlier. When a call with probe metadata attached is inlined, the probe will be gone or it will be kept somehow? I think you want to keep the probe especially for inline instance to reconstruct the context but I didn't figure it out how you did that from the description.
Nov 30 2020
Nov 25 2020
LGTM.
LGTM.
Nov 24 2020
LGTM.
Nov 20 2020
LGTM.
Nov 19 2020
By the way, David has gone through the patches and talked to me offline saying he is ok with the patches generally. Thanks for your great work and patience!
LGTM.
Nov 18 2020
Nov 16 2020
LGTM.
Nov 13 2020
LGTM.