Page MenuHomePhabricator

wlei (Lei Wang)
Software Engineer at Facebook

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2020, 11:36 PM (18 w, 5 d)

Recent Activity

Fri, Jan 22

wlei added inline comments to D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.
Fri, Jan 22, 5:44 PM · Restricted Project
wlei updated the diff for D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.

Removed the dangling probe related code, solution will come in another patch

Fri, Jan 22, 5:44 PM · Restricted Project

Thu, Jan 21

wlei added inline comments to D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Thu, Jan 21, 12:33 PM · Restricted Project
wlei added inline comments to D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Thu, Jan 21, 10:00 AM · Restricted Project
wlei updated the diff for D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.

addressing Wenlei's feedback, added line-based test

Thu, Jan 21, 9:53 AM · Restricted Project

Wed, Jan 20

wlei added inline comments to D94111: [CSSPGO][llvm-profgen] Merge and trim profile for cold context to reduce profile size.
Wed, Jan 20, 10:40 AM · Restricted Project

Tue, Jan 19

wlei added inline comments to D94110: [CSSPGO][llvm-profgen] Aggregate samples on call frame trie to speed up profile generation.
Tue, Jan 19, 9:59 PM · Restricted Project
wlei updated the diff for D94110: [CSSPGO][llvm-profgen] Aggregate samples on call frame trie to speed up profile generation.

addressing Hongtao's feedback

Tue, Jan 19, 9:59 PM · Restricted Project
wlei committed rGdaeea961a6d9: [llvm-profgen][NFC] Fix the incorrect computation of callsite sample count (authored by wlei).
[llvm-profgen][NFC] Fix the incorrect computation of callsite sample count
Tue, Jan 19, 6:11 PM
wlei closed D95009: [llvm-profgen][NFC] Fix the incorrect computation of callsite sample count.
Tue, Jan 19, 6:11 PM · Restricted Project
wlei updated the diff for D95009: [llvm-profgen][NFC] Fix the incorrect computation of callsite sample count.

remove updateBodySamplesforFunctionProfile and redundant check

Tue, Jan 19, 5:34 PM · Restricted Project
wlei added inline comments to D95009: [llvm-profgen][NFC] Fix the incorrect computation of callsite sample count.
Tue, Jan 19, 5:01 PM · Restricted Project
wlei added inline comments to D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Tue, Jan 19, 4:45 PM · Restricted Project
wlei updated the diff for D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.

addressing Hongtao's feedback

Tue, Jan 19, 4:44 PM · Restricted Project
wlei updated the summary of D95009: [llvm-profgen][NFC] Fix the incorrect computation of callsite sample count.
Tue, Jan 19, 4:26 PM · Restricted Project
wlei requested review of D95009: [llvm-profgen][NFC] Fix the incorrect computation of callsite sample count.
Tue, Jan 19, 4:20 PM · Restricted Project
wlei added inline comments to D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Tue, Jan 19, 9:29 AM · Restricted Project
wlei updated the diff for D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.

addressing Hongtao's feedback

Tue, Jan 19, 9:27 AM · Restricted Project

Fri, Jan 15

wlei added inline comments to D94111: [CSSPGO][llvm-profgen] Merge and trim profile for cold context to reduce profile size.
Fri, Jan 15, 2:40 PM · Restricted Project
wlei updated the diff for D94111: [CSSPGO][llvm-profgen] Merge and trim profile for cold context to reduce profile size.

fix typo and rebase

Fri, Jan 15, 2:35 PM · Restricted Project
wlei added inline comments to D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.
Fri, Jan 15, 2:08 PM · Restricted Project
wlei updated the diff for D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.

fix typo

Fri, Jan 15, 2:05 PM · Restricted Project
wlei updated the diff for D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.

Addressing Wei's feedback

Fri, Jan 15, 1:55 PM · Restricted Project
wlei added inline comments to D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Fri, Jan 15, 9:57 AM · Restricted Project
wlei updated the diff for D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.

Remove more redundancy cases during deduplication

Fri, Jan 15, 9:53 AM · Restricted Project

Thu, Jan 14

wlei added inline comments to D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Thu, Jan 14, 4:58 PM · Restricted Project
wlei added inline comments to D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Thu, Jan 14, 3:52 PM · Restricted Project
wlei updated the diff for D94111: [CSSPGO][llvm-profgen] Merge and trim profile for cold context to reduce profile size.

Refine the cl::desc for CSProfColdThres and CSProfKeepCold

Thu, Jan 14, 3:03 PM · Restricted Project
wlei added inline comments to D94111: [CSSPGO][llvm-profgen] Merge and trim profile for cold context to reduce profile size.
Thu, Jan 14, 12:28 PM · Restricted Project

Wed, Jan 13

wlei added inline comments to D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Wed, Jan 13, 4:10 PM · Restricted Project
wlei updated the diff for D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.

rewrote the comments, adding more examples

Wed, Jan 13, 4:09 PM · Restricted Project
wlei committed rG35debdfcaca1: [NFC] Fix build break by a initializer list converting error (authored by wlei).
[NFC] Fix build break by a initializer list converting error
Wed, Jan 13, 2:29 PM
wlei committed rG33a8466531e6: [NFC] fix missing SectionName declaration (authored by wlei).
[NFC] fix missing SectionName declaration
Wed, Jan 13, 11:31 AM
wlei committed rG414930b91bfd: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample… (authored by wlei).
[CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample…
Wed, Jan 13, 11:07 AM
wlei committed rGc681400b25a6: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe (authored by wlei).
[CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe
Wed, Jan 13, 11:07 AM
wlei committed rGb3154d11bc6d: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling (authored by wlei).
[CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling
Wed, Jan 13, 11:07 AM
wlei closed D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.
Wed, Jan 13, 11:07 AM · Restricted Project
wlei closed D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.
Wed, Jan 13, 11:07 AM · Restricted Project
wlei closed D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.
Wed, Jan 13, 11:07 AM · Restricted Project

Tue, Jan 12

wlei updated the diff for D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.

rebase

Tue, Jan 12, 5:57 PM · Restricted Project
wlei added inline comments to D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.
Tue, Jan 12, 4:44 PM · Restricted Project
wlei added inline comments to D94111: [CSSPGO][llvm-profgen] Merge and trim profile for cold context to reduce profile size.
Tue, Jan 12, 1:53 PM · Restricted Project
wlei updated the diff for D94111: [CSSPGO][llvm-profgen] Merge and trim profile for cold context to reduce profile size.

Rebase and addressing Wei's feedback

Tue, Jan 12, 1:52 PM · Restricted Project
wlei added a comment to D94110: [CSSPGO][llvm-profgen] Aggregate samples on call frame trie to speed up profile generation.
In D94110#2489390, @wmi wrote:

This change speeds up this by grouping all the call frame within one LBR sample into a trie and aggregating the result(sample counter) on it.

5x speedup shows it is a really impressive improvement. I am wondering whether there is callstack overlap between different LBR samples so you can have further grouping of call frames -- by reusing unwindState. You may also save some cost by reusing the frame trie. IIUC although samples have been aggregated based on callstack, each LBR sample may have multiple callstacks inferred from unwindCall/unwindReturn. If there are callstack overlap between different LBR samples, you may be able to further group them.

Tue, Jan 12, 1:42 PM · Restricted Project
wlei updated the diff for D94110: [CSSPGO][llvm-profgen] Aggregate samples on call frame trie to speed up profile generation.

Addessing Wei's feedback

Tue, Jan 12, 1:41 PM · Restricted Project

Mon, Jan 11

wlei added inline comments to D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Mon, Jan 11, 5:15 PM · Restricted Project
wlei updated the diff for D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.

Addressing Wei's feedback

Mon, Jan 11, 5:12 PM · Restricted Project
wlei added inline comments to D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.
Mon, Jan 11, 10:22 AM · Restricted Project
wlei updated the diff for D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.

Address Wei's feedback

Mon, Jan 11, 10:20 AM · Restricted Project
wlei added a comment to D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.
In D92334#2488123, @wmi wrote:

Sorry for the delay in review. I will try to catch up.

Mon, Jan 11, 9:25 AM · Restricted Project
wlei updated the diff for D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.

Addressing Wei's feedback

Mon, Jan 11, 9:21 AM · Restricted Project

Wed, Jan 6

wlei added a comment to D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.

Kindly ping @wmi ,
I have addressed feedbacks from Hongtao and Wenlei, want to know whether this's also good for you or any other questions.
Also for other pseudo probe patches(https://reviews.llvm.org/D92334, https://reviews.llvm.org/D92896, https://reviews.llvm.org/D92998). Thanks!

Wed, Jan 6, 10:23 AM · Restricted Project

Tue, Jan 5

wlei updated the diff for D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.

rebase and fix clang-tidy

Tue, Jan 5, 5:33 PM · Restricted Project
wlei updated the summary of D94111: [CSSPGO][llvm-profgen] Merge and trim profile for cold context to reduce profile size.
Tue, Jan 5, 3:21 PM · Restricted Project
wlei retitled D94110: [CSSPGO][llvm-profgen] Aggregate samples on call frame trie to speed up profile generation from [CSSPGO][llvm-profgen] Aggregate sample on call frame trie to speed up profile generation to [CSSPGO][llvm-profgen] Aggregate samples on call frame trie to speed up profile generation.
Tue, Jan 5, 3:08 PM · Restricted Project
wlei requested review of D94111: [CSSPGO][llvm-profgen] Merge and trim profile for cold context to reduce profile size.
Tue, Jan 5, 12:22 PM · Restricted Project
wlei requested review of D94110: [CSSPGO][llvm-profgen] Aggregate samples on call frame trie to speed up profile generation.
Tue, Jan 5, 12:16 PM · Restricted Project

Dec 22 2020

wlei updated the diff for D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.

fix lint

Dec 22 2020, 12:47 PM · Restricted Project
wlei updated the diff for D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.

added CHECK-NEXT and other refactoring work

Dec 22 2020, 12:45 PM · Restricted Project

Dec 21 2020

wlei added inline comments to D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.
Dec 21 2020, 5:51 PM · Restricted Project
wlei added inline comments to D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.
Dec 21 2020, 5:47 PM · Restricted Project
wlei added inline comments to D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.
Dec 21 2020, 4:08 PM · Restricted Project
wlei added inline comments to D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.
Dec 21 2020, 2:54 PM · Restricted Project
wlei added inline comments to D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.
Dec 21 2020, 10:28 AM · Restricted Project
wlei updated the diff for D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.

rebase and fix clang-tidy

Dec 21 2020, 10:26 AM · Restricted Project
wlei updated the diff for D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.

rebase

Dec 21 2020, 9:49 AM · Restricted Project
wlei added inline comments to D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.
Dec 21 2020, 9:46 AM · Restricted Project
wlei updated the diff for D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.

Address Hongtao's feedback: support profile checksum and some other NFC work

Dec 21 2020, 9:38 AM · Restricted Project

Dec 18 2020

wlei updated the diff for D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.

rebase

Dec 18 2020, 4:12 PM · Restricted Project
wlei updated the summary of D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.
Dec 18 2020, 2:35 PM · Restricted Project
wlei updated the summary of D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Dec 18 2020, 11:28 AM · Restricted Project
wlei requested review of D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context.
Dec 18 2020, 10:42 AM · Restricted Project

Dec 16 2020

wlei added a comment to D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.

LBRSample will be added when AutoFDO support is moved into llvm-profgen, right? For AutoFDO, we could use the same infrastructure except that context will always be empty.

Good question, Yes, my initial thought is to decouple this by using separated LBRSample when it comes to AutoFDO, perhaps this's good for readability. I guess your suggestion is for the performance since we won't have virtual call. That's good. If so and we don't have other kinds of perf sample, we might don't need the base class PerfSample and can just name HybridSample to more general name(like PerfSample).

Dec 16 2020, 1:33 PM · Restricted Project
wlei updated the diff for D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.

Address Wenlei's feedback

Dec 16 2020, 1:30 PM · Restricted Project

Dec 15 2020

wlei accepted D93348: llvm-profgen: Parse command line arguments after initializing targets.

LGTM, Thanks for woking on this @tstellar

Dec 15 2020, 3:26 PM · Restricted Project
wlei added inline comments to D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.
Dec 15 2020, 1:02 PM · Restricted Project
wlei added inline comments to D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.
Dec 15 2020, 10:22 AM · Restricted Project
wlei updated the diff for D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.

address reviewers' feedback

Dec 15 2020, 10:19 AM · Restricted Project

Dec 11 2020

wlei updated the diff for D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.

Address some feedback from hongtao. The string handling part will be redesigned and come later

Dec 11 2020, 7:51 PM · Restricted Project
wlei added inline comments to D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.
Dec 11 2020, 5:55 PM · Restricted Project
wlei added inline comments to D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.
Dec 11 2020, 5:36 PM · Restricted Project

Dec 10 2020

wlei updated the summary of D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.
Dec 10 2020, 3:50 PM · Restricted Project
wlei added inline comments to D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.
Dec 10 2020, 1:03 PM · Restricted Project
wlei added inline comments to D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.
Dec 10 2020, 12:15 PM · Restricted Project
wlei updated the diff for D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.

change to use post-order traversal to extract inlined context stack

Dec 10 2020, 12:08 PM · Restricted Project

Dec 9 2020

wlei requested review of D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation.
Dec 9 2020, 9:18 PM · Restricted Project
wlei updated the diff for D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.

rebase

Dec 9 2020, 6:05 PM · Restricted Project
wlei updated the diff for D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.

Chang to use SmallVector instead of std::list

Dec 9 2020, 4:47 PM · Restricted Project
wlei added inline comments to D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.
Dec 9 2020, 3:57 PM · Restricted Project
wlei added inline comments to D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.
Dec 9 2020, 3:36 PM · Restricted Project
wlei updated the diff for D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.

Address Hongtao's feedback

Dec 9 2020, 2:44 PM · Restricted Project

Dec 8 2020

wlei updated the summary of D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.
Dec 8 2020, 5:01 PM · Restricted Project
wlei requested review of D92896: [CSSPGO][llvm-profgen] Virtual unwinding with pseudo probe.
Dec 8 2020, 3:55 PM · Restricted Project
wlei updated the diff for D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.

rebase

Dec 8 2020, 3:15 PM · Restricted Project
wlei updated the diff for D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling.

Address Hongtao's feedback, reuse the code from pseudo probe encoding and some refactoring work

Dec 8 2020, 3:12 PM · Restricted Project

Dec 7 2020

wlei added a comment to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.

Hi, @vitalybuka , sorry for the test failure, the fix-up patch(https://reviews.llvm.org/D92816) is already landed, please update the repo, thanks!

Dec 7 2020, 10:48 PM · Restricted Project
wlei committed rGeea67baf8706: [llvm-profgen][NFC] Fix test failure by making unwinder's output deterministic (authored by wlei).
[llvm-profgen][NFC] Fix test failure by making unwinder's output deterministic
Dec 7 2020, 10:38 PM
wlei closed D92816: [llvm-profgen][NFC] Fix test failure by making unwinder's output deterministic.
Dec 7 2020, 10:37 PM · Restricted Project
wlei updated the diff for D92816: [llvm-profgen][NFC] Fix test failure by making unwinder's output deterministic.

change according wenlei's suggestion

Dec 7 2020, 10:28 PM · Restricted Project
wlei added inline comments to D92816: [llvm-profgen][NFC] Fix test failure by making unwinder's output deterministic.
Dec 7 2020, 10:24 PM · Restricted Project