Page MenuHomePhabricator

weiwang (Wei Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 2:20 PM (19 w, 3 d)

Recent Activity

Tue, Dec 1

weiwang added a comment to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

Ah, I am sorry. Thanks for fixing it.

Tue, Dec 1, 9:07 AM · Restricted Project, Restricted Project

Mon, Nov 30

weiwang committed rG93dc1b5b8cb2: [Remarks][2/2] Expand remarks hotness threshold option support in more tools (authored by weiwang).
[Remarks][2/2] Expand remarks hotness threshold option support in more tools
Mon, Nov 30, 9:58 PM
weiwang committed rG3acda91742b7: [Remarks][1/2] Expand remarks hotness threshold option support in more tools (authored by weiwang).
[Remarks][1/2] Expand remarks hotness threshold option support in more tools
Mon, Nov 30, 9:58 PM
weiwang closed D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.
Mon, Nov 30, 9:57 PM · Restricted Project, Restricted Project
weiwang closed D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Mon, Nov 30, 9:57 PM · Restricted Project
weiwang added a comment to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

lgtm with a couple of minor nits noted below that you can fix before submitting

Mon, Nov 30, 9:53 PM · Restricted Project, Restricted Project
weiwang updated the diff for D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.
  1. Fix typo.
  2. Minor order adjustment in testcase.
Mon, Nov 30, 9:51 PM · Restricted Project, Restricted Project
weiwang updated the diff for D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

rebase

Mon, Nov 30, 11:24 AM · Restricted Project, Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

rebase

Mon, Nov 30, 11:24 AM · Restricted Project
weiwang added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

@tejohnson @MaskRay Do you have other comments?

Mon, Nov 30, 9:52 AM · Restricted Project
weiwang added a comment to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

@tejohnson @MaskRay Do you have other comments?

Mon, Nov 30, 9:51 AM · Restricted Project, Restricted Project

Wed, Nov 18

weiwang added a comment to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

Thanks for adding the Driver test. I was thinking of something to test the CompilerInvocation changes, similar to your test using opt, that ensures the option has the desired behavior when invoked via clang. Looks like there is an existing test clang/test/Frontend/optimization-remark-with-hotness.c that perhaps could be extended or leveraged?

Wed, Nov 18, 4:25 PM · Restricted Project, Restricted Project
weiwang updated the diff for D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.
  1. Add clang test with remarks output.
  2. Fix a missing dependency on PSI in legacy pass manager.
Wed, Nov 18, 4:23 PM · Restricted Project, Restricted Project

Tue, Nov 17

weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

revert back MSVC fix

Tue, Nov 17, 5:50 PM · Restricted Project
weiwang added inline comments to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Tue, Nov 17, 5:39 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

update to address MSVC build error

Tue, Nov 17, 5:25 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

update test case

Tue, Nov 17, 5:08 PM · Restricted Project
weiwang added inline comments to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Tue, Nov 17, 5:08 PM · Restricted Project
weiwang added inline comments to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Tue, Nov 17, 3:38 PM · Restricted Project
weiwang added inline comments to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Tue, Nov 17, 3:31 PM · Restricted Project
weiwang added inline comments to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Tue, Nov 17, 2:35 PM · Restricted Project
weiwang updated the diff for D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

update test case for clang option pass-through

Tue, Nov 17, 1:19 PM · Restricted Project, Restricted Project
weiwang committed rG3279347da05e: [BPI] Look through bitcasts in calcZeroHeuristic (authored by weiwang).
[BPI] Look through bitcasts in calcZeroHeuristic
Tue, Nov 17, 9:35 AM
weiwang closed D91450: [BPI] Look through bitcasts in calcZeroHeuristic.
Tue, Nov 17, 9:34 AM · Restricted Project
weiwang added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

Thanks! I will wait for his input.

Tue, Nov 17, 9:29 AM · Restricted Project

Mon, Nov 16

weiwang added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

@MaskRay @tejohnson, do you have other comments regarding this change and its dependent?

Mon, Nov 16, 4:33 PM · Restricted Project
weiwang updated the diff for D91450: [BPI] Look through bitcasts in calcZeroHeuristic.

add test case

Mon, Nov 16, 10:26 AM · Restricted Project

Fri, Nov 13

weiwang updated the summary of D91450: [BPI] Look through bitcasts in calcZeroHeuristic.
Fri, Nov 13, 11:27 AM · Restricted Project
weiwang added a reviewer for D91450: [BPI] Look through bitcasts in calcZeroHeuristic: samparker.
Fri, Nov 13, 11:22 AM · Restricted Project
weiwang requested review of D91450: [BPI] Look through bitcasts in calcZeroHeuristic.
Fri, Nov 13, 11:21 AM · Restricted Project

Oct 27 2020

weiwang closed D85810: [clang] Pass-through remarks options to linker.

Diff was committed, but did not close automatically. Manual close it now.

Oct 27 2020, 5:33 PM · Restricted Project
weiwang committed rGc4868700c580: [clang] Pass-through remarks options to linker (authored by weiwang).
[clang] Pass-through remarks options to linker
Oct 27 2020, 5:24 PM
weiwang updated the summary of D85810: [clang] Pass-through remarks options to linker.
Oct 27 2020, 5:22 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

fix typo

Oct 27 2020, 5:21 PM · Restricted Project

Oct 26 2020

weiwang committed rGd602e79a81ad: [X86] Encode global address in small code model (authored by weiwang).
[X86] Encode global address in small code model
Oct 26 2020, 11:14 PM
weiwang closed D89341: [X86] Encode global symbol address in small code model.
Oct 26 2020, 11:14 PM · Restricted Project
weiwang retitled D89341: [X86] Encode global symbol address in small code model from [X86] Encode global symbol address in sub if possible to [X86] Encode global symbol address in small code model.
Oct 26 2020, 9:50 AM · Restricted Project

Oct 23 2020

weiwang updated the diff for D89341: [X86] Encode global symbol address in small code model.

Sorry for the long delay. Got held up by some other task.

Oct 23 2020, 1:40 PM · Restricted Project

Oct 15 2020

weiwang added a comment to D89341: [X86] Encode global symbol address in small code model.

Thanks for the comment, Craig.

isSExtAbsoluteSymbolRef does seem to check for the width of immediate. If the immediate can be encoded directly, the node should be replaced with one of the SUB64ri* nodes. I think the X86Wrapper node can be replaced with a corresponding imm node if conditions are met, then the matching can proceed.

I was thinking that if we don't have range information from getAbsoluteSymbolRange, but the Width passed to isSExtAbsoluteSymbolRef is 32 and the code model is small we could return true?

Oct 15 2020, 11:36 AM · Restricted Project

Oct 13 2020

weiwang added a comment to D89341: [X86] Encode global symbol address in small code model.

Would be good to share benchmark/performance numbers you have for this change too. Thanks.

Oct 13 2020, 5:46 PM · Restricted Project
weiwang added a comment to D89341: [X86] Encode global symbol address in small code model.

Thanks for the comment, Craig.

Oct 13 2020, 5:31 PM · Restricted Project
weiwang edited reviewers for D89341: [X86] Encode global symbol address in small code model, added: craig.topper; removed: hoyFB.
Oct 13 2020, 2:27 PM · Restricted Project
weiwang added a reviewer for D89341: [X86] Encode global symbol address in small code model: hoyFB.
Oct 13 2020, 1:57 PM · Restricted Project
weiwang updated the summary of D89341: [X86] Encode global symbol address in small code model.
Oct 13 2020, 1:57 PM · Restricted Project
weiwang requested review of D89341: [X86] Encode global symbol address in small code model.
Oct 13 2020, 1:52 PM · Restricted Project

Oct 6 2020

weiwang added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

Thanks @MaskRay ! I am really sorry I didn't catch up your comments earlier. My email somehow stops giving me notifications on diff updates.

Oct 6 2020, 10:02 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

Address Comments.

Oct 6 2020, 9:34 PM · Restricted Project

Sep 28 2020

weiwang added a comment to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

@tejohnson @MaskRay Do you have other comments to the change?

Sep 28 2020, 2:29 PM · Restricted Project, Restricted Project
weiwang added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

@tejohnson @MaskRay Do you have other comments to the change?

Sep 28 2020, 2:28 PM · Restricted Project

Sep 21 2020

weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

minor update to test case

Sep 21 2020, 4:58 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.
  1. remove unreachable code
  2. udpate test case
Sep 21 2020, 4:07 PM · Restricted Project

Sep 17 2020

weiwang added inline comments to D85810: [clang] Pass-through remarks options to linker.
Sep 17 2020, 5:25 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

update test case

Sep 17 2020, 5:20 PM · Restricted Project

Sep 4 2020

weiwang updated the summary of D87104: [OpenMPOpt] Assume indirect call always changes ICV.
Sep 4 2020, 9:00 AM · Restricted Project

Sep 3 2020

weiwang updated the diff for D87104: [OpenMPOpt] Assume indirect call always changes ICV.

Add test case for indirect call. Without the fix, the test will crash.

Sep 3 2020, 10:59 PM · Restricted Project
weiwang updated subscribers of D87104: [OpenMPOpt] Assume indirect call always changes ICV.
Sep 3 2020, 11:32 AM · Restricted Project
weiwang updated the summary of D87104: [OpenMPOpt] Assume indirect call always changes ICV.
Sep 3 2020, 11:31 AM · Restricted Project
weiwang added a reviewer for D87104: [OpenMPOpt] Assume indirect call always changes ICV: sstefan1.
Sep 3 2020, 11:28 AM · Restricted Project
weiwang requested review of D87104: [OpenMPOpt] Assume indirect call always changes ICV.
Sep 3 2020, 11:27 AM · Restricted Project

Sep 2 2020

weiwang added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

Really appreciate the feedbacks. If there is no more, could anyone approve 3 changes? Thanks.

Sep 2 2020, 5:37 PM · Restricted Project

Aug 27 2020

weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

remove redundant check

Aug 27 2020, 1:43 PM · Restricted Project
weiwang added inline comments to D85810: [clang] Pass-through remarks options to linker.
Aug 27 2020, 1:27 PM · Restricted Project
weiwang added inline comments to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.
Aug 27 2020, 1:24 PM · Restricted Project, Restricted Project

Aug 19 2020

weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

try to fix windows build linking error.

Aug 19 2020, 9:44 AM · Restricted Project

Aug 18 2020

weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

try to fix windows build error. Use fully qualified name for enum value Optional.

Aug 18 2020, 10:06 PM · Restricted Project
weiwang updated the diff for D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.

add comment on test case.

Aug 18 2020, 8:53 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

fix typo

Aug 18 2020, 8:38 PM · Restricted Project
weiwang added inline comments to D85810: [clang] Pass-through remarks options to linker.
Aug 18 2020, 8:36 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

coding style change

Aug 18 2020, 8:35 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

Try to fix a windows build error. No msvc available locally, so even with this change, the build could still fail.

Aug 18 2020, 8:33 PM · Restricted Project

Aug 17 2020

weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

move some unrelated change into parent diff.

Aug 17 2020, 10:56 PM · Restricted Project
weiwang updated the summary of D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 10:55 PM · Restricted Project
weiwang retitled D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools from [remarks] Optimization remarks hotness filtering from profile summary to [Remarks][2/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 10:55 PM · Restricted Project, Restricted Project
weiwang updated the diff for D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

update:

  1. reorganize code splitting with parent diff.
  2. format and style change.
Aug 17 2020, 10:53 PM · Restricted Project, Restricted Project
weiwang updated the summary of D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 10:50 PM · Restricted Project
weiwang retitled D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools from [LTO] Make setupLLVMOptimizationRemarks accept remarks hotness threshold to [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 10:50 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

update:

  1. move internal remarks hotness threshold type change and its related handling code from child diff into this one. With this move, remarks hotness threshold now accepts 'auto' value, but its handling is currently disabled.
  2. format change.
Aug 17 2020, 10:48 PM · Restricted Project
weiwang added inline comments to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 3:34 PM · Restricted Project
weiwang updated the summary of D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.
Aug 17 2020, 3:16 PM · Restricted Project
weiwang retitled D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions from [FIX] Add check for empty body function to [FIX] Avoid creating BFI when emitting remarks for dead functions.
Aug 17 2020, 3:15 PM · Restricted Project
weiwang updated the diff for D84715: [FIX] Avoid creating BFI when emitting remarks for dead functions.

Instead of adding checks for all passes/analyses, use light-weight ORE to emit remarks for dead functions.

Aug 17 2020, 3:14 PM · Restricted Project
weiwang updated the summary of D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Aug 17 2020, 1:24 PM · Restricted Project
weiwang retitled D85810: [clang] Pass-through remarks options to linker from [clang] Pass-through remarks options to lld to [clang] Pass-through remarks options to linker.
Aug 17 2020, 1:16 PM · Restricted Project
weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

update:

  1. add --plugin-opt alias for remarks in lld
  2. handle both lld and ld.gold pass-through
  3. simplify target checking logic
  4. code format update
Aug 17 2020, 1:12 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

format update

Aug 17 2020, 1:08 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

format update

Aug 17 2020, 1:07 PM · Restricted Project
weiwang retitled D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools from [lld] Enable remarks hotness filtering in lld and llvm-lto2 to [LTO] Make setupLLVMOptimizationRemarks accept remarks hotness threshold.
Aug 17 2020, 1:00 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

update:
add remarks hotness threshold to all the tools uses lto::setupLLVMOptimizationRemarks

Aug 17 2020, 12:59 PM · Restricted Project

Aug 13 2020

weiwang added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

The changes to *LTOCodeGenerator and the test using llvm-lto are unrelated to lld (they are the old LTO API used by ld64). So they should be moved to a different patch or the patch name changed. Would be good to add llvm-lto2 tests which exercise the new LTO API changed in LTO.cpp, LTOBackend.cpp etc. Note those changes are broader than just lld (also used by gold-plugin).

Aug 13 2020, 7:00 PM · Restricted Project
weiwang retitled D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools from [lld] Enable remarks hotness filtering in lld to [lld] Enable remarks hotness filtering in lld and llvm-lto2.
Aug 13 2020, 6:58 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

changes:

  1. revert the change made to llvm-lto.
  2. add the new option to llvm-lto2 wit test cases.
Aug 13 2020, 6:56 PM · Restricted Project
weiwang added a comment to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

This is the 3rd of 3 dependent patches:

  1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809
  2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810
  3. [remarks] Optimization remarks hotness filtering from profile summary: https://reviews.llvm.org/D85808

You can relate these as Parent/Child patches in Phabricator. See "Edit Related Revisions" on the top right. It helps reviewers to see the relationship and keep track of what patches are still open.

Note these relationships get set up automatically when you upload a patch with "Depends on Dxxxxx." in the description.

Aug 13 2020, 4:54 PM · Restricted Project, Restricted Project

Aug 12 2020

weiwang updated the diff for D85810: [clang] Pass-through remarks options to linker.

update test case

Aug 12 2020, 4:18 PM · Restricted Project
weiwang updated the diff for D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

clang-format

Aug 12 2020, 2:59 PM · Restricted Project
weiwang abandoned D85856: [lld] Enable remarks hotness filtering in lld.
Aug 12 2020, 2:46 PM · Restricted Project
weiwang requested review of D85856: [lld] Enable remarks hotness filtering in lld.
Aug 12 2020, 2:46 PM · Restricted Project

Aug 11 2020

weiwang abandoned D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold.

Diff has been split into 3 smaller ones:

Aug 11 2020, 10:56 PM · Restricted Project, Restricted Project
weiwang retitled D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools from [remarks] Optimization remarks hotness filetering from profile summary to [remarks] Optimization remarks hotness filtering from profile summary.
Aug 11 2020, 10:53 PM · Restricted Project, Restricted Project
weiwang added reviewers for D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools: wenlei, hoyFB.

This is the 3rd of 3 dependent patches:

  1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809
  2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810
  3. [remarks] Optimization remarks hotness filtering from profile summary: https://reviews.llvm.org/D85808
Aug 11 2020, 10:51 PM · Restricted Project, Restricted Project
weiwang added reviewers for D85810: [clang] Pass-through remarks options to linker: wenlei, hoyFB.

This is the 2nd of 3 dependent patches:

  1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809
  2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810
  3. [remarks] Optimization remarks hotness filtering from profile summary: https://reviews.llvm.org/D85808
Aug 11 2020, 10:50 PM · Restricted Project