Page MenuHomePhabricator

varungandhi-apple (Varun Gandhi)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2019, 5:18 PM (80 w, 19 h)

Recent Activity

Mon, Apr 5

varungandhi-apple updated the diff for D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall))..
  1. Remove '::' when calling static function.
  2. Fix bug in function merging around missing musttail.
  3. Add off-by-default check in verifier for swifttailcc->swifttailcc tail calls that are not marked musttail.
Mon, Apr 5, 10:28 AM · Restricted Project, Restricted Project

Thu, Mar 25

varungandhi-apple updated the diff for D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall))..

Fix codegen + add tests for methods and function pointers.

Thu, Mar 25, 2:10 PM · Restricted Project, Restricted Project

Mar 11 2021

varungandhi-apple updated the diff for D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall))..

Use musttail call instead of tail call. (This patch needs to be marked as dependent on another patch which implements proper musttail support, but that is not available yet.)

Mar 11 2021, 2:23 AM · Restricted Project, Restricted Project
varungandhi-apple updated the diff for D95561: [Clang] Introduce Swift async calling convention..

Permit swift_context and swift_indirect_result parameters for
swiftasynccall functions. (Earlier, these were restricted to
swiftcall-only.)

Mar 11 2021, 1:56 AM · Restricted Project, Restricted Project

Mar 2 2021

varungandhi-apple updated the diff for D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall))..

Add null check for callee; instead of using getFunctionType() directly.

Mar 2 2021, 10:29 AM · Restricted Project, Restricted Project

Feb 26 2021

varungandhi-apple updated the diff for D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall))..

Added checks for C++.

Feb 26 2021, 12:03 PM · Restricted Project, Restricted Project

Feb 24 2021

varungandhi-apple updated the diff for D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall))..

Generate tail call when doing codegen for return statement.

Feb 24 2021, 2:15 PM · Restricted Project, Restricted Project
varungandhi-apple updated the diff for D95561: [Clang] Introduce Swift async calling convention..

Address review feedback; remove centralized target check for CC_SwiftAsync.

Feb 24 2021, 1:41 PM · Restricted Project, Restricted Project

Feb 17 2021

varungandhi-apple abandoned D96802: [Clang] Add proper target checks for SwiftAsync convention..

I've updated the earlier patch https://reviews.llvm.org/D95561 to include this change, so that we don't have an in-between state where we erroneously claim that we support a bunch of targets which we don't actually support.

Feb 17 2021, 3:22 PM · Restricted Project
varungandhi-apple added a comment to D96802: [Clang] Add proper target checks for SwiftAsync convention..

The TargetInfo classes are already target-architecture-specific, so it's somewhat strange for them all to funnel to a single function that then immediately switches on the target architecture.

Feb 17 2021, 2:48 PM · Restricted Project
varungandhi-apple updated the diff for D95561: [Clang] Introduce Swift async calling convention..
  • Remove semantic restriction of swift_async_context being only applicable to swiftasynccall.
  • Update target checks to make sure we only allow supported targets.
  • Update doc comment.
Feb 17 2021, 12:16 PM · Restricted Project, Restricted Project

Feb 16 2021

varungandhi-apple requested review of D96802: [Clang] Add proper target checks for SwiftAsync convention..
Feb 16 2021, 10:49 AM · Restricted Project

Feb 12 2021

varungandhi-apple updated the diff for D95704: [CodeGen] Introduce DWARF tag for SwiftTail and emit it in CodeGen..

Tweak test case diff to adjust for change in previous commit.

Feb 12 2021, 9:30 AM · Restricted Project, Restricted Project
varungandhi-apple updated the diff for D95561: [Clang] Introduce Swift async calling convention..

Fix test case for debuginfo.

Feb 12 2021, 9:29 AM · Restricted Project, Restricted Project
varungandhi-apple added inline comments to D95561: [Clang] Introduce Swift async calling convention..
Feb 12 2021, 8:57 AM · Restricted Project, Restricted Project

Feb 5 2021

varungandhi-apple updated the diff for D95561: [Clang] Introduce Swift async calling convention..

Correct documentation on tail call behavior as pointed out by John.

Feb 5 2021, 9:26 AM · Restricted Project, Restricted Project

Feb 4 2021

varungandhi-apple updated the diff for D95561: [Clang] Introduce Swift async calling convention..
  1. Update whitespace and add documentation for swiftasynccall.
  2. Update commit message.
Feb 4 2021, 10:00 AM · Restricted Project, Restricted Project

Feb 3 2021

varungandhi-apple added a comment to D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall))..

I am planning to add more tests, figured it is better to put up the patch sooner rather than later.

Feb 3 2021, 3:44 PM · Restricted Project, Restricted Project
varungandhi-apple requested review of D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall))..
Feb 3 2021, 3:43 PM · Restricted Project, Restricted Project

Feb 2 2021

varungandhi-apple added inline comments to D95561: [Clang] Introduce Swift async calling convention..
Feb 2 2021, 12:29 PM · Restricted Project, Restricted Project
varungandhi-apple added inline comments to D95561: [Clang] Introduce Swift async calling convention..
Feb 2 2021, 12:27 PM · Restricted Project, Restricted Project

Feb 1 2021

varungandhi-apple added inline comments to D95443: IR/AArch64/X86: add "swifttailcc" calling convention..
Feb 1 2021, 1:30 PM · Restricted Project
varungandhi-apple requested review of D95814: [NFC] Simplify test to use multiple FileCheck prefixes..
Feb 1 2021, 12:41 PM · Restricted Project

Jan 29 2021

varungandhi-apple requested review of D95704: [CodeGen] Introduce DWARF tag for SwiftTail and emit it in CodeGen..
Jan 29 2021, 3:45 PM · Restricted Project, Restricted Project
varungandhi-apple added a comment to D95443: IR/AArch64/X86: add "swifttailcc" calling convention..

Could you add a short entry on swifttailcc to LangRef.rst?

Jan 29 2021, 3:35 PM · Restricted Project

Jan 27 2021

varungandhi-apple added inline comments to D95561: [Clang] Introduce Swift async calling convention..
Jan 27 2021, 5:43 PM · Restricted Project, Restricted Project
varungandhi-apple added a comment to D95561: [Clang] Introduce Swift async calling convention..

I don't get how you stack your change on top of someone else's change (the diff seems to have been created with only one commit), but this depends on https://reviews.llvm.org/D95228, which depends on https://reviews.llvm.org/D95044.

Jan 27 2021, 2:11 PM · Restricted Project, Restricted Project
varungandhi-apple added inline comments to D95561: [Clang] Introduce Swift async calling convention..
Jan 27 2021, 2:09 PM · Restricted Project, Restricted Project
varungandhi-apple published D95561: [Clang] Introduce Swift async calling convention. for review.
Jan 27 2021, 2:08 PM · Restricted Project, Restricted Project
varungandhi-apple added inline comments to D95044: IR+AArch64: add `swiftasync` function parameter attribute.
Jan 27 2021, 1:43 PM · Restricted Project
varungandhi-apple committed rG44f792966e0f: [Demangle] Support demangling Swift calling convention in MS demangler. (authored by varungandhi-apple).
[Demangle] Support demangling Swift calling convention in MS demangler.
Jan 27 2021, 1:25 PM
varungandhi-apple closed D95053: [Demangle] Support demangling Swift calling convention in MS demangler..
Jan 27 2021, 1:25 PM · Restricted Project, Restricted Project

Jan 20 2021

varungandhi-apple committed rG87a89549c4b1: [NFC] Minor cleanup for ValueHandle code. (authored by varungandhi-apple).
[NFC] Minor cleanup for ValueHandle code.
Jan 20 2021, 4:28 PM
varungandhi-apple closed D94238: [NFC] Minor cleanup for ValueHandle code..
Jan 20 2021, 4:28 PM · Restricted Project
varungandhi-apple added a comment to D95053: [Demangle] Support demangling Swift calling convention in MS demangler..

I've fixed this by including an additional space in the string instead of using a method like outputSpaceIfNecessary; (1) that method doesn't work as it is and I think changing it for this purpose is not appropriate and (2) we probably want the space there unconditionally anyways.

Jan 20 2021, 4:02 PM · Restricted Project, Restricted Project
varungandhi-apple updated the diff for D95053: [Demangle] Support demangling Swift calling convention in MS demangler..

Add extra space for better readability, as suggested by @compnerd.

Jan 20 2021, 3:58 PM · Restricted Project, Restricted Project
varungandhi-apple requested review of D95053: [Demangle] Support demangling Swift calling convention in MS demangler..
Jan 20 2021, 8:41 AM · Restricted Project, Restricted Project

Jan 19 2021

varungandhi-apple abandoned D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool)..

Closing this in favor of a Swift-side fix: https://github.com/apple/swift/pull/35488.

Jan 19 2021, 11:41 AM · Restricted Project

Jan 16 2021

varungandhi-apple added a comment to D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool)..

The way you'd test it on the Clang side would be to just write a test case that passes such an aggregate and tests that it's passed as an i8.

Jan 16 2021, 2:28 PM · Restricted Project

Jan 15 2021

varungandhi-apple added a comment to D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool)..

I don't know how to test this on the LLVM-side (is there a way to do it?). Here's the Swift side test which trips over right now (but is fixed with this patch) by attempting a zext from an i8 to an i1 in Swift's NativeConventionSchema::mapIntoNative.

Jan 15 2021, 6:57 PM · Restricted Project
varungandhi-apple requested review of D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool)..
Jan 15 2021, 6:48 PM · Restricted Project

Jan 7 2021

varungandhi-apple added a comment to rG3503c856819e: Fixup Asserts+!AbiBreakingChecks fallout from db33f85c7124.

Thanks!

Jan 7 2021, 3:32 PM
varungandhi-apple requested review of D94238: [NFC] Minor cleanup for ValueHandle code..
Jan 7 2021, 8:51 AM · Restricted Project
varungandhi-apple committed rGdb33f85c7124: [IR] Use LLVM_ENABLE_ABI_BREAKING_CHECKS to guard ABI changes. (authored by varungandhi-apple).
[IR] Use LLVM_ENABLE_ABI_BREAKING_CHECKS to guard ABI changes.
Jan 7 2021, 8:42 AM
varungandhi-apple closed D93433: [IR] Use LLVM_ENABLE_ABI_BREAKING_CHECKS to guard ABI changes..
Jan 7 2021, 8:42 AM · Restricted Project
varungandhi-apple added a comment to D93433: [IR] Use LLVM_ENABLE_ABI_BREAKING_CHECKS to guard ABI changes..

Going to land this as-is, will make suggested tweaks in a follow-up change.

Jan 7 2021, 8:41 AM · Restricted Project

Jan 6 2021

varungandhi-apple committed rG37e83bc6db3a: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy (authored by varungandhi-apple).
[NFC] Move readAPValue/writeAPValue up the inheritance hierarchy
Jan 6 2021, 4:45 PM
varungandhi-apple closed D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy.
Jan 6 2021, 4:45 PM · Restricted Project
varungandhi-apple updated the diff for D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy.

Appease clang-tidy.

Jan 6 2021, 3:12 PM · Restricted Project
varungandhi-apple requested review of D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy.
Jan 6 2021, 2:38 PM · Restricted Project

Dec 16 2020

varungandhi-apple requested review of D93433: [IR] Use LLVM_ENABLE_ABI_BREAKING_CHECKS to guard ABI changes..
Dec 16 2020, 5:10 PM · Restricted Project

Sep 1 2020

varungandhi-apple committed rG94948f3c929e: [ADT] Make Optional a literal type. (authored by varungandhi-apple).
[ADT] Make Optional a literal type.
Sep 1 2020, 4:14 PM
varungandhi-apple closed D86354: [ADT] Make Optional a literal type..
Sep 1 2020, 4:14 PM · Restricted Project

Aug 27 2020

varungandhi-apple added a comment to D86354: [ADT] Make Optional a literal type..

(I'm going to wait till at least Monday to land this, in case anyone has objections or would like to suggest changes to the implementation or tests.)

Aug 27 2020, 10:19 AM · Restricted Project

Aug 26 2020

varungandhi-apple added a comment to D86354: [ADT] Make Optional a literal type..
Aug 26 2020, 4:07 PM · Restricted Project
varungandhi-apple updated the diff for D86354: [ADT] Make Optional a literal type..
  1. Allow many more operations in constexpr.
  2. Update test to reflect use in constexpr instead of relying on implementation details.
Aug 26 2020, 4:05 PM · Restricted Project
varungandhi-apple updated subscribers of D86354: [ADT] Make Optional a literal type..

This seems to only allow empty optionals to be constexpr. Should the non-default constructor also be constexpr?

Aug 26 2020, 12:39 PM · Restricted Project

Aug 21 2020

varungandhi-apple requested review of D86354: [ADT] Make Optional a literal type..
Aug 21 2020, 8:45 AM · Restricted Project

Jul 26 2020

varungandhi-apple added a comment to D82791: [lit] Improve lit's output with default settings and --verbose..

Some of the changes probably don't make perfect sense in this revision because I initially started out with the whole change being one revision and then split things into commits, while trying to minimize the churn between revisions. Please also take a look at the follow-up revision D82811 and let me know if that's acceptable (less churn, less self-contained, things make sense when you look at the two together) or if you'd prefer that I make this revision more self-contained (that would create more churn in D82811).

Jul 26 2020, 10:13 PM · Restricted Project, Restricted Project
varungandhi-apple updated the diff for D82791: [lit] Improve lit's output with default settings and --verbose..

Address review comments.

Jul 26 2020, 10:11 PM · Restricted Project, Restricted Project
varungandhi-apple added a comment to D82808: [docs] [lit] Add a more helpful description for lit.py's -s flag..

@yln could you please land the patch? I do not have commit access.

Jul 26 2020, 8:23 PM · Restricted Project

Jul 21 2020

varungandhi-apple added a comment to D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf..

Thanks!

Jul 21 2020, 5:01 PM · Restricted Project
varungandhi-apple added inline comments to rG473fbc90d1fb: [clang][NFC] Store a pointer to the ASTContext in ASTDumper and TextNodeDumper.
Jul 21 2020, 3:52 PM
varungandhi-apple added a comment to D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf..

(Could you land the patch if it looks good? I don't have commit access.)

Jul 21 2020, 3:41 PM · Restricted Project
varungandhi-apple added inline comments to D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf..
Jul 21 2020, 3:38 PM · Restricted Project
varungandhi-apple added inline comments to rG473fbc90d1fb: [clang][NFC] Store a pointer to the ASTContext in ASTDumper and TextNodeDumper.
Jul 21 2020, 12:56 PM

Jul 20 2020

varungandhi-apple added inline comments to rG473fbc90d1fb: [clang][NFC] Store a pointer to the ASTContext in ASTDumper and TextNodeDumper.
Jul 20 2020, 9:16 PM

Jul 17 2020

varungandhi-apple added a reviewer for D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.: aprantl.
Jul 17 2020, 10:30 PM · Restricted Project
varungandhi-apple updated the diff for D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf..

Updated commit message with reviewer information and revision link.

Jul 17 2020, 10:30 PM · Restricted Project
Herald added a project to D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.: Restricted Project.
Jul 17 2020, 10:25 PM · Restricted Project
varungandhi-apple added a comment to D83449: [llvm] Add contains(KeyType) -> bool methods to Set types..

Oh, and sorry I forgot to update the "author" field to appropriately credit you when I committed these

Jul 17 2020, 12:16 PM · Restricted Project
varungandhi-apple added a comment to D83449: [llvm] Add contains(KeyType) -> bool methods to Set types..

Thanks! It seems a bit weird that this revision now only shows the one commit under Revision contents even though the 'Commits' above shows the six commits. 🤷

Jul 17 2020, 11:56 AM · Restricted Project

Jul 16 2020

Herald added a project to D84000: [lit] Print non-existent paths when no tests are discovered.: Restricted Project.
Jul 16 2020, 8:25 PM · Restricted Project
varungandhi-apple added a comment to D83449: [llvm] Add contains(KeyType) -> bool methods to Set types..

@dblaikie could you land the patch for me? I do not have bot permissions/commit privileges.

Jul 16 2020, 10:20 AM · Restricted Project

Jul 15 2020

varungandhi-apple updated the diff for D83449: [llvm] Add contains(KeyType) -> bool methods to Set types..

Split up single commit into several commits (one commit per set type).

Jul 15 2020, 8:38 PM · Restricted Project
varungandhi-apple added a comment to D83449: [llvm] Add contains(KeyType) -> bool methods to Set types..

I've added some unit tests. Are these adequate/do you have any other suggestions on what I should test?

Jul 15 2020, 12:07 PM · Restricted Project
varungandhi-apple updated the diff for D83449: [llvm] Add contains(KeyType) -> bool methods to Set types..

Added comments and test cases addressing fhahn's review comment.

Jul 15 2020, 12:01 PM · Restricted Project

Jul 8 2020

varungandhi-apple added a comment to D83449: [llvm] Add contains(KeyType) -> bool methods to Set types..

I don't understand the clang-tidy/clang-format complaints. I've formatted the code based on how the surrounding code is formatted.

Jul 8 2020, 8:16 PM · Restricted Project
varungandhi-apple added a comment to D83449: [llvm] Add contains(KeyType) -> bool methods to Set types..

Prior art:

Jul 8 2020, 7:35 PM · Restricted Project
Herald added a project to D83449: [llvm] Add contains(KeyType) -> bool methods to Set types.: Restricted Project.
Jul 8 2020, 7:32 PM · Restricted Project

Jul 6 2020

varungandhi-apple added a comment to D82791: [lit] Improve lit's output with default settings and --verbose..

Thanks for the review, it's a big patch. 😅 I'm a bit busy at the moment, I will respond to the other comments later this week or sometime next week.

Jul 6 2020, 12:29 PM · Restricted Project, Restricted Project

Jul 1 2020

varungandhi-apple updated the diff for D82814: [lit] Replace echo_all_commands with run_with_command_output..

Rebase after changes in D82808.

Jul 1 2020, 10:48 AM · Restricted Project
varungandhi-apple updated the diff for D82811: [lit] Highlight failing line with colored output..

Rebase after changes in D82808.

Jul 1 2020, 10:48 AM · Restricted Project
varungandhi-apple updated the diff for D82791: [lit] Improve lit's output with default settings and --verbose..

Rebase after changes in D82808.

Jul 1 2020, 10:48 AM · Restricted Project, Restricted Project
varungandhi-apple updated the diff for D82808: [docs] [lit] Add a more helpful description for lit.py's -s flag..

Addressed review comment: replace shows -> show.

Jul 1 2020, 10:48 AM · Restricted Project

Jun 29 2020

varungandhi-apple added a comment to D82811: [lit] Highlight failing line with colored output..

Please review D82791: "[lit] Improve lit's output with default settings and --verbose." before reviewing this revision.

Jun 29 2020, 3:32 PM · Restricted Project
varungandhi-apple added a comment to D82814: [lit] Replace echo_all_commands with run_with_command_output..

Please review D82791: "[lit] Improve lit's output with default settings and --verbose." and D82811 "[lit] Highlight failing line with colored output." before reviewing this revision.

Jun 29 2020, 3:32 PM · Restricted Project
varungandhi-apple abandoned D80694: Improve lit.py's usability by highlighting failing lines..
Jun 29 2020, 3:18 PM · Restricted Project
varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

I've split this patch up into four different patches. Here is the suggested review order:

Jun 29 2020, 3:18 PM · Restricted Project
varungandhi-apple created D82814: [lit] Replace echo_all_commands with run_with_command_output..
Jun 29 2020, 3:18 PM · Restricted Project
varungandhi-apple added a reviewer for D82791: [lit] Improve lit's output with default settings and --verbose.: yln.
Jun 29 2020, 2:58 PM · Restricted Project, Restricted Project
varungandhi-apple created D82811: [lit] Highlight failing line with colored output..
Jun 29 2020, 2:58 PM · Restricted Project
varungandhi-apple updated the diff for D82791: [lit] Improve lit's output with default settings and --verbose..
  • [docs] [lit] Add a more helpful description for lit.py's -s flag.
  • [NFC] [lit] Separate verbose and showOutput.
  • [lit] Improve lit's output with default settings and --verbose.
Jun 29 2020, 2:46 PM · Restricted Project, Restricted Project
varungandhi-apple updated the diff for D82791: [lit] Improve lit's output with default settings and --verbose..

Include missing commit separating verbose and showOutput.

Jun 29 2020, 2:46 PM · Restricted Project, Restricted Project
varungandhi-apple created D82808: [docs] [lit] Add a more helpful description for lit.py's -s flag..
Jun 29 2020, 2:46 PM · Restricted Project
varungandhi-apple created D82791: [lit] Improve lit's output with default settings and --verbose..
Jun 29 2020, 10:48 AM · Restricted Project, Restricted Project

Jun 19 2020

varungandhi-apple added inline comments to D82233: [lit] Add --show-xxx command line options.
Jun 19 2020, 5:56 PM · Restricted Project

May 31 2020

varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

On second thought, I'm going to update the documentation alongside the behavior change, to make sure the two are in sync.
Patch 1: Change behavior of -v. (and default and -vv behavior). Update https://llvm.org/docs/CommandGuide/lit.html as necessary.
Patch 2: Add highlighting/colored output. Update https://llvm.org/docs/CommandGuide/lit.html as necessary.
Patch 3: Rename echo_all_commands to runWithCommandOutput.

May 31 2020, 7:25 PM · Restricted Project

May 28 2020

varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

Quick question: We show the command output up to and including the failing line. Should we do the same for the script part, i.e., skip the un-executed part of the script? Is it ever useful to know which script line/command would have been executed next?

May 28 2020, 5:38 PM · Restricted Project
varungandhi-apple added a comment to D80694: Improve lit.py's usability by highlighting failing lines..

@JDevlieghere, that is part of the code that is writing out the command line.

May 28 2020, 3:59 PM · Restricted Project