Page MenuHomePhabricator

tsymalla (Thomas Symalla)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2020, 7:16 AM (10 w, 4 d)

Recent Activity

Mon, Feb 8

tsymalla committed rGf89f6d1e5d7d: [AMDGPU]: Fixes an invalid clamp selection pattern. (authored by tsymalla).
[AMDGPU]: Fixes an invalid clamp selection pattern.
Mon, Feb 8, 4:07 AM
tsymalla closed D95878: [AMDGPU]: Fixes an invalid clamp selection pattern..
Mon, Feb 8, 4:06 AM · Restricted Project

Wed, Feb 3

tsymalla updated subscribers of D95878: [AMDGPU]: Fixes an invalid clamp selection pattern..

I extracted the corresponding parts into a separate lambda and improved the logic to only apply the combine in the corresponding cases where either a min-max or max-min pattern exists in the MIR.
As @Flakebi reverted the changes to prevent the sanitizer from failing, I re-added the changes to this revision.

Wed, Feb 3, 8:19 AM · Restricted Project
tsymalla updated the diff for D95878: [AMDGPU]: Fixes an invalid clamp selection pattern..

[AMDGPU] Re-adding the changes from D93708 and fixing the clamp selection pattern.
This patch intends to re-add the changes from D93708 which were removed in d49efdc9696afee4b972c54bc3678b28c5700047 and should fix the issue adressed in this update.
This should fix the sanitizer builds and prevent applying the clamp in unwanted cases.

Wed, Feb 3, 8:16 AM · Restricted Project

Tue, Feb 2

tsymalla added inline comments to D95878: [AMDGPU]: Fixes an invalid clamp selection pattern..
Tue, Feb 2, 9:41 AM · Restricted Project
tsymalla requested review of D95878: [AMDGPU]: Fixes an invalid clamp selection pattern..
Tue, Feb 2, 9:29 AM · Restricted Project
tsymalla committed rG677a3529d3e6: [AMDGPU] Add new short clamp pattern in GlobalISel. (authored by tsymalla).
[AMDGPU] Add new short clamp pattern in GlobalISel.
Tue, Feb 2, 12:33 AM
tsymalla committed rG508329922dad: Removed Diff file. (authored by tsymalla).
Removed Diff file.
Tue, Feb 2, 12:18 AM
tsymalla committed rGfaeed774d157: Fixed includes. (authored by tsymalla).
Fixed includes.
Tue, Feb 2, 12:17 AM
tsymalla committed rG6c85e98f0642: Fixed includes. (authored by tsymalla).
Fixed includes.
Tue, Feb 2, 12:17 AM
tsymalla committed rG09508d284960: Reverted whitespace changes. (authored by tsymalla).
Reverted whitespace changes.
Tue, Feb 2, 12:17 AM
tsymalla committed rGe630dd476ca7: Added missing includes. (authored by tsymalla).
Added missing includes.
Tue, Feb 2, 12:17 AM
tsymalla closed D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Tue, Feb 2, 12:17 AM · Restricted Project, Restricted Project
tsymalla committed rG602896b9d2f2: Renamed med3 opcode, removed superfluous copy. (authored by tsymalla).
Renamed med3 opcode, removed superfluous copy.
Tue, Feb 2, 12:17 AM
tsymalla committed rGfa3e840d3d7d: Removed the generic virtual register creations. Reworked the tests. (authored by tsymalla).
Removed the generic virtual register creations. Reworked the tests.
Tue, Feb 2, 12:17 AM
tsymalla committed rGc781c2541244: Implemented a MED3_S32 GIR opcode. (authored by tsymalla).
Implemented a MED3_S32 GIR opcode.
Tue, Feb 2, 12:17 AM
tsymalla committed rG6604d81e1bb3: Added and used new target pseudo for v_cvt_pk_i16_i32, changes due to code… (authored by tsymalla).
Added and used new target pseudo for v_cvt_pk_i16_i32, changes due to code…
Tue, Feb 2, 12:17 AM
tsymalla committed rG52bfb50145ab: Formatting changes (authored by tsymalla).
Formatting changes
Tue, Feb 2, 12:17 AM
tsymalla committed rGbcd6c2d2031a: Updating formatting changes. (authored by tsymalla).
Updating formatting changes.
Tue, Feb 2, 12:17 AM
tsymalla committed rG7d24026ed2b7: Formatting changes. (authored by tsymalla).
Formatting changes.
Tue, Feb 2, 12:17 AM
tsymalla committed rGecbed4e0ab3e: Resolve formatting changes. (authored by tsymalla).
Resolve formatting changes.
Tue, Feb 2, 12:17 AM
tsymalla committed rG7b2e701906c6: Code changes yielded from review. (authored by tsymalla).
Code changes yielded from review.
Tue, Feb 2, 12:17 AM
tsymalla committed rG79e729bdf14c: Fixed tests. (authored by tsymalla).
Fixed tests.
Tue, Feb 2, 12:17 AM
tsymalla committed rG3a46502264b6: Move step to PreLegalizer (authored by tsymalla).
Move step to PreLegalizer
Tue, Feb 2, 12:17 AM
tsymalla committed rGcdfd9b3bf52e: Move Combiner to PreLegalize step (authored by tsymalla).
Move Combiner to PreLegalize step
Tue, Feb 2, 12:17 AM
tsymalla committed rGf2ef2fbc692e: Renamed identifiers in lit (authored by tsymalla).
Renamed identifiers in lit
Tue, Feb 2, 12:16 AM
tsymalla committed rG9a8da909f192: Reverted unintended git-format change. (authored by tsymalla).
Reverted unintended git-format change.
Tue, Feb 2, 12:16 AM
tsymalla committed rGdae85e467141: Fixed the lit tests and a bug in the implementation. (authored by tsymalla).
Fixed the lit tests and a bug in the implementation.
Tue, Feb 2, 12:16 AM
tsymalla committed rG88a832aef1a6: Refactored the pattern matching. (authored by tsymalla).
Refactored the pattern matching.
Tue, Feb 2, 12:16 AM
tsymalla committed rGd41b7fa9bf80: Renames (authored by tsymalla).
Renames
Tue, Feb 2, 12:16 AM
tsymalla committed rGfce3230be2c8: Added early exit. (authored by tsymalla).
Added early exit.
Tue, Feb 2, 12:16 AM
tsymalla committed rGd722924f2091: Added comments. (authored by tsymalla).
Added comments.
Tue, Feb 2, 12:16 AM
tsymalla committed rGec043967ecb4: clang-format (authored by tsymalla).
clang-format
Tue, Feb 2, 12:16 AM
tsymalla committed rG62af0305b7cc: Added clamp i64 to i16 global isel pattern. (authored by tsymalla).
Added clamp i64 to i16 global isel pattern.
Tue, Feb 2, 12:16 AM

Mon, Feb 1

tsymalla updated the diff for D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Reverted whitespace changes, added missing includes.

Mon, Feb 1, 12:44 AM · Restricted Project, Restricted Project

Sun, Jan 31

tsymalla added a comment to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

I investigated the problem and it seems, there were some includes missing in PostLegalizerCombiner as there were changes in terms of how the instructions are made available to the TU.
I will fix this and upload a new patch.

Sun, Jan 31, 11:58 PM · Restricted Project, Restricted Project

Jan 27 2021

tsymalla added a comment to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

I've tried applying this but getting some build errors. You also have some remaining trailing whitespace and extra whitespace changes

Jan 27 2021, 11:12 AM · Restricted Project, Restricted Project
tsymalla added a comment to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Requested access. Thanks.

Jan 27 2021, 10:01 AM · Restricted Project, Restricted Project
tsymalla added a comment to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Hi, it seems, I am not permitted to commit this patch. Could somebody please do the commit for me? Thanks!

Jan 27 2021, 1:24 AM · Restricted Project, Restricted Project

Jan 26 2021

tsymalla updated the diff for D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Renamed the G_MED3 opcode and removed a superfluous copy.

Jan 26 2021, 2:30 AM · Restricted Project, Restricted Project

Jan 25 2021

tsymalla updated the diff for D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Removes the generic createVirtualRegister invocations and the manual setting of the VGPR32 register class.

Jan 25 2021, 6:22 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Jan 25 2021, 6:20 AM · Restricted Project, Restricted Project

Jan 18 2021

tsymalla added a comment to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Added the new MED3 pseudo.

Jan 18 2021, 7:07 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

This adds an additional G_MED3_S32 GIR opcode and uses it in the PreLegalizerCombiner.

Jan 18 2021, 7:06 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Jan 18 2021, 4:03 AM · Restricted Project, Restricted Project

Jan 13 2021

tsymalla updated the diff for D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Implemented a GMIR instruction for the V_CVT opcode and did some changes to the implementation according to the code reviews.

Jan 13 2021, 6:45 AM · Restricted Project, Restricted Project
tsymalla added a comment to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

No, I doubt there is support for this in the other path.

Jan 13 2021, 6:41 AM · Restricted Project, Restricted Project

Jan 12 2021

tsymalla updated the diff for D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Various changes according to the code review. I don't know why the formatting changes in the PostLegalizer keep showing up as they are already reverted to HEAD...

Jan 12 2021, 4:05 AM · Restricted Project, Restricted Project
tsymalla added a comment to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Previously this was implemented in the PostLegalizer. The SMAX / SMIN MIR gets lowered to a pattern of G_SELECT / G_ICMP, so the state after PostLegalizing is equivalent to what I've implemented in the tests before matching this to the min/max instructions. Disabling the optimization in the implementation here yields a result similar to the following:

Jan 12 2021, 12:39 AM · Restricted Project, Restricted Project

Jan 11 2021

tsymalla updated the diff for D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

This moves the implementation to the PreLegalizer and is based on LLVM max/min intrinsics.

Jan 11 2021, 6:13 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Jan 11 2021, 4:33 AM · Restricted Project, Restricted Project

Jan 5 2021

tsymalla added inline comments to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Jan 5 2021, 9:07 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Jan 5 2021, 2:25 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Renamed the identifiers in the lit test.

Jan 5 2021, 2:25 AM · Restricted Project, Restricted Project

Jan 4 2021

tsymalla added inline comments to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Jan 4 2021, 6:56 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Refactored the pattern matching algorithm. I removed the construct from MIPatternMatch and implemented it directly in the PostLegalizerCombiner.

Jan 4 2021, 6:28 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Mostly renamings.

Jan 4 2021, 2:50 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Jan 4 2021, 2:21 AM · Restricted Project, Restricted Project

Dec 22 2020

tsymalla requested review of D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Dec 22 2020, 7:39 AM · Restricted Project, Restricted Project
tsymalla abandoned D93706: Added early exit..
Dec 22 2020, 7:23 AM · Restricted Project
tsymalla requested review of D93706: Added early exit..
Dec 22 2020, 7:22 AM · Restricted Project