Page MenuHomePhabricator

tpopp (Theodore Popp)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 3 2020, 4:17 AM (55 w, 1 h)

Recent Activity

Tue, Jan 19

tpopp added a comment to D94934: [llvm] Prevent infinite loop in InstCombine of select statements.

I apologize, but I was not having any luck at creating a test case that wasn't constant folded away.

Tue, Jan 19, 1:31 AM · Restricted Project

Mon, Jan 18

tpopp added a comment to D94862: [InstCombine] Replace one-use select operand based on condition.

I've been unable to create a reproducer because of other optimizations getting in the way, but I'm seeing a case of infinite loops in inst combine due to both CmpLHS and CmpRHS being constants.

Mon, Jan 18, 2:45 PM · Restricted Project
tpopp added reviewers for D94934: [llvm] Prevent infinite loop in InstCombine of select statements: nikic, aqjune.
Mon, Jan 18, 2:42 PM · Restricted Project
tpopp requested review of D94934: [llvm] Prevent infinite loop in InstCombine of select statements.
Mon, Jan 18, 2:41 PM · Restricted Project
tpopp added a comment to D92071: [PowerPC] support register pressure reduction in machine combiner..

Thanks for addressing the issues shchenz! I'm glad you figured out the use-of-uninitialized-value because that one confused me. I'm finishing my workday for the day, so I can rerun the patch tomorrow. Alternatively, all I know is that I had errors in my environment and that's what sanitizers showed, so you reproducing and fixing the issues is plenty I think.

Mon, Jan 18, 11:19 AM · Restricted Project
tpopp added a comment to D92071: [PowerPC] support register pressure reduction in machine combiner..

I'm going to roll this back as it's causing build bot failures (in progress example here: http://45.33.8.238/win/31506/). Sanitizers show the following issues:

==9097==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x5628a1bd3d10 in llvm::PPCInstrInfo::getFMAPatterns(llvm::MachineInstr&, llvm::SmallVectorImpl<llvm::MachineCombinerPattern>&, bool) const third_party/llvm/llvm-project/llvm/lib/Target/PowerPC/PPCInstrIn
fo.cpp:474:27                                                                                            
    #1 0x5628a1bd7e6c in llvm::PPCInstrInfo::getMachineCombinerPatterns(llvm::MachineInstr&, llvm::SmallVectorImpl<llvm::MachineCombinerPattern>&, bool) const third_party/llvm/llvm-project/llvm/lib/Target/PowerP
C/PPCInstrInfo.cpp:751:7                            
    #2 0x5628a3291840 in combineInstructions third_party/llvm/llvm-project/llvm/lib/CodeGen/MachineCombiner.cpp:593:15
    #3 0x5628a3291840 in (anonymous namespace)::MachineCombiner::runOnMachineFunction(llvm::MachineFunction&) third_party/llvm/llvm-project/llvm/lib/CodeGen/MachineCombiner.cpp:736:16                            
    #4 0x5628a32f91a2 in llvm::MachineFunctionPass::runOnFunction(llvm::Function&) third_party/llvm/llvm-project/llvm/lib/CodeGen/MachineFunctionPass.cpp:72:13                                                    
    #5 0x5628a5e0dce7 in llvm::FPPassManager::runOnFunction(llvm::Function&) third_party/llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1439:27                                                               
    #6 0x5628a5e22f60 in llvm::FPPassManager::runOnModule(llvm::Module&) third_party/llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1485:16                                                                   
    #7 0x5628a5e0f1d5 in runOnModule third_party/llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1554:27
    #8 0x5628a5e0f1d5 in llvm::legacy::PassManagerImpl::run(llvm::Module&) third_party/llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:541:44                                                                  
    #9 0x56289f8dcb66 in compileModule(char**, llvm::LLVMContext&) third_party/llvm/llvm-project/llvm/tools/llc/llc.cpp:658:8

and

==1709==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f155364a060 at pc 0x555a067755c4 bp 0x7fff9b909050 sp 0x7fff9b909048
READ of size 8 at 0x7f155364a060 thread T0
    #0 0x555a067755c3 in operator[] third_party/crosstool/v18/stable/toolchain/bin/../include/c++/v1/vector:1550:18
    #1 0x555a067755c3 in llvm::PPCInstrInfo::shouldReduceRegisterPressure(llvm::MachineBasicBlock*, llvm::RegisterClassInfo*) const third_party/llvm/llvm-project/llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:655:10
    #2 0x555a07df5618 in combineInstructions third_party/llvm/llvm-project/llvm/lib/CodeGen/MachineCombiner.cpp:561:12
    #3 0x555a07df5618 in (anonymous namespace)::MachineCombiner::runOnMachineFunction(llvm::MachineFunction&) third_party/llvm/llvm-project/llvm/lib/CodeGen/MachineCombiner.cpp:736:16
    #4 0x555a07e54479 in llvm::MachineFunctionPass::runOnFunction(llvm::Function&) third_party/llvm/llvm-project/llvm/lib/CodeGen/MachineFunctionPass.cpp:72:13
    #5 0x555a0b360710 in llvm::FPPassManager::runOnFunction(llvm::Function&) third_party/llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1439:27
    #6 0x555a0b374470 in llvm::FPPassManager::runOnModule(llvm::Module&) third_party/llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1485:16
    #7 0x555a0b3616e0 in runOnModule third_party/llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1554:27
    #8 0x555a0b3616e0 in llvm::legacy::PassManagerImpl::run(llvm::Module&) third_party/llvm/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:541:44
    #9 0x555a0461db8b in compileModule(char**, llvm::LLVMContext&) third_party/llvm/llvm-project/llvm/tools/llc/llc.cpp:658:8
    #10 0x555a046183bf in main third_party/llvm/llvm-project/llvm/tools/llc/llc.cpp:363:22
Mon, Jan 18, 3:00 AM · Restricted Project

Fri, Jan 15

tpopp updated the diff for D94784: [llvm][nvptx] add atomicity to counter in ISelLowering.

Another naming convention correction.

Fri, Jan 15, 1:09 PM · Restricted Project
tpopp updated the diff for D94784: [llvm][nvptx] add atomicity to counter in ISelLowering.

Match LLVM naming convention.

Fri, Jan 15, 9:00 AM · Restricted Project
tpopp requested review of D94784: [llvm][nvptx] add atomicity to counter in ISelLowering.
Fri, Jan 15, 8:13 AM · Restricted Project

Thu, Jan 14

tpopp requested review of D94706: [mlir] Remove TosaToLinalg dependency on all Passes.
Thu, Jan 14, 12:06 PM · Restricted Project

Wed, Jan 13

tpopp requested review of D94623: [mlir] Correct 2 places that result in corrupted conversion rollbacks.
Wed, Jan 13, 11:20 AM · Restricted Project

Tue, Jan 5

tpopp added a comment to D93903: [mlir] Gen removeAttr methods with tablegen.

No problem. https://reviews.llvm.org/D94132 is my fix CL. Please take a look if you have time. I just prepended ::mlir:: everywhere, but I didn't look deeply at the code (I'm running tests now, but they take a while for me).

Tue, Jan 5, 3:45 PM · Restricted Project
tpopp requested review of D94132: [mlir] Fully specify removeAttr return type.
Tue, Jan 5, 3:43 PM · Restricted Project
tpopp added a comment to D93903: [mlir] Gen removeAttr methods with tablegen.

I can handle this one, but just a note that this used Attribute instead of ::mlir::Attribute like all the other cases. This can fail then on any code not in an mlir namespace.

Tue, Jan 5, 3:36 PM · Restricted Project

Dec 21 2020

tpopp requested review of D93666: [mlir] Add SmallVector sizes.
Dec 21 2020, 2:11 PM · Restricted Project
tpopp accepted D93635: Remove unused variables..
Dec 21 2020, 7:22 AM · Restricted Project

Dec 16 2020

tpopp requested review of D93418: [mlir] Modify linalg loops test to have nested regions.
Dec 16 2020, 1:13 PM · Restricted Project

Dec 15 2020

tpopp updated the diff for D93349: [mlir] Allow SymbolTable to update existing symbols.

Correct typo and add comment

Dec 15 2020, 3:19 PM · Restricted Project
tpopp requested review of D93349: [mlir] Allow SymbolTable to update existing symbols.
Dec 15 2020, 3:15 PM · Restricted Project
tpopp requested review of D93313: [mlir] Add std.powf to ROCDL lowering..
Dec 15 2020, 9:26 AM · Restricted Project
tpopp requested review of D93311: [mlir] Add std.pow lowering to LLVMIR.
Dec 15 2020, 9:16 AM · Restricted Project
tpopp requested review of D93308: [mlir] Allow nested regions in inlineRegionAndEmitStore.
Dec 15 2020, 8:41 AM · Restricted Project
tpopp updated the diff for D93303: [mlir] Add NVVM lowering for std.pow.

Add test case

Dec 15 2020, 8:34 AM · Restricted Project
tpopp requested review of D93303: [mlir] Add NVVM lowering for std.pow.
Dec 15 2020, 8:18 AM · Restricted Project
tpopp updated the summary of D93119: [mlir] Add std op for X raised to the power of Y.
Dec 15 2020, 7:58 AM · Restricted Project
tpopp updated the diff for D93119: [mlir] Add std op for X raised to the power of Y.

Add link to RFC and test case.

Dec 15 2020, 7:57 AM · Restricted Project

Dec 14 2020

tpopp updated the diff for D93119: [mlir] Add std op for X raised to the power of Y.

Remove powi

Dec 14 2020, 10:57 AM · Restricted Project

Dec 11 2020

tpopp requested review of D93119: [mlir] Add std op for X raised to the power of Y.
Dec 11 2020, 7:10 AM · Restricted Project

Dec 9 2020

tpopp requested review of D92963: [mlir] Allow RegionBranchOps in dependence analysis..
Dec 9 2020, 12:58 PM · Restricted Project

Dec 8 2020

tpopp added inline comments to D92685: [mlir] Use rewriting infrastructure in AsyncToLLVM.
Dec 8 2020, 7:29 AM · Restricted Project
tpopp accepted D92843: [mlir][Shape] Canonicalize assume_all with one input and tensor_cast of constant_shape.
Dec 8 2020, 7:27 AM · Restricted Project
tpopp requested changes to D92843: [mlir][Shape] Canonicalize assume_all with one input and tensor_cast of constant_shape.
Dec 8 2020, 6:46 AM · Restricted Project

Dec 7 2020

tpopp updated the diff for D92685: [mlir] Use rewriting infrastructure in AsyncToLLVM.

Update comments.

Dec 7 2020, 3:10 PM · Restricted Project

Dec 4 2020

tpopp added a comment to D92562: [MLIR] Refactored BufferDeallocation pass to enable support for individual alloc/clone/free operations..

As a general matter of policy in LLVM, we do not bypass ongoing design discussions to unblock downstream users.

Dec 4 2020, 5:57 PM · Restricted Project
tpopp updated the diff for D92685: [mlir] Use rewriting infrastructure in AsyncToLLVM.

Pass an OpBuilder instead of an optional Listener.

Dec 4 2020, 1:22 PM · Restricted Project
tpopp requested review of D92685: [mlir] Use rewriting infrastructure in AsyncToLLVM.
Dec 4 2020, 1:15 PM · Restricted Project

Nov 30 2020

tpopp accepted D92075: Don't count attributes when addressing operands..
Nov 30 2020, 6:31 AM · Restricted Project

Nov 27 2020

tpopp added inline comments to D92075: Don't count attributes when addressing operands..
Nov 27 2020, 2:27 PM · Restricted Project

Nov 25 2020

tpopp added inline comments to D92075: Don't count attributes when addressing operands..
Nov 25 2020, 7:52 AM · Restricted Project

Nov 19 2020

tpopp added a comment to D91822: [mlir] Add missing const * updates in StandardAttributes.

No problem :) It's just unfortunate there weren't any tests using this to catch this.

Nov 19 2020, 1:57 PM · Restricted Project
tpopp requested review of D91822: [mlir] Add missing const * updates in StandardAttributes.
Nov 19 2020, 1:50 PM · Restricted Project
tpopp requested review of D91791: Use rewriter in SCFToSPIRV conversion..
Nov 19 2020, 5:42 AM · Restricted Project
tpopp requested review of D91788: Fix rollback of first block in a region..
Nov 19 2020, 5:29 AM · Restricted Project

Nov 18 2020

tpopp accepted D91672: Add a shape function library op.

Only nits.

Nov 18 2020, 6:40 PM · Restricted Project

Nov 11 2020

tpopp added inline comments to D91185: [mlir] Rework DialectConversion inlineRegionBefore.
Nov 11 2020, 1:42 AM · Restricted Project
tpopp updated the diff for D91185: [mlir] Rework DialectConversion inlineRegionBefore.

Add a test

Nov 11 2020, 1:41 AM · Restricted Project

Nov 10 2020

tpopp accepted D91070: [mlir] Add print functions for i64, index..
Nov 10 2020, 10:58 AM · Restricted Project
tpopp requested review of D91185: [mlir] Rework DialectConversion inlineRegionBefore.
Nov 10 2020, 10:08 AM · Restricted Project

Nov 9 2020

tpopp requested review of D91079: [mlir] Fix bug in use of rewiter for AtomicRMWOp..
Nov 9 2020, 6:57 AM · Restricted Project

Nov 3 2020

tpopp abandoned D90405: [mlir] Add shape.is_broadcastable..

Somehow I submitted this already, but the commit detached from this review. I am abandoning this change, so it goes away, but I will handle feedback in a follow up commit.

Nov 3 2020, 12:42 AM · Restricted Project

Oct 30 2020

tpopp added inline comments to D89325: [mlir] Add partial lowering of shape.cstr_broadcastable..
Oct 30 2020, 3:07 AM · Restricted Project
tpopp added a comment to D90407: [mlir] Add lowering for IsBroadcastable to Std dialect..

I'm going to land this with these changes because the code was already in another commit and didn't receive any strong negative feedback, so I'm hoping there are only nits left if anything. I will follow up on any comments.

Oct 30 2020, 2:41 AM · Restricted Project

Oct 29 2020

tpopp updated the diff for D89325: [mlir] Add partial lowering of shape.cstr_broadcastable..

Reformat each block of code in own namespace.

Oct 29 2020, 9:45 AM · Restricted Project
tpopp added inline comments to D90407: [mlir] Add lowering for IsBroadcastable to Std dialect..
Oct 29 2020, 9:42 AM · Restricted Project
tpopp added a reviewer for D90407: [mlir] Add lowering for IsBroadcastable to Std dialect.: jpienaar.
Oct 29 2020, 9:40 AM · Restricted Project
tpopp updated the diff for D89325: [mlir] Add partial lowering of shape.cstr_broadcastable..

Rework to lower to IsBroadcastable which is further lowered.

Oct 29 2020, 9:40 AM · Restricted Project
tpopp requested review of D90407: [mlir] Add lowering for IsBroadcastable to Std dialect..
Oct 29 2020, 9:39 AM · Restricted Project
tpopp abandoned D90406: [mlir] Add lowering for shape.is_broadcastable to Std dialect..
Oct 29 2020, 9:33 AM · Restricted Project
tpopp requested review of D90406: [mlir] Add lowering for shape.is_broadcastable to Std dialect..
Oct 29 2020, 9:32 AM · Restricted Project
tpopp requested review of D90405: [mlir] Add shape.is_broadcastable..
Oct 29 2020, 9:27 AM · Restricted Project
tpopp requested review of D90375: [mlir] Reorder shape assuming bufferization..
Oct 29 2020, 3:05 AM · Restricted Project

Oct 28 2020

tpopp abandoned D89877: [mlir] Remove ConversionPatternRewriter recursive optimization..

Thank you for the explanation. My first example was the example, so I've reworked the code to move data before replacing an op. I will follow up with adding an assert to help prevent other people making the same mistake as me.

Oct 28 2020, 10:25 AM · Restricted Project

Oct 21 2020

tpopp accepted D89833: [mlir][shape] Split out structural type conversions for shape dialect..

Thanks for the explanation regarding the AssumingYieldOp also. I found it strange that it was working with that before and just assumed that ops didn't need to be updated if only their inputs changed.

Oct 21 2020, 7:01 AM · Restricted Project
tpopp added a comment to D89877: [mlir] Remove ConversionPatternRewriter recursive optimization..

Let me know what you think of something like this River.

Oct 21 2020, 6:25 AM · Restricted Project
tpopp requested review of D89877: [mlir] Remove ConversionPatternRewriter recursive optimization..
Oct 21 2020, 6:12 AM · Restricted Project

Oct 20 2020

tpopp requested review of D89782: [mlir] Use affine dim instead of symbol in SCFToGPU lowering..
Oct 20 2020, 2:35 AM · Restricted Project

Oct 16 2020

tpopp resigned from D88973: IR: Fix issues with linking typed sret.
Oct 16 2020, 8:55 AM · Restricted Project

Oct 13 2020

tpopp added a comment to D89325: [mlir] Add partial lowering of shape.cstr_broadcastable..

Please let me know what you think of this. I think lowering away the "broadcast" logic and keeping the "cstr" logic in ShapeToStd fits with the purpose of the pass, but that is debatable.

Oct 13 2020, 8:59 AM · Restricted Project
tpopp requested review of D89325: [mlir] Add partial lowering of shape.cstr_broadcastable..
Oct 13 2020, 8:57 AM · Restricted Project

Oct 9 2020

tpopp requested review of D89134: [mlir] Type erase inputs to select statements in shape.broadcast lowering..
Oct 9 2020, 8:04 AM · Restricted Project
tpopp requested review of D89129: [mlir] Forward listeners when utilizing scf::IfOp::get*BodyBuilder..
Oct 9 2020, 6:46 AM · Restricted Project
tpopp requested review of D89122: [mlir] Use PatternRewriter infrastructure for shape.assuming bufferization.
Oct 9 2020, 5:36 AM · Restricted Project

Oct 2 2020

tpopp added inline comments to D88083: [mlir] Add file to implement bufferization for shape ops..
Oct 2 2020, 7:00 AM · Restricted Project
tpopp updated the diff for D88083: [mlir] Add file to implement bufferization for shape ops..

Clarify the transformation of tensors to memrefs.
Leave TODOs to generalize this the rest of the way in regards to supported type conversions.

Oct 2 2020, 6:58 AM · Restricted Project

Sep 29 2020

tpopp added inline comments to D88423: Fix llvm-link assert failure in BitCodeWriter.
Sep 29 2020, 1:35 AM · Restricted Project
tpopp added a comment to D88241: OpaquePtr: Add type to sret attribute.

I have reverted this change based on the comments in the fixup patch. I apologize for any difficulties this causes.

Sep 29 2020, 1:33 AM · Restricted Project

Sep 22 2020

tpopp resigned from D87941: [mlir][shape] Start a pass that lowers shape constraints..
Sep 22 2020, 6:34 AM · Restricted Project
tpopp added inline comments to D87941: [mlir][shape] Start a pass that lowers shape constraints..
Sep 22 2020, 6:34 AM · Restricted Project
tpopp requested review of D88083: [mlir] Add file to implement bufferization for shape ops..
Sep 22 2020, 3:25 AM · Restricted Project

Sep 18 2020

tpopp abandoned D84635: [MLIR] Add lowering for shape.extend..
Sep 18 2020, 7:07 AM · Restricted Project
tpopp abandoned D84632: [MLIR] Add shape.extend op..

I'm abandoning this revision for now

Sep 18 2020, 7:07 AM · Restricted Project
tpopp updated the diff for D87894: [mlir] Shape.AssumingOp implements RegionBranchOpInterface..

Add note to explain purpose of method.

Sep 18 2020, 5:06 AM · Restricted Project
tpopp added a comment to D87894: [mlir] Shape.AssumingOp implements RegionBranchOpInterface..

Ready for review now.

Sep 18 2020, 5:06 AM · Restricted Project
tpopp updated the diff for D87894: [mlir] Shape.AssumingOp implements RegionBranchOpInterface..

Update test case to pass by using previously unused value.

Sep 18 2020, 5:04 AM · Restricted Project
tpopp added a comment to D87894: [mlir] Shape.AssumingOp implements RegionBranchOpInterface..

Note that this is not complete and was uploaded at the current state to share a patch to reproduce a bug.

Sep 18 2020, 2:18 AM · Restricted Project
tpopp requested review of D87894: [mlir] Shape.AssumingOp implements RegionBranchOpInterface..
Sep 18 2020, 2:16 AM · Restricted Project

Sep 15 2020

tpopp requested review of D87706: [mlir] Remove redundant shape.cstr_broadcastable canonicalization..
Sep 15 2020, 9:31 AM · Restricted Project

Jul 29 2020

tpopp requested review of D84845: [MLIR][NFC] Move Shape::WitnessType Declaration..
Jul 29 2020, 7:04 AM · Restricted Project
tpopp requested review of D84832: [MLIR] Forward extent tensors through shape.broadcast..
Jul 29 2020, 4:04 AM · Restricted Project

Jul 27 2020

tpopp updated the diff for D84635: [MLIR] Add lowering for shape.extend..

Correct loop space of the second for loop to be a suffix rather than a prefix.

Jul 27 2020, 6:12 AM · Restricted Project
Herald added a project to D84635: [MLIR] Add lowering for shape.extend.: Restricted Project.
Jul 27 2020, 4:14 AM · Restricted Project
Herald added a project to D84632: [MLIR] Add shape.extend op.: Restricted Project.
Jul 27 2020, 3:48 AM · Restricted Project

Jul 21 2020

tpopp added inline comments to D83969: Create the Reduction Tree Pass.
Jul 21 2020, 11:43 AM · Restricted Project

Jul 17 2020

tpopp added inline comments to D83969: Create the Reduction Tree Pass.
Jul 17 2020, 9:38 AM · Restricted Project

Jul 15 2020

tpopp accepted D83854: [mlir][shape] Fold shape.broadcast with scalar operands.

LGTM otherwise

Jul 15 2020, 8:50 AM · Restricted Project
tpopp added inline comments to D83854: [mlir][shape] Fold shape.broadcast with scalar operands.
Jul 15 2020, 8:45 AM · Restricted Project

Jul 7 2020

tpopp added inline comments to D83194: [mlir] Add additional Canonicalization of shape.cstr_broadcastable..
Jul 7 2020, 4:57 AM · Restricted Project
tpopp updated the diff for D83194: [mlir] Add additional Canonicalization of shape.cstr_broadcastable..

Refactor code. No new behavior was added.

Jul 7 2020, 4:30 AM · Restricted Project

Jul 6 2020

tpopp accepted D83123: [MLIR][Shape] Lower `shape.any`.
Jul 6 2020, 2:46 AM · Restricted Project
Herald added a project to D83194: [mlir] Add additional Canonicalization of shape.cstr_broadcastable.: Restricted Project.
Jul 6 2020, 1:44 AM · Restricted Project