Page MenuHomePhabricator

tomrittervg (Tom Ritter)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2019, 9:58 AM (74 w, 1 d)

Recent Activity

Yesterday

tomrittervg added a comment to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

I started trying to work on a patch, but I'm still unpacking from a move and don't have all my machines set up - trying to enable and build tests filled up my hard drive (even after I removed the easy-to-remove stuff), so I don't think I'm going to be able to create a test for this in the short-term.

Okay, I think this LGTM even without the test coverage. Thank you for the patch, do you need someone to commit it on your behalf?

Tue, Jan 19, 7:55 AM · Restricted Project

Fri, Jan 15

tomrittervg added a comment to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

I started trying to work on a patch, but I'm still unpacking from a move and don't have all my machines set up - trying to enable and build tests filled up my hard drive (even after I removed the easy-to-remove stuff), so I don't think I'm going to be able to create a test for this in the short-term.

Fri, Jan 15, 11:09 AM · Restricted Project
tomrittervg updated the diff for D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

Remove braces

Fri, Jan 15, 11:07 AM · Restricted Project

Thu, Jan 14

tomrittervg updated the diff for D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

Okay, completely new direction that handles things better I think.

Thu, Jan 14, 12:51 PM · Restricted Project
tomrittervg added a comment to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

Actually, I think I need to be smarter than changing the default. We want to let clang auto-detect the tty and behave that way by default if the option isn't specified. Otherwise you'd get ASNI color codes when you pipe to a file.

+1 to this, but also, you need to thread the option through to the diagnostics engine as well.

Thu, Jan 14, 7:18 AM · Restricted Project
tomrittervg retitled D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior from [PATCH] [clang-query] Add a --use-color option to clang-query to [PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 7:07 AM · Restricted Project
tomrittervg updated the diff for D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

Actually, I think I need to be smarter than changing the default. We want to let clang auto-detect the tty and behave that way by default if the option isn't specified. Otherwise you'd get ASNI color codes when you pipe to a file.

Thu, Jan 14, 7:07 AM · Restricted Project
tomrittervg added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:39 AM · Restricted Project
tomrittervg added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:24 AM · Restricted Project

Wed, Jan 13

tomrittervg requested review of D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Wed, Jan 13, 11:31 AM · Restricted Project