Page MenuHomePhabricator

tmatheson (Tomas Matheson)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 10 2020, 4:17 AM (18 w, 3 d)

Recent Activity

Wed, Apr 14

tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Update abilist for MacOS C++20

Wed, Apr 14, 3:50 AM · Unknown Object (Project)
tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Ping

Wed, Apr 14, 2:59 AM · Unknown Object (Project)

Wed, Apr 7

tmatheson added inline comments to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
Wed, Apr 7, 12:42 PM · Unknown Object (Project)
tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Update formatting to match the rest of the file

Wed, Apr 7, 12:36 PM · Unknown Object (Project)
tmatheson added inline comments to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
Wed, Apr 7, 10:16 AM · Unknown Object (Project)
tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
  • Remove handling of INFINITY and associated tests, add a few tests for variations of INF
Wed, Apr 7, 10:02 AM · Unknown Object (Project)
tmatheson added inline comments to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
Wed, Apr 7, 9:29 AM · Unknown Object (Project)
tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Ping

Wed, Apr 7, 2:43 AM · Unknown Object (Project)
tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
  • Update ABI symbols to account for added parameter in stage2_float_loop
  • Explicit cast in tests to avoid error when compiling with GCC
Wed, Apr 7, 2:28 AM · Unknown Object (Project)

Wed, Mar 31

tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

typo

Wed, Mar 31, 3:31 AM · Unknown Object (Project)

Tue, Mar 30

tmatheson added a reviewer for D99091: [locale][num_get] Improve Stage 2 of string to float conversion: ldionne.
Tue, Mar 30, 10:09 AM · Unknown Object (Project)
tmatheson accepted D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct.

That makes sense, you are correct that that warning is not prevented. I'm not sure what I did differently when I checked. LGTM.

Tue, Mar 30, 10:08 AM · Restricted Project
tmatheson committed rGa9968c0a339a: [NFC][CodeGen] Tidy up TargetRegisterInfo stack realignment functions (authored by tmatheson).
[NFC][CodeGen] Tidy up TargetRegisterInfo stack realignment functions
Tue, Mar 30, 9:32 AM
tmatheson closed D98716: [NFC][CodeGen] Separate TargetRegisterInfo needsStackRealignment and canRealignStack.
Tue, Mar 30, 9:31 AM · Restricted Project
tmatheson added a comment to D98716: [NFC][CodeGen] Separate TargetRegisterInfo needsStackRealignment and canRealignStack.

It looks like the clang-tidy CI is broken (running clang tidy on backends that have been modified but are not built?). The rest of the CI looks ok so I will merge this.

Tue, Mar 30, 9:28 AM · Restricted Project
tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

clang-format

Tue, Mar 30, 9:14 AM · Unknown Object (Project)
tmatheson updated the diff for D98716: [NFC][CodeGen] Separate TargetRegisterInfo needsStackRealignment and canRealignStack.

Rebase

Tue, Mar 30, 6:59 AM · Restricted Project
tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Also ping

Tue, Mar 30, 6:22 AM · Unknown Object (Project)
tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Replace lambda in header with macro

Tue, Mar 30, 5:49 AM · Unknown Object (Project)
tmatheson updated the diff for D98716: [NFC][CodeGen] Separate TargetRegisterInfo needsStackRealignment and canRealignStack.

Update with new names: shouldRealignStack/canRealignStack/hasStackRealignment

Tue, Mar 30, 4:44 AM · Restricted Project

Fri, Mar 26

tmatheson added a comment to D98716: [NFC][CodeGen] Separate TargetRegisterInfo needsStackRealignment and canRealignStack.

needsStackRealignment feels too strong given that the target can say we're not realigning the stack anyway. How about something like hasImpliedStackRealignment? And a partner function to call both called something like hasStackRealignment? And a partner function to call both called something like hasStackRealignment?

Fri, Mar 26, 7:11 AM · Restricted Project

Wed, Mar 24

tmatheson added a comment to D98716: [NFC][CodeGen] Separate TargetRegisterInfo needsStackRealignment and canRealignStack.

Ping

Wed, Mar 24, 4:06 AM · Restricted Project

Tue, Mar 23

tmatheson abandoned D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.

Thank you everyone for the comments, they have been very useful. From the discussions here and internally it seems that neither of these approaches (new target hook for spill location, or using bundles) is the right way forward, and I should look into the pseudo instructions. Since this review has grown quite large I will abandon it and open a new review when I have something working with pseudo expansion.

Tue, Mar 23, 4:41 AM · Restricted Project
tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Tidy up tests

Tue, Mar 23, 4:25 AM · Unknown Object (Project)
tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
  • Add tests for double and long double
  • Replace lambda with macro (there are C++03 builds, and filename/line number are not output when using lambda)
  • Remove constexpr (C++03 builds)
  • Undo refactoring of old tests
Tue, Mar 23, 3:56 AM · Unknown Object (Project)

Mon, Mar 22

tmatheson added reviewers for D99091: [locale][num_get] Improve Stage 2 of string to float conversion: Quuxplusone, zoecarver, miyuki.
Mon, Mar 22, 10:33 AM · Unknown Object (Project)
tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Minor change to tests

Mon, Mar 22, 10:23 AM · Unknown Object (Project)
tmatheson requested review of D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
Mon, Mar 22, 10:18 AM · Unknown Object (Project)

Mar 17 2021

tmatheson added inline comments to D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.
Mar 17 2021, 6:40 AM · Restricted Project
tmatheson added a comment to D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.

@lenary sorry for the delay in responding to comments.

Mar 17 2021, 5:49 AM · Restricted Project
tmatheson updated the diff for D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.
  • Address review comments and clang-tidy
  • Rename isLoadInstr/isStoreInstr to isExclusiveLoad/isExclusiveStore
Mar 17 2021, 5:23 AM · Restricted Project

Mar 16 2021

tmatheson updated the diff for D98716: [NFC][CodeGen] Separate TargetRegisterInfo needsStackRealignment and canRealignStack.

SparcFrameLowering: fix the check for failure to realign that was causing the test failure, and remove the old comment explaining needStackRealignment behavior.

Mar 16 2021, 1:20 PM · Restricted Project
tmatheson accepted D98720: [libc++] Consistency in _LIBCPP_CLANG_VER tests in <type_traits>.
Mar 16 2021, 10:00 AM · Unknown Object (Project)
tmatheson added a comment to D97283: [libcxx][type_traits] is_unsigned is false for enum types.

@zoecarver yes sorry about that, for some reason I had it in my head that they were green. I'll keep an eye out in case I broke something.

Mar 16 2021, 9:50 AM · Unknown Object (Project)
tmatheson committed rG64595f9b84fa: [libcxx][type_traits] add tests for is_signed and is_unsigned (authored by tmatheson).
[libcxx][type_traits] add tests for is_signed and is_unsigned
Mar 16 2021, 9:37 AM
tmatheson closed D97283: [libcxx][type_traits] is_unsigned is false for enum types.
Mar 16 2021, 9:36 AM · Unknown Object (Project)
tmatheson added reviewers for D98716: [NFC][CodeGen] Separate TargetRegisterInfo needsStackRealignment and canRealignStack: arsenm, carwil, momchil.velikov, reames, aeubanks, fhahn, MaskRay, MatzeB, shchenz.
Mar 16 2021, 9:30 AM · Restricted Project
tmatheson added a comment to D97283: [libcxx][type_traits] is_unsigned is false for enum types.

Thanks. Should I wait for @ldionne to approve?

Mar 16 2021, 9:25 AM · Unknown Object (Project)
tmatheson requested review of D98716: [NFC][CodeGen] Separate TargetRegisterInfo needsStackRealignment and canRealignStack.
Mar 16 2021, 9:09 AM · Restricted Project
tmatheson added inline comments to D97283: [libcxx][type_traits] is_unsigned is false for enum types.
Mar 16 2021, 2:08 AM · Unknown Object (Project)
tmatheson updated the diff for D97283: [libcxx][type_traits] is_unsigned is false for enum types.

Disable fast path for clang < 13

Mar 16 2021, 2:02 AM · Unknown Object (Project)

Mar 15 2021

tmatheson updated the diff for D97283: [libcxx][type_traits] is_unsigned is false for enum types.

Remove char and wchar_t tests

Mar 15 2021, 8:05 AM · Unknown Object (Project)
tmatheson added a comment to D97283: [libcxx][type_traits] is_unsigned is false for enum types.

Ping

Mar 15 2021, 3:51 AM · Unknown Object (Project)
tmatheson added a comment to D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct.

This seems quite an early point to bail out, so it will prevent some errors/warnings associated with initialization from being emitted. For example, this warning is currently emitted but would be suppressed by this patch:

Mar 15 2021, 2:55 AM · Restricted Project

Mar 9 2021

tmatheson accepted D98258: [ARM] Add comment explaining stack frame layout.

This is great, thanks

Mar 9 2021, 7:01 AM · Restricted Project
tmatheson committed rG7e5cea5b509f: [Clang][Sema] Warn when function argument is less aligned than parameter (authored by tmatheson).
[Clang][Sema] Warn when function argument is less aligned than parameter
Mar 9 2021, 2:39 AM
tmatheson closed D97187: [Clang][Sema] Warn when function argument is less aligned than parameter.
Mar 9 2021, 2:38 AM · Restricted Project

Mar 8 2021

tmatheson updated the diff for D97187: [Clang][Sema] Warn when function argument is less aligned than parameter.

...use SIZE_TYPE

Mar 8 2021, 5:53 AM · Restricted Project
tmatheson updated the diff for D97187: [Clang][Sema] Warn when function argument is less aligned than parameter.

int -> unsigned long long

Mar 8 2021, 5:45 AM · Restricted Project
tmatheson updated the diff for D97187: [Clang][Sema] Warn when function argument is less aligned than parameter.

Attempt to fix error on windows: change unsigned long -> int in operator new

Mar 8 2021, 5:40 AM · Restricted Project
tmatheson updated the diff for D97187: [Clang][Sema] Warn when function argument is less aligned than parameter.
  • Add blank line after retun
Mar 8 2021, 4:24 AM · Restricted Project
tmatheson added a comment to D97283: [libcxx][type_traits] is_unsigned is false for enum types.

was this causing problems for you in the wild, or did you just notice that there was an issue? If the latter, I think we should just take the tests from this patch and only enable them on ToT clang for the next six months.

Mar 8 2021, 4:16 AM · Unknown Object (Project)
tmatheson updated the diff for D97283: [libcxx][type_traits] is_unsigned is false for enum types.
  • Add #ifdef around the __is_unsigned condition based on clang version number. I'm not convinced the value of this outweighs the noise it creates. But with it, this patch can be landed before or after D98104.
Mar 8 2021, 4:11 AM · Unknown Object (Project)

Mar 5 2021

tmatheson added a comment to D97283: [libcxx][type_traits] is_unsigned is false for enum types.

make libc++ conditionally use just __is_unsigned or a combination of __is_unsigned && !__is_enum based on the version of Clang

Mar 5 2021, 7:36 AM · Unknown Object (Project)

Mar 2 2021

tmatheson added a comment to D97187: [Clang][Sema] Warn when function argument is less aligned than parameter.

Ping

Mar 2 2021, 4:13 AM · Restricted Project

Mar 1 2021

tmatheson added a comment to D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.

Ping. @arsenm, any comments on new approach using bundles, and the regalloc changes?

Mar 1 2021, 4:33 AM · Restricted Project
tmatheson added a comment to D97283: [libcxx][type_traits] is_unsigned is false for enum types.

Thanks both, I'm still new to this process so didn't realise there were specific approvers.

Mar 1 2021, 4:30 AM · Unknown Object (Project)

Feb 26 2021

tmatheson added a comment to D97283: [libcxx][type_traits] is_unsigned is false for enum types.

@Quuxplusone @Mordante are there any outstanding issues to be addressed, or any further comments?

Feb 26 2021, 3:04 AM · Unknown Object (Project)

Feb 23 2021

tmatheson added a comment to D97283: [libcxx][type_traits] is_unsigned is false for enum types.

Why doesn't is_signed be updated in the same way? I see the builds on buildkite passing, but the difference between is_unsigned and is_signed look very odd to me.

Feb 23 2021, 9:21 AM · Unknown Object (Project)
tmatheson updated the diff for D97283: [libcxx][type_traits] is_unsigned is false for enum types.

Update the comments on #else and #endif

Feb 23 2021, 9:18 AM · Unknown Object (Project)
tmatheson updated the diff for D97283: [libcxx][type_traits] is_unsigned is false for enum types.

Add tests for enums with explicitly signed and unsigned underlying types

Feb 23 2021, 9:15 AM · Unknown Object (Project)
tmatheson added inline comments to D97283: [libcxx][type_traits] is_unsigned is false for enum types.
Feb 23 2021, 8:15 AM · Unknown Object (Project)
tmatheson added inline comments to D97283: [libcxx][type_traits] is_unsigned is false for enum types.
Feb 23 2021, 8:07 AM · Unknown Object (Project)
tmatheson updated the diff for D97283: [libcxx][type_traits] is_unsigned is false for enum types.

Add corresponding tests to is_signed.pass.cpp

Feb 23 2021, 8:05 AM · Unknown Object (Project)
tmatheson added reviewers for D97283: [libcxx][type_traits] is_unsigned is false for enum types: miyuki, mclow.lists, arthur.j.odwyer, ldionne, curdeius.
Feb 23 2021, 7:09 AM · Unknown Object (Project)
tmatheson requested review of D97283: [libcxx][type_traits] is_unsigned is false for enum types.
Feb 23 2021, 6:31 AM · Unknown Object (Project)

Feb 22 2021

tmatheson added a comment to D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.

Ping

Feb 22 2021, 5:58 AM · Restricted Project
tmatheson added reviewers for D97187: [Clang][Sema] Warn when function argument is less aligned than parameter: john.brawn, eli.friedman, dnsampaio, amilendra_arm, lebedev.ri, ahatanak.
Feb 22 2021, 2:50 AM · Restricted Project
tmatheson requested review of D97187: [Clang][Sema] Warn when function argument is less aligned than parameter.
Feb 22 2021, 2:31 AM · Restricted Project

Feb 17 2021

tmatheson abandoned D96765: [ARM][AtomicExpand] Bundle exclusive loads and stores created by AtomicExpandPass.
Feb 17 2021, 10:28 AM · Restricted Project

Feb 16 2021

tmatheson added inline comments to D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.
Feb 16 2021, 2:43 AM · Restricted Project
tmatheson updated the diff for D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.

This is quite a substantial change in approach, please take a look.

Feb 16 2021, 2:41 AM · Restricted Project
tmatheson requested review of D96765: [ARM][AtomicExpand] Bundle exclusive loads and stores created by AtomicExpandPass.
Feb 16 2021, 2:37 AM · Restricted Project

Jan 29 2021

tmatheson closed D95361: [ARM][RegisterScavenging] Don't consider LR liveout if it is not reloaded.

This committed as b9ed8ebe0e2ffa803b0bda60f9bbc9bb26f95000

Jan 29 2021, 2:28 AM · Restricted Project

Jan 28 2021

tmatheson committed rG9a2bbfae6c82: [NFC] Move scavenge-lr.mir From AArch64 to Thumb2 test directory. (authored by tmatheson).
[NFC] Move scavenge-lr.mir From AArch64 to Thumb2 test directory.
Jan 28 2021, 2:22 AM
tmatheson committed rGb9ed8ebe0e2f: [ARM][RegisterScavenging] Don't consider LR liveout if it is not reloaded (authored by tmatheson).
[ARM][RegisterScavenging] Don't consider LR liveout if it is not reloaded
Jan 28 2021, 1:23 AM
tmatheson committed rG01b9e613c28b: [Clang][Codegen] Truncate initializers of union bitfield members (authored by tmatheson).
[Clang][Codegen] Truncate initializers of union bitfield members
Jan 28 2021, 1:21 AM
tmatheson closed D93101: [Clang][Codegen] Truncate initializers of union bitfield members.
Jan 28 2021, 1:21 AM · Restricted Project

Jan 27 2021

tmatheson added inline comments to D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.
Jan 27 2021, 12:30 AM · Restricted Project
tmatheson updated the diff for D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.

Use Optional rather than returning 0 (==TargetOpcode::PHI).
Rename isExclusiveLoad to IsExclusiveLoad.

Jan 27 2021, 12:20 AM · Restricted Project

Jan 25 2021

tmatheson added a comment to D93101: [Clang][Codegen] Truncate initializers of union bitfield members.

Ping

Jan 25 2021, 7:17 AM · Restricted Project
tmatheson added reviewers for D95361: [ARM][RegisterScavenging] Don't consider LR liveout if it is not reloaded: kristof.beyls, john.brawn, MatzeB, ostannard, voltur01.
Jan 25 2021, 7:11 AM · Restricted Project
tmatheson requested review of D95361: [ARM][RegisterScavenging] Don't consider LR liveout if it is not reloaded.
Jan 25 2021, 7:07 AM · Restricted Project

Jan 18 2021

tmatheson added reviewers for D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo: t.p.northover, arsenm, voltur01, sdesmalen, mtrofin, vhscampos, greened, kazu.
Jan 18 2021, 11:33 PM · Restricted Project
tmatheson abandoned D94948: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.

Duplicate

Jan 18 2021, 11:27 PM · Restricted Project
tmatheson abandoned D94902: [ARM][AArch64] Add findSpillBefore to TargetRegisterInfo.

Duplicate

Jan 18 2021, 11:27 PM · Restricted Project
tmatheson requested review of D94949: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.
Jan 18 2021, 11:25 PM · Restricted Project
tmatheson requested review of D94948: [AArch64][RegAllocFast] Add findSpillBefore to TargetRegisterInfo.
Jan 18 2021, 11:23 PM · Restricted Project
tmatheson added inline comments to D93101: [Clang][Codegen] Truncate initializers of union bitfield members.
Jan 18 2021, 6:03 AM · Restricted Project
tmatheson updated the diff for D93101: [Clang][Codegen] Truncate initializers of union bitfield members.

Make unions in test cases const, and clarify logic

Jan 18 2021, 5:58 AM · Restricted Project
tmatheson retitled D94902: [ARM][AArch64] Add findSpillBefore to TargetRegisterInfo from SDCOMP-56828 Add findSpillBefore to TargetRegisterInfo to [ARM][AArch64] Add findSpillBefore to TargetRegisterInfo.
Jan 18 2021, 2:59 AM · Restricted Project
tmatheson requested review of D94902: [ARM][AArch64] Add findSpillBefore to TargetRegisterInfo.
Jan 18 2021, 2:58 AM · Restricted Project
tmatheson updated the diff for D93101: [Clang][Codegen] Truncate initializers of union bitfield members.

Add test RUN line that checks C++11 behaviour

Jan 18 2021, 2:45 AM · Restricted Project
tmatheson updated the diff for D93101: [Clang][Codegen] Truncate initializers of union bitfield members.

Added more test cases and explanatory comments

Jan 18 2021, 2:36 AM · Restricted Project

Jan 13 2021

tmatheson accepted D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension.
Jan 13 2021, 3:21 AM · Restricted Project, Restricted Project

Jan 12 2021

tmatheson added reviewers for D93101: [Clang][Codegen] Truncate initializers of union bitfield members: ahatanak, david-arm, RKSimon, joechrisellis, MaskRay, erichkeane.
Jan 12 2021, 6:53 AM · Restricted Project

Jan 6 2021

tmatheson committed rG643e3c90761f: [AArch64] Add BRB IALL and BRB INJ instructions (authored by tmatheson).
[AArch64] Add BRB IALL and BRB INJ instructions
Jan 6 2021, 4:14 AM
tmatheson closed D93899: [AArch64] Add BRB IALL and BRB INJ instructions.
Jan 6 2021, 4:14 AM · Restricted Project

Jan 5 2021

tmatheson added inline comments to D93948: [MC] Merge section flags for user defined sections.
Jan 5 2021, 10:52 AM · Restricted Project
tmatheson updated the diff for D93948: [MC] Merge section flags for user defined sections.
  • Added check for incompatible SHF_TLS flags
  • Moved test to llvm/test/CodeGen/Generic
  • Removed arm vendor from triple in test
  • Changed isDefaultELFSection to check section by name rather than pointer value
Jan 5 2021, 10:06 AM · Restricted Project