Page MenuHomePhabricator

tinloaf (Lukas Barth)
User

Projects

User does not belong to any projects.

User Details

User Since
Thu, Dec 31, 7:28 AM (2 w, 4 d)

Recent Activity

Sat, Jan 16

tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fixed documentation for the AlignConsecutive* options. I have used the suggested approach: Remove all documentation from AlignConsecutiveStyle and instead put the documentation of the possible values and what they do in the AlignConsecutive* options' docs.

Sat, Jan 16, 4:33 AM · Restricted Project, Restricted Project

Tue, Jan 12

tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fixed formatting issue.

Tue, Jan 12, 5:27 AM · Restricted Project, Restricted Project

Sun, Jan 10

tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Apart from my inline comment and the pre merge check this is superb. (I will not accept it, until we have reached a conclusion for the documentation.)

Sun, Jan 10, 3:05 PM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fix merge conflict in the release notes.

Sun, Jan 10, 7:20 AM · Restricted Project, Restricted Project
tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

This is now an all-in-one revision, including bit fields, assignments, declarations and macros. I did not reproduce the full "across empty lines, across comments, across empty lines *and* comments" test suite for all four of them, since they all use the same logic (and code, mostly). AlignConsecutiveAssignments is tested extensively, AlignConsecutiveBitFields and AlignConsecutiveDeclarations only have tests for AlignAcrossEmptyLinesAndComments (since they delegate to the same AlignTokens method), and AlignConsecutiveMacros has its own set of tests, since it uses a different implementation (of the same logic, basically).

Sun, Jan 10, 7:16 AM · Restricted Project, Restricted Project
tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Ideally we should add a comment to the release notes, (which you could do via a separate NFC commit if you wanted)

Thank, I'll do that. But before that, I will create a revision that adds the same feature for the other three alignment types.

I think it should happen in this revision so that it is atomically.

Sun, Jan 10, 7:10 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
  • Unify the type of the options for AlignConsecutive{BitFields, Declarations, Assignments, Macros}
  • Implement across-alignment for bit fields, declarations, assignments and macros
  • Add tests for across-alignment for bit fields, declarations, assignments and macros
  • Add changelog entry
Sun, Jan 10, 7:10 AM · Restricted Project, Restricted Project

Tue, Jan 5

tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Tue, Jan 5, 3:32 AM · Restricted Project, Restricted Project

Mon, Jan 4

tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Mon, Jan 4, 3:22 PM · Restricted Project, Restricted Project
tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Ideally we should add a comment to the release notes, (which you could do via a separate NFC commit if you wanted)

Mon, Jan 4, 9:23 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fix bogus default case reported by clang-tidy.

Mon, Jan 4, 7:22 AM · Restricted Project, Restricted Project
tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Mon, Jan 4, 5:01 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Address reviewer comments, noteworthy changes:

Mon, Jan 4, 4:58 AM · Restricted Project, Restricted Project

Sun, Jan 3

tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Sun, Jan 3, 12:46 PM · Restricted Project, Restricted Project
tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Sun, Jan 3, 10:21 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Address MyDeveloperDay's review comments.

Sun, Jan 3, 10:19 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fix formatting issue resulting from ancient clang-format.

Sun, Jan 3, 7:43 AM · Restricted Project, Restricted Project
tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Two remarks, first: I made the change only for AlignConsecutiveAssignments, but I think it should be consistent for AlignConsecutiveMacros, AlignConsecutiveBitFields and AlignConsecutiveDeclarations, as well. If this change is accepted, I will make corresponding changes to the other three.

Sun, Jan 3, 4:35 AM · Restricted Project, Restricted Project
tinloaf requested review of D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Sun, Jan 3, 4:33 AM · Restricted Project, Restricted Project