Page MenuHomePhabricator

timwoj (Tim Wojtulewicz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2019, 4:26 PM (109 w, 4 d)

Recent Activity

Thu, Mar 4

timwoj added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Rebase onto master again

master or main? Please rebase on main. That is where the pushes land. (And as far as I can see master hasn't been updated in quite some time.

Thu, Mar 4, 9:32 PM · Restricted Project, Restricted Project
timwoj updated the diff for D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Rebase onto master again

Thu, Mar 4, 2:17 PM · Restricted Project, Restricted Project

Mon, Mar 1

timwoj added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Do you need someone to push this?

Yes I do. I don't have committer access.

Please state the name and mail for the commit.

Mon, Mar 1, 4:54 PM · Restricted Project, Restricted Project

Sun, Feb 28

timwoj added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Do you need someone to push this?

Sun, Feb 28, 6:04 PM · Restricted Project, Restricted Project

Wed, Feb 10

timwoj updated the diff for D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Rebased on main

Wed, Feb 10, 7:54 AM · Restricted Project, Restricted Project

Tue, Feb 9

timwoj updated the diff for D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Added release note entry

Tue, Feb 9, 12:57 PM · Restricted Project, Restricted Project

Jan 29 2021

timwoj added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

https://bugs.llvm.org/show_bug.cgi?id=48668 already exists as a bug report linked to this review. I'm not sure "the Zeek project would like to start using this" is a good enough reason to block an LLVM release though. I'm fairly certain there aren't a whole lot of people in the world using Whitesmiths. That said, there's already at least one clang-format bug in the release-blocker list.

Jan 29 2021, 11:32 AM · Restricted Project, Restricted Project

Jan 28 2021

timwoj added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

No problem, sorry it took a bit of back-and-forth there. Is there any way this can sneak into 12.0?

Jan 28 2021, 10:44 AM · Restricted Project, Restricted Project

Jan 27 2021

timwoj updated the diff for D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
  • Make LineLevel an enum class
  • Combine multiple duplicate checks into a named variable
  • Minor formatting fixes
Jan 27 2021, 4:38 PM · Restricted Project, Restricted Project
timwoj added inline comments to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 27 2021, 3:36 PM · Restricted Project, Restricted Project

Jan 25 2021

timwoj updated the diff for D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Restored lost single-nesting namespace test

Jan 25 2021, 5:04 PM · Restricted Project, Restricted Project

Jan 20 2021

timwoj updated the diff for D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Add tests for Whitesmiths with all of the NamespaceIndentation options

Jan 20 2021, 10:11 AM · Restricted Project, Restricted Project

Jan 19 2021

timwoj updated the diff for D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Fixing diff to look at the right commit

Jan 19 2021, 8:58 PM · Restricted Project, Restricted Project
timwoj updated the diff for D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Updates from review:

  • Fixed handling of IndentCaseLabels
  • Fixed indentation of namespace braces
  • Replaced bool argument to addUnwrappedLine with an enum
Jan 19 2021, 8:55 PM · Restricted Project, Restricted Project

Jan 14 2021

timwoj added inline comments to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 14 2021, 1:24 PM · Restricted Project, Restricted Project

Jan 13 2021

timwoj added inline comments to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 13 2021, 4:31 PM · Restricted Project, Restricted Project
timwoj added a reviewer for D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser: MyDeveloperDay.
Jan 13 2021, 6:13 AM · Restricted Project, Restricted Project
timwoj added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

This fixes https://bugs.llvm.org/show_bug.cgi?id=48569, amongst other things.

Jan 13 2021, 6:12 AM · Restricted Project, Restricted Project

Jan 12 2021

timwoj requested review of D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 12 2021, 8:09 AM · Restricted Project, Restricted Project

Jan 19 2020

timwoj added a comment to D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements.

I know that 10.0 was branch recently. Any chance this can make it over?

Jan 19 2020, 10:03 AM · Restricted Project, Restricted Project

Jan 15 2020

timwoj created D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements.
Jan 15 2020, 10:59 AM · Restricted Project, Restricted Project

Nov 19 2019

timwoj added a comment to D68346: [clang-format] Add new option to add spaces around conditions.

Thanks for the consideration on committer access, but I'm going to have to pass for the time being.

Nov 19 2019, 6:23 PM · Restricted Project, Restricted Project

Oct 16 2019

timwoj updated the diff for D68346: [clang-format] Add new option to add spaces around conditions.

Fix ordering

Oct 16 2019, 8:27 PM · Restricted Project, Restricted Project

Oct 14 2019

timwoj added a comment to D68346: [clang-format] Add new option to add spaces around conditions.

Changed option name to SpacesInConditionalStatement, added isKeywordWithCondition method, added some extra tests

Oct 14 2019, 12:18 PM · Restricted Project, Restricted Project
timwoj updated the diff for D68346: [clang-format] Add new option to add spaces around conditions.

Changed option name to SpacesInConditionalStatement, added isKeywordWithCondition method, added some extra tests

Oct 14 2019, 12:18 PM · Restricted Project, Restricted Project

Oct 2 2019

timwoj created D68346: [clang-format] Add new option to add spaces around conditions.
Oct 2 2019, 10:42 AM · Restricted Project, Restricted Project

Sep 21 2019

timwoj added a comment to D67627: Clang-format: Add Whitesmiths indentation style.

I don't have push access for master. Can someone merge this?

Sep 21 2019, 11:14 AM · Restricted Project, Restricted Project

Sep 17 2019

timwoj updated the diff for D67627: Clang-format: Add Whitesmiths indentation style.

Marked failing tests as FIXME

Sep 17 2019, 9:43 PM · Restricted Project, Restricted Project

Sep 16 2019

timwoj created D67627: Clang-format: Add Whitesmiths indentation style.
Sep 16 2019, 10:49 AM · Restricted Project, Restricted Project

Jun 11 2019

timwoj added a comment to D6833: Clang-format: Braces Indent Style Whitesmith.

I updated this patch to remove all of the code from ContinuationIndenter and to use the newer BraceWrapping style option instead of setting each one individually in UnwrappedLineParser.

Jun 11 2019, 7:16 PM