Page MenuHomePhabricator

thejh (Jann Horn)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2020, 12:11 PM (63 w, 5 d)

Recent Activity

Mar 4 2021

thejh added a comment to D97952: [test] Fix new CodeGenPrepare test for non-X86 systems.

Is there a way to force a specific builder (like https://lab.llvm.org/buildbot/#/builders/107) to test a change like this? Or does the change have to be committed before those builders can run on it?

Mar 4 2021, 7:54 AM · Restricted Project
thejh requested review of D97952: [test] Fix new CodeGenPrepare test for non-X86 systems.
Mar 4 2021, 7:50 AM · Restricted Project

Mar 3 2021

thejh added inline comments to D97848: [CodeGenPrepare] Eliminate llvm.expect before removing empty blocks.
Mar 3 2021, 7:37 AM · Restricted Project
thejh updated the diff for D97848: [CodeGenPrepare] Eliminate llvm.expect before removing empty blocks.

added another test

Mar 3 2021, 7:32 AM · Restricted Project
thejh added inline comments to D97848: [CodeGenPrepare] Eliminate llvm.expect before removing empty blocks.
Mar 3 2021, 5:56 AM · Restricted Project
thejh added a comment to D97848: [CodeGenPrepare] Eliminate llvm.expect before removing empty blocks.

bug report for context: https://bugs.llvm.org/show_bug.cgi?id=49403

Mar 3 2021, 3:15 AM · Restricted Project
thejh requested review of D97848: [CodeGenPrepare] Eliminate llvm.expect before removing empty blocks.
Mar 3 2021, 3:11 AM · Restricted Project

Dec 7 2020

thejh added a comment to D92140: Fix noderef for array member of deref expr.

Thanks! :)

Dec 7 2020, 2:51 PM · Restricted Project

Dec 1 2020

thejh added a comment to D92140: Fix noderef for array member of deref expr.

@leonardchan I don't have commit access; can you land this change and D92141 for me?

Dec 1 2020, 7:15 AM · Restricted Project

Nov 25 2020

thejh added inline comments to D92141: Fix noderef for AddrOf on MemberExpr.
Nov 25 2020, 4:45 PM · Restricted Project
thejh updated the diff for D92141: Fix noderef for AddrOf on MemberExpr.

Removed duplicate tests as suggested by leonardchan

Nov 25 2020, 4:43 PM · Restricted Project
thejh added a comment to D92141: Fix noderef for AddrOf on MemberExpr.

(I marked this as depending on D92140 because if you apply this patch to the current HEAD directly, the tests will break.)

Nov 25 2020, 3:59 PM · Restricted Project
thejh requested review of D92141: Fix noderef for AddrOf on MemberExpr.
Nov 25 2020, 3:57 PM · Restricted Project
thejh requested review of D92140: Fix noderef for array member of deref expr.
Nov 25 2020, 3:55 PM · Restricted Project

Nov 23 2020

thejh added a comment to D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.

@aaron.ballman Can you land it for me? I don't have commit access.

Happy to do so -- are you okay with "Jann Horn <jannh@google.com>" for author attribution?

Nov 23 2020, 5:08 AM · Restricted Project
thejh added a comment to D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.

@aaron.ballman Can you land it for me? I don't have commit access.

Nov 23 2020, 5:06 AM · Restricted Project

Nov 20 2020

thejh added inline comments to D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.
Nov 20 2020, 3:24 PM · Restricted Project
thejh updated the diff for D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.

As requested by @aaron.ballman, added tests for edgecases where
sizeof()/typeid() can cause memory access.

Nov 20 2020, 3:23 PM · Restricted Project

Nov 19 2020

thejh updated the diff for D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.

re-uploading to trigger a new build, since the build error looks unrelated.
maybe current trunk is flaky?

Nov 19 2020, 4:44 PM · Restricted Project
thejh requested review of D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context.
Nov 19 2020, 3:53 PM · Restricted Project

Oct 14 2020

thejh requested review of D89442: [Support] Use SA_ONSTACK in CrashRecoveryContext.
Oct 14 2020, 7:32 PM · Restricted Project

Apr 30 2020

thejh updated the diff for D77619: [AddressSanitizer] Instrument byval call arguments.
Apr 30 2020, 2:07 AM · Restricted Project
thejh updated the diff for D77618: [AddressSanitizer] Refactor: Permit >1 interesting operands per instruction.
Apr 30 2020, 2:06 AM · Restricted Project
thejh updated the diff for D77617: [AddressSanitizer] Split out memory intrinsic handling.
Apr 30 2020, 2:06 AM · Restricted Project
thejh updated the diff for D77616: [AddressSanitizer] Refactor ClDebug{Min,Max} handling.
Apr 30 2020, 2:06 AM · Restricted Project

Apr 27 2020

thejh updated the diff for D77619: [AddressSanitizer] Instrument byval call arguments.

resend patch to trigger new build

Apr 27 2020, 12:29 AM · Restricted Project
thejh updated the diff for D77618: [AddressSanitizer] Refactor: Permit >1 interesting operands per instruction.

resend patch to trigger new build

Apr 27 2020, 12:29 AM · Restricted Project
thejh updated the diff for D77617: [AddressSanitizer] Split out memory intrinsic handling.

resend patch to trigger new build

Apr 27 2020, 12:29 AM · Restricted Project

Apr 24 2020

thejh updated the diff for D77616: [AddressSanitizer] Refactor ClDebug{Min,Max} handling.

let's see whether the build system is more happy if I just resend this...

Apr 24 2020, 4:16 PM · Restricted Project
thejh added a comment to D77616: [AddressSanitizer] Refactor ClDebug{Min,Max} handling.

I don't understand those latest build failures at all. I've run the regression tests, with mlir enabled. I see no failures, even when building off the exact commit in the build log. Manually running mlir/test/Dialect/Vector/vector-transforms.mlir doesn't show any errors either.

Apr 24 2020, 4:16 PM · Restricted Project
thejh updated the diff for D77619: [AddressSanitizer] Instrument byval call arguments.

rebase to make harbormaster happy

Apr 24 2020, 10:48 AM · Restricted Project
thejh updated the diff for D77618: [AddressSanitizer] Refactor: Permit >1 interesting operands per instruction.

rebase to make harbormaster happy

Apr 24 2020, 10:48 AM · Restricted Project
thejh updated the diff for D77617: [AddressSanitizer] Split out memory intrinsic handling.

rebase to make harbormaster happy

Apr 24 2020, 10:48 AM · Restricted Project
thejh updated the diff for D77616: [AddressSanitizer] Refactor ClDebug{Min,Max} handling.

rebase to make harbormaster happy

Apr 24 2020, 10:48 AM · Restricted Project
thejh added a comment to D77619: [AddressSanitizer] Instrument byval call arguments.

Ugh... so the build failed on this patch because actually a preceding patch no longer applies cleanly and LLVM's build infrastructure doesn't have base-commit support and therefore can't do an automatic 3-way merge?

Apr 24 2020, 10:48 AM · Restricted Project
thejh updated the diff for D77619: [AddressSanitizer] Instrument byval call arguments.

I missed that Kostya commented a while back that it'd be better to have a flag to gate the new functionality... adding that now.

Apr 24 2020, 10:15 AM · Restricted Project

Apr 14 2020

thejh added a comment to D77616: [AddressSanitizer] Refactor ClDebug{Min,Max} handling.

@glider Alright, I've fixed the clang-format stuff (and fixed a mistake where I put a variable declaration in the wrong patch, and another clang-tidy warning about coding conventions on variable naming). The build status is "passed" on all four patches now.

Apr 14 2020, 3:45 PM · Restricted Project
thejh updated the diff for D77619: [AddressSanitizer] Instrument byval call arguments.

rebase onto changed preceding patches

Apr 14 2020, 12:24 PM · Restricted Project
thejh updated the diff for D77618: [AddressSanitizer] Refactor: Permit >1 interesting operands per instruction.

move one declaration from patch 3 to patch 2

Apr 14 2020, 12:24 PM · Restricted Project
thejh updated the diff for D77617: [AddressSanitizer] Split out memory intrinsic handling.

move one declaration from patch 3 to patch 2

Apr 14 2020, 12:24 PM · Restricted Project
thejh updated the diff for D77616: [AddressSanitizer] Refactor ClDebug{Min,Max} handling.

fix clang-tidy complaint

Apr 14 2020, 12:24 PM · Restricted Project
thejh updated the diff for D77619: [AddressSanitizer] Instrument byval call arguments.

fix clang-format warnings

Apr 14 2020, 10:10 AM · Restricted Project
thejh updated the diff for D77616: [AddressSanitizer] Refactor ClDebug{Min,Max} handling.

fix clang-format warnings

Apr 14 2020, 10:10 AM · Restricted Project
thejh updated the diff for D77618: [AddressSanitizer] Refactor: Permit >1 interesting operands per instruction.

fix clang-format warnings

Apr 14 2020, 10:10 AM · Restricted Project
thejh updated the diff for D77617: [AddressSanitizer] Split out memory intrinsic handling.

fix clang-format warnings

Apr 14 2020, 10:10 AM · Restricted Project

Apr 6 2020

thejh updated the summary of D77619: [AddressSanitizer] Instrument byval call arguments.
Apr 6 2020, 6:34 PM · Restricted Project
thejh updated the summary of D77618: [AddressSanitizer] Refactor: Permit >1 interesting operands per instruction.
Apr 6 2020, 6:34 PM · Restricted Project
thejh updated the summary of D77617: [AddressSanitizer] Split out memory intrinsic handling.
Apr 6 2020, 6:34 PM · Restricted Project
thejh updated the summary of D77616: [AddressSanitizer] Refactor ClDebug{Min,Max} handling.
Apr 6 2020, 6:34 PM · Restricted Project
thejh created D77619: [AddressSanitizer] Instrument byval call arguments.
Apr 6 2020, 6:33 PM · Restricted Project
thejh created D77618: [AddressSanitizer] Refactor: Permit >1 interesting operands per instruction.
Apr 6 2020, 6:33 PM · Restricted Project
thejh updated the summary of D77618: [AddressSanitizer] Refactor: Permit >1 interesting operands per instruction.
Apr 6 2020, 6:33 PM · Restricted Project
thejh created D77617: [AddressSanitizer] Split out memory intrinsic handling.
Apr 6 2020, 6:33 PM · Restricted Project
thejh created D77616: [AddressSanitizer] Refactor ClDebug{Min,Max} handling.
Apr 6 2020, 6:01 PM · Restricted Project
thejh created D77613: [AddressSanitizer] Instrument byval call arguments.
Apr 6 2020, 6:01 PM · Restricted Project
thejh abandoned D77613: [AddressSanitizer] Instrument byval call arguments.
Apr 6 2020, 6:01 PM · Restricted Project

Feb 3 2020

thejh added a comment to D73126: [X86] Generate unaligned access for fixed slots in unaligned stack.

ping

Feb 3 2020, 8:19 AM · Restricted Project

Jan 25 2020

thejh added inline comments to D73126: [X86] Generate unaligned access for fixed slots in unaligned stack.
Jan 25 2020, 8:37 AM · Restricted Project
thejh added inline comments to D73126: [X86] Generate unaligned access for fixed slots in unaligned stack.
Jan 25 2020, 8:29 AM · Restricted Project

Jan 22 2020

thejh added a comment to D73126: [X86] Generate unaligned access for fixed slots in unaligned stack.

Ah, and I don't have commit access. (The docs say I'm supposed to point that out.)

Jan 22 2020, 6:24 AM · Restricted Project

Jan 21 2020

thejh created D73126: [X86] Generate unaligned access for fixed slots in unaligned stack.
Jan 21 2020, 10:29 AM · Restricted Project