Page MenuHomePhabricator

tellenbach (David Tellenbach)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 24 2019, 10:52 AM (91 w, 2 d)

Recent Activity

Aug 28 2020

tellenbach added a comment to D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

Does this conflict with D80791?

It does, we're using different module attributes.

Aug 28 2020, 12:16 PM · Restricted Project, Restricted Project

Aug 21 2020

tellenbach added a comment to D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

Does this conflict with D80791? Other than that it lgtm.

Aug 21 2020, 2:21 PM · Restricted Project, Restricted Project

Aug 11 2020

tellenbach added inline comments to D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.
Aug 11 2020, 6:25 AM · Restricted Project, Restricted Project
tellenbach added a comment to D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

Hi @chill, thanks for this patch, looks like the correct way to handle this.

Aug 11 2020, 6:19 AM · Restricted Project, Restricted Project

Jul 3 2020

tellenbach added a comment to D68076: [AArch64] Enable unwind tables by default for Gnu targets.

do we have a plan to follow up on this patch?

Jul 3 2020, 3:14 PM · Restricted Project

Apr 9 2020

tellenbach accepted D77601: Make SmallVector assert if it cannot grow..
Apr 9 2020, 3:45 AM · Restricted Project
tellenbach added a comment to D77601: Make SmallVector assert if it cannot grow..

LGTM, thanks.

Apr 9 2020, 3:45 AM · Restricted Project

Apr 7 2020

tellenbach added inline comments to D77601: Make SmallVector assert if it cannot grow..
Apr 7 2020, 9:44 AM · Restricted Project

Apr 6 2020

tellenbach added inline comments to D77601: Make SmallVector assert if it cannot grow..
Apr 6 2020, 5:29 PM · Restricted Project
tellenbach added a reviewer for D77601: Make SmallVector assert if it cannot grow.: tellenbach.
Apr 6 2020, 4:55 PM · Restricted Project

Mar 12 2020

tellenbach added a comment to D71027: Support repeated machine outlining.

LGTM, but let's wait a bit for other comments.

Mar 12 2020, 4:50 PM · Restricted Project

Mar 11 2020

tellenbach added inline comments to D71027: Support repeated machine outlining.
Mar 11 2020, 5:03 PM · Restricted Project
tellenbach added inline comments to D71027: Support repeated machine outlining.
Mar 11 2020, 5:03 PM · Restricted Project

Feb 26 2020

tellenbach added a reviewer for D75173: [Transform][MemCpyOpt] Add missing DebugLoc to %tmpbitcast: tellenbach.
Feb 26 2020, 10:25 AM · Restricted Project
tellenbach added a comment to D75173: [Transform][MemCpyOpt] Add missing DebugLoc to %tmpbitcast.

Hi, thanks for this. The test case look very verbose and can probably be reduced. At least all unnecessary meta-information should be removed, e.g. does it really need all these function attributes?

Feb 26 2020, 10:25 AM · Restricted Project

Feb 10 2020

tellenbach added a comment to D71027: Support repeated machine outlining.

Is there any update for D69446? I am writing the test case for D71217. The changes D71027 have to be checked in first. Thanks.

Feb 10 2020, 2:42 PM · Restricted Project

Jan 6 2020

tellenbach added a comment to D70329: [AArch64] Add isAuthenticating predicate to MCInstDesc.

Hi! Does this cover pre v8.3 pointer authenticating instructions (AUTIASP/AUTIBSP) too?

Jan 6 2020, 10:25 AM · Restricted Project

Dec 16 2019

tellenbach committed rGdf0cc105fa7f: Reland [AArch64][MachineOutliner] Return address signing for outlined functions (authored by tellenbach).
Reland [AArch64][MachineOutliner] Return address signing for outlined functions
Dec 16 2019, 5:45 AM
tellenbach closed D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Dec 16 2019, 5:45 AM · Restricted Project

Dec 11 2019

tellenbach added a comment to D71350: [MachineScheduler] Reorder cfi to avoid PostRA scheduling differences.

+1 to all comments above.

Dec 11 2019, 3:06 PM · Restricted Project
tellenbach edited reviewers for D71350: [MachineScheduler] Reorder cfi to avoid PostRA scheduling differences, added: tellenbach; removed: dtell.
Dec 11 2019, 2:47 PM · Restricted Project
tellenbach requested review of D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Dec 11 2019, 9:36 AM · Restricted Project
tellenbach updated the diff for D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.

hasIllegalSPModification now only accepts matching sp modifying add and sub instructions of if they just increment/decrement sp.

Dec 11 2019, 9:33 AM · Restricted Project
tellenbach planned changes to D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Dec 11 2019, 8:55 AM · Restricted Project
tellenbach reopened D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.

Reopening this since it's still not correct.

Dec 11 2019, 8:52 AM · Restricted Project

Dec 9 2019

tellenbach added a comment to D71027: Support repeated machine outlining.

Sure. I have updated the patch. Please note that the repeating machine outliner may not work correctly without fixing the logic at line 1265.

Dec 9 2019, 1:21 PM · Restricted Project
tellenbach added a comment to D71217: Fix incorrect logic in maintaining the side-effect of compiler generated outliner functions.

As @lebedev.ri already said, is it possible to add a test for this? I know it is probably covered in your test for D71027 but an independent test would be great!

Dec 9 2019, 1:12 PM · Restricted Project
tellenbach added a comment to D69446: [llvm][MachineOutliner] Add support for repeating machine outliner N times. .

Reverse ping: Is this revision still active?

Dec 9 2019, 5:00 AM · Restricted Project
tellenbach added a comment to D71027: Support repeated machine outlining.

Okay, thanks for clarifying.

Dec 9 2019, 4:55 AM · Restricted Project

Dec 8 2019

tellenbach committed rG9fdb7ac503a9: [NFC][LivePhysRegs] Fix incorrect comment (authored by rollrat).
[NFC][LivePhysRegs] Fix incorrect comment
Dec 8 2019, 12:16 PM
tellenbach closed D71051: LivePhysRegs: Fix incorrect comment.
Dec 8 2019, 12:16 PM · Restricted Project

Dec 5 2019

tellenbach added a comment to D71027: Support repeated machine outlining.

D69446 seems to introduce something similar. Are these patches related or is this just coincidence?

Dec 5 2019, 6:26 PM · Restricted Project
tellenbach added a reviewer for D71027: Support repeated machine outlining: paquette.
Dec 5 2019, 6:26 PM · Restricted Project
tellenbach added a reviewer for D71027: Support repeated machine outlining: tellenbach.
Dec 5 2019, 6:16 PM · Restricted Project
tellenbach accepted D71051: LivePhysRegs: Fix incorrect comment.

Thanks for correcting this comment. For possible future patches make sure to provide more context on your diff, i.e., run git diff -U99999. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface.

Dec 5 2019, 6:16 PM · Restricted Project
tellenbach added a reviewer for D71051: LivePhysRegs: Fix incorrect comment: tellenbach.
Dec 5 2019, 6:16 PM · Restricted Project

Dec 4 2019

tellenbach added a comment to D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.

@saugustine Thanks, I was just about to fix it with this patch but running the asan tests locally took longer than expected.

Do I need new review for this?

I wouldn't think so. It's been reviewed twice now and will be a useful change once it sticks. So conisder me accepting it.

Dec 4 2019, 5:38 PM · Restricted Project
tellenbach committed rGcec2d5c17457: Reland [AArch64][MachineOutliner] Return address signing for outlined functions (authored by tellenbach).
Reland [AArch64][MachineOutliner] Return address signing for outlined functions
Dec 4 2019, 5:29 PM
tellenbach added inline comments to D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Dec 4 2019, 5:10 PM · Restricted Project
tellenbach updated the diff for D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Dec 4 2019, 5:10 PM · Restricted Project
tellenbach updated the diff for D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.

@saugustine Thanks, I was just about to fix it with this patch but running the asan tests locally took longer than expected.

Dec 4 2019, 5:00 PM · Restricted Project
tellenbach added inline comments to D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Dec 4 2019, 2:57 PM · Restricted Project
tellenbach added a comment to D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.

Thanks for the review!

Dec 4 2019, 10:59 AM · Restricted Project
tellenbach committed rG02760b750b2f: Reland [AArch64][MachineOutliner] Return address signing for outlined functions (authored by tellenbach).
Reland [AArch64][MachineOutliner] Return address signing for outlined functions
Dec 4 2019, 10:41 AM
tellenbach closed D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Dec 4 2019, 10:40 AM · Restricted Project

Dec 2 2019

tellenbach added a comment to D70482: [NFC] Change return type for 'shouldOptimizeForSize'.

this looks good beside some minor inline comments.

Dec 2 2019, 3:02 PM · Restricted Project
tellenbach added a reviewer for D70482: [NFC] Change return type for 'shouldOptimizeForSize': tellenbach.
Dec 2 2019, 3:02 PM · Restricted Project
tellenbach added inline comments to D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Dec 2 2019, 6:01 AM · Restricted Project

Nov 23 2019

tellenbach committed rGb8e6319f3ef7: [NFC] [AArch64] Fix wrong documentation for IsStoreRegOffsetOp (authored by tellenbach).
[NFC] [AArch64] Fix wrong documentation for IsStoreRegOffsetOp
Nov 23 2019, 10:21 AM
tellenbach added inline comments to D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Nov 23 2019, 10:12 AM · Restricted Project
tellenbach abandoned D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.

I've opened the following new revision that includes a fix for the bug in this patch and added @ostannard and @paquette again as reviewers: https://reviews.llvm.org/D70635

Nov 23 2019, 10:12 AM · Restricted Project
tellenbach updated the summary of D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Nov 23 2019, 10:03 AM · Restricted Project
tellenbach updated the diff for D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.

Add newline at eof

Nov 23 2019, 10:03 AM · Restricted Project
tellenbach created D70635: Reland [AArch64][MachineOutliner] Return address signing for outlined functions.
Nov 23 2019, 9:53 AM · Restricted Project

Nov 21 2019

tellenbach committed rG75434366cec1: [AArch64] [FrameLowering] Allow conditional insertion of CFI instruction (authored by tellenbach).
[AArch64] [FrameLowering] Allow conditional insertion of CFI instruction
Nov 21 2019, 3:34 PM
tellenbach closed D70129: [AArch64] [FrameLowering] Allow conditional insertion of CFI instruction.
Nov 21 2019, 3:34 PM · Restricted Project

Nov 20 2019

tellenbach updated the diff for D70129: [AArch64] [FrameLowering] Allow conditional insertion of CFI instruction.

Address review comments.

Nov 20 2019, 11:19 AM · Restricted Project
tellenbach added a comment to D70129: [AArch64] [FrameLowering] Allow conditional insertion of CFI instruction.

Ping.

Nov 20 2019, 6:11 AM · Restricted Project
tellenbach planned changes to D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
Nov 20 2019, 5:48 AM · Restricted Project
tellenbach reopened D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
Nov 20 2019, 5:48 AM · Restricted Project

Nov 12 2019

tellenbach added a comment to D70129: [AArch64] [FrameLowering] Allow conditional insertion of CFI instruction.

@ostannard The CFI instruction that can be omitted using this patch is the reason for D69097 (Return address signing for outlined functions) to be buggy, hence I've added you as a reviewer.

Nov 12 2019, 9:14 AM · Restricted Project
tellenbach created D70129: [AArch64] [FrameLowering] Allow conditional insertion of CFI instruction.
Nov 12 2019, 9:04 AM · Restricted Project
tellenbach added reviewers for D70129: [AArch64] [FrameLowering] Allow conditional insertion of CFI instruction: t.p.northover, ostannard.
Nov 12 2019, 9:04 AM · Restricted Project

Nov 1 2019

tellenbach added a comment to D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.

@ostannard wow, good catch! Thanks for reverting this.

Nov 1 2019, 3:02 PM · Restricted Project
tellenbach accepted D69185: [AArch64] Output the pseudo SPACE in asm and object files.

LGTM, thanks!

Nov 1 2019, 6:26 AM · Restricted Project
tellenbach added inline comments to D69446: [llvm][MachineOutliner] Add support for repeating machine outliner N times. .
Nov 1 2019, 5:05 AM · Restricted Project
tellenbach added a reviewer for D69446: [llvm][MachineOutliner] Add support for repeating machine outliner N times. : tellenbach.
Nov 1 2019, 3:59 AM · Restricted Project
tellenbach added a comment to D69446: [llvm][MachineOutliner] Add support for repeating machine outliner N times. .

I'd actually prefer an option outliner-runs that is defaulted to 1 rather than a rerun option. From a user perspective I'd be unclear what outliner-reruns=0 exactly means? Does that mean one run or zero?

Nov 1 2019, 3:59 AM · Restricted Project

Oct 31 2019

tellenbach committed rG55314d323738: [MachineOutliner][NFC] Fix FileCheck regex in two of test-cases (authored by tellenbach).
[MachineOutliner][NFC] Fix FileCheck regex in two of test-cases
Oct 31 2019, 7:23 AM

Oct 30 2019

tellenbach committed rGfbe7f5e9729a: [NFC][MachineOutliner] Fix typo in comment (authored by tellenbach).
[NFC][MachineOutliner] Fix typo in comment
Oct 30 2019, 9:30 AM
tellenbach committed rG70caa1fc30c3: [AArch64][MachineOutliner] Return address signing for outlined functions (authored by tellenbach).
[AArch64][MachineOutliner] Return address signing for outlined functions
Oct 30 2019, 8:25 AM
tellenbach closed D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
Oct 30 2019, 8:25 AM · Restricted Project
tellenbach committed rG67474c60d344: [compiler-rt] libhwasan interceptor ABI intercept longjmp/setjmp (authored by tellenbach).
[compiler-rt] libhwasan interceptor ABI intercept longjmp/setjmp
Oct 30 2019, 7:10 AM
tellenbach closed D69045: libhwasan interceptor ABI intercept longjmp/setjmp.
Oct 30 2019, 7:10 AM · Restricted Project, Restricted Project
tellenbach added a comment to D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.

Thanks for the great review!

Oct 30 2019, 3:45 AM · Restricted Project

Oct 29 2019

tellenbach updated the diff for D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
  • Disable outlining for functions that disagree on their v8.3A feature support
  • Add a test for the above bullet point
Oct 29 2019, 10:26 AM · Restricted Project
tellenbach added inline comments to D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
Oct 29 2019, 9:30 AM · Restricted Project
tellenbach added inline comments to D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
Oct 29 2019, 8:53 AM · Restricted Project
tellenbach added a reviewer for D69417: [ADT] add equality operator for SmallSet: tellenbach.
Oct 29 2019, 8:07 AM · Restricted Project
tellenbach updated the diff for D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
  • Improve support for v8.3a signing instructions
  • Add tests
  • Address review comments
  • Moved signing logic into separate function
Oct 29 2019, 8:02 AM · Restricted Project
tellenbach added inline comments to D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
Oct 29 2019, 6:43 AM · Restricted Project

Oct 28 2019

tellenbach committed rGe3a45a24d107: [ARM][Thumb2InstrInfo] Fix default `0` opcode when rewriting frame indices (authored by tellenbach).
[ARM][Thumb2InstrInfo] Fix default `0` opcode when rewriting frame indices
Oct 28 2019, 12:00 PM
tellenbach closed D69432: [ARM][Thumb2InstrInfo]: fix default '0' opcode when rewriting frame indeces.
Oct 28 2019, 12:00 PM · Restricted Project
tellenbach added a comment to D69482: [MachineOuliner][NFC] Refactoring code to make outline rerunning a cleaner diff..

Maybe I just don't see it but I don't get the reason for creating this new function doOutline. Doesn't it basically just call outline? Why can't you just add OutlinedFunctionNum to outline and then call outline in runOnModule?

Please be so kind to clarify this.

It’s possible to get greater size reduction through rerunning the outliner repeatedly. I and a couple other folks were looking into this and I noticed that much of the change could be refactored into an nfc change which is preferable.

Oct 28 2019, 10:46 AM · Restricted Project
tellenbach added a comment to D69482: [MachineOuliner][NFC] Refactoring code to make outline rerunning a cleaner diff..

Maybe I just don't see it but I don't get the reason for creating this new function doOutline. Doesn't it basically just call outline? Why can't you just add OutlinedFunctionNum to outline and then call outline in runOnModule?

Oct 28 2019, 10:37 AM · Restricted Project
tellenbach accepted D69432: [ARM][Thumb2InstrInfo]: fix default '0' opcode when rewriting frame indeces.

Thanks for addressing the comments, LGTM!

Oct 28 2019, 4:43 AM · Restricted Project
tellenbach accepted D69429: [ADT] Adds equality operator for SmallPtrSet.

Thanks for addressing the comments, LGTM.

Oct 28 2019, 3:15 AM · Restricted Project

Oct 25 2019

tellenbach added a reviewer for D69432: [ARM][Thumb2InstrInfo]: fix default '0' opcode when rewriting frame indeces: tellenbach.
Oct 25 2019, 9:48 AM · Restricted Project
tellenbach added inline comments to D69432: [ARM][Thumb2InstrInfo]: fix default '0' opcode when rewriting frame indeces.
Oct 25 2019, 8:06 AM · Restricted Project
tellenbach added inline comments to D69429: [ADT] Adds equality operator for SmallPtrSet.
Oct 25 2019, 7:19 AM · Restricted Project
tellenbach added a reviewer for D69429: [ADT] Adds equality operator for SmallPtrSet: tellenbach.
Oct 25 2019, 7:19 AM · Restricted Project
tellenbach updated the diff for D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.

Add test for outlined thunk

Oct 25 2019, 4:20 AM · Restricted Project
tellenbach added a reviewer for D69185: [AArch64] Output the pseudo SPACE in asm and object files: tellenbach.
Oct 25 2019, 2:20 AM · Restricted Project
tellenbach added inline comments to D69185: [AArch64] Output the pseudo SPACE in asm and object files.
Oct 25 2019, 2:19 AM · Restricted Project

Oct 24 2019

tellenbach updated the diff for D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.

Add .mir test for MachineOutlinerRegSave

Oct 24 2019, 10:09 AM · Restricted Project
tellenbach updated the diff for D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
  • Fix determination of signing scope equality
  • Add comments
Oct 24 2019, 8:49 AM · Restricted Project
tellenbach updated the diff for D69097: [AArch64][MachineOutliner] Return address signing for outlined functions.
  • Make test more generic
  • If a function has no "sign-return-address" attribute, its signing behaviour is equivalent to a function with the "sign-return-address"="none" attribute
Oct 24 2019, 8:36 AM · Restricted Project
tellenbach committed rG6d11abfe3507: [compiler-rt] Expose __hwasan_tag_mismatch_stub (authored by tellenbach).
[compiler-rt] Expose __hwasan_tag_mismatch_stub
Oct 24 2019, 3:31 AM
tellenbach committed rG93aec861f529: Revert "Expose __hwasan_tag_mismatch_stub" (authored by tellenbach).
Revert "Expose __hwasan_tag_mismatch_stub"
Oct 24 2019, 3:19 AM
tellenbach added a reverting change for rG612eadb7bc06: Expose __hwasan_tag_mismatch_stub: rG93aec861f529: Revert "Expose __hwasan_tag_mismatch_stub".
Oct 24 2019, 3:19 AM