Page MenuHomePhabricator

tcanens (Tim Song)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 4 2016, 2:18 PM (275 w, 3 d)

Recent Activity

Sun, Apr 11

tcanens added inline comments to D100255: [libcxx] adds `range` access CPOs.
Sun, Apr 11, 11:07 AM · Restricted Project

Wed, Apr 7

tcanens added inline comments to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Wed, Apr 7, 7:57 PM · Restricted Project
tcanens added inline comments to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Wed, Apr 7, 7:19 PM · Restricted Project
tcanens added inline comments to D99863: [libcxx] adds `iter_difference_t` and `iter_value_t`.
Wed, Apr 7, 7:02 PM · Restricted Project
tcanens added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Wed, Apr 7, 6:51 PM · Restricted Project
tcanens added inline comments to D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.
Wed, Apr 7, 6:34 PM · Restricted Project
tcanens added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t.
Wed, Apr 7, 6:24 PM · Restricted Project

Sun, Mar 21

tcanens added a comment to D99041: [libcxx] moves `std::invoke` into `__functional_base`.

The exact expression in an atomic constraint is not observable so you can certainly substitute something else if that is preferable for whatever reason.

Sun, Mar 21, 4:38 PM · Restricted Project

Mar 14 2021

tcanens added a comment to D98573: [libc++] Remove most of the special logic for "noexcept iterators" in basic_string.

For append, we can always use the optimized approach, because if an iterator operation throws, we just restore the null terminator and we're back where we started, no problem.

Mar 14 2021, 5:32 PM · Restricted Project

Mar 4 2021

tcanens added inline comments to D97394: [libc++] [C++2b] [P2162] Allow inheritance from std::variant..
Mar 4 2021, 12:53 PM · Restricted Project

Mar 3 2021

tcanens added inline comments to D97162: [libcxx] adds std::ranges::swap, std::swappable, and std::swappable_with.
Mar 3 2021, 7:17 PM · Restricted Project

Mar 2 2021

tcanens added inline comments to D97394: [libc++] [C++2b] [P2162] Allow inheritance from std::variant..
Mar 2 2021, 9:35 PM · Restricted Project

Dec 8 2020

tcanens added a comment to D91292: [libc++] [P0935] [C++20] Eradicating unnecessarily explicit default constructors from the standard library..

LWG doesn't do official DRs like ever,

I'm not sure I follow. Aren't all LWG issues considered DRs and "back applied" to earlier standards, hence what we do in the libraries wrt LWG issues?

Dec 8 2020, 10:13 AM · Restricted Project
tcanens added a comment to D91292: [libc++] [P0935] [C++20] Eradicating unnecessarily explicit default constructors from the standard library..

I removed the unnecessary check for > C++11 in make_implicit, but that doesn't change a lot as it's used anyway only in C++20.
Anyway, I've just seen that P0935 has been adopted as a DR applied retroactively to previous standards down to C++11. My only source tho is https://en.cppreference.com/w/cpp/numeric/random/uniform_real_distribution/uniform_real_distribution.
Should I apply it to pre-C++20 then?

It was adopted as a paper, and it does *not* appear to have been voted as a DR. I found on the Rapperswill (2018) wiki motion page:

Motion 25
Move to apply to the C++ working paper the proposed wording in P0935R0 (Eradicating unnecessarily explicit default constructors from the standard library).

It doesn't appear to be applied as a DR, however the author himself was the one to change cppreference (looking at the history). @tcanens Do you have more context?

Dec 8 2020, 9:15 AM · Restricted Project

Apr 1 2020

tcanens added a comment to D67900: [libc++] Use builtin type traits whenever possible.

@tcanens I didn't look closely enough at the error. It looks like it's because vector uses numeric limits. I'll revert the changes which will fix the problem so, don't worry about it :)

Apr 1 2020, 12:57 PM · Restricted Project

Jul 13 2018

tcanens added a comment to D38075: Fix PR34668 - P0704R1 implementation is too permissive.

Do you need someone to commit it?

Jul 13 2018, 9:09 AM · Restricted Project

Jun 28 2018

tcanens added inline comments to D48616: Implement LWG 2946, 3075 and 3076.
Jun 28 2018, 12:55 PM

Feb 26 2018

tcanens added a comment to D43773: Implement the container bits of P0805R1.

Hmm, for vector and deque, we define a temporary variable, check that sizes match and then use range-and-a-half equal:

Feb 26 2018, 1:10 PM

Nov 21 2017

tcanens added inline comments to D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.
Nov 21 2017, 12:46 AM · Restricted Project, Restricted Project

Nov 20 2017

tcanens added inline comments to D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.
Nov 20 2017, 7:48 PM · Restricted Project, Restricted Project
tcanens added inline comments to D40144: Implement `std::launder`.
Nov 20 2017, 1:22 PM
tcanens added inline comments to D40259: [libcxx] LWG2993: reference_wrapper<T> conversion from T&&.
Nov 20 2017, 12:11 PM · Restricted Project, Restricted Project

Nov 16 2017

tcanens added a comment to D40144: Implement `std::launder`.

At least for GCC, it should use __builtin_launder.

Nov 16 2017, 12:20 PM

Sep 25 2017

tcanens updated the diff for D38075: Fix PR34668 - P0704R1 implementation is too permissive.

Also tweaked preceding comment.

Sep 25 2017, 5:03 AM · Restricted Project

Sep 20 2017

tcanens added inline comments to D38075: Fix PR34668 - P0704R1 implementation is too permissive.
Sep 20 2017, 12:57 PM · Restricted Project
tcanens removed rL LLVM as the repository for D38075: Fix PR34668 - P0704R1 implementation is too permissive.
Sep 20 2017, 3:25 AM · Restricted Project
tcanens created D38075: Fix PR34668 - P0704R1 implementation is too permissive.
Sep 20 2017, 3:24 AM · Restricted Project

Dec 1 2016

tcanens added inline comments to D27068: Improve string::find.
Dec 1 2016, 11:46 AM

Jan 7 2016

tcanens added inline comments to D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973..
Jan 7 2016, 12:20 PM
tcanens added inline comments to D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973..
Jan 7 2016, 12:15 PM
tcanens added inline comments to D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973..
Jan 7 2016, 9:17 AM

Jan 4 2016

tcanens added inline comments to D15862: A possible direction for fixing https://llvm.org/bugs/show_bug.cgi?id=25973..
Jan 4 2016, 2:32 PM