- User Since
- Apr 28 2017, 8:23 AM (246 w, 2 d)
Fri, Jan 14
LGTM, thank you for this fix!
Dec 1 2021
Oct 25 2021
LGTM, but I would wait for one more approval.
Oct 20 2021
Oct 7 2021
Added inline comment
Jun 16 2021
Feb 28 2021
D96952 is landed instead.
Feb 19 2021
Removed unrelated changes from the patch.
Thanks for such a detailed review, David!
I would love to split off the changes into separate patches, but if I do so, this patch just will not be compileable.
Feb 18 2021
clang-tidy would not be happy;)
I created D96952 - a demonstrative example of the CRTP-based version of this patch. Please, take a look.
Feb 17 2021
Removed explicit conversions to StringRef from the test with respect to D96861.
CRTP was my first implementation, however, I discarded it as more bug-prone. Virtual Clone function at the interface is so common that, I believe, everyone knows it must be overridden by a new derived class. The necessity of inheriting from base_clone_helper is not so obvious.
Feb 16 2021
Feb 8 2021
Feb 3 2021
Feb 2 2021
Feb 1 2021
Removed test since the same case was added by D95761.
It turns out that the Debugger recalculated the selected stack frame without taking the Process's run lock. I replaced the whole context evaluation with creating ExecutionContextRef which does these things right.
Jan 20 2021
D92164 was intended for fixing the "settings set" issue, however, it revealed some deadlocks and data races, and had to be reverted temporarily. Currently, I'm working on those multithreading issues and will submit a patch as soon as possible.
Dec 19 2020
Dec 18 2020
Fixed CommandInterpreter::GetProcessOutput to avoid deadlock in Windows process plugin. This should also fix the problem @labath described above.
Dec 12 2020
Dec 11 2020
Removed do_select's default value.
Dec 10 2020
Thanks for pointing to the nested command problem! Replaced pointer to the execution context with the stack of contexts.
Nov 30 2020
Removed refactoring to make the changes clearer.
Nov 26 2020
Oct 7 2020
Oct 6 2020
I used Swig 3.0.12 + cherry-picked commit that fixes that bug (https://github.com/swig/swig/issues/1321) on Windows. It worked well with both Python 3.7 and 3.8.
Sep 14 2020
Looks reasonable to me.
Aug 5 2020
I'm not familiar with the z/OS target, so I cannot check the correctness of the target-specific changes. The overall patch looks good.
Aug 4 2020
I see. The option "/Zc:__cplusplus" affects GTEST_LANG_CXX11 but not GTEST_HAS_TR1_TUPLE. I didn't have warnings just because my LLVM fork uses C++17.
Aug 3 2020
The option "/Zc:__cplusplus" solves this problem. With this option passed, Gtest doesn't try using namespace tr1. I don't have such warnings if pass this option.
LLVM documentation says: "You will need Visual Studio 2017 or higher, with the latest Update installed". Does this mean Visual Studio 2017 version 15.9? Because the /Zc:__cplusplus option is available starting in Visual Studio 2017 version 15.7.
Thank you! I fixed the commit title and description as you suggested.
Jul 30 2020
TestAddressBreakpoints.py fails on the last check - it expects hit count to be saved after re-launching the process. Removed that check.
Jul 29 2020
Ups... Pushed it occationaly with the other patchs.
Un-skip TestRequireHWBreakpoints.py on Windows, now it works as expected.
It also fixes warnings about using deprecated std::tr1, which became errors in VS 2019, produced while compiling lldbUtilityHelpers project (http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17887/steps/test/logs/stdio).
Jul 24 2020
I went further than just moving m_hardware_index from StoppointLocation. Please, take a look at D84527 and let me know what you think about that.
@omjavaid, thank you for verifying this!
Jul 22 2020
BreakpointSite::IntersectsRange returns false for hardware breakpoints, that's why the assertion fails.
Jul 21 2020
Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64.
Jul 20 2020
No updates, just to trigger rebasing onto master where tests should be already fixed.