Page MenuHomePhabricator

tari (Peter Marheine)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 31 2015, 11:51 AM (287 w, 4 d)

Recent Activity

Feb 14 2017

tari added a comment to D29959: x86 interrupt calling convention: only save xmm registers if the target supports SSE.

LGTM. I thought we already handled the no-SSE case, but looks like only for the 32-bit subtarget.

Feb 14 2017, 12:44 PM

Dec 21 2015

tari abandoned D12498: X86: add an interrupt calling convention.

Superceded by D15567.

Dec 21 2015, 11:51 AM

Dec 16 2015

tari accepted D15567: Support of x86 interrupt and exception handlers in LLVM.

LGTM too. Thanks for putting in the legwork since I was busy!

Dec 16 2015, 12:06 PM

Dec 6 2015

tari added a comment to D12498: X86: add an interrupt calling convention.

Peter, how do you suggest to go further from here? Do you want to make the needed changes and upload a new patch?

Dec 6 2015, 11:37 AM

Nov 18 2015

tari added inline comments to D12498: X86: add an interrupt calling convention.
Nov 18 2015, 11:53 AM
tari added a comment to D12498: X86: add an interrupt calling convention.

the frame parameter is passed in C as a pointer argument.
However, in the assembly it should be passed by value on the stack rather than a pointer on the stack.
Do we assume that this will be handled by the clang-FE ?

Nov 18 2015, 11:50 AM

Sep 3 2015

tari added a comment to D12498: X86: add an interrupt calling convention.

It's worth noting that I opted to implement this as a calling convention because it's relatively easy to support in the Rust compiler, where I really want this feature. While something similar might be useful in a C frontend as well, historically there has been no great need.

Sep 3 2015, 3:52 PM

Sep 1 2015

tari added a comment to D12498: X86: add an interrupt calling convention.

The hardware provides only up to one parameter, unless I've missed some major point. I think software interrupt calling conventions would be best left to some other work (if even they're well-defined enough to be worth trying to support).

Sep 1 2015, 7:43 AM

Aug 31 2015

tari added a reviewer for D12498: X86: add an interrupt calling convention: nadav.
Aug 31 2015, 2:26 PM
tari retitled D12498: X86: add an interrupt calling convention from to X86: add an interrupt calling convention.
Aug 31 2015, 12:16 PM