Page MenuHomePhabricator

stuart (Stuart Brady)
GPU Compiler Engineer at ARM

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2018, 6:55 AM (165 w, 2 d)

Recent Activity

Wed, Jun 16

stuart added a comment to D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14.

There is no CPlusPlus03 in LangOptions, so it is better not to merge DW_LANG_C_plus_plus_03 support with D99250.

Wed, Jun 16, 3:38 AM · Restricted Project, debug-info

Tue, Jun 15

stuart planned changes to D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C.

Changes will be required to align this with D104291.

Tue, Jun 15, 7:45 AM · debug-info, Restricted Project
stuart accepted D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14.
Tue, Jun 15, 7:37 AM · Restricted Project, debug-info
stuart added a comment to D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14.

This looks good to me.

Tue, Jun 15, 7:37 AM · Restricted Project, debug-info
stuart added inline comments to D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C.
Tue, Jun 15, 7:26 AM · debug-info, Restricted Project
stuart added inline comments to D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C.
Tue, Jun 15, 2:59 AM · debug-info, Restricted Project

Fri, Jun 11

stuart updated the diff for D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C.

Add missing trailing commas to CHECK lines of FileCheck test.

Fri, Jun 11, 8:10 AM · debug-info, Restricted Project
stuart added a comment to D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C.

Note: there is currently no DWARF language code defined for C++ for OpenCL, so we must use DW_LANG_C_plus_plus* if we wish to be able to determine whether output has been generated from C++ for OpenCL source or from OpenCL C source. I have raised DWARF issue 210514.1 to add a dedicated C++ for OpenCL code in the next version of DWARF, but for now I believe that it is best to use DW_LANG_OpenCL for OpenCL C only, and not for C++ for OpenCL.

Fri, Jun 11, 7:32 AM · debug-info, Restricted Project
stuart requested review of D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C.
Fri, Jun 11, 7:21 AM · debug-info, Restricted Project

Thu, Jun 10

stuart updated the summary of D103833: [demangler] Fix demangling of 'half'.
Thu, Jun 10, 12:39 PM · Restricted Project, Restricted Project
stuart added a comment to D103833: [demangler] Fix demangling of 'half'.

(I note the new behavior also matches gcc)

Thu, Jun 10, 12:39 PM · Restricted Project, Restricted Project
stuart updated subscribers of D103833: [demangler] Fix demangling of 'half'.
Thu, Jun 10, 6:46 AM · Restricted Project, Restricted Project
stuart added a comment to D103833: [demangler] Fix demangling of 'half'.

but your diff excerpt in the comment above is missing that extra directory prefix. I suspect you've got a local configuration file setting diff.noprefix = true

Thu, Jun 10, 6:31 AM · Restricted Project, Restricted Project
stuart updated the diff for D103833: [demangler] Fix demangling of 'half'.

Add a/ and b/ prefixes to diff.

Thu, Jun 10, 6:23 AM · Restricted Project, Restricted Project
stuart added a comment to D103833: [demangler] Fix demangling of 'half'.
Thu, Jun 10, 3:47 AM · Restricted Project, Restricted Project
stuart updated the diff for D103833: [demangler] Fix demangling of 'half'.

Reupload with no changes.

Thu, Jun 10, 3:45 AM · Restricted Project, Restricted Project
stuart updated subscribers of D103833: [demangler] Fix demangling of 'half'.

@jyknight, I have reuploaded the exact same diff with full context:

Thu, Jun 10, 3:18 AM · Restricted Project, Restricted Project
stuart updated the diff for D103833: [demangler] Fix demangling of 'half'.

Reupload with no changes.

Thu, Jun 10, 2:59 AM · Restricted Project, Restricted Project

Mon, Jun 7

stuart added a comment to D103833: [demangler] Fix demangling of 'half'.

The pre-merge check failures relating to the failure to include "ItaniumDemangle.h" seem confusing to me. I cannot see how they would be caused by this change, itself: this looks on the surface to be a problem with the CI. Do I need to do anything about this?

Mon, Jun 7, 2:03 PM · Restricted Project, Restricted Project
stuart added a comment to D103833: [demangler] Fix demangling of 'half'.
Mon, Jun 7, 1:44 PM · Restricted Project, Restricted Project
stuart updated the summary of D103833: [demangler] Fix demangling of 'half'.
Mon, Jun 7, 1:42 PM · Restricted Project, Restricted Project
stuart updated the diff for D103833: [demangler] Fix demangling of 'half'.
Mon, Jun 7, 1:42 PM · Restricted Project, Restricted Project
stuart added reviewers for D103833: [demangler] Fix demangling of 'half': jyknight, erik.pilkington.
Mon, Jun 7, 11:44 AM · Restricted Project, Restricted Project
stuart requested review of D103833: [demangler] Fix demangling of 'half'.
Mon, Jun 7, 11:39 AM · Restricted Project, Restricted Project
stuart committed rG9b14670f3ca2: [OpenCL] Add const attribute to ctz() builtins (authored by stuart).
[OpenCL] Add const attribute to ctz() builtins
Mon, Jun 7, 3:44 AM
stuart closed D97725: [OpenCL] Add const attribute to ctz() builtin.
Mon, Jun 7, 3:44 AM · Restricted Project, Restricted Project

Fri, Jun 4

stuart committed rG333987b04589: [OpenCL] Add DWARF address spaces mapping for SPIR (authored by jzzheng22).
[OpenCL] Add DWARF address spaces mapping for SPIR
Fri, Jun 4, 10:11 AM
stuart closed D103097: Add DWARF address spaces mapping for SPIR.
Fri, Jun 4, 10:11 AM · Restricted Project
stuart added inline comments to D103097: Add DWARF address spaces mapping for SPIR.
Fri, Jun 4, 8:44 AM · Restricted Project
stuart committed rG86c24493ea66: [OpenCL][NFC] Test commit: tidy up whitespace in comment (authored by stuart).
[OpenCL][NFC] Test commit: tidy up whitespace in comment
Fri, Jun 4, 6:45 AM

Mar 11 2021

stuart accepted D98418: [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h.

Looks good to me.

Mar 11 2021, 4:18 PM · Restricted Project

Mar 1 2021

stuart requested review of D97725: [OpenCL] Add const attribute to ctz() builtin.
Mar 1 2021, 1:26 PM · Restricted Project, Restricted Project

Feb 9 2021

stuart requested changes to D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata.

Looks good, just some suggestions about the test.

Feb 9 2021, 3:07 AM · Restricted Project

Feb 5 2021

stuart requested changes to D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata.

Looks good. Small nit about the test case.

Feb 5 2021, 11:34 AM · Restricted Project
stuart added a comment to D96151: [OpenCL] Fix pipe type printing in arg info metadata.

This looks like a really good cleanup, in addition to fixing the metadata for pipes.

Feb 5 2021, 11:18 AM · Restricted Project

Sep 12 2019

stuart added inline comments to D67507: Refer to IEEE 754-2019 in langref instead of 2018 draft.
Sep 12 2019, 11:21 AM · Restricted Project
stuart added inline comments to D67507: Refer to IEEE 754-2019 in langref instead of 2018 draft.
Sep 12 2019, 10:51 AM · Restricted Project
stuart added a comment to D67507: Refer to IEEE 754-2019 in langref instead of 2018 draft.

@hans, is it too late for this to be considered as a candidate for the 9.0.0 release?

Sep 12 2019, 9:49 AM · Restricted Project
stuart created D67507: Refer to IEEE 754-2019 in langref instead of 2018 draft.
Sep 12 2019, 9:42 AM · Restricted Project

Apr 27 2018

stuart updated the summary of D46015: [OpenCL] Add separate read_only and write_only pipe IR types.
Apr 27 2018, 3:37 AM
stuart updated the summary of D46015: [OpenCL] Add separate read_only and write_only pipe IR types.
Apr 27 2018, 3:33 AM
stuart updated the summary of D46015: [OpenCL] Add separate read_only and write_only pipe IR types.
Apr 27 2018, 3:31 AM

Apr 25 2018

stuart added a comment to D46015: [OpenCL] Add separate read_only and write_only pipe IR types.

There should not be need for bitcast. Could give an example ? Thanks.

If I have a write_only pipe as the argument to get_pipe_max_packets(), and this uses a single __get_pipe_num_packets() function taking a read_only pipe, we will automatically get a bitcast:

%20 = call i32 bitcast (i32 (%opencl.pipe_ro_t*, i32, i32)* @__get_pipe_max_packets to i32 (%opencl.pipe_wo_t*, i32, i32)*)(%opencl.pipe_wo_t* %19, i32 4, i32 4)

Sorry, but I don't quite understand what does get_pipe_max_packets(), uses __get_pipe_num_packets() mean. Could you clarify? Possibly OpenCL C source example could help.

Apr 25 2018, 9:51 AM
stuart added a comment to D46015: [OpenCL] Add separate read_only and write_only pipe IR types.

There should not be need for bitcast. Could give an example ? Thanks.

Apr 25 2018, 8:31 AM
stuart added a comment to D46015: [OpenCL] Add separate read_only and write_only pipe IR types.

It is not clear why we need two versions of get_pipe_num_packets and get_pipe_max_packets builtins. There is only one instruction per builtin in the SPIR-V spec. I think splitting the IR type is enough for translation to SPIR-V purposes.

Apr 25 2018, 8:25 AM
stuart updated the diff for D46015: [OpenCL] Add separate read_only and write_only pipe IR types.

Changed new getPipeType() method to have protected visibility.

Apr 25 2018, 8:16 AM

Apr 24 2018

stuart created D46015: [OpenCL] Add separate read_only and write_only pipe IR types.
Apr 24 2018, 8:25 AM