Page MenuHomePhabricator

sthibaul (Samuel Thibault)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 23 2018, 12:36 AM (110 w, 4 d)

Recent Activity

Aug 3 2020

sthibaul closed D74282: [Hurd] Use the GCC multilib/multiarch paths support.

Oh.
It was committed already as c298e5a022928b59941d74680a41fc9c76038b2a ("[Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu") but apparently with the wrong Differential Revision (D73845 instead of D74282).
Now closing.

Aug 3 2020, 2:19 AM · Restricted Project

Apr 25 2020

sthibaul added a comment to D74282: [Hurd] Use the GCC multilib/multiarch paths support.

@MaskRay @phosek : can we have a look at this then?

Apr 25 2020, 11:40 AM · Restricted Project

Apr 24 2020

sthibaul added a comment to D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

@MaskRay : Samuel Thibault <samuel.thibault@ens-lyon.org>

Apr 24 2020, 1:34 AM · Restricted Project

Apr 23 2020

sthibaul added a comment to D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

Thanks! I don't have commit access, could somebody commit this for me?

Apr 23 2020, 3:15 PM · Restricted Project

Apr 22 2020

sthibaul added a comment to D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

ping @phosek ?

Apr 22 2020, 1:03 PM · Restricted Project

Apr 9 2020

sthibaul updated the diff for D74282: [Hurd] Use the GCC multilib/multiarch paths support.
Apr 9 2020, 4:53 PM · Restricted Project
sthibaul added inline comments to D74282: [Hurd] Use the GCC multilib/multiarch paths support.
Apr 9 2020, 4:53 PM · Restricted Project
sthibaul updated the diff for D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.
Apr 9 2020, 4:02 PM · Restricted Project
sthibaul added a comment to D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

Moving functions from Linux.cpp to Gnu.cpp is definitely appropriate. Have you made any adjustment?

Apr 9 2020, 4:02 PM · Restricted Project

Feb 25 2020

sthibaul added a comment to D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

Hello, any news on this?

Feb 25 2020, 2:10 PM · Restricted Project

Feb 8 2020

sthibaul added a comment to D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

I however didn't find how to specify in phabricator a dependency between the two diffs, is that supported in phabricator?

Feb 8 2020, 9:43 AM · Restricted Project
sthibaul added a comment to D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

I feel like in this specific case it may be worth splitting this into two patches:

Alright, doing so.

Feb 8 2020, 9:43 AM · Restricted Project
sthibaul updated the diff for D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.
Feb 8 2020, 9:43 AM · Restricted Project
sthibaul created D74282: [Hurd] Use the GCC multilib/multiarch paths support.
Feb 8 2020, 9:43 AM · Restricted Project
sthibaul added a comment to D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

I feel like in this specific case it may be worth splitting this into two patches:

Feb 8 2020, 9:35 AM · Restricted Project
sthibaul updated the diff for D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

Right, here is an updated patch

Feb 8 2020, 4:30 AM · Restricted Project

Feb 2 2020

sthibaul added a comment to D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

There is no behavior change, I checked for no regression on GNU/Linux with ninja check-all.

Feb 2 2020, 1:59 AM · Restricted Project
sthibaul created D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.
Feb 2 2020, 1:55 AM · Restricted Project

Jan 5 2020

sthibaul added a comment to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

Let me know if you need this committed.

Jan 5 2020, 1:37 PM · Restricted Project
sthibaul added a comment to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

I am actually getting many failures with ninja check-all on my build box:

Jan 5 2020, 1:00 PM · Restricted Project
sthibaul added a comment to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

(I don't see anything looking like what you have, so can't investigate)

Jan 5 2020, 1:00 PM · Restricted Project
sthibaul added a comment to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

Which checksuite are you running? I had been using ninja check-all, and I do indeed get unexpected failures, but exactly the same set of failures as when building against master.

Jan 5 2020, 8:30 AM · Restricted Project

Dec 30 2019

sthibaul added a comment to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

[Gnu toolchain]
maybe this can be removed in the title?

Dec 30 2019, 2:57 PM · Restricted Project
sthibaul added a comment to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

I have updated the patch to the latest git and re-ran checks. Could somebody have a look at it please?

Dec 30 2019, 2:38 PM · Restricted Project
sthibaul updated the diff for D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.
Dec 30 2019, 2:34 PM · Restricted Project

Nov 13 2019

sthibaul added inline comments to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.
Nov 13 2019, 2:50 PM · Restricted Project
sthibaul updated the diff for D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.
Nov 13 2019, 2:50 PM · Restricted Project
sthibaul added a comment to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

Not sure what NFCI means, but for Linux the behavior should just not change at all, and the testsuite indeed behaved exactly the same on Linux indeed.

Nov 13 2019, 9:06 AM · Restricted Project

Nov 2 2019

sthibaul created D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.
Nov 2 2019, 4:52 PM · Restricted Project
sthibaul created D69754: [hurd] Add --build-id option when enabled.
Nov 2 2019, 2:09 PM · Restricted Project

Nov 1 2019

sthibaul updated the diff for D69683: [Hurd]: use /proc/self/exe to get program path.

Here it is updated to use gnu_hurd, please commit indeed

Nov 1 2019, 10:19 AM · Restricted Project
sthibaul added a comment to D69683: [Hurd]: use /proc/self/exe to get program path.

gnu_hurd can work as well indeed

Nov 1 2019, 9:58 AM · Restricted Project

Oct 31 2019

sthibaul created D69683: [Hurd]: use /proc/self/exe to get program path.
Oct 31 2019, 2:04 PM · Restricted Project

Jan 16 2019

sthibaul added a comment to D54677: [hurd] Fix unconditional use of PATH_MAX.

Any news on this?

Jan 16 2019, 4:15 PM

Dec 18 2018

sthibaul updated the diff for D54677: [hurd] Fix unconditional use of PATH_MAX.

Right, that looks better indeed :)

Dec 18 2018, 3:40 PM

Nov 28 2018

sthibaul added a comment to D54379: Add Hurd toolchain support to Clang.

I don't have this issue with make check-all in clang/. Just to make sure: are the .keep files of the patch getting created? Otherwise the i386-gnu/ directories will not get created and then it's not surprising that clang doesn't add them to the research paths.

Nov 28 2018, 6:29 PM

Nov 27 2018

sthibaul added a comment to D54677: [hurd] Fix unconditional use of PATH_MAX.

I have updated the patch according to the comment.

Nov 27 2018, 11:59 AM
sthibaul updated the diff for D54677: [hurd] Fix unconditional use of PATH_MAX.
Nov 27 2018, 11:58 AM

Nov 25 2018

sthibaul added a comment to D54379: Add Hurd toolchain support to Clang.

I have added static and shared library tests

Nov 25 2018, 3:43 PM
sthibaul updated the diff for D54379: Add Hurd toolchain support to Clang.
Nov 25 2018, 3:42 PM
sthibaul added a comment to D54379: Add Hurd toolchain support to Clang.

(there still needs to be work on the test part)

Nov 25 2018, 2:51 PM
sthibaul updated the diff for D54379: Add Hurd toolchain support to Clang.
Nov 25 2018, 2:51 PM
sthibaul added a comment to D54379: Add Hurd toolchain support to Clang.

I'll update the diff according to the comments.

Nov 25 2018, 2:50 PM

Nov 19 2018

sthibaul updated the diff for D54677: [hurd] Fix unconditional use of PATH_MAX.
Nov 19 2018, 4:53 PM
sthibaul updated the diff for D54677: [hurd] Fix unconditional use of PATH_MAX.
Nov 19 2018, 4:33 PM
sthibaul added inline comments to D54677: [hurd] Fix unconditional use of PATH_MAX.
Nov 19 2018, 4:33 PM
sthibaul updated the diff for D54677: [hurd] Fix unconditional use of PATH_MAX.
Nov 19 2018, 4:30 PM
sthibaul updated the diff for D54677: [hurd] Fix unconditional use of PATH_MAX.

Here is the test for realpath extension fixed.

Nov 19 2018, 2:12 PM
sthibaul added inline comments to D54677: [hurd] Fix unconditional use of PATH_MAX.
Nov 19 2018, 1:33 PM

Nov 18 2018

sthibaul added a comment to D54339: Fix threads detection on GNU/Hurd.

(I can't commit this myself)

Nov 18 2018, 2:35 PM
sthibaul created D54677: [hurd] Fix unconditional use of PATH_MAX.
Nov 18 2018, 7:37 AM
sthibaul updated the diff for D54379: Add Hurd toolchain support to Clang.

I have added a few checks (the ld.so dynamic linker specification, the ../lib32 paths, and /usr/lib/i386-gnu)

Nov 18 2018, 5:24 AM

Nov 17 2018

sthibaul added a comment to D54379: Add Hurd toolchain support to Clang.

I believe this version addresses all the comments.
I could run this with check-all on a linux-amd64 box.

Nov 17 2018, 7:18 PM
sthibaul updated the diff for D54379: Add Hurd toolchain support to Clang.
Nov 17 2018, 7:15 PM
sthibaul added a comment to D54379: Add Hurd toolchain support to Clang.

In general when structuring your code, the performance penalty for other targets when the conditions that can be easily tested are not met should pretty much be close to nonexistent. I would suggest keeping that in mind when submitting revisions.

Nov 17 2018, 11:07 AM
sthibaul added inline comments to D54379: Add Hurd toolchain support to Clang.
Nov 17 2018, 10:57 AM
sthibaul added reviewers for D54339: Fix threads detection on GNU/Hurd: ldionne, mclow.lists.
Nov 17 2018, 7:53 AM

Nov 12 2018

sthibaul added a comment to D54338: Fix threads build on GNU/Hurd.

Doesn't APPLE imply MACH anyway outside of targets that are way out of scope of libc++?

Nov 12 2018, 1:36 AM
sthibaul updated the diff for D54338: Fix threads build on GNU/Hurd.

I have dropped the endif comment as requested.

Nov 12 2018, 1:34 AM

Nov 11 2018

sthibaul updated the diff for D54379: Add Hurd toolchain support to Clang.

This includes version finding the gcc Hurd triplet (i[3456]-gnu) in the Gcc detector.

Nov 11 2018, 5:15 PM
sthibaul updated the diff for D54379: Add Hurd toolchain support to Clang.
Nov 11 2018, 4:53 PM
sthibaul updated the diff for D54378: Add Hurd triplet to LLVMSupport.

So we are back with this.

Nov 11 2018, 4:45 PM
sthibaul updated the diff for D54379: Add Hurd toolchain support to Clang.

In this version, the Driver introduces the "-hurd-" part

Nov 11 2018, 4:44 PM
sthibaul added a comment to D54338: Fix threads build on GNU/Hurd.

(I can't commit this myself)

Nov 11 2018, 2:17 PM

Nov 10 2018

sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

i386-pc-hurd-gnu is fine as is, however, it seems that you want to be able to use i386-pc-gnu from Clang, if I understand correctly.

Nov 10 2018, 6:34 PM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

Or perhaps at least keep a Triplet::isOSHurd() which does the hurd-specific triplet parsing, instead of adding a function to clang to be used wherever we want to check for that?

Nov 10 2018, 5:16 PM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

I'm not sure to understand: do you mean to drop this patch entirely, so that llvm considers i386-pc-gnu as just a GNU-ish platform, and then Driver::getToolChain should special-case the Triple::UnknownOS and parse Triple::getTriple itself to call the Hurd code instead of the default toolchains::Generic_GCC case?

Nov 10 2018, 5:10 PM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

(as expected, I could run make check-all fine on an x86_64 linux host)

Nov 10 2018, 4:48 PM
sthibaul updated the diff for D54378: Add Hurd triplet to LLVMSupport.

Perhaps we could go this way with additional code in cmake/config-ix.cmake, to get "hurd-gnu" as soon as possible just after detection and keep everything else inside llvm straight with llvm conventions?

Nov 10 2018, 4:42 PM
sthibaul added inline comments to D54379: Add Hurd toolchain support to Clang.
Nov 10 2018, 3:50 PM
sthibaul updated the diff for D54338: Fix threads build on GNU/Hurd.

Ah, right, sorry, done so now.

Nov 10 2018, 1:56 PM
sthibaul added a comment to D54338: Fix threads build on GNU/Hurd.

Well, that's what I did the in the latest version?

Nov 10 2018, 1:51 PM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

For sure I consider that not breaking anything on other archs is a must :)

Nov 10 2018, 10:52 AM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

Well, it definitely is for GNU/Hurd, now that very basic software pieces such as librsvg start _depending_ on rust, which is available only through llvm.

That was an old Hurd joke (that it would never be used by anyone), thus the smiley face. Jokes don't work well on the Internet, sorry.

Nov 10 2018, 8:15 AM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

I'm getting an immense amount of errors, did you run make check-all on this patch?

Nov 10 2018, 8:13 AM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

if people forget the OS part, for example, write "target-gnu" instead of "target-linux-gnu".

Nov 10 2018, 8:06 AM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

not supporting Hurd at all (which is not that big of a problem, I get it :).

Nov 10 2018, 8:02 AM
sthibaul updated the diff for D54379: Add Hurd toolchain support to Clang.
Nov 10 2018, 8:00 AM
sthibaul added a comment to D54379: Add Hurd toolchain support to Clang.

I commented one of them, and will fix the rest.

Nov 10 2018, 8:00 AM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

I understand your concerns, but that's really not something that we can change at this point, there is far too much software which has written i386-pc-gnu in their source code for us to change all that.

Nov 10 2018, 7:00 AM
sthibaul added a comment to D54379: Add Hurd toolchain support to Clang.

The Hurd::Hurd constructor would actually need to do the same gcc inclusion path detection as on Linux, but let's leave this aside for now, this commit is enough for a build without libc++.

Nov 10 2018, 6:06 AM
sthibaul created D54379: Add Hurd toolchain support to Clang.
Nov 10 2018, 6:03 AM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

(I can not commit this myself)

Nov 10 2018, 5:55 AM
sthibaul added a comment to D54378: Add Hurd triplet to LLVMSupport.

The GNU/Hurd triple is target-gnu, simply.

Nov 10 2018, 5:42 AM
sthibaul updated the diff for D54378: Add Hurd triplet to LLVMSupport.
Nov 10 2018, 5:42 AM
sthibaul created D54378: Add Hurd triplet to LLVMSupport.
Nov 10 2018, 5:31 AM
sthibaul updated the diff for D54338: Fix threads build on GNU/Hurd.
Nov 10 2018, 4:42 AM
sthibaul added a comment to D54338: Fix threads build on GNU/Hurd.

So that'd be it? I don't know if libcxx supports more than free/net/open bsd and apple ?

Nov 10 2018, 2:36 AM
sthibaul updated the diff for D54338: Fix threads build on GNU/Hurd.
Nov 10 2018, 2:36 AM

Nov 9 2018

sthibaul created D54339: Fix threads detection on GNU/Hurd.
Nov 9 2018, 11:28 AM
sthibaul added reviewers for D54338: Fix threads build on GNU/Hurd: EricWF, howard.hinnant, joerg.
Nov 9 2018, 11:26 AM
sthibaul created D54338: Fix threads build on GNU/Hurd.
Nov 9 2018, 11:25 AM

Nov 6 2018

sthibaul added a comment to D54079: [OPENMP] Add Hurd support.

(I cannot commit this myself)

Nov 6 2018, 3:42 PM
sthibaul updated the diff for D54079: [OPENMP] Add Hurd support.
Nov 6 2018, 3:33 PM
sthibaul added a comment to D54079: [OPENMP] Add Hurd support.

Here it is

Nov 6 2018, 6:10 AM
sthibaul updated the diff for D54079: [OPENMP] Add Hurd support.
Nov 6 2018, 6:10 AM

Nov 3 2018

sthibaul created D54079: [OPENMP] Add Hurd support.
Nov 3 2018, 2:11 PM

Oct 23 2018

sthibaul updated the diff for D53557: [hurd] Make getMainExecutable get the real binary path.
Oct 23 2018, 9:18 AM
sthibaul added a comment to D53557: [hurd] Make getMainExecutable get the real binary path.

(I can not commit this myself)

Oct 23 2018, 9:14 AM
sthibaul added reviewers for D53557: [hurd] Make getMainExecutable get the real binary path: rnk, JDevlieghere.
Oct 23 2018, 12:54 AM