Page MenuHomePhabricator

smhc (Shane)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2020, 3:37 AM (5 w, 1 d)

Recent Activity

Wed, Nov 25

smhc added inline comments to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.
Wed, Nov 25, 1:23 AM · Restricted Project, Restricted Project

Tue, Nov 24

smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

There's a build failure from this merge, looks like a typo:

Tue, Nov 24, 6:06 PM · Restricted Project, Restricted Project

Mon, Nov 23

smhc added a comment to D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.

Yes all looks good, thanks!

Mon, Nov 23, 3:16 PM · Restricted Project, Restricted Project
smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Yes I thought the same wrt the doco. There is also a hungarian notation config option in the works which does the same thing.

Mon, Nov 23, 12:59 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Removed unnecessary diff

Mon, Nov 23, 12:54 PM · Restricted Project, Restricted Project
smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Thanks for the reviews everyone, I have updated the title and summary.
Unfortunately I don't have push access to llvm - could someone help to push this please?

Mon, Nov 23, 12:16 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Fixed uk/us spelling difference as suggested

Mon, Nov 23, 12:07 PM · Restricted Project, Restricted Project
smhc retitled D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks from [clang-tidy] Add IgnoreShortNames config to identifier naming checks to [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.
Mon, Nov 23, 12:06 PM · Restricted Project, Restricted Project

Sun, Nov 22

smhc added inline comments to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.
Sun, Nov 22, 3:03 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Updated after review comments.

Sun, Nov 22, 3:01 PM · Restricted Project, Restricted Project
smhc added a comment to D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.

Thank you - I don't have commit access so am unable to merge it myself. The clang-tidy tests are passing fine.

Sun, Nov 22, 12:42 PM · Restricted Project, Restricted Project

Sat, Nov 21

smhc updated the diff for D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.

Thanks - I had it like that originally but was not sure how often MacroUsageCallbacks would be instantiated or whether there was a many-to-one relationship. I've now modified it to create and maintain the regex object as a member of MacroUsageCallbacks.

Sat, Nov 21, 12:26 PM · Restricted Project, Restricted Project
smhc requested review of D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.
Sat, Nov 21, 1:16 AM · Restricted Project, Restricted Project

Fri, Nov 20

smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Updated after review comments.

Fri, Nov 20, 6:15 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

removed notes on short length threshold

Fri, Nov 20, 7:26 AM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Updated diff to use 'IgnoredRegexp'
I see that a regexp has been used elsewhere for some other checks (macro usage, AllowedRegexp).

Fri, Nov 20, 7:21 AM · Restricted Project, Restricted Project

Thu, Nov 19

smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Regexes may be a bit of a slippery slope as any identifier scheme could be represented as a regex (casing, prefix, suffix etc) but it's not practical to provide a fix or suggestion with a regex.
For example with a 'ShortThreshold' a fix could offer to change the casing/xffix or to trim the variable length. With a regex it's less about making a naming rule and more about providing a workaround for problematic edge cases. As such should be used sparingly.

Thu, Nov 19, 8:13 PM · Restricted Project, Restricted Project

Sun, Nov 15

smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Re-based to llvm master and re-diffed.

Sun, Nov 15, 4:02 PM · Restricted Project, Restricted Project

Sat, Nov 14

smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

I updated it to use XXShortSizeThreshold.

Sat, Nov 14, 9:13 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.
Sat, Nov 14, 9:02 PM · Restricted Project, Restricted Project

Thu, Nov 12

smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Should this be a NamingStyle option instead.
{key: readability-identifier-naming.ParameterShortSizeThreshold, value: 2}
WDYT?

I think that makes a lot of sense -- I can imagine wanting to enforce different identifier lengths depending on whether we're spelling a type name vs a local variable name, etc.

Thu, Nov 12, 10:15 PM · Restricted Project, Restricted Project
smhc set the repository for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks to rG LLVM Github Monorepo.
Thu, Nov 12, 3:30 AM · Restricted Project, Restricted Project

Thu, Nov 5

smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

I've updated the release notes and corrected the unit tests to be passing. Thanks again.

Thu, Nov 5, 6:44 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Thanks for the review! Agreed with suggestions, submitted updated diff.
Please note I do not have commit access to llvm. Regards.

Thu, Nov 5, 3:36 AM · Restricted Project, Restricted Project

Wed, Nov 4

smhc retitled D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks from Add IgnoreShortNames config to identifier naming checks to [clang-tidy] Add IgnoreShortNames config to identifier naming checks.
Wed, Nov 4, 6:38 PM · Restricted Project, Restricted Project

Oct 27 2020

smhc requested review of D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.
Oct 27 2020, 7:31 PM · Restricted Project, Restricted Project