User Details
- User Since
- Apr 23 2019, 8:52 PM (102 w, 6 d)
Yesterday
Thu, Apr 8
Mon, Mar 29
Fri, Mar 26
Feb 17 2021
Jan 31 2021
@lenary Do you need to update something? There are three tests fail according to the log.
Jan 25 2021
FYI, this patch also fix the bug that "X86::Int_MemBarrier should be a MetaInstruction".
Jan 18 2021
LGTM. Before this patch, we could only write code like
CS insl
addr32/addr16 and CS/DS/ES/FS/GS/SS are prefixes, so they should be allowed to be written before the instruction in the same line, and GNU-AS does support this syntax.
One behavior different from GNU-AS is that as rejects es and ss in 64-bit mode, but this has beyond the purpose of this patch.
Jan 17 2021
Jan 13 2021
LGTM
Jan 12 2021
Jan 11 2021
Aug 26 2020
Aug 25 2020
I think this introduces an old issue when lowering the instruction.
Jul 9 2020
Jul 8 2020
Address review comments
Jul 7 2020
Update comments
Jun 8 2020
Related revision: D80822
Jun 3 2020
May 27 2020
May 22 2020
Ping.
May 20 2020
Refactor addX86AlignBranchArgs to be reused in CommonArgs.cpp
Move tests to x86-malign-branch.c
May 12 2020
May 8 2020
Apr 26 2020
LGTM
Apr 25 2020
LGTM (with one comment)
Apr 20 2020
Rebase
LGTM
Apr 19 2020
Address review comments
Apr 18 2020
Address review comments
Address review comments (only test file changes)
Apr 17 2020
Add test for RISCV to prevent future regression
Feel free to add yourself as a reviewer if you'd like to.
@MaskRay Is this acceptable?
Apr 16 2020
Address review comments
Address review comments
Address part of review comments
Check the REX is not zero before emitting it
Address review comments