Page MenuHomePhabricator

shivanshu3 (Shivanshu Goyal)
User

Projects

User does not belong to any projects.

User Details

User Since
Tue, Sep 1, 7:02 PM (3 w, 6 d)

Recent Activity

Thu, Sep 3

shivanshu3 added a comment to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.

Note that I do not have commit access and this change will have to be committed by someone else on my behalf. Thanks!

Thu, Sep 3, 3:41 PM · Restricted Project
shivanshu3 added inline comments to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Thu, Sep 3, 1:12 PM · Restricted Project
shivanshu3 updated the diff for D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
  • Remove the bool IsDependencyFileArg in the implementation of getClangStripDependencyFileAdjuster() to make it simpler.
  • Add an extra argument after -MT in the test case to ensure we do not strip arguments after -MT when using the cl driver mode.
Thu, Sep 3, 1:11 PM · Restricted Project

Wed, Sep 2

shivanshu3 added inline comments to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Wed, Sep 2, 5:44 PM · Restricted Project
shivanshu3 updated the diff for D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
  • Simplified the implementation of getDriverMode and got rid of the Optional return type.
  • When using the cl driver mode, we do not want to skip the next argument for -MF, -MT, -MQ.
Wed, Sep 2, 5:40 PM · Restricted Project

Tue, Sep 1

shivanshu3 added a reviewer for D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver: zahen.
Tue, Sep 1, 8:33 PM · Restricted Project
shivanshu3 requested review of D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Tue, Sep 1, 8:32 PM · Restricted Project