Page MenuHomePhabricator

sgraenitz (Stefan Gränitz)
dev

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2018, 11:23 AM (131 w, 6 d)

We may think in generalities, but weliveindetail

Recent Activity

Fri, Jan 15

sgraenitz committed rG6edc3fe598af: [Orc] Fix OrcV2Examples after D94690 (authored by sgraenitz).
[Orc] Fix OrcV2Examples after D94690
Fri, Jan 15, 4:46 AM
sgraenitz committed rGcf905274c6f4: [Orc] Allow LLJITBuilder's CreateObjectLinkingLayer to return errors (authored by sgraenitz).
[Orc] Allow LLJITBuilder's CreateObjectLinkingLayer to return errors
Fri, Jan 15, 3:54 AM
sgraenitz committed rGa5eb9df1e3ba: [Orc][NFC] Turn LLJIT member ObjTransformLayer into unique_ptr (authored by sgraenitz).
[Orc][NFC] Turn LLJIT member ObjTransformLayer into unique_ptr
Fri, Jan 15, 3:54 AM
sgraenitz closed D94690: [Orc] Allow LLJITBuilder's CreateObjectLinkingLayer to return errors.
Fri, Jan 15, 3:54 AM · Restricted Project
sgraenitz closed D94689: [Orc][NFC] Turn LLJIT member ObjTransformLayer into unique_ptr.
Fri, Jan 15, 3:54 AM · Restricted Project

Thu, Jan 14

sgraenitz retitled D94690: [Orc] Allow LLJITBuilder's CreateObjectLinkingLayer to return errors from [Orc] Allow errors via output parameter in LLJITBuilder's CreateObjectLinkingLayer to [Orc] Allow LLJITBuilder's CreateObjectLinkingLayer to return errors.
Thu, Jan 14, 1:19 PM · Restricted Project
sgraenitz updated the diff for D94690: [Orc] Allow LLJITBuilder's CreateObjectLinkingLayer to return errors.

Drop the Error output parameter and return an Expected instead

Thu, Jan 14, 1:19 PM · Restricted Project
sgraenitz added inline comments to D94690: [Orc] Allow LLJITBuilder's CreateObjectLinkingLayer to return errors.
Thu, Jan 14, 12:55 PM · Restricted Project
sgraenitz added a comment to D94689: [Orc][NFC] Turn LLJIT member ObjTransformLayer into unique_ptr.

The follow-up change is D94690. It also moves the instantiation of ObjLinkingLayer from the initialization list to the ctor body.

Thu, Jan 14, 7:41 AM · Restricted Project
sgraenitz requested review of D94690: [Orc] Allow LLJITBuilder's CreateObjectLinkingLayer to return errors.
Thu, Jan 14, 7:37 AM · Restricted Project
sgraenitz requested review of D94689: [Orc][NFC] Turn LLJIT member ObjTransformLayer into unique_ptr.
Thu, Jan 14, 7:22 AM · Restricted Project
sgraenitz added a comment to D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.

Thanks! Eventually, I closed https://llvm.org/PR36209

Thu, Jan 14, 7:15 AM · Restricted Project
sgraenitz committed rG332e220ef42b: [docs] Update DebuggingJITedCode page after fix in LLDB (authored by sgraenitz).
[docs] Update DebuggingJITedCode page after fix in LLDB
Thu, Jan 14, 6:45 AM
sgraenitz closed D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.
Thu, Jan 14, 6:45 AM · Restricted Project

Mon, Jan 11

sgraenitz added a comment to D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.

I'd like to land this before release 12 branches. If you have any objections, please speak up before the end of the week. Thanks.

Mon, Jan 11, 7:26 AM · Restricted Project

Dec 8 2020

sgraenitz committed rGc54d827fdb12: [Orc] Two small fixes in TPCDynamicLibrarySearchGenerator (authored by sgraenitz).
[Orc] Two small fixes in TPCDynamicLibrarySearchGenerator
Dec 8 2020, 1:59 AM
sgraenitz closed D91707: [Orc] Two small fixes in TPCDynamicLibrarySearchGenerator.
Dec 8 2020, 1:58 AM · Restricted Project
sgraenitz committed rG83b52b5ba278: [JITLink][ELF] Route objects to their matching linker backends based on header… (authored by sgraenitz).
[JITLink][ELF] Route objects to their matching linker backends based on header…
Dec 8 2020, 1:56 AM
sgraenitz closed D90860: [JITLink][ELF] Route objects to their matching linker backends based on header info.
Dec 8 2020, 1:56 AM · Restricted Project

Dec 2 2020

sgraenitz added a comment to D91707: [Orc] Two small fixes in TPCDynamicLibrarySearchGenerator.

Friendly ping. @lhames Can you confirm this fix? I couldn't find a test for this piece of code.

Dec 2 2020, 4:27 AM · Restricted Project

Dec 1 2020

sgraenitz added a comment to D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.

Does anyone have objections to this documentation update? Preview is here still:
https://weliveindetail.github.io/docs-pub/html/DebuggingJITedCode.html

Dec 1 2020, 3:25 AM · Restricted Project

Nov 23 2020

sgraenitz added inline comments to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..
Nov 23 2020, 8:27 AM · Restricted Project

Nov 18 2020

sgraenitz requested review of D91707: [Orc] Two small fixes in TPCDynamicLibrarySearchGenerator.
Nov 18 2020, 6:23 AM · Restricted Project

Nov 12 2020

sgraenitz accepted D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Ok, I grabbed your latest version and checked again for the EH frame registration on Linux. This works very well now! Thanks

Nov 12 2020, 6:37 AM · Restricted Project

Nov 11 2020

sgraenitz added a comment to D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.

One issue with the orc-lazy JIT will be symbol renaming for lazy reexports: Upfront we only emit stubs for our function symbols and they trigger compilation of the actual code in a separate logical unit once they are called. The debug object we hand over to LLDB doesn't take that into account. (Maybe we are just inserting the wrong load address? Don't know.) Additionally, I am not sure how debug data is handled in the partitioning logic of the CompileOnDemandLayer.

Nov 11 2020, 10:44 AM · Restricted Project
sgraenitz removed a reviewer for D69589: [lldb] Refactor all POST_BUILD commands into targets: sgraenitz.
Nov 11 2020, 6:07 AM · Unknown Object (Project)
sgraenitz added a comment to D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.

Thanks for having a look.

Nov 11 2020, 6:05 AM · Restricted Project
sgraenitz added a comment to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Last issue: EH-frame registration isn't ready for ELF right? That would be great to fix (see the unticked inline comment).
I can offer to check the mangling prefix details once this had landed.

Nov 11 2020, 4:00 AM · Restricted Project

Nov 10 2020

sgraenitz committed rG203b4774b883: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via… (authored by sgraenitz).
[lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via…
Nov 10 2020, 2:39 AM
sgraenitz closed D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB).
Nov 10 2020, 2:39 AM · Unknown Object (Project)
sgraenitz added a reviewer for D90789: [docs] Update DebuggingJITedCode page after fix in LLDB: AlexDenisov.
Nov 10 2020, 2:35 AM · Restricted Project
sgraenitz added reviewers for D90789: [docs] Update DebuggingJITedCode page after fix in LLDB: loladiro, yurydelendik, lhames, anarazel.
Nov 10 2020, 2:34 AM · Restricted Project

Nov 6 2020

sgraenitz added a comment to D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB).

That's right, but I don't see how even the static ones could be resolved. Wouldn't it hard-wire the objects together? In the next session we want to load some object files from cache while others have changed.. Maybe one day I should check how ccache and the likes handle it.

Nov 6 2020, 9:58 AM · Unknown Object (Project)

Nov 5 2020

sgraenitz added a comment to D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB).

Thanks for having a look!

Nov 5 2020, 10:13 AM · Unknown Object (Project)
sgraenitz requested review of D90860: [JITLink][ELF] Route objects to their matching linker backends based on header info.
Nov 5 2020, 9:21 AM · Restricted Project

Nov 4 2020

sgraenitz added a comment to D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.

LLDB regression https://bugs.llvm.org/show_bug.cgi?id=36209 fixed with D61611 and D90769

Nov 4 2020, 1:19 PM · Restricted Project
sgraenitz added a comment to D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.

Preview for the update: https://weliveindetail.github.io/docs-pub/html/DebuggingJITedCode.html

Nov 4 2020, 1:09 PM · Restricted Project
sgraenitz requested review of D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.
Nov 4 2020, 1:06 PM · Restricted Project
sgraenitz requested review of D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB).
Nov 4 2020, 8:45 AM · Unknown Object (Project)
sgraenitz committed rG694c16a82386: [JITLink][ELF] Omit temporary labels in tests (authored by sgraenitz).
[JITLink][ELF] Omit temporary labels in tests
Nov 4 2020, 2:05 AM
sgraenitz closed D90676: [JITLink][ELF] Omit temporary labels in tests.
Nov 4 2020, 2:04 AM · Restricted Project

Nov 3 2020

sgraenitz added a comment to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Two issues when trying to build llvm-jitlink-executor with the libs separated:

Nov 3 2020, 8:08 AM · Restricted Project
sgraenitz added a comment to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

I'm curious to get your take on the library breakdown and corresponding headers too.

There's a number of includes still pointing to #include "llvm/ExecutionEngine/Orc/TargetProcess/XY". Otherwise, yes LGTM.

Nov 3 2020, 5:07 AM · Restricted Project
sgraenitz added a comment to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

I'm curious to get your take on the library breakdown and corresponding headers too.

Nov 3 2020, 4:36 AM · Restricted Project
sgraenitz added a comment to D90331: [JITLink][ELF] Implement R_X86_64_PLT32 relocations.

Such a oneshot temporary label can usually be omitted:

Nov 3 2020, 4:15 AM · Restricted Project
sgraenitz requested review of D90676: [JITLink][ELF] Omit temporary labels in tests.
Nov 3 2020, 4:12 AM · Restricted Project
sgraenitz committed rGb397795f1a2f: [JITLink][ELF] Implement R_X86_64_PLT32 relocations (authored by sgraenitz).
[JITLink][ELF] Implement R_X86_64_PLT32 relocations
Nov 3 2020, 4:09 AM
sgraenitz closed D90331: [JITLink][ELF] Implement R_X86_64_PLT32 relocations.
Nov 3 2020, 4:09 AM · Restricted Project

Oct 28 2020

sgraenitz updated the diff for D90331: [JITLink][ELF] Implement R_X86_64_PLT32 relocations.

Polish comments and variable names in test

Oct 28 2020, 2:57 PM · Restricted Project
sgraenitz requested review of D90331: [JITLink][ELF] Implement R_X86_64_PLT32 relocations.
Oct 28 2020, 12:11 PM · Restricted Project

Oct 27 2020

sgraenitz added inline comments to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..
Oct 27 2020, 7:48 AM · Restricted Project

Oct 26 2020

sgraenitz added a comment to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Great that there is so fast progress! Haven't reviewed in detail (yet), but it looks like there are no conceptual changes compared to the proposal we know? A few notes inline.

Oct 26 2020, 11:23 AM · Restricted Project

Oct 24 2020

sgraenitz added a reverting change for rG10b1a61bafba: Revert "[jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON": rG66abe650fff6: Reapply "[jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON".
Oct 24 2020, 8:01 AM
sgraenitz committed rG66abe650fff6: Reapply "[jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON" (authored by sgraenitz).
Reapply "[jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON"
Oct 24 2020, 8:01 AM
sgraenitz committed rGb6ef40891c7f: [JITLink][ELF] PCRel32GOTLoad edge offset can be smaller three (authored by sgraenitz).
[JITLink][ELF] PCRel32GOTLoad edge offset can be smaller three
Oct 24 2020, 8:01 AM
sgraenitz added a reverting change for rGe9955b0843cc: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON: rG10b1a61bafba: Revert "[jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON".
Oct 24 2020, 6:44 AM
sgraenitz committed rG10b1a61bafba: Revert "[jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON" (authored by sgraenitz).
Revert "[jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON"
Oct 24 2020, 6:44 AM
sgraenitz added a reverting change for D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON: rG10b1a61bafba: Revert "[jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON".
Oct 24 2020, 6:44 AM · Restricted Project
sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

One note on the optimizeELF_x86_64_GOTAndStubs pass that had to be considered for this patch: it currently only relaxes edges for MOVQ instructions to LEA and we avoid that in the test by using a MOVL. If I understand correctly, LLD doesn't have this restriction. It relaxes MOVQ to LEAQ and MOVL to LEAL. For reference see https://reviews.llvm.org/D15779#change-f8vl5AmubNpC

Oct 24 2020, 6:04 AM · Restricted Project
sgraenitz committed rGe9955b0843cc: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON (authored by sgraenitz).
[jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON
Oct 24 2020, 5:57 AM
sgraenitz committed rG138b9f192845: [JITLink][ELF] PCRel32GOTLoad relocations are resolved like regular PCRel32 ones (authored by sgraenitz).
[JITLink][ELF] PCRel32GOTLoad relocations are resolved like regular PCRel32 ones
Oct 24 2020, 5:56 AM
sgraenitz closed D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.
Oct 24 2020, 5:56 AM · Restricted Project
sgraenitz updated the diff for D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

With movl we have to target eax

Oct 24 2020, 5:26 AM · Restricted Project

Oct 23 2020

sgraenitz updated the diff for D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

Prevent the optimizer from relaxing the edge by using a movl instruction (anyway it's been only 4 bytes all the time)

Oct 23 2020, 1:44 PM · Restricted Project
sgraenitz added a comment to rG996a8b42aa2d: Re-apply "[JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation".

I think it's not a big deal, but you may want to revert the named_data change. See inline comment.

Oct 23 2020, 1:32 PM
sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

Skipping the optimization pass, I had expected to get something like movq 0x1ff9(%rip), %rax but instead it's:

dis -s 0x00007ffff7ff5000 -e 0x00007ffff7ff5010
    0x7ffff7ff5000: movq   (%rip), %rax
Oct 23 2020, 8:30 AM · Restricted Project
sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

I didn't get the test to work yet. Neither with a R_X86_64_REX_GOTPCRELX relocation for common_data (TOT clang and llvm-mc emit that, llvm-mc-10 too btw) nor with R_X86_64_GOTPCREL (clang-10). Some observations in the following.

Oct 23 2020, 8:08 AM · Restricted Project
sgraenitz updated the diff for D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

Add test ELF_x86-64_common

Oct 23 2020, 7:48 AM · Restricted Project
sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

Yes, that brings up the issue with relaxed R_X86_64_REX_GOTPCRELX (42) relocations you mentioned in Discord: JIT session error: Unsupported x86-64 relocation:42 I will check whether we can map it to PCRel32GOTLoad or otherwise what's the difference.

Oct 23 2020, 5:34 AM · Restricted Project
sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

Thanks for coming up with a test case. I haven't looked into llvm-jitlink's check code yet. That serves a an excellent starting point!

Oct 23 2020, 5:31 AM · Restricted Project

Oct 22 2020

sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

The ELF spec has an extra paragraph for special handling in dynamic linkers. I am not sure how much it's relevant here:

When the dynamic linker encounters a reference to a symbol that resolves to a definition of type STT_COMMON, it may (but is not required to) change its symbol resolution rules as follows: instead of binding the reference to the first symbol found with the given name, the dynamic linker searches for the first symbol with that name with type other than STT_COMMON. If no such symbol is found, it looks for the STT_COMMON definition of that name that has the largest size.
Oct 22 2020, 12:28 PM · Restricted Project
sgraenitz retitled D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON from [jitlink][ELF] Allocate SHN_COMMON symbols as uninitialized blocks in __common to [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.
Oct 22 2020, 12:27 PM · Restricted Project
sgraenitz updated the diff for D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

Polish comments

Oct 22 2020, 12:27 PM · Restricted Project
sgraenitz updated the diff for D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

Drop unrelated switch case R_X86_64_32S

Oct 22 2020, 12:19 PM · Restricted Project
sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

Of course, I must compile with -fPIC to avoid relocation types like R_X86_64_32S in the first place. Looking into the test case now.

Oct 22 2020, 9:17 AM · Restricted Project
sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

It turned out the SIGSEGV: invalid address is caused by not handling the R_X86_64_32S type correctly. This is somewhat unrelated, but must be fixed in order to come up with a test case.

Oct 22 2020, 8:50 AM · Restricted Project
sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

Relocations to the common section seem to be calculated correctly now, but at runtime I see a SIGSEGV: invalid address. Maybe memory for the section isn't allocated?

Oct 22 2020, 6:15 AM · Restricted Project
sgraenitz updated the diff for D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

Fix NULL entry in symbol table

Oct 22 2020, 6:08 AM · Restricted Project

Oct 21 2020

sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.
Oct 21 2020, 1:32 PM · Restricted Project

Oct 20 2020

sgraenitz added a comment to D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

FYI The issue came up when I was trying to jitlink gzip: https://people.csail.mit.edu/smcc/projects/single-file-programs/gzip.c Next step would be an isolated test case.

Oct 20 2020, 7:54 AM · Restricted Project
sgraenitz requested review of D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.
Oct 20 2020, 7:51 AM · Restricted Project

Oct 1 2020

sgraenitz committed rG306571cc4642: [ORC][examples] Temporarily remove LLJITWithChildProcess until ORC TPC lands (authored by sgraenitz).
[ORC][examples] Temporarily remove LLJITWithChildProcess until ORC TPC lands
Oct 1 2020, 1:30 AM
sgraenitz committed rGe5795a1b364d: [ORC][examples] Remove ThinLtoJIT example after LLJITWithThinLTOSummaries… (authored by sgraenitz).
[ORC][examples] Remove ThinLtoJIT example after LLJITWithThinLTOSummaries…
Oct 1 2020, 1:30 AM

Aug 23 2020

sgraenitz added a comment to D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples.

Looks good. Two bots failed, both unrelated to my change.
http://green.lab.llvm.org/green/job/lldb-cmake/23457/
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/17430/

Aug 23 2020, 12:04 PM · Restricted Project
sgraenitz committed rGb014cc0f655d: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples (authored by sgraenitz).
[ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples
Aug 23 2020, 5:05 AM
sgraenitz closed D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples.
Aug 23 2020, 5:05 AM · Restricted Project

Aug 20 2020

sgraenitz added a comment to D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples.

Back to the review: I'd like to keep the test for the example and see how the build servers behave. Generally it might be useful to have tests for all the "LLJITWith..." examples right?
Do you think it makes sense to land the patch on the weekend in order to keep the number of people getting annoyed by me breaking their builds at a minimum? :)

Aug 20 2020, 12:58 PM · Restricted Project
sgraenitz added a comment to D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples.

I will get back to performance evaluation maybe in a few weeks and sure I am happy to share my progress.

Aug 20 2020, 12:52 PM · Restricted Project

Aug 15 2020

sgraenitz updated the diff for D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples.

Fix clang-tidy warnings

Aug 15 2020, 5:12 AM · Restricted Project

Aug 14 2020

sgraenitz updated the diff for D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples.

Fix clang-format issue and rebase

Aug 14 2020, 11:00 AM · Restricted Project
sgraenitz added a comment to D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples.

What performance issues did you run in to with threading and performance? I haven't had a chance to look in to that yet.

Aug 14 2020, 10:28 AM · Restricted Project
sgraenitz committed rG63aed9cbe5b0: [ORC] Build LLJITWithChildProcess example only on UNIX host systems (authored by sgraenitz).
[ORC] Build LLJITWithChildProcess example only on UNIX host systems
Aug 14 2020, 9:09 AM
sgraenitz updated the diff for D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples.

Test discovery should ignore subdirectories that contain test inputs.

Aug 14 2020, 8:05 AM · Restricted Project
sgraenitz abandoned D72176: Make ErrorList class default constructible and add simple push_back() method.
Aug 14 2020, 8:00 AM · Restricted Project
sgraenitz abandoned D73837: Add minimal test for the ThinLtoJIT example.
Aug 14 2020, 7:59 AM · Restricted Project
sgraenitz abandoned D75087: [ORC] Add LookupKind::TransitiveStatic for linker-resolved transitive dependencies.
Aug 14 2020, 7:59 AM · Restricted Project
sgraenitz abandoned D75090: [ORC] Align weak definition handling in JITDylib::defineMaterializing() and JITDylib::defineImpl().
Aug 14 2020, 7:58 AM · Restricted Project
sgraenitz added a comment to D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples.

I would like to remove the ThinLtoJIT example. It needs a more decent threading library to speed-up multithreaded compile times and that's easier to do out-of-tree.
This might be a useful (minimal) portion to keep in-tree. What do you think?

Aug 14 2020, 7:56 AM · Restricted Project
sgraenitz requested review of D85974: [ORC] Add a LLJITWithThinLTOSummaries example in OrcV2Examples.
Aug 14 2020, 7:47 AM · Restricted Project
sgraenitz added a comment to D85919: [ORC] Add JITLink-compatible remote memory-manager and LLJITWithChildProcess example.

Fixed with commit 28e1015e327ec56ac4bf93967d3aa2915b215e36

Aug 14 2020, 3:10 AM · Restricted Project