Page MenuHomePhabricator

sgraenitz (Stefan Gränitz)
dev

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2018, 11:23 AM (178 w, 1 d)

We may think in generalities, but weliveindetail

Recent Activity

Thu, Nov 11

sgraenitz added inline comments to D112451: implemented R_AARCH64_ADR_PREL_PG_HI21, R_AARCH64_ADR_PREL_PG_HI21_NC, R_AARCH64_ADD_ABS_LO12_NC.
Thu, Nov 11, 9:50 AM · Restricted Project

Oct 25 2021

sgraenitz added inline comments to D112451: implemented R_AARCH64_ADR_PREL_PG_HI21, R_AARCH64_ADR_PREL_PG_HI21_NC, R_AARCH64_ADD_ABS_LO12_NC.
Oct 25 2021, 12:11 PM · Restricted Project
sgraenitz added a comment to D112451: implemented R_AARCH64_ADR_PREL_PG_HI21, R_AARCH64_ADR_PREL_PG_HI21_NC, R_AARCH64_ADD_ABS_LO12_NC.

it always fall into OutOfRangeError

Oct 25 2021, 12:07 PM · Restricted Project
sgraenitz committed rGcdb335ffaff2: [JITLink] Fix warning 'shift count exceeds width' in AArch64 backend (authored by sgraenitz).
[JITLink] Fix warning 'shift count exceeds width' in AArch64 backend
Oct 25 2021, 11:45 AM
sgraenitz added a comment to D112451: implemented R_AARCH64_ADR_PREL_PG_HI21, R_AARCH64_ADR_PREL_PG_HI21_NC, R_AARCH64_ADD_ABS_LO12_NC.

Hi Kelvin, thanks for working on this. I will run your patch through my pi tonight and see how I can help.

Oct 25 2021, 7:13 AM · Restricted Project

Oct 23 2021

sgraenitz abandoned D104016: [Orc][examples] Join ListenerThread on early exit in LLJITWithRemoteDebugging.

Eventually this should be fixed with 878060aaf965

Oct 23 2021, 1:19 PM · Restricted Project
sgraenitz committed rG878060aaf965: [Orc][examples] Re-enable test for LLJITWithRemoteDebugging (authored by sgraenitz).
[Orc][examples] Re-enable test for LLJITWithRemoteDebugging
Oct 23 2021, 8:01 AM
sgraenitz closed D110649: [ORC][examples] Re-enable test for LLJITWithRemoteDebugging.
Oct 23 2021, 8:01 AM · Restricted Project

Oct 11 2021

sgraenitz committed rGa6c9506365fb: [Orc] Handle hangup messages in SimpleRemoteEPC (authored by sgraenitz).
[Orc] Handle hangup messages in SimpleRemoteEPC
Oct 11 2021, 12:05 PM
sgraenitz closed D111527: [Orc] Handle hangup messages in SimpleRemoteEPC.
Oct 11 2021, 12:05 PM · Restricted Project
sgraenitz abandoned D111528: [Orc] Allow in-band errors for runAsMain() via SPS.

Passing a valid function address is the responsibility of the user and laying out argv correctly is an ABI detail. If anything like this fails, we probably have to hang up anyway and send the error with that D111527.

Oct 11 2021, 11:33 AM · Restricted Project
sgraenitz requested review of D111528: [Orc] Allow in-band errors for runAsMain() via SPS.
Oct 11 2021, 1:39 AM · Restricted Project
sgraenitz requested review of D111527: [Orc] Handle hangup messages in SimpleRemoteEPC.
Oct 11 2021, 1:33 AM · Restricted Project

Sep 29 2021

sgraenitz abandoned D110530: [ORC] Avoid deadlocks in ObjectLinkingLayer plugins with blocking finalize handlers.

Thanks for confirming the issue. Aiming for a more thorough solution is fine for me. I committed the SimpleRemoteEPC port for the LLJITWithRemnoteDebugging example with ac2daacb310cbb1732de1c139be7a0e8e982169e even though it's not fully functional yet, because it drops the last in-tree dependency to the old OrcRPC implementation. Once we have a fix for the threading issue here, I will re-enable the test for the example (see D110649).

Sep 29 2021, 2:56 AM · Restricted Project
sgraenitz added a comment to D110649: [ORC][examples] Re-enable test for LLJITWithRemoteDebugging.

SimpleRemoteEPC port of the LLJITWithRemoteDebugging example landed with ac2daacb310cbb1732de1c139be7a0e8e982169e

Sep 29 2021, 1:26 AM · Restricted Project
sgraenitz committed rGac2daacb310c: [ORC][examples] Port LLJITWithRemoteDebugging to SimpleRemoteEPC (authored by sgraenitz).
[ORC][examples] Port LLJITWithRemoteDebugging to SimpleRemoteEPC
Sep 29 2021, 1:25 AM

Sep 28 2021

sgraenitz requested review of D110649: [ORC][examples] Re-enable test for LLJITWithRemoteDebugging.
Sep 28 2021, 12:38 PM · Restricted Project
sgraenitz requested review of D110615: [ORC] SimpleRemoteEPCServer: exit gracefully when detecting invalid connection.
Sep 28 2021, 2:25 AM · Restricted Project

Sep 27 2021

sgraenitz added a comment to D110484: [clang-repl] Allow loading of plugins in clang-repl..

Two minor comments. Otherwise LGTM.

Sep 27 2021, 6:23 AM · Restricted Project
sgraenitz added a comment to D110530: [ORC] Avoid deadlocks in ObjectLinkingLayer plugins with blocking finalize handlers.

Using the plugin's very own DebugObject::finalizeAsync() is not sufficient

Sep 27 2021, 4:02 AM · Restricted Project
sgraenitz requested review of D110530: [ORC] Avoid deadlocks in ObjectLinkingLayer plugins with blocking finalize handlers.
Sep 27 2021, 3:58 AM · Restricted Project

Sep 23 2021

sgraenitz committed rG1286bbc85f42: [ORC][examples] Export exectuable symbols explicitly in… (authored by sgraenitz).
[ORC][examples] Export exectuable symbols explicitly in…
Sep 23 2021, 12:40 PM
sgraenitz closed D110345: [ORC][examples] Export exectuable symbols explicitly in LLJITWithExecutorProcessControl.
Sep 23 2021, 12:40 PM · Restricted Project
sgraenitz added a comment to D110260: [ORC] Minor renaming and typo fixes (NFC).

FYI Included one more typo fix in ExecutorAddress.h

Sep 23 2021, 12:36 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D110345: [ORC][examples] Export exectuable symbols explicitly in LLJITWithExecutorProcessControl.

FYI Included one more typo fix in ExecutorAddress.h (Edit: This was in the other review.)

Sep 23 2021, 12:34 PM · Restricted Project
sgraenitz committed rG767b328e506e: [ORC] Minor renaming and typo fixes (NFC) (authored by sgraenitz).
[ORC] Minor renaming and typo fixes (NFC)
Sep 23 2021, 12:34 PM
sgraenitz closed D110260: [ORC] Minor renaming and typo fixes (NFC).
Sep 23 2021, 12:34 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D110345: [ORC][examples] Export exectuable symbols explicitly in LLJITWithExecutorProcessControl.

Issue reported during review D110260. With this fix, nm should return something like this now:

➜ nm bin/LLJITWithExecutorProcessControl | grep return1
0000000100004c10 T _return1
Sep 23 2021, 9:58 AM · Restricted Project
sgraenitz requested review of D110345: [ORC][examples] Export exectuable symbols explicitly in LLJITWithExecutorProcessControl.
Sep 23 2021, 9:56 AM · Restricted Project
sgraenitz added a comment to D110260: [ORC] Minor renaming and typo fixes (NFC).

Yeah we need testcases, now it says

JIT session error: Symbols not found: [ return1 ]
JIT session error: Failed to materialize symbols: { (main, { foo_body }) }
Unable to lazily compile function. Exiting.

Sep 23 2021, 9:42 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D110260: [ORC] Minor renaming and typo fixes (NFC).

Thanks @xgupta for your note! The parameter passed to EPCIndirectionUtils::Create() in the example was referencing a moved-from value. This caused the segfault. Unfortunately, the examples don't have good test coverage so far.

Sep 23 2021, 7:38 AM · Restricted Project, Restricted Project
sgraenitz committed rG828422747d65: [ORC][examples] Fix segfault in LLJITWithTargetProcessControl (authored by sgraenitz).
[ORC][examples] Fix segfault in LLJITWithTargetProcessControl
Sep 23 2021, 7:34 AM

Sep 22 2021

sgraenitz committed rG2131eb696386: [ORC] DebugObjectManagerPlugin tests can use lli in ORC greedy mode (authored by sgraenitz).
[ORC] DebugObjectManagerPlugin tests can use lli in ORC greedy mode
Sep 22 2021, 9:28 AM
sgraenitz updated subscribers of rG506dbd88fe8f: [ORC] Re-enable ELF DebugObjectManagerPlugin tests.

@mgorny I hope it's not breaking your test suites again?

Sep 22 2021, 8:59 AM
sgraenitz committed rG506dbd88fe8f: [ORC] Re-enable ELF DebugObjectManagerPlugin tests (authored by sgraenitz).
[ORC] Re-enable ELF DebugObjectManagerPlugin tests
Sep 22 2021, 8:58 AM
sgraenitz requested review of D110260: [ORC] Minor renaming and typo fixes (NFC).
Sep 22 2021, 8:53 AM · Restricted Project, Restricted Project
sgraenitz committed rG9689c1b7bb77: [lldb] JITLoaderGDB tests can use lli in ORC greedy mode (authored by sgraenitz).
[lldb] JITLoaderGDB tests can use lli in ORC greedy mode
Sep 22 2021, 5:46 AM

Sep 20 2021

sgraenitz added a comment to D110066: Regression Fix : __jit_debug_descriptor bind on Windows O/S (updated - formatting).

Thanks for working on this. The formatting nits should be straightforward to fix. Apart from that, it would be really nice if the jit-loader_jitlink/rtdyld_elf.test tests could reflect this fix. Otherwise it might regress again any time.

Sep 20 2021, 1:29 PM
sgraenitz updated subscribers of rG68914dc99083: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).

You're right, it's been a bad merge. In the meantime @GMNGeoffrey fixed it with 01b097afd0ea. Sorry for the inconvenience.

Sep 20 2021, 1:17 PM
sgraenitz added a comment to rG01b097afd0ea: Fix bad merge the removed switch case.

@GMNGeoffrey You'er right, thanks for the fix. I've been distracted the whole day.

Sep 20 2021, 1:13 PM
sgraenitz added a comment to D105429: [JITLink][RISCV] Initial Support RISCV64 in JITLink.

It think someone need to accept this revision now to close it.

Sep 20 2021, 6:54 AM · Restricted Project
sgraenitz committed rGe8d81d80f660: [JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC) (authored by sgraenitz).
[JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC)
Sep 20 2021, 6:47 AM
sgraenitz committed rG68914dc99083: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC) (authored by sgraenitz).
[JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC)
Sep 20 2021, 6:47 AM
sgraenitz closed D109522: [JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC).
Sep 20 2021, 6:47 AM · Restricted Project
sgraenitz closed D109520: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).
Sep 20 2021, 6:47 AM · Restricted Project

Sep 17 2021

sgraenitz added a comment to D109520: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).

Ping! I was hoping to land this together with D109522.

Sep 17 2021, 8:28 AM · Restricted Project

Sep 13 2021

sgraenitz added inline comments to D109522: [JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC).
Sep 13 2021, 6:48 AM · Restricted Project
sgraenitz updated the diff for D109522: [JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC).

Account for modifications in the underlying patch

Sep 13 2021, 6:47 AM · Restricted Project
sgraenitz updated the diff for D109520: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).

Account for modifications in the underlying patch && address pre-merge checks

Sep 13 2021, 6:19 AM · Restricted Project
sgraenitz committed rG96918515827b: [JITLink] Factor out forEachRelocation() function from addRelocations() in ELF… (authored by sgraenitz).
[JITLink] Factor out forEachRelocation() function from addRelocations() in ELF…
Sep 13 2021, 6:00 AM
sgraenitz closed D109516: [JITLink] Factor out forEachRelocation() function from addRelocations() in ELF Aarch64 backend (NFC).
Sep 13 2021, 5:59 AM · Restricted Project

Sep 11 2021

sgraenitz added a comment to D109516: [JITLink] Factor out forEachRelocation() function from addRelocations() in ELF Aarch64 backend (NFC).

Is there a reason that forEachRelocation works one-section-at-a-time? I thought that forEachRelocation could embed the loop over the sections within it to simplify addRelocations further.

Sep 11 2021, 3:36 PM · Restricted Project
sgraenitz added inline comments to D109516: [JITLink] Factor out forEachRelocation() function from addRelocations() in ELF Aarch64 backend (NFC).
Sep 11 2021, 3:33 PM · Restricted Project
sgraenitz updated the diff for D109516: [JITLink] Factor out forEachRelocation() function from addRelocations() in ELF Aarch64 backend (NFC).

Turn std::function into template parameter

Sep 11 2021, 3:33 PM · Restricted Project

Sep 9 2021

sgraenitz added a comment to D109522: [JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC).

The patch aims to be NFC (except debug output format). Please ping me if I introduced a functional change by accident.

Sep 9 2021, 9:29 AM · Restricted Project
sgraenitz requested review of D109522: [JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC).
Sep 9 2021, 9:28 AM · Restricted Project
sgraenitz added a comment to D109520: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).

The patch aims to be NFC (except debug output format). Please ping me if I introduced a functional change by accident.

Sep 9 2021, 9:24 AM · Restricted Project
sgraenitz requested review of D109520: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).
Sep 9 2021, 9:22 AM · Restricted Project
sgraenitz added a comment to D109516: [JITLink] Factor out forEachRelocation() function from addRelocations() in ELF Aarch64 backend (NFC).

As discussed in D108986. Furthermore the patch:

  • aligns the format of debug output with the MachO implementation (seemed more comprehensible)
  • aims to be NFC otherwise -- ping me if I introduced a functional change by accident
  • replaces auto with concrete type names where they aren't obvious or irrelevant
  • tries to use more consistent names
Sep 9 2021, 9:08 AM · Restricted Project
sgraenitz requested review of D109516: [JITLink] Factor out forEachRelocation() function from addRelocations() in ELF Aarch64 backend (NFC).
Sep 9 2021, 8:57 AM · Restricted Project

Sep 3 2021

sgraenitz committed rG2ed91da0f1f3: [JITLink] Add initial Aarch64 support (authored by sgraenitz).
[JITLink] Add initial Aarch64 support
Sep 3 2021, 1:53 AM
sgraenitz closed D108986: [JITLink] Add initial Aarch64 support.
Sep 3 2021, 1:52 AM · Restricted Project
sgraenitz added inline comments to D108986: [JITLink] Add initial Aarch64 support.
Sep 3 2021, 1:51 AM · Restricted Project

Aug 31 2021

sgraenitz added a reviewer for D108986: [JITLink] Add initial Aarch64 support: Kelvinyu1117.
Aug 31 2021, 8:47 AM · Restricted Project
sgraenitz updated the diff for D108986: [JITLink] Add initial Aarch64 support.

Basic polishing

Aug 31 2021, 6:12 AM · Restricted Project
sgraenitz added a comment to D108986: [JITLink] Add initial Aarch64 support.

This is an early draft and it will require polishing here and there. Please don't hesitate to propose improvements.

Aug 31 2021, 5:10 AM · Restricted Project
sgraenitz updated the summary of D108986: [JITLink] Add initial Aarch64 support.
Aug 31 2021, 5:09 AM · Restricted Project
sgraenitz requested review of D108986: [JITLink] Add initial Aarch64 support.
Aug 31 2021, 4:57 AM · Restricted Project

Aug 27 2021

sgraenitz added a comment to D95747: Fix modules build for LLVMOrcShared.

Hi Lang, thanks for your notes. I will leave this here as a reminder for myself and revisit the plan once it's time for the next release to branch.

Aug 27 2021, 5:50 AM · Restricted Project

Aug 11 2021

sgraenitz committed rGc5ab55f5331c: [Orc] Enable debug object tests only on x86_64 hosts (authored by sgraenitz).
[Orc] Enable debug object tests only on x86_64 hosts
Aug 11 2021, 3:10 AM
sgraenitz closed D107640: [Orc] Enable debug object tests only on x86_64 hosts.
Aug 11 2021, 3:10 AM · Restricted Project
sgraenitz retitled D107640: [Orc] Enable debug object tests only on x86_64 hosts from [Orc] Enable debug object tests only for 64-bit processes on x86_64 hosts to [Orc] Enable debug object tests only on x86_64 hosts.
Aug 11 2021, 3:07 AM · Restricted Project
sgraenitz updated the diff for D107640: [Orc] Enable debug object tests only on x86_64 hosts.

For the moment ignore 32-bit on x86_64

Aug 11 2021, 3:03 AM · Restricted Project
sgraenitz added a comment to D107640: [Orc] Enable debug object tests only on x86_64 hosts.

Just to confirm, the test suite passes for me (both i386 and amd64 build) with the following diff

Aug 11 2021, 3:00 AM · Restricted Project

Aug 6 2021

sgraenitz added a comment to D97694: [lli] Test debug support in RuntimeDyld with built-in functions.

For the moment D107640 limits the debug object tests to 64-bit processes on x86_64 hosts. This is what the debug plugin and tests were made for.

Aug 6 2021, 6:25 AM · Restricted Project
sgraenitz abandoned D107569: [ORC] Emit i386 indirections for 32-bit processes on x86_64 hosts.

I am still seeing segfaults in 32-bit builds even with the appropriate triple. Not sure what else is missing and right now I don't have the time to investigate the details. For the moment D107640 limits the debug object tests to 64-bit processes on x86_64 hosts. This is what the debug plugin and tests were made for.

Aug 6 2021, 6:24 AM · Restricted Project
sgraenitz requested review of D107640: [Orc] Enable debug object tests only on x86_64 hosts.
Aug 6 2021, 5:47 AM · Restricted Project
sgraenitz committed rG9c63e5b415d1: [Orc][examples] Temporarily disable tests for the C API due to failures on… (authored by sgraenitz).
[Orc][examples] Temporarily disable tests for the C API due to failures on…
Aug 6 2021, 2:33 AM
sgraenitz added a comment to D107569: [ORC] Emit i386 indirections for 32-bit processes on x86_64 hosts.

Why are we getting Triple::x86_64 rather than Triple::x86? I think we really want to add a Triple::x86 case and then figure out how to make sure the right triple is fed in.

Aug 6 2021, 2:29 AM · Restricted Project

Aug 5 2021

sgraenitz added inline comments to D107569: [ORC] Emit i386 indirections for 32-bit processes on x86_64 hosts.
Aug 5 2021, 8:24 AM · Restricted Project
sgraenitz added a comment to D107569: [ORC] Emit i386 indirections for 32-bit processes on x86_64 hosts.

I did debug the misbehavior in LazyCallThroughManager specifically and verified that this change fixes the issue. I assume that the approach can/should be used in IndirectStubsManager and JITCompileCallbackManager as well, but these cases don't seem to have test coverage right now.

Aug 5 2021, 8:14 AM · Restricted Project
sgraenitz requested review of D107569: [ORC] Emit i386 indirections for 32-bit processes on x86_64 hosts.
Aug 5 2021, 7:24 AM · Restricted Project

Jul 31 2021

sgraenitz added a comment to D97694: [lli] Test debug support in RuntimeDyld with built-in functions.

Yes, I can make some time for it next week. Do we have a bot that builds the relevant configuration? Otherwise, is it straightforward for you to reproduce on Linux with LLVM_BUILD_32_BITS=ON? Or does it take any extra steps/settings?

Jul 31 2021, 6:49 AM · Restricted Project

Jul 29 2021

sgraenitz committed rG058935145d6b: [Orc][examples] Adopt ExecutorProcessControl API and re-enable… (authored by sgraenitz).
[Orc][examples] Adopt ExecutorProcessControl API and re-enable…
Jul 29 2021, 5:41 AM

Jul 25 2021

sgraenitz committed rGe814b28eeb30: [docs] Update release notes to mention lli JIT engine switch (authored by sgraenitz).
[docs] Update release notes to mention lli JIT engine switch
Jul 25 2021, 3:00 PM

Jun 30 2021

sgraenitz accepted D104898: [clang-repl] Allow passing in code as positional arguments..

LGTM

Jun 30 2021, 8:48 AM · Restricted Project
sgraenitz added a comment to D104918: [clang-repl] Implement partial translation units and error recovery..

A few minor notes

Jun 30 2021, 8:05 AM · Restricted Project
sgraenitz accepted D104694: [ORC] Require TargetProcessControl instance when constructing ExecutionSession..

I prepared a patch for the LLJITWithRemoteDebugging example: https://github.com/weliveindetail/llvm-project/commits/arcpatch-D104694 It's still unix-only and I need to double-check that it doesn't break Windows bots, but otherwise this should work. Build and test are currently disabled on main, so landing the change from this review should not break it.

Jun 30 2021, 4:37 AM · Restricted Project

Jun 28 2021

sgraenitz committed rGe5d8cfb2f134: [Orc][examples] Temporarily disable LLJITWithRemoteDebugging build and test (authored by sgraenitz).
[Orc][examples] Temporarily disable LLJITWithRemoteDebugging build and test
Jun 28 2021, 7:55 AM
sgraenitz added a comment to D104694: [ORC] Require TargetProcessControl instance when constructing ExecutionSession..

Hi Lang

Jun 28 2021, 7:53 AM · Restricted Project

Jun 27 2021

sgraenitz added a comment to D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.

Got three buildbot failure mails with only me in the blamelist (thats a first), but they don't look like they are related to the change, but rather the build server having killed the compiler?
just to be sure, any action required by me?

Jun 27 2021, 7:12 AM · Restricted Project
sgraenitz closed D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.

Thanks for working on this.

Jun 27 2021, 4:59 AM · Restricted Project
sgraenitz committed rGf45eee270671: [Orc][examples] LLJITWithRemoteDebugger: fix CMake when utils are not built (authored by LittleFox94).
[Orc][examples] LLJITWithRemoteDebugger: fix CMake when utils are not built
Jun 27 2021, 4:55 AM

Jun 26 2021

sgraenitz accepted D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.
Jun 26 2021, 5:07 AM · Restricted Project
sgraenitz added a comment to D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.

Thanks for fixing this. Looks good to me!

Jun 26 2021, 5:07 AM · Restricted Project

Jun 10 2021

sgraenitz added a comment to D104016: [Orc][examples] Join ListenerThread on early exit in LLJITWithRemoteDebugging.

However, while investigating I found the threading issue that this patch aims to fix. @lhames Might the unjoined thread have caused the assertion failure in SymbolStringPool?

Jun 10 2021, 3:19 AM · Restricted Project
sgraenitz added a comment to D104016: [Orc][examples] Join ListenerThread on early exit in LLJITWithRemoteDebugging.

After commit 2f9ba6aa8b6d the test failure https://lab.llvm.org/buildbot/#/builders/61/builds/10796 occurred on one of the few build bots that include the examples. The patch doesn't affect any code exercised in this test and the bot turned green with the subsequent build. Thus, the test might be considered flaky. So far I failed to reproduce the exact error:

Jun 10 2021, 2:54 AM · Restricted Project
sgraenitz requested review of D104016: [Orc][examples] Join ListenerThread on early exit in LLJITWithRemoteDebugging.
Jun 10 2021, 2:42 AM · Restricted Project

May 21 2021

sgraenitz added a comment to D101835: [llvm] llvm-tapi-diff.

Hey, just a few notes on proper error handling.

May 21 2021, 3:00 AM · Restricted Project

May 10 2021

sgraenitz updated subscribers of D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.

We're already building runtime libraries, but in the tests it looks like we're building a parallel archive for the runtime and writing it to the test directory for the tests to link against. Is there a reason the tests can't just link against the built runtimes?

May 10 2021, 1:59 AM · Restricted Project