Page MenuHomePhabricator

segoon (Vasily Kulikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2020, 2:06 AM (10 w, 1 d)

Recent Activity

Today

segoon added a comment to D94622: [clang-tidy] add concurrency-async-no-new-threads.

Eugene.Zelenko, thanks for the review! fixed

Fri, Jan 15, 2:31 AM · Restricted Project, Restricted Project
segoon added a comment to D94621: [clang-tidy] add concurrency-async-fs.

Eugene.Zelenko, thanks for the review! fixed

Fri, Jan 15, 2:31 AM · Restricted Project, Restricted Project

Yesterday

segoon updated the diff for D94621: [clang-tidy] add concurrency-async-fs.
  • use back-ticks
  • fix the first document line
  • add default values
Thu, Jan 14, 8:07 AM · Restricted Project, Restricted Project
segoon updated the diff for D94622: [clang-tidy] add concurrency-async-no-new-threads.
  • fix the first document line
  • add default values
Thu, Jan 14, 8:02 AM · Restricted Project, Restricted Project
segoon added a comment to D94621: [clang-tidy] add concurrency-async-fs.

njames93, the purpose is to flag it indeed. This approach was found valueable in Yandex.Taxi, as it is very easy to forget that you're in a coroutine and may not use blocking API. The bug does affect performance (e.g. all coroutine threads wait for fs), it cannot be found by functional tests (as it is not a functional invariant violation) and may be rather tricky to debug (as the performance harm depends on many things like IO limits, page cache size, current load, etc.). It can be caught during code review, but it suffers from human errors. Rather than playing catch-me-if-you-can games, the check can be automated. As C/C++ standard libraries contain quite many blocking functions and C++20 gains official coroutine support, I find it valuable for the C++ community to have an already compiled list of such blocking functions and the check that uses it.

Thu, Jan 14, 4:55 AM · Restricted Project, Restricted Project

Wed, Jan 13

segoon added a reviewer for D94622: [clang-tidy] add concurrency-async-no-new-threads: njames93.
Wed, Jan 13, 11:15 AM · Restricted Project, Restricted Project
segoon added a reviewer for D94621: [clang-tidy] add concurrency-async-fs: njames93.
Wed, Jan 13, 11:15 AM · Restricted Project, Restricted Project
segoon requested review of D94622: [clang-tidy] add concurrency-async-no-new-threads.
Wed, Jan 13, 11:11 AM · Restricted Project, Restricted Project
segoon updated the diff for D94621: [clang-tidy] add concurrency-async-fs.

fix

Wed, Jan 13, 11:08 AM · Restricted Project, Restricted Project
segoon requested review of D94621: [clang-tidy] add concurrency-async-fs.
Wed, Jan 13, 11:07 AM · Restricted Project, Restricted Project

Mon, Jan 11

segoon added a comment to D93940: [clang-tidy] Add a check for blocking types and functions..

friendly ping, any comments on the patch?

Mon, Jan 11, 1:12 AM · Restricted Project, Restricted Project

Tue, Jan 5

segoon updated the summary of D93940: [clang-tidy] Add a check for blocking types and functions..
Tue, Jan 5, 10:15 AM · Restricted Project, Restricted Project
segoon updated the diff for D93940: [clang-tidy] Add a check for blocking types and functions..
  • review fixes
  • drop of atomic::is_always_lock_free check
Tue, Jan 5, 8:41 AM · Restricted Project, Restricted Project

Wed, Dec 30

segoon added inline comments to D93940: [clang-tidy] Add a check for blocking types and functions..
Wed, Dec 30, 11:39 AM · Restricted Project, Restricted Project
segoon added inline comments to D93940: [clang-tidy] Add a check for blocking types and functions..
Wed, Dec 30, 11:38 AM · Restricted Project, Restricted Project
segoon updated the diff for D93940: [clang-tidy] Add a check for blocking types and functions..

review fixes

Wed, Dec 30, 11:36 AM · Restricted Project, Restricted Project
segoon added reviewers for D93940: [clang-tidy] Add a check for blocking types and functions.: lebedev.ri, njames93.
Wed, Dec 30, 4:04 AM · Restricted Project, Restricted Project
segoon updated the diff for D93940: [clang-tidy] Add a check for blocking types and functions..

fix the mess

Wed, Dec 30, 4:01 AM · Restricted Project, Restricted Project
segoon updated the diff for D93940: [clang-tidy] Add a check for blocking types and functions..

up

Wed, Dec 30, 3:55 AM · Restricted Project, Restricted Project
segoon requested review of D93940: [clang-tidy] Add a check for blocking types and functions..
Wed, Dec 30, 3:44 AM · Restricted Project, Restricted Project

Nov 27 2020

segoon added a comment to D90944: [clang-tidy] implement concurrency-mt-unsafe.

Please upload all patches with full context (-U9999)

Nov 27 2020, 12:57 AM · Restricted Project, Restricted Project
segoon updated the diff for D90944: [clang-tidy] implement concurrency-mt-unsafe.
  • git diff -U9999
Nov 27 2020, 12:55 AM · Restricted Project, Restricted Project
segoon updated the diff for D91656: [clang-tidy] add concurrency module.
  • git dif -U9999
Nov 27 2020, 12:49 AM · Restricted Project, Restricted Project

Nov 26 2020

segoon updated the diff for D90944: [clang-tidy] implement concurrency-mt-unsafe.
  • revert decls marking
Nov 26 2020, 9:56 AM · Restricted Project, Restricted Project
segoon added a comment to D90944: [clang-tidy] implement concurrency-mt-unsafe.
  • mark mt-unsafe decls and check for marks in exprs

Eeeh.
I was thinking of either some smart matcher "match any function declaration
with name from these lists, and then match every call to said decl".

Nov 26 2020, 9:12 AM · Restricted Project, Restricted Project
segoon updated the diff for D90944: [clang-tidy] implement concurrency-mt-unsafe.
  • move static vectors out of namespace
  • mark mt-unsafe decls and check for marks in exprs
Nov 26 2020, 8:48 AM · Restricted Project, Restricted Project
segoon updated the diff for D91656: [clang-tidy] add concurrency module.
  • fix sort order
Nov 26 2020, 8:47 AM · Restricted Project, Restricted Project
segoon added a comment to D91656: [clang-tidy] add concurrency module.

lebedev.ri, any comments?

Nov 26 2020, 1:41 AM · Restricted Project, Restricted Project

Nov 23 2020

segoon added a comment to D91656: [clang-tidy] add concurrency module.

LGTM

Nov 23 2020, 4:56 AM · Restricted Project, Restricted Project
segoon updated the diff for D91656: [clang-tidy] add concurrency module.
  • sort order
  • do not link with FrontendOpenMP
Nov 23 2020, 4:24 AM · Restricted Project, Restricted Project
segoon added a comment to D91656: [clang-tidy] add concurrency module.

Any comments on the patch?

Nov 23 2020, 4:05 AM · Restricted Project, Restricted Project

Nov 18 2020

segoon added a comment to D91656: [clang-tidy] add concurrency module.

Can you remove the code related to adding the mt-unsafe-posix check.

Nov 18 2020, 4:10 AM · Restricted Project, Restricted Project
segoon updated the diff for D91656: [clang-tidy] add concurrency module.
  • remove garbage files
Nov 18 2020, 4:09 AM · Restricted Project, Restricted Project
segoon updated the diff for D91656: [clang-tidy] add concurrency module.
  • concurrent -> concurrency
Nov 18 2020, 2:46 AM · Restricted Project, Restricted Project
segoon updated the diff for D90944: [clang-tidy] implement concurrency-mt-unsafe.
  • concurrent -> concurrency
  • split the patch apart
Nov 18 2020, 2:45 AM · Restricted Project, Restricted Project

Nov 17 2020

segoon requested review of D91656: [clang-tidy] add concurrency module.
Nov 17 2020, 12:17 PM · Restricted Project, Restricted Project
segoon updated the diff for D90944: [clang-tidy] implement concurrency-mt-unsafe.
  • move plugin to concurrent group
  • naming fixes
  • use anyOf
  • Libc -> FunctionSet
Nov 17 2020, 6:23 AM · Restricted Project, Restricted Project
segoon added inline comments to D90944: [clang-tidy] implement concurrency-mt-unsafe.
Nov 17 2020, 4:55 AM · Restricted Project, Restricted Project

Nov 16 2020

segoon added a comment to D90944: [clang-tidy] implement concurrency-mt-unsafe.

What i would however like to be improved, is better docs.

Nov 16 2020, 3:50 AM · Restricted Project, Restricted Project
segoon updated the diff for D90944: [clang-tidy] implement concurrency-mt-unsafe.
  • minor changes to docs
Nov 16 2020, 3:48 AM · Restricted Project, Restricted Project

Nov 10 2020

segoon updated the diff for D90944: [clang-tidy] implement concurrency-mt-unsafe.
  • add Libc option
  • improve docs
Nov 10 2020, 7:56 AM · Restricted Project, Restricted Project

Nov 6 2020

segoon updated the diff for D90944: [clang-tidy] implement concurrency-mt-unsafe.
  • use static instead of namespace {}
  • don't use SourceRange()
  • revert unrelated changes to .rst
Nov 6 2020, 1:11 PM · Restricted Project, Restricted Project
segoon added a comment to D90944: [clang-tidy] implement concurrency-mt-unsafe.

It appears to not check for signs that the code is running in a multi threaded manner, This will result in many false positives in code that is known to be single threaded.

Nov 6 2020, 12:54 PM · Restricted Project, Restricted Project
segoon added inline comments to D90944: [clang-tidy] implement concurrency-mt-unsafe.
Nov 6 2020, 12:09 PM · Restricted Project, Restricted Project
segoon added inline comments to D90944: [clang-tidy] implement concurrency-mt-unsafe.
Nov 6 2020, 10:38 AM · Restricted Project, Restricted Project
segoon updated the diff for D90944: [clang-tidy] implement concurrency-mt-unsafe.

don't include any system headers in tests

Nov 6 2020, 10:37 AM · Restricted Project, Restricted Project
segoon requested review of D90944: [clang-tidy] implement concurrency-mt-unsafe.
Nov 6 2020, 7:05 AM · Restricted Project, Restricted Project