Page MenuHomePhabricator

sdmitriev (Sergey Dmitriev)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 7 2016, 2:42 PM (214 w, 5 d)

Recent Activity

Thu, Jan 14

sdmitriev added a comment to D94643: [llvm-link] Improve link time for bitcode archives [NFC].
In D94643#2498870, @tra wrote:

LGTM.

Do you have any measurements showing actual impact on performance or memory consumption?

Thu, Jan 14, 5:29 PM · Restricted Project
sdmitriev updated the diff for D94643: [llvm-link] Improve link time for bitcode archives [NFC].

Addressed review comment.

Thu, Jan 14, 5:26 PM · Restricted Project

Wed, Jan 13

sdmitriev requested review of D94643: [llvm-link] Improve link time for bitcode archives [NFC].
Wed, Jan 13, 6:22 PM · Restricted Project

Tue, Jan 5

sdmitriev committed rG761aca1e2e39: [llvm-link] fix linker behavior when linking archives with --only-needed option (authored by sdmitriev).
[llvm-link] fix linker behavior when linking archives with --only-needed option
Tue, Jan 5, 10:09 AM
sdmitriev closed D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.
Tue, Jan 5, 10:08 AM · Restricted Project

Mon, Jan 4

sdmitriev added inline comments to D80816: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives..
Mon, Jan 4, 12:54 AM · Restricted Project, Restricted Project

Mon, Dec 28

sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

Looks good to me. Please wait for @tra to accept it.

Mon, Dec 28, 8:39 AM · Restricted Project

Tue, Dec 22

sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

Well, it looks like nobody is going to respond.

Tue, Dec 22, 5:33 PM · Restricted Project

Dec 18 2020

sdmitriev added a reviewer for D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option: saiislam.
Dec 18 2020, 3:53 AM · Restricted Project
sdmitriev added inline comments to D80816: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives..
Dec 18 2020, 3:34 AM · Restricted Project, Restricted Project

Dec 14 2020

sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

ping

Dec 14 2020, 8:39 PM · Restricted Project

Dec 10 2020

sdmitriev updated the diff for D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

Updated diff after committing NFC changes (D92918).

Dec 10 2020, 12:17 AM · Restricted Project

Dec 9 2020

sdmitriev committed rG025d4faadb68: [llvm-link][NFC] Minor cleanup (authored by sdmitriev).
[llvm-link][NFC] Minor cleanup
Dec 9 2020, 11:18 PM
sdmitriev closed D92918: [llvm-link][NFC] Minor cleanup.
Dec 9 2020, 11:18 PM · Restricted Project
sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

I wonder if we want to go even further and bring archive linking closer to how static linking works with normal object files?
Instead of linking all files in the archive together (that may have its own set of issues) and returning a single module, perhaps we should just load individual files, return them as a vector and link each of them in order with --only-needed.

Dec 9 2020, 10:46 PM · Restricted Project
sdmitriev added a comment to D92918: [llvm-link][NFC] Minor cleanup.

Well, when you use a class you have to know the interface it defines, so this is not about the implementation details, but about the interface provided by the class. llvm::Linker::linkModules(), as it is defined today, is a static member of the class, so it does not require an instance of llvm::Linker class to be called. Adding an additional parameter to loadArFile just in case does not buy as anything at all except unneeded redundancy. And, by the way, this function is called as a static member (i.e. Linker::linkModules()) everywhere in LLVM sources except llvm-link.cpp:

Dec 9 2020, 5:51 PM · Restricted Project

Dec 8 2020

sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

I have prepared a separate patch for NFC changes D92918. Will update this patch once D92918 is approved.

Dec 8 2020, 11:33 PM · Restricted Project
sdmitriev requested review of D92918: [llvm-link][NFC] Minor cleanup.
Dec 8 2020, 11:31 PM · Restricted Project
sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.
In D92535#2440317, @tra wrote:

The patch description describes what the patch does, but does not tell us much about the problem is is supposed to fix.
Could you give us more details on why the patch is needed?

Dec 8 2020, 8:01 PM · Restricted Project

Dec 7 2020

sdmitriev added a reviewer for D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option: JDevlieghere.
Dec 7 2020, 6:55 PM · Restricted Project
sdmitriev added a reviewer for D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option: tra.
Dec 7 2020, 6:51 PM · Restricted Project
sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

Do you have any comments for this patch?

Dec 7 2020, 3:04 AM · Restricted Project

Dec 3 2020

sdmitriev updated the diff for D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

I have realized that this patch is not NFC, and it corrects llvm-link behavior when archive is linked with other inputs as a library (with --only-needed option). I have updated description and added LIT test to the patch.

Dec 3 2020, 1:44 AM · Restricted Project

Dec 2 2020

sdmitriev requested review of D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.
Dec 2 2020, 8:02 PM · Restricted Project
sdmitriev committed rG715ba18d3e11: [llvm-link] use file magic when deciding if input should be loaded as archive (authored by sdmitriev).
[llvm-link] use file magic when deciding if input should be loaded as archive
Dec 2 2020, 5:34 PM
sdmitriev updated the diff for D92376: [llvm-link] use file magic when deciding if input should be loaded as archive.

Added BinaryFormat to the list of components that need to be linked.

Dec 2 2020, 5:15 PM · Restricted Project
sdmitriev added a reverting change for rG55f8c2fdfbc5: [llvm-link] use file magic when deciding if input should be loaded as archive: rG9c955b79fb2b: Revert "[llvm-link] use file magic when deciding if input should be loaded as….
Dec 2 2020, 4:54 PM
sdmitriev committed rG9c955b79fb2b: Revert "[llvm-link] use file magic when deciding if input should be loaded as… (authored by sdmitriev).
Revert "[llvm-link] use file magic when deciding if input should be loaded as…
Dec 2 2020, 4:54 PM
sdmitriev added a reverting change for D92376: [llvm-link] use file magic when deciding if input should be loaded as archive: rG9c955b79fb2b: Revert "[llvm-link] use file magic when deciding if input should be loaded as….
Dec 2 2020, 4:54 PM · Restricted Project
sdmitriev committed rG55f8c2fdfbc5: [llvm-link] use file magic when deciding if input should be loaded as archive (authored by sdmitriev).
[llvm-link] use file magic when deciding if input should be loaded as archive
Dec 2 2020, 4:44 PM
sdmitriev closed D92376: [llvm-link] use file magic when deciding if input should be loaded as archive.
Dec 2 2020, 4:44 PM · Restricted Project

Dec 1 2020

sdmitriev requested review of D92376: [llvm-link] use file magic when deciding if input should be loaded as archive.
Dec 1 2020, 2:45 AM · Restricted Project

Nov 24 2020

sdmitriev added inline comments to D80816: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives..
Nov 24 2020, 8:13 PM · Restricted Project, Restricted Project
sdmitriev committed rG1b0ca81a6c35: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC] (authored by sdmitriev).
[clang-offload-bundler] use std::forward_list for storing temp file names [NFC]
Nov 24 2020, 8:09 AM
sdmitriev closed D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC].
Nov 24 2020, 8:09 AM · Restricted Project
sdmitriev added inline comments to D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC].
Nov 24 2020, 7:35 AM · Restricted Project
sdmitriev added inline comments to D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC].
Nov 24 2020, 6:55 AM · Restricted Project
sdmitriev requested review of D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC].
Nov 24 2020, 1:08 AM · Restricted Project

Nov 12 2020

sdmitriev added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Nov 12 2020, 12:52 AM · Restricted Project, Restricted Project

Jul 27 2020

sdmitriev committed rGbec77ece1489: [CallGraph] Preserve call records vector when replacing call edge (authored by sdmitriev).
[CallGraph] Preserve call records vector when replacing call edge
Jul 27 2020, 6:17 AM
sdmitriev closed D84295: [CallGraph] Preserve call records vector when replacing call edge.
Jul 27 2020, 6:16 AM · Restricted Project
sdmitriev updated the diff for D84295: [CallGraph] Preserve call records vector when replacing call edge.
Jul 27 2020, 12:41 AM · Restricted Project
sdmitriev updated the diff for D84295: [CallGraph] Preserve call records vector when replacing call edge.

Added unit test for the CallGraphNode::replaceCallEdge() change. Without this change test finishes with an assertion on windows debug build.

Jul 27 2020, 12:21 AM · Restricted Project

Jul 22 2020

sdmitriev added a comment to D84295: [CallGraph] Preserve call records vector when replacing call edge.

Yes, exactly. If the number of callbacks is the same we can avoid invalidating iterators. I assume that should really cover most of the cases.

Jul 22 2020, 7:46 PM · Restricted Project
sdmitriev updated the diff for D84295: [CallGraph] Preserve call records vector when replacing call edge.
Jul 22 2020, 2:02 AM · Restricted Project
Herald added a project to D84295: [CallGraph] Preserve call records vector when replacing call edge: Restricted Project.
Jul 22 2020, 1:41 AM · Restricted Project

Jul 13 2020

sdmitriev accepted D83718: [CallGraph] Update callback call sites in RefreshCallGraph.

LGTM

Jul 13 2020, 4:42 PM · Restricted Project

Jul 1 2020

sdmitriev committed rGcb8faaacb52c: [CallGraph] Add support for callback call sites (authored by sdmitriev).
[CallGraph] Add support for callback call sites
Jul 1 2020, 2:05 PM
sdmitriev closed D82572: [CallGraph] Add support for callback call sites.
Jul 1 2020, 2:05 PM · Restricted Project

Jun 28 2020

sdmitriev updated the diff for D82572: [CallGraph] Add support for callback call sites.

Rebase after committing NFC patch (D82686).

Jun 28 2020, 8:52 PM · Restricted Project
sdmitriev committed rG1becd298b82e: [NFC] CallGraph related cleanup (authored by sdmitriev).
[NFC] CallGraph related cleanup
Jun 28 2020, 4:06 PM
sdmitriev closed D82686: [NFC] CallGraph related cleanup.
Jun 28 2020, 4:06 PM · Restricted Project

Jun 26 2020

sdmitriev added a comment to D82572: [CallGraph] Add support for callback call sites.

Sure, I have separated NFC changes to D82686.

Jun 26 2020, 2:41 PM · Restricted Project
sdmitriev created D82686: [NFC] CallGraph related cleanup.
Jun 26 2020, 2:41 PM · Restricted Project
sdmitriev added inline comments to D82572: [CallGraph] Add support for callback call sites.
Jun 26 2020, 9:17 AM · Restricted Project

Jun 25 2020

sdmitriev updated the diff for D82572: [CallGraph] Add support for callback call sites.
Jun 25 2020, 7:08 PM · Restricted Project
sdmitriev added inline comments to D82572: [CallGraph] Add support for callback call sites.
Jun 25 2020, 6:02 PM · Restricted Project
sdmitriev updated the diff for D82572: [CallGraph] Add support for callback call sites.

One more fix for pre-merge check issues.

Jun 25 2020, 2:44 PM · Restricted Project
sdmitriev updated the diff for D82572: [CallGraph] Add support for callback call sites.

Fixed 'clang-format' issue reported by pre-merge checks.

Jun 25 2020, 10:13 AM · Restricted Project
sdmitriev created D82572: [CallGraph] Add support for callback call sites.
Jun 25 2020, 9:07 AM · Restricted Project

May 12 2020

sdmitriev committed rG32f5ee830b0f: [Attributor] Fixup block addresses after rewriting function signature (authored by sdmitriev).
[Attributor] Fixup block addresses after rewriting function signature
May 12 2020, 2:00 PM
sdmitriev closed D79801: [Attributor] Fixup block addresses after rewriting function signature.
May 12 2020, 2:00 PM · Restricted Project
sdmitriev created D79801: [Attributor] Fixup block addresses after rewriting function signature.
May 12 2020, 1:27 PM · Restricted Project

May 11 2020

sdmitriev committed rG3df40007e631: [Attributor] Fix for a crash on RAUW when rewriting function signature (authored by sdmitriev).
[Attributor] Fix for a crash on RAUW when rewriting function signature
May 11 2020, 8:35 AM
sdmitriev closed D79680: [Attributor] Fix for a crash on RAUW when rewriting function signature.
May 11 2020, 8:35 AM · Restricted Project

May 9 2020

sdmitriev created D79680: [Attributor] Fix for a crash on RAUW when rewriting function signature.
May 9 2020, 5:01 PM · Restricted Project

May 4 2020

sdmitriev committed rGf637334df93f: [CallGraphUpdater] Removed references to calles when deleting function (authored by sdmitriev).
[CallGraphUpdater] Removed references to calles when deleting function
May 4 2020, 7:23 PM
sdmitriev closed D79382: [CallGraphUpdater] Removed references to calles when deleting function.
May 4 2020, 7:23 PM · Restricted Project
sdmitriev created D79382: [CallGraphUpdater] Removed references to calles when deleting function.
May 4 2020, 5:46 PM · Restricted Project

May 3 2020

sdmitriev committed rG0f70f733080e: [Attributor] Bitcast constant to the returned value type if it has different… (authored by sdmitriev).
[Attributor] Bitcast constant to the returned value type if it has different…
May 3 2020, 12:14 PM
sdmitriev closed D79277: [Attributor] Bitcast constant to the returned value type if it has different type.
May 3 2020, 12:13 PM · Restricted Project

May 1 2020

sdmitriev updated the diff for D79277: [Attributor] Bitcast constant to the returned value type if it has different type.
May 1 2020, 5:53 PM · Restricted Project
sdmitriev added inline comments to D79277: [Attributor] Bitcast constant to the returned value type if it has different type.
May 1 2020, 5:37 PM · Restricted Project
sdmitriev created D79277: [Attributor] Bitcast constant to the returned value type if it has different type.
May 1 2020, 5:18 PM · Restricted Project

Apr 30 2020

sdmitriev committed rGcfea3dc10214: [AbstractCallSite] Look though constant cast expression when checking for… (authored by sdmitriev).
[AbstractCallSite] Look though constant cast expression when checking for…
Apr 30 2020, 3:39 PM
sdmitriev closed D79188: [AbstractCallSite] Look though constant cast expression when checking for callee use.
Apr 30 2020, 3:39 PM · Restricted Project
sdmitriev created D79188: [AbstractCallSite] Look though constant cast expression when checking for callee use.
Apr 30 2020, 11:15 AM · Restricted Project

Apr 25 2020

sdmitriev committed rG67aed1469b0f: [Attributor] Do not set 'returned' attribute for arguments that cannot be… (authored by sdmitriev).
[Attributor] Do not set 'returned' attribute for arguments that cannot be…
Apr 25 2020, 10:05 AM
sdmitriev closed D78828: [Attributor] Do not set 'returned' attribute for arguments that cannot be bitcasted to function result.
Apr 25 2020, 10:04 AM · Restricted Project

Apr 24 2020

sdmitriev created D78828: [Attributor] Do not set 'returned' attribute for arguments that cannot be bitcasted to function result.
Apr 24 2020, 12:59 PM · Restricted Project

Apr 14 2020

sdmitriev committed rGc1a9dd9aea49: [AbstractCallSite] Check that callback callee index is within call arguments (authored by sdmitriev).
[AbstractCallSite] Check that callback callee index is within call arguments
Apr 14 2020, 9:40 AM
sdmitriev closed D78112: [AbstractCallSite] Check that callback callee index is within call arguments.
Apr 14 2020, 9:39 AM · Restricted Project
sdmitriev created D78112: [AbstractCallSite] Check that callback callee index is within call arguments.
Apr 14 2020, 8:33 AM · Restricted Project

Jan 30 2020

sdmitriev committed rG5be2ca29217a: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef (authored by sdmitriev).
[Clang][Bundler][NFC] Replace SmallString<...> with StringRef
Jan 30 2020, 12:55 PM
sdmitriev closed D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef.
Jan 30 2020, 12:54 PM · Restricted Project
sdmitriev created D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef.
Jan 30 2020, 12:43 PM · Restricted Project
sdmitriev committed rG36bfdb7096cf: [Clang][Driver] Disable llvm passes for the first host OpenMP offload… (authored by sdmitriev).
[Clang][Driver] Disable llvm passes for the first host OpenMP offload…
Jan 30 2020, 10:31 AM
sdmitriev closed D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation.
Jan 30 2020, 10:30 AM · Restricted Project
sdmitriev created D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation.
Jan 30 2020, 9:29 AM · Restricted Project
sdmitriev committed rGc53cb2bdc78e: [Clang][Bundler] Reduce fat object size (authored by sdmitriev).
[Clang][Bundler] Reduce fat object size
Jan 30 2020, 8:32 AM
sdmitriev added a reverting change for D65819: [Driver][Bundler] Improve bundling of object files.: rGc53cb2bdc78e: [Clang][Bundler] Reduce fat object size.
Jan 30 2020, 8:32 AM · Restricted Project, Restricted Project
sdmitriev closed D73642: [Clang][Bundler] Reduce fat object size.
Jan 30 2020, 8:32 AM · Restricted Project
sdmitriev added a comment to D73642: [Clang][Bundler] Reduce fat object size.

@ABataev, do you have any additional comments?

Jan 30 2020, 7:45 AM · Restricted Project

Jan 29 2020

sdmitriev added inline comments to D73642: [Clang][Bundler] Reduce fat object size.
Jan 29 2020, 1:40 PM · Restricted Project
sdmitriev updated the diff for D73642: [Clang][Bundler] Reduce fat object size.

Addressed review comments.

Jan 29 2020, 1:40 PM · Restricted Project
sdmitriev updated the diff for D73642: [Clang][Bundler] Reduce fat object size.

Addressed review comments.

Jan 29 2020, 1:13 PM · Restricted Project
sdmitriev created D73642: [Clang][Bundler] Reduce fat object size.
Jan 29 2020, 9:58 AM · Restricted Project
sdmitriev added a reverting change for D65819: [Driver][Bundler] Improve bundling of object files.: D73642: [Clang][Bundler] Reduce fat object size.
Jan 29 2020, 9:58 AM · Restricted Project, Restricted Project
sdmitriev committed rG6e82d0dfd8df: [Clang][Bundler] Add 'exclude' flag to target objects sections (authored by sdmitriev).
[Clang][Bundler] Add 'exclude' flag to target objects sections
Jan 29 2020, 9:03 AM
sdmitriev closed D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections.
Jan 29 2020, 9:03 AM · Restricted Project