Page MenuHomePhabricator

rarutyun (Ruslan Arutyunyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2020, 3:30 PM (19 w, 2 d)

Recent Activity

Tue, Jan 12

rarutyun added inline comments to D90968: Fix for the Bug 41784.
Tue, Jan 12, 8:58 AM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Tue, Jan 12, 8:26 AM · Restricted Project
rarutyun added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

@rarutyun Can you please rebase onto main so that the CI will trigger? I added the LLVM monorepo tag to the review.

Tue, Jan 12, 7:54 AM · Restricted Project
rarutyun updated the diff for D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Tue, Jan 12, 7:32 AM · Restricted Project

Mon, Jan 11

rarutyun added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

Michael approved this review. Can we proceed?

Mon, Jan 11, 1:45 AM · Restricted Project

Tue, Dec 29

rarutyun added a comment to D90968: Fix for the Bug 41784.

Any progress on that review? Should I rebase it one more time?

Tue, Dec 29, 1:56 AM · Restricted Project

Mon, Dec 28

rarutyun added inline comments to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Mon, Dec 28, 1:55 PM · Restricted Project
rarutyun updated the diff for D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Mon, Dec 28, 1:51 PM · Restricted Project

Dec 14 2020

rarutyun added inline comments to D90968: Fix for the Bug 41784.
Dec 14 2020, 8:47 AM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Dec 14 2020, 8:47 AM · Restricted Project

Dec 10 2020

rarutyun added inline comments to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Dec 10 2020, 3:15 PM · Restricted Project
rarutyun updated the diff for D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Dec 10 2020, 2:46 PM · Restricted Project

Dec 9 2020

rarutyun added inline comments to D90968: Fix for the Bug 41784.
Dec 9 2020, 8:45 AM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Dec 9 2020, 8:43 AM · Restricted Project

Dec 8 2020

rarutyun added inline comments to D90968: Fix for the Bug 41784.
Dec 8 2020, 9:40 AM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Dec 8 2020, 9:33 AM · Restricted Project

Nov 26 2020

rarutyun added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

I also faintly remember that we already tried implementing this in libc++, didn't we?

Nov 26 2020, 3:27 AM · Restricted Project

Nov 24 2020

rarutyun removed 1 blocking reviewer(s) for D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit: Restricted Project.
Nov 24 2020, 10:06 AM · Restricted Project
rarutyun added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

Didn't find corresponding feature macro. Let me know if we need to do something with that.

Nov 24 2020, 10:05 AM · Restricted Project
rarutyun requested review of D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Nov 24 2020, 10:00 AM · Restricted Project

Nov 11 2020

rarutyun added a comment to D87171: Implement P0919R3.

I prepared the small change with adding the proper release version but I cannot upload the new diff. I guess that's because I am not author anymore @ldionne, is it possible to make me author again? I didn't find the way to do it myself, I guess I don't have permissions for that.

Nov 11 2020, 2:23 PM · Restricted Project

Nov 10 2020

rarutyun added a comment to D87171: Implement P0919R3.

By the way currently the tests failed on GCC with friend approach.

Nov 10 2020, 3:31 PM · Restricted Project
rarutyun added a comment to D87171: Implement P0919R3.

I think this is pretty much good to go, however there's a specific way I'd like to structure the test harness to make the approach clearer. I'll commandeer this because it's a lot easier than explaining exactly what I mean, but LMK if you're OK with my approach. It's very very close to yours.

Nov 10 2020, 2:39 PM · Restricted Project

Nov 6 2020

rarutyun requested review of D90968: Fix for the Bug 41784.
Nov 6 2020, 1:08 PM · Restricted Project

Oct 29 2020

rarutyun added a comment to D87171: Implement P0919R3.

@ldionne any thoughts on the current state of the review?

Oct 29 2020, 3:08 PM · Restricted Project

Oct 28 2020

rarutyun added inline comments to D87171: Implement P0919R3.
Oct 28 2020, 4:42 AM · Restricted Project
rarutyun updated the diff for D87171: Implement P0919R3.
Oct 28 2020, 4:18 AM · Restricted Project

Oct 27 2020

rarutyun added inline comments to D87171: Implement P0919R3.
Oct 27 2020, 10:03 AM · Restricted Project

Oct 20 2020

rarutyun added a comment to D87171: Implement P0919R3.

@rarutyun Please look at the tests in D59886 and take anything that increases the coverage.

Oct 20 2020, 11:20 AM · Restricted Project

Oct 19 2020

rarutyun added inline comments to D87171: Implement P0919R3.
Oct 19 2020, 8:22 AM · Restricted Project
rarutyun updated the diff for D87171: Implement P0919R3.
Oct 19 2020, 7:56 AM · Restricted Project

Oct 9 2020

rarutyun added a comment to D87171: Implement P0919R3.

Hi @zoecarver. I am also sorry about duplicating the work. I looked at the cxx2a_status.html and saw that it is not taken. I created the review with just having the update of cxx2a_status.html with marking that feature as In progress. Unfortunately, I didn't have information who should be invited to the review. I knew only Marshall and added him. Seems nobody was informed I took this part of work. As you can see the review was created on September the 5th. After that it was very hard to find the time to finish the feature implementation. Finally I found the bandwidth and implemented all of this stuff for a couple of days.

Oct 9 2020, 1:58 PM · Restricted Project
rarutyun added inline comments to D87171: Implement P0919R3.
Oct 9 2020, 6:20 AM · Restricted Project
rarutyun updated the diff for D87171: Implement P0919R3.
Oct 9 2020, 5:35 AM · Restricted Project
rarutyun added a reviewer for D87171: Implement P0919R3: ldionne.
Oct 9 2020, 5:31 AM · Restricted Project
rarutyun updated the diff for D87171: Implement P0919R3.
Oct 9 2020, 5:16 AM · Restricted Project

Sep 4 2020

rarutyun requested review of D87171: Implement P0919R3.
Sep 4 2020, 3:45 PM · Restricted Project