Page MenuHomePhabricator

rapidsna (Yeoul Na)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 1 2018, 5:06 PM (128 w, 1 d)

Recent Activity

Dec 27 2018

rapidsna abandoned D54016: [X86] don't allow X86_64 PIC mode addresses to be used as immediates.

So with 'i' it should actually work as a PC-relative mode. Gotcha, that totally makes sense. Thanks for confirming this @rnk.

Dec 27 2018, 6:23 PM

Dec 26 2018

rapidsna added a comment to D54016: [X86] don't allow X86_64 PIC mode addresses to be used as immediates.

@rnk thanks for looking into this!! yes, I need someone to commit it on my behalf.

Dec 26 2018, 5:23 PM

Dec 25 2018

rapidsna updated the diff for D54016: [X86] don't allow X86_64 PIC mode addresses to be used as immediates.

Thanks for looking into this @rnk. I am adding a unit test for this patch. Let me know if the test looks okay.

Dec 25 2018, 11:52 PM

Nov 30 2018

rapidsna added a comment to D54016: [X86] don't allow X86_64 PIC mode addresses to be used as immediates.

@rnk Thanks for looking into this.

Nov 30 2018, 9:24 PM

Nov 2 2018

rapidsna added a comment to D54016: [X86] don't allow X86_64 PIC mode addresses to be used as immediates.

Thanks for having look at this. I had also looked at that part, but the problem here has to do with local linkage functions which do not use GOTOFF relocations so classifyLocalReference() just returns MO_NO_FLAG. That's the reason why the if (isGlobalStubReference(Subtarget.classifyGlobalReference(GV))) does not catch this. However, these local linkage functions still need to be accessed in a RIP-relative way in the PIC mode and thus should not be used as immediate values.

Nov 2 2018, 5:37 PM

Nov 1 2018

rapidsna added a reviewer for D54016: [X86] don't allow X86_64 PIC mode addresses to be used as immediates: craig.topper.
Nov 1 2018, 5:54 PM
rapidsna created D54016: [X86] don't allow X86_64 PIC mode addresses to be used as immediates.
Nov 1 2018, 5:34 PM