Page MenuHomePhabricator

rahmanl (Rahman Lavaee)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2019, 2:02 PM (60 w, 4 d)

Recent Activity

Fri, Sep 25

rahmanl added a comment to D88199: Introduce and use a new section type for the bb_addr_map section..

Thanks @jhenderson, turned out I did need a one-line change for asmparser to work.

Fri, Sep 25, 11:21 AM · Restricted Project
rahmanl updated the diff for D88199: Introduce and use a new section type for the bb_addr_map section..
  • Add new test for MCParser.
  • Clang-format.
Fri, Sep 25, 11:19 AM · Restricted Project

Thu, Sep 24

rahmanl updated the diff for D73739: Exception support for basic block sections.
  • clang-format.
Thu, Sep 24, 2:59 PM · Restricted Project
rahmanl added a comment to D73739: Exception support for basic block sections.

Thanks for the comments @MaskRay

Thu, Sep 24, 2:42 PM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.
  • Rebase.
  • Unify access to exception symbols for basic-block-sections and no basic-block-sections.
  • other nits.
Thu, Sep 24, 2:40 PM · Restricted Project
rahmanl updated the summary of D88199: Introduce and use a new section type for the bb_addr_map section..
Thu, Sep 24, 12:45 AM · Restricted Project
rahmanl published D88199: Introduce and use a new section type for the bb_addr_map section. for review.
Thu, Sep 24, 12:44 AM · Restricted Project

Tue, Sep 22

rahmanl accepted D87999: [EHStreamer] Ensure CallSiteEntry::{BeginLabel,EndLabel} are non-null. NFC.
Tue, Sep 22, 1:31 PM · Restricted Project

Mon, Sep 21

rahmanl added a comment to D87999: [EHStreamer] Ensure CallSiteEntry::{BeginLabel,EndLabel} are non-null. NFC.

LGTM.
Please just keep in mind that call-site-table is not rigorously tested in LLVM.

Mon, Sep 21, 11:08 AM · Restricted Project
rahmanl added inline comments to D87999: [EHStreamer] Ensure CallSiteEntry::{BeginLabel,EndLabel} are non-null. NFC.
Mon, Sep 21, 9:32 AM · Restricted Project

Fri, Sep 18

rahmanl edited reviewers for D73739: Exception support for basic block sections, added: MaskRay; removed: wenlei.
Fri, Sep 18, 12:55 PM · Restricted Project
rahmanl accepted D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.
Fri, Sep 18, 12:24 PM · Restricted Project

Wed, Sep 16

rahmanl added a comment to D73739: Exception support for basic block sections.

@rahmanl Have you had a chance to run your added test on ARM64 as another itanium C++ ABI target to make sure it works properly? Having testing there is fine as a follow-up but wanted to make sure we're in agreement here. Otherwise changes LGTM, please let @MaskRay have a chance to provide any additional feedback.

Wed, Sep 16, 11:25 PM · Restricted Project
rahmanl committed rGb1cb9d627126: [obj2yaml] - Match ".stack_size" with the original section name, and not the… (authored by rahmanl).
[obj2yaml] - Match ".stack_size" with the original section name, and not the…
Wed, Sep 16, 2:25 PM
rahmanl closed D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
Wed, Sep 16, 2:24 PM · Restricted Project
rahmanl added a comment to D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..

@MaskRay ping.

Wed, Sep 16, 1:09 PM · Restricted Project
rahmanl added a comment to D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..

Sorry about the headache @MaskRay I should've built after rebasing.

Wed, Sep 16, 12:14 PM · Restricted Project
rahmanl abandoned D87784: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
Wed, Sep 16, 12:12 PM · Restricted Project
rahmanl updated the diff for D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
  • Change the getSectionName call to pass pointer.
Wed, Sep 16, 12:11 PM · Restricted Project
rahmanl updated subscribers of D87784: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
Wed, Sep 16, 12:06 PM · Restricted Project
rahmanl requested review of D87784: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
Wed, Sep 16, 12:04 PM · Restricted Project
rahmanl added a reverting change for rG14e55f82980c: [obj2yaml] - Match ".stack_size" with the original section name, and not the…: rGf80f2516a269: Revert "[obj2yaml] - Match ".stack_size" with the original section name, and….
Wed, Sep 16, 11:43 AM
rahmanl committed rGf80f2516a269: Revert "[obj2yaml] - Match ".stack_size" with the original section name, and… (authored by rahmanl).
Revert "[obj2yaml] - Match ".stack_size" with the original section name, and…
Wed, Sep 16, 11:43 AM
rahmanl added a reverting change for D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name.: rGf80f2516a269: Revert "[obj2yaml] - Match ".stack_size" with the original section name, and….
Wed, Sep 16, 11:43 AM · Restricted Project
rahmanl committed rG14e55f82980c: [obj2yaml] - Match ".stack_size" with the original section name, and not the… (authored by rahmanl).
[obj2yaml] - Match ".stack_size" with the original section name, and not the…
Wed, Sep 16, 11:34 AM
rahmanl closed D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
Wed, Sep 16, 11:33 AM · Restricted Project
rahmanl updated the diff for D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
  • Rebase with upstream.
Wed, Sep 16, 11:30 AM · Restricted Project
rahmanl retitled D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name. from Match ".stack_size" with the original section name, and not the uniquified name. to [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
Wed, Sep 16, 11:15 AM · Restricted Project
rahmanl updated the diff for D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..

Use "Entries:" instead of "Content:" in test.

Wed, Sep 16, 11:13 AM · Restricted Project

Tue, Sep 15

rahmanl removed a reviewer for D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name.: espindola.
Tue, Sep 15, 3:15 PM · Restricted Project
rahmanl edited reviewers for D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name., added: grimar, MaskRay; removed: espindola.
Tue, Sep 15, 3:14 PM · Restricted Project
rahmanl requested review of D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
Tue, Sep 15, 3:13 PM · Restricted Project

Mon, Sep 14

rahmanl committed rG7841e21c9849: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map… (authored by rahmanl).
Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map…
Mon, Sep 14, 10:17 AM
rahmanl closed D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
Mon, Sep 14, 10:17 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
  • Rebase
Mon, Sep 14, 10:15 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
  • Merge branch 'master' into arcpatch-D85408
Mon, Sep 14, 9:40 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
  • Remove the "labels" part of the clang test as the functionality is tested on LLVM tests.
Mon, Sep 14, 9:13 AM · Restricted Project, Restricted Project

Fri, Sep 11

rahmanl added a comment to D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..

@efriedma Would you please chime in specially with respect to @MaskRay 's comment about the clang test involving assembly?

I'll chime in, perhaps @efriedma will/can too: This patch has no changes to Clang's code, so it should have no changes to Clang's tests, generally speaking.

Whatever codepath/behavior is being tested by that Clang test change should be testable (& generally only tested) via LLVM's tools/tests, like llc, I would expect? (I guess that's what the basic-block-sections-labels.ll test is doing? Making the Clang test update redundant)

The only reason I'd expect to see the assembly tested in Clang is if the flag that enables this feature is an MCOptions (or other similar API level feature) member, rather than part of LLVM IR proper. In that case the only way to test that the flag has any effect (since we can't observe the MCOptions struct state directly in a test) is to test for the MCOptions effect on LLVM's output. Depending on the complexity, sometimes such tests are just skipped entirely (leaving the setting of the MCOption untested) - I think I did that for, for example, DWARF type units. Other times, an end-to-end test is used to ensure the flag is working. But that's all the test should do: test the flag is working, with some very basic/rudimentary property of the feature being enabled (so pretty much /any/ change to the way the feature works will still pass the test, but if the feature were turned off entirely (the MCOptions flag stopped being set correctly), the test would fail). Not test all the functionality of the feature that the flag enables - all that testing should be down in LLVM.

Fri, Sep 11, 1:24 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
  • Remove the complex assembly from the clang test.
Fri, Sep 11, 1:22 AM · Restricted Project, Restricted Project
rahmanl added a comment to D73739: Exception support for basic block sections.

Taking a closer look at the test (haven't delved into the code yet): the PIC vs non-PIC difference of .gcc_exception_table looks strange.
.gcc_except_table (please also test its section flags "a") has an absolute relocation referencing main.2. This is not good. In all targets (except RISC-V -mno-relax), .gcc_except_table is a relocation-free section.

I think you should just use PIC handling for -fno-PIC.

Fri, Sep 11, 12:13 AM · Restricted Project

Thu, Sep 10

rahmanl updated the diff for D73739: Exception support for basic block sections.
  • clang-format.
Thu, Sep 10, 11:43 PM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.
  • Do not use Optional for the CallSiteRanges parameter.
  • Add the new function llvm::avoidZeroOffsetLandingPad(MachineFunction&) and expose it in BasicBlockSectionUtils.h.
  • Use getNoop(MCInst&) instead of insertNoop() to insert NOP.
Thu, Sep 10, 11:39 PM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.
  • Rebase.
  • Override X86InstrInfo::InsertNoops and use it in BasicBlockSections.cpp to emit a NOP before the first EH pad.
  • Create a lambda function for duplicated code in EHStreamer.cpp.
  • Change some references to const.
Thu, Sep 10, 2:54 PM · Restricted Project

Wed, Sep 9

rahmanl accepted D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets..
Wed, Sep 9, 6:24 PM · Restricted Project
rahmanl added a comment to D73739: Exception support for basic block sections.

Once this patch is in we can look into splitting ehpads out though I'm more inclined to enhance the static profile count mechanism to account for ehpads appropriately rather than adding a new flag to MFS.

On this front, is there a specific reviewer that we're waiting for here to get this change through?

Wed, Sep 9, 2:21 PM · Restricted Project
rahmanl edited reviewers for D73739: Exception support for basic block sections, added: modimo, wenlei; removed: majnemer, davidxl, MaskRay, jyknight.
Wed, Sep 9, 2:18 PM · Restricted Project

Tue, Sep 8

rahmanl added a comment to D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..

@efriedma Would you please chime in specially with respect to @MaskRay 's comment about the clang test involving assembly?

Tue, Sep 8, 2:52 PM · Restricted Project, Restricted Project
rahmanl added a comment to D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..

Thanks for the review @MaskRay. Is this ready to land now?

Tue, Sep 8, 9:53 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
  • Merge remote-tracking branch 'origin/master' into arcpatch-D85408
Tue, Sep 8, 9:44 AM · Restricted Project, Restricted Project

Thu, Sep 3

rahmanl added inline comments to D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
Thu, Sep 3, 11:04 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
  • Address +MaskRay's comments:
  • Change the check prefix simply to "CHECK" for basic-block-sections-labels.ll
  • Change the triple to x86_64 for this test.
  • nits.
  • Remove the "-LABEL" feature from basic-block-sections-labels.ll and use precise BB indices.
  • Remove the assertion in emitBBAddrMapSection.
Thu, Sep 3, 11:01 AM · Restricted Project, Restricted Project
rahmanl updated subscribers of D73739: Exception support for basic block sections.

I think with this alongside the recently committed MachineFunctionSplitter (MFS) the MFS phase is a good place to split out EH landing pads in both profile and non-profile code. A small change in MFS will enable EH LP splits in profiling given they should always be cold. I think in non-profile mode a sub-flag can be added like -mfs-split-LP-only where EH LPs are always split out. Enabling a general static-analysis splitting could also be interesting but outside of EH LPs I'm not certain there's guaranteed gains in other scenarios.

Thu, Sep 3, 9:14 AM · Restricted Project

Wed, Sep 2

rahmanl added a comment to D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..

Thanks a lot for the comments @MaskRay.

Wed, Sep 2, 9:45 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
  • Address @MaskRay's comments.
  • Rebase with upstream.
Wed, Sep 2, 9:40 AM · Restricted Project, Restricted Project

Fri, Aug 28

rahmanl edited reviewers for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols., added: craig.topper; removed: tmsriram, shenhan.
Fri, Aug 28, 1:45 PM · Restricted Project, Restricted Project
rahmanl added inline comments to D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
Fri, Aug 28, 1:33 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
  • Move getBBAddrMetadata to AsmPrinter as a static function + nits.
Fri, Aug 28, 1:30 PM · Restricted Project, Restricted Project

Aug 26 2020

rahmanl added inline comments to D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
Aug 26 2020, 7:10 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..

Address Snehasish's comments.

  • Move getBBAddrMetadata to AsmPrinter as a static function in AsmPrinter
  • Remove unnecessary IR instructions in basic-block-sections-labels.ll
Aug 26 2020, 7:08 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..

Fix failing clang test which used to check for the old ".bb_info" name.

Aug 26 2020, 1:39 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..

Fix failing clang test which used to check for the old ".bb_info" name.

Aug 26 2020, 1:38 PM · Restricted Project, Restricted Project
rahmanl retitled D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols. from Let -basic-block-sections=labels emit basicblock metadata in a new .bb_info section, instead of emitting special unary-encoded symbols. to Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols..
Aug 26 2020, 12:38 PM · Restricted Project, Restricted Project
rahmanl published D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols. for review.
Aug 26 2020, 12:37 PM · Restricted Project, Restricted Project

Aug 20 2020

rahmanl abandoned D65837: For explicit sections, limit unique section ids to when fintegrated-as=true..
Aug 20 2020, 5:41 PM · Restricted Project

Aug 18 2020

rahmanl updated the diff for D73739: Exception support for basic block sections.

The previous diff was created incorrectly. This update fixes it.

Aug 18 2020, 3:20 PM · Restricted Project

Aug 15 2020

rahmanl abandoned D86016: clang-tidy..
Aug 15 2020, 2:59 AM · Restricted Project
rahmanl requested review of D86016: clang-tidy..
Aug 15 2020, 2:58 AM · Restricted Project

Aug 5 2020

rahmanl committed rG20a568c29db0: [Propeller]: Use a descriptive temporary symbol name for the end of the basic… (authored by rahmanl).
[Propeller]: Use a descriptive temporary symbol name for the end of the basic…
Aug 5 2020, 1:17 PM
rahmanl closed D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..
Aug 5 2020, 1:17 PM · Restricted Project

Aug 4 2020

rahmanl added inline comments to D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..
Aug 4 2020, 11:43 PM · Restricted Project
rahmanl updated the diff for D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..

Rebase.

Aug 4 2020, 11:38 PM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.

Fix case style.

Aug 4 2020, 10:55 PM · Restricted Project
rahmanl updated subscribers of D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..

@eli.friedman and @MaskRay Does this small patch sound alright?

Aug 4 2020, 10:42 PM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.

Fix exception handling on PIC targets (Credit to @amharc for implementing the fix).

Aug 4 2020, 1:58 PM · Restricted Project

Jul 22 2020

rahmanl added a reviewer for D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block.: snehasish.
Jul 22 2020, 10:11 AM · Restricted Project

Jul 21 2020

rahmanl added inline comments to D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..
Jul 21 2020, 2:34 PM · Restricted Project
rahmanl updated the summary of D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..
Jul 21 2020, 2:34 PM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.

This update does some refactoring on the CallSiteRange struct and how it is initialized.

Jul 21 2020, 2:16 PM · Restricted Project
rahmanl updated the summary of D73739: Exception support for basic block sections.
Jul 21 2020, 1:59 AM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.
Jul 21 2020, 1:54 AM · Restricted Project

Jul 17 2020

rahmanl added inline comments to D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..
Jul 17 2020, 2:12 AM · Restricted Project
rahmanl updated the diff for D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..
Jul 17 2020, 2:10 AM · Restricted Project
rahmanl updated the diff for D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..

Remove unrelated changes.

Jul 17 2020, 1:50 AM · Restricted Project
rahmanl added a reviewer for D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block.: eli.friedman.
Jul 17 2020, 1:32 AM · Restricted Project

Jul 15 2020

rahmanl updated the diff for D73739: Exception support for basic block sections.

This syncs and updates the patch with upstream and propeller changes.

Jul 15 2020, 12:05 PM · Restricted Project
rahmanl updated subscribers of D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..
Jul 15 2020, 11:56 AM · Restricted Project
rahmanl created D83885: [Propeller]: Use a descriptive temporary symbol name for the end of the basic block..
Jul 15 2020, 9:20 AM · Restricted Project

Jun 11 2020

rahmanl abandoned D68073: Propeller code layout optimizations.

No longer pursued in LLD with BB-clusters ( D76954) as alternative route.

Jun 11 2020, 2:52 PM · Restricted Project

Apr 13 2020

rahmanl committed rG05192e585ce1: Extend BasicBlock sections to allow specifying clusters of basic blocks in the… (authored by rahmanl).
Extend BasicBlock sections to allow specifying clusters of basic blocks in the…
Apr 13 2020, 12:28 PM
rahmanl committed rG4ddf7ab454b0: Revert "Extend BasicBlock sections to allow specifying clusters of basic blocks" (authored by rahmanl).
Revert "Extend BasicBlock sections to allow specifying clusters of basic blocks"
Apr 13 2020, 12:28 PM
rahmanl added a reverting change for rG0d4ec16d3db3: Extend BasicBlock sections to allow specifying clusters of basic blocks in the…: rG4ddf7ab454b0: Revert "Extend BasicBlock sections to allow specifying clusters of basic blocks".
Apr 13 2020, 12:28 PM
rahmanl closed D76954: LLVM support for BB-cluster sections.
Apr 13 2020, 12:28 PM · Restricted Project
rahmanl updated the diff for D76954: LLVM support for BB-cluster sections.

Re-uploading the diff since I missed test files in the latest update.

Apr 13 2020, 12:25 PM · Restricted Project
rahmanl updated the diff for D76954: LLVM support for BB-cluster sections.

This final update applies @MaskRay and @efriedma's last suggestions.
Thanks to all the reviewers.

Apr 13 2020, 12:25 PM · Restricted Project
rahmanl committed rG0d4ec16d3db3: Extend BasicBlock sections to allow specifying clusters of basic blocks in the… (authored by rahmanl).
Extend BasicBlock sections to allow specifying clusters of basic blocks in the…
Apr 13 2020, 11:54 AM

Apr 11 2020

rahmanl committed rG61d39b627a80: Revert "This is a test commit." (authored by rahmanl).
Revert "This is a test commit."
Apr 11 2020, 4:01 PM
rahmanl added a reverting change for rGab31797e166c: This is a test commit.: rG61d39b627a80: Revert "This is a test commit.".
Apr 11 2020, 4:00 PM
rahmanl committed rGab31797e166c: This is a test commit. (authored by rahmanl).
This is a test commit.
Apr 11 2020, 4:00 PM

Apr 10 2020

rahmanl added a comment to D76954: LLVM support for BB-cluster sections.

Thanks again @efriedma and @tmsriram.

Apr 10 2020, 3:36 PM · Restricted Project
rahmanl updated the diff for D76954: LLVM support for BB-cluster sections.

The major change with this is a new struct called MBBSectionID to represent the basic block section IDs instead of a plain integer.
This makes the code cleaner (especially for the upcoming CFI and DebugInfo patches).

Apr 10 2020, 3:36 PM · Restricted Project