Page MenuHomePhabricator

pvellien (praveen velliengiri)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 24 2020, 11:41 PM (7 w, 6 d)

Recent Activity

Thu, Dec 24

pvellien abandoned D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch .

This change is wrong, the different patch is landed in llvm to handle global address space access in gfx60x for HSA Os. So closing it.

Thu, Dec 24, 2:24 AM · Restricted Project, Restricted Project
pvellien added a comment to D92483: AMDGPU - Use MUBUF instructions for global address space access.
Thu, Dec 24, 12:21 AM · Restricted Project
pvellien updated the diff for D92483: AMDGPU - Use MUBUF instructions for global address space access.

Fixed a small typo in comments. Nothing else is changed from prior diff.

Thu, Dec 24, 12:18 AM · Restricted Project
pvellien updated the diff for D92483: AMDGPU - Use MUBUF instructions for global address space access.

Included the suggestions given by tony.

Thu, Dec 24, 12:07 AM · Restricted Project

Wed, Dec 23

pvellien added inline comments to D92483: AMDGPU - Use MUBUF instructions for global address space access.
Wed, Dec 23, 10:45 PM · Restricted Project
pvellien added a comment to D92483: AMDGPU - Use MUBUF instructions for global address space access.

If this is fine, place land. I don't have commit access yet.

Wed, Dec 23, 11:19 AM · Restricted Project
pvellien added inline comments to D92483: AMDGPU - Use MUBUF instructions for global address space access.
Wed, Dec 23, 10:22 AM · Restricted Project
pvellien updated the diff for D92483: AMDGPU - Use MUBUF instructions for global address space access.

added a blank line in amdgpuusage.rst file.

Wed, Dec 23, 9:42 AM · Restricted Project
pvellien updated the diff for D92483: AMDGPU - Use MUBUF instructions for global address space access.

Updated the AMDGPUUsage doc. Also I don't have commit access, please commit this patch on my behalf.
Thanks a lot your time.

Wed, Dec 23, 7:07 AM · Restricted Project

Tue, Dec 22

pvellien updated the diff for D92483: AMDGPU - Use MUBUF instructions for global address space access.

Updated the code according to scott's suggestion. And I tried to compile sample program with all possible combinations of processors and ABIs( amdhsa, mesa3d, amdpal), it seems like the backend supports all the ABIs for all processors. So Instead of adding a separate column, (since values of processors will be the same) I added a text pharse above the processor table which documents. Is it right thing to do so?

Tue, Dec 22, 12:42 PM · Restricted Project

Mon, Dec 21

pvellien added a comment to D92483: AMDGPU - Use MUBUF instructions for global address space access.

But I still do not think this is a right thing to do to accept amdhsa on SI, even if you turn off flat instructions. SI does not support HSA.

As far as I the support of HSA in SI processors. Tony suggested that gfx60x processors should support AMDHSA OS because it is capable of supporting OpenCL 1.2 which not need generic pointers. This topic was discussed in amdgcn weekly and using MUBUF instructions for global address space in gfx60x is decided. The same is also documented in AMDGPU User Guide earlier.

But it is not. In fact AMDGPUUsage.rst says that SI does NOT support amdhsa and it is only supported starting from gfx700:

**GCN GFX6 (Southern Islands (SI))** [AMD-GCN-GFX6]_
-----------------------------------------------------------------------------------------------------------------------
``gfx600``  - ``tahiti``    ``amdgcn``   dGPU                    - Does not      - *pal-amdpal*
                                                                   support
                                                                   generic
                                                                   address
                                                                   space
``gfx601``  - ``pitcairn``  ``amdgcn``   dGPU                    - Does not      - *pal-amdpal*
            - ``verde``                                            support
                                                                   generic
                                                                   address
                                                                   space
``gfx602``  - ``hainan``    ``amdgcn``   dGPU                    - Does not      - *pal-amdpal*
            - ``oland``                                            support
                                                                   generic
                                                                   address
                                                                   space

It is only amdpal listed here.

What was discussed is that we can use buffer instructions for global on SI even if amdhsa is not supported.

At one point, while you were on vacation, the consensus was "support amdhsa OS with gfx6, and fail to compile in the presence of e.g. generic pointers".

Has there been more discussion since then?

Mon, Dec 21, 9:28 AM · Restricted Project

Dec 18 2020

pvellien added a comment to D92483: AMDGPU - Use MUBUF instructions for global address space access.

if mcpu is specified, set Gen to the correct generation that cpu belongs to, by initializing it with SOUTHERN_ISLANDS.
if mcpu is not specified (in this case GPU = "generic-hsa"), set Gen to the SEA_LANDS to be in parity with previous code> Comments inline

You are forcing SI for any SPECIFIED GPU instead:

!GPU.contains("generic") ? SOUTHERN_ISLANDS

Read this code line: if CPU is NOT generic, force it to SI.

Ugh. I see what you mean now, it took debugger to understand. The real value of Gen is assigned below in the GCNSubtarget::initializeSubtargetDependencies().

But I still do not think this is a right thing to do to accept amdhsa on SI, even if you turn off flat instructions. SI does not support HSA.

Dec 18 2020, 8:49 AM · Restricted Project

Dec 16 2020

pvellien added a comment to D92483: AMDGPU - Use MUBUF instructions for global address space access.

Comments inline

Dec 16 2020, 8:54 AM · Restricted Project

Dec 11 2020

pvellien added inline comments to D92483: AMDGPU - Use MUBUF instructions for global address space access.
Dec 11 2020, 10:08 AM · Restricted Project

Dec 10 2020

pvellien added inline comments to D92483: AMDGPU - Use MUBUF instructions for global address space access.
Dec 10 2020, 11:24 AM · Restricted Project

Dec 8 2020

pvellien added inline comments to D92483: AMDGPU - Use MUBUF instructions for global address space access.
Dec 8 2020, 10:53 AM · Restricted Project

Dec 7 2020

pvellien updated the diff for D92483: AMDGPU - Use MUBUF instructions for global address space access.

Removed error reporting based on string comparison. Updated the memory legalizer tests to include amdhsa for gfx60x

Dec 7 2020, 5:46 AM · Restricted Project

Dec 2 2020

pvellien added a comment to D92483: AMDGPU - Use MUBUF instructions for global address space access.

fixed a typo in comments.

Dec 2 2020, 9:10 PM · Restricted Project
pvellien added a comment to D92483: AMDGPU - Use MUBUF instructions for global address space access.

Comments inline

Dec 2 2020, 9:01 PM · Restricted Project
pvellien requested review of D92483: AMDGPU - Use MUBUF instructions for global address space access.
Dec 2 2020, 7:07 AM · Restricted Project

Nov 27 2020

pvellien added inline comments to D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch .
Nov 27 2020, 11:50 AM · Restricted Project, Restricted Project
pvellien added inline comments to D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch .
Nov 27 2020, 10:40 AM · Restricted Project, Restricted Project
pvellien updated the diff for D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch .

Updated with stanislav comments

Nov 27 2020, 4:06 AM · Restricted Project, Restricted Project

Nov 25 2020

pvellien requested review of D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch .
Nov 25 2020, 10:17 AM · Restricted Project, Restricted Project